0m31.69s |
++++---+
| After |300,000 | 0m33.11s | 0m06.21s |
++++---+
Signed-off-by: Hyeongseok Kim
---
fs/exfat/exfat_fs.h | 12 +++---
fs/exfat/inode.c| 91 +++--
fs/exfat/namei
ser 0m05.91s system
After : 0m07.01s real 0m00.25s user 0m04.34s system
Signed-off-by: Hyeongseok Kim
---
fs/exfat/dir.c | 19 +--
fs/exfat/exfat_fs.h | 2 +-
fs/exfat/namei.c| 9 -
3 files changed, 22 insertions(+), 8 deletions(-)
diff --gi
/dev/null",
Before : 0m08.69s real 0m00.27s user 0m05.91s system
After : 0m07.01s real 0m00.25s user 0m04.34s system
Signed-off-by: Hyeongseok Kim
---
fs/exfat/dir.c | 39 ---
fs/exfat/exfat_fs.h | 2 +-
fs/exfat/namei.c| 6 -
ser 0m05.91s system
After : 0m07.01s real 0m00.25s user 0m04.34s system
Signed-off-by: Hyeongseok Kim
---
fs/exfat/dir.c | 39 ---
fs/exfat/exfat_fs.h | 2 +-
fs/exfat/namei.c| 6 --
3 files changed, 37 insertions(+), 10 deleti
On 3/18/21 1:07 AM, Sungjong Seo wrote:
/*
- * return values:
- * >= 0 : return dir entiry position with the name in dir
- * -ENOENT : entry with the name does not exist
- * -EIO : I/O error
+ * @ei: inode info of directory
+ * @p_dir: input as directory structure in
0m07.01s real 0m00.25s user 0m04.34s system
Signed-off-by: Hyeongseok Kim
---
fs/exfat/dir.c | 42 +-
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c
index e1d5536de948..59d12eaa0649 100644
--
Degradation of write speed caused by frequent disk access for cluster
bitmap update on every cluster allocation could be improved by
selective syncing bitmap buffer. Change to flush bitmap buffer only
for the directory related operations.
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c
cluster size which is 2, leading
to discard unrelated sectors included in target+2 cluster.
Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Looks good.
Acked-by: Su
, remove the wrong comments in set/clear/find bitmap
functions.
Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
Signed-off-by: Hyeongseok Kim
Acked-by: Sungjong Seo
---
fs/exfat/balloc.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/fs/exfat/
Add FITRIM ioctl to enable discarding unused blocks while mounted.
As current exFAT doesn't have generic ioctl handler, add empty ioctl
function first, and add FITRIM handler.
Reviewed-by: Chaitanya Kulkarni
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c
s_lock which is for protecting concurrent access of file operations is
too huge for cluster bitmap protection, so introduce a new bitmap_lock
to narrow the lock range if only need to access cluster bitmap.
Signed-off-by: Hyeongseok Kim
---
fs/exfat/exfat_fs.h | 1 +
fs/exfat/fatent.c | 37
- Change variable declaration order as reverse tree style.
- Return -EOPNOTSUPP from sb_issue_discard() just as it is.
- Remove cond_resched() in while loop.
- Move ioctl related code into it's helper function.
Hyeongseok Kim (2):
exfat: introduce bitmap_lock for cluster bitmap access
exfa
("exfat: add bitmap operations")
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/exfat/balloc.c b/fs/exfat/balloc.c
index 761c79c3a4ba..41a1dfd9d98a 100644
--- a/fs/exfat/balloc.c
+++ b/fs/exfat/balloc.c
@@ -18
On 2/17/21 2:39 PM, Namjae Jeon wrote:
Hi Hyeongseok,
Do you have any other opinion about this?
I also think this patch should be combined with the 2/2 patch.
If you agree, I'll merge these as one.
Yep, Agreed. Please do that:)
Thanks!
Thank you for the opinion.
I sent out v3.
style.
- Return -EOPNOTSUPP from sb_issue_discard() just as it is.
- Remove cond_resched() in while loop.
- Move ioctl related code into it's helper function.
Hyeongseok Kim (1):
exfat: add support ioctl and FITRIM function
fs/exfat/balloc.c | 81 ++
Add FITRIM ioctl to enable discarding unused blocks while mounted.
As current exFAT doesn't have generic ioctl handler, add empty ioctl
function first, and add FITRIM handler.
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c | 81 +
fs/
On 2/17/21 9:17 AM, Chaitanya Kulkarni wrote:
On 2/16/21 16:13, Hyeongseok Kim wrote:
Sorry, I don't understand exactly.
You're saying that these 2 patch should be merged to a single patch?
Would it be better?
I think so unless there is a specific reason for this to keep it isol
On 2/17/21 8:56 AM, Chaitanya Kulkarni wrote:
On 2/16/21 14:36, Hyeongseok Kim wrote:
+static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
+{
+ struct super_block *sb = inode->i_sb;
Do you really need sb variable ? it is only used once if I'm not wrong.
On 2/17/21 8:51 AM, Chaitanya Kulkarni wrote:
On 2/16/21 14:36, Hyeongseok Kim wrote:
Initialize empty ioctl function
Signed-off-by: Hyeongseok Kim
This patch doesn't do much, but this commit log could be better.
Sorry, I don't understand exactly.
You're saying that these 2
add FITRIM ioctl to support trimming mounted filesystem
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c | 81 +
fs/exfat/exfat_fs.h | 1 +
fs/exfat/file.c | 33 ++
3 files changed, 115 insertions(+)
diff --git a/fs/exfat
Initialize empty ioctl function
Signed-off-by: Hyeongseok Kim
---
fs/exfat/dir.c | 5 +
fs/exfat/exfat_fs.h | 3 +++
fs/exfat/file.c | 21 +
3 files changed, 29 insertions(+)
diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c
index 916797077aad..e1d5536de948 100644
hed() in while loop.
- Move ioctl related code into it's helper function.
Hyeongseok Kim (2):
exfat: add initial ioctl function
exfat: add support FITRIM ioctl
fs/exfat/balloc.c | 81 +
fs/exfat/dir.c | 5 +++
fs/exfat/exfat_fs.h | 4
Hi Chaitanya,
Thank you for the review.
On 2/16/21 4:33 AM, Chaitanya Kulkarni wrote:
On 2/14/21 20:28, Hyeongseok Kim wrote:
+
+int exfat_trim_fs(struct inode *inode, struct fstrim_range *range)
+{
+ struct super_block *sb = inode->i_sb;
Reverse tree style for function varia
add FITRIM ioctl to support trimming mounted filesystem
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c | 89 +
fs/exfat/exfat_fs.h | 1 +
fs/exfat/file.c | 33 +
3 files changed, 123 insertions(+)
diff --git a/fs/exfat
Initialize empty ioctl function
Signed-off-by: Hyeongseok Kim
---
fs/exfat/dir.c | 5 +
fs/exfat/exfat_fs.h | 3 +++
fs/exfat/file.c | 21 +
3 files changed, 29 insertions(+)
diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c
index 916797077aad..e1d5536de948 100644
:0Writes Requeued:0
Reads Completed: 0,0KiB Writes Completed: 13,6KiB
Read Merges: 0,0KiB Write Merges: 0,0KiB
IO unplugs:1Timer unplugs: 0
Signed-off-by: Hyeongseok Kim
---
fs
Signed-off-by: Hyeongseok Kim
---
fs/exfat/balloc.c | 4 ++--
fs/exfat/exfat_fs.h | 2 +-
fs/exfat/fatent.c | 42 --
3 files changed, 39 insertions(+), 9 deletions(-)
diff --git a/fs/exfat/balloc.c b/fs/exfat/balloc.c
index a987919686c0
The stream.size field is updated to the value of create timestamp
of the file entry. Fix this to use correct stream entry pointer.
Fixes: 29bbb14bfc80 ("exfat: fix incorrect update of stream entry in
__exfat_truncate()")
Signed-off-by: Hyeongseok Kim
---
fs/exfat/file.c | 2 +-
1 fi
28 matches
Mail list logo
