Re: [PATCH v2] bridge: Fix a deadlock when enabling multicast snooping

2020-12-04 Thread Huang, Joseph
> > + if (join_snoopers) > > + br_multicast_join_snoopers(br); > > + else if (leave_snoopers) > > + br_multicast_leave_snoopers(br); > > If I'm not missing anything this can be just 1 bool like "change_snoopers" or > something which if set to true will check BROPT_M

Re: [PATCH] bridge: Fix a deadlock when enabling multicast snooping

2020-12-03 Thread Huang, Joseph
> From: Huang, Joseph > Sent: Thursday, December 3, 2020 4:53 PM > To: Nikolay Aleksandrov ; Jakub Kicinski > > Cc: Roopa Prabhu ; David S. Miller > ; bri...@lists.linux-foundation.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linus Lüssing > > Subject

RE: [PATCH] bridge: Fix a deadlock when enabling multicast snooping

2020-12-03 Thread Huang, Joseph
> From: Nikolay Aleksandrov > Sent: Thursday, December 3, 2020 3:47 PM > To: Jakub Kicinski ; Huang, Joseph > > Cc: Roopa Prabhu ; David S. Miller > ; bri...@lists.linux-foundation.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linus Lüssing > > Subject