[PATCH 2.6.25] lib/vsprintf.c: Fix bug omitting minus sign of numbers (module_param)

lib/vsprintf.c: Fix bug omitting minus sign of numbers (module_param) This exists in 2.6.25 only. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- lib/vsprintf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index f

[PATCH] IB/ipoib: Fix undefined symbol (priv->cm) if ipoib_cm disabled

Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/ulp/ipoib/ipoib_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index e499626..0a58ac4 100644

Re: [PATCH] IB/ehca: Forward event client-reregister-required to registered clients

Hi Roland, Just want to make sure you've seen this patch and if it looks ok for you. Thanks Nam On Thursday 20 December 2007 15:06, Hoang-Nam Nguyen wrote: > This patch allows ehca to forward event client-reregister-required to > registered clients. Such one event is generated by th

[PATCH] IB/ehca: Forward event client-reregister-required to registered clients

This patch allows ehca to forward event client-reregister-required to registered clients. Such one event is generated by the switch eg. after its reboot. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 12 1 files chang

Re: [PATCH] hugetlb: follow_hugetlb_page for write access

On Wednesday 07 November 2007 20:51, Adam Litke wrote: > > When calling get_user_pages(), a write flag is passed in by the caller to > indicate if write access is required on the faulted-in pages. Currently, > follow_hugetlb_page() ignores this flag and always faults pages for > read-only access.

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

Hi Adam! On Tuesday 06 November 2007 16:05, aglitke wrote: > Please try this patch and see if it helps. Tested on 2.6.22 (don't have the system with 2.6.23 at the moment) and the testcase ran perfectly. Thanks! Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

Hello Roland! > We currently see this when testing Infiniband on ppc64 with ehca + > hugetlbfs. > From reading the code this should also be an issue on other architectures. > Roland, Adam, are you aware of anything in this area with mellanox > Infiniband cards or other usages with I/O adapters? Bel

Re: [ofa-general] [PATCH 7/7] IB/ehca: Prevent overwriting QP init attributes given by caller

[EMAIL PROTECTED] wrote on 16.08.2007 18:17:22: > I don't understand this patch. says this about > ib_create_qp(): > > * @qp_init_attr: A list of initial attributes required to create the > * QP. If QP creation succeeds, then the attributes are updated to > * the actual capabilities of t

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

rg. Thanks Nam On Friday 03 August 2007 10:36, Hoang-Nam Nguyen wrote: > From: Hoang-Nam Nguyen > Date: Fri, 3 Aug 2007 09:44:56 +0200 > Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space > This patch utilizes remap_4k_pfn() as introduced by Paul M., > for de

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

From: Hoang-Nam Nguyen Date: Fri, 3 Aug 2007 09:44:56 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq, qp firmware context

[PATCH] ehca: map 4k firmware context of cq, qp to user space

From: Hoang-Nam Nguyen Date: Thu, 2 Aug 2007 10:08:30 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq, qp firmware context

Re: [PATCH 2/5] ehca: Generate event when SRQ limit reached

Hi, > BTW, does your SRQ-capable hardware support generating the "last WQE > reached" event? There's not any reliable way to avoid problems when > destroying QPs attached to an SRQ without it, and the IB spec requires > CAs that support SRQs to generate it (o11-5.2.5 in chapter 11 of vol 1). > >

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

Hi Roland! > the patch looks fine except your mailer seems to have mangled > it... can you resend so I can apply it? Was going to recreate this patch, but then I saw that you probably have incorporated it (manually) in your latest git. Just want to make sure I'm seeing it right. Anyway, appreciate

[PATCH 2/2] ehca: correction include order according kernel coding style

>From a2794450cbee597cefd7b6e159257583c459d358 Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen Date: Fri, 27 Jul 2007 10:26:40 +0200 Subject: [PATCH] correction include order according kernel coding style Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniban

[PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

>From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen Date: Fri, 27 Jul 2007 10:24:49 +0200 Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided in .c files" Signed-off-by: Hoang-Nam Nguyen <[EMAIL PRO

[PATCH 0/2] ehca: remove WARNING: externs should be avoided in .c files

Hello Roland! This small patch set fixes some coding-style related issues for ehca: [1/2] remove checkpatch.pl's warnings "externs should be avoided in .c files" [2/2] correction include order according kernel coding style Thanks Nam - To unsubscribe from this list: send the line "unsubscribe linu

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

Hi Roland! > I applied this, but I agree with checkpatch.pl: > > > WARNING: externs should be avoided in .c files > > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > > +extern int ehca_mr_largepage; > > > > WARNING: externs should be avoided in .c files > > #949: FILE: drivers/infini

[PATCH 5/5] ehca: Support small QP queues

with firmware, this code needs to manage bite-sized chunks of kernel pages, making sure that no kernel page is shared between different protection domains. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h | 41 -- drivers/infiniband/h

[PATCH 2/5] ehca: Generate event when SRQ limit reached

From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:51:43 +0200 Subject: [PATCH 2/5] IB/ehca: Generate event when SRQ limit reached Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 42 ++--- 1 files changed,

[PATCH 4/5] ehca: Make internal_create/destroy_qp() static

From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:40:00 +0200 Subject: [PATCH 4/5] IB/ehca: Make internal_{create,destroy}_qp() static They're only used in ehca_qp.c Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c | 17 +--

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:13:57 +0200 Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline It's nowhere in the main path and making it non-inline saves ~1.5K of code. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/

[PATCH 1/5] ehca: Supports large page MRs

From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:48:04 +0200 Subject: [PATCH 1/5] IB/ehca: Support large page MRs Add support for MR pages larger than 4K on eHCA2. This reduces firmware memory consumption. If enabled via the mr_largepage module parameter, the MR page siz

[PATCH 0/5] ehca: MR large page, small queue and fixes

Here is a patch set against Roland's git, branch for-2.6.23 for ehca. It adds support for MR large page and small queues. In addition of that it also contains various small fixes from previous comments and what we found. They are in details: [1/5] adds support for MR large page [2/5] generates eve

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

Roland Dreier <[EMAIL PROTECTED]> wrote on 17.07.2007 19:52:55: > At a higher level, I'm left wondering why nobody talked about multiple > EQs during the last months of the 2.6.22 process and now all of a > sudden it becomes urgent in the last few days of the 2.6.23 merge > window. That's not real

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26: > Do you have any data on how well this round-robin assignment works? > It seems not quite right to me for the driver to advertise nr_eqs > completion vectors, but then if round-robin is turned on to ignore the > consumer's decision ab

Re: [PATCH] fix idr_get_new_above id alias bugs

> With this patch, idr.c should work as advertised allocating id > values in the range 0...0x7fff. Andrew had speculated that > it should allow the full range 0...0x to be used. I was > tempted to make changes to allow this, but it would require changes > to API, e.g. making the start

Re: idr_get_new_above() limitation?

On Tuesday 03 July 2007 02:31, Jim Houston wrote: > The problem is in idr_get_new_above_int() in the loop which > adds new layers to the top of the radix tree. It is failing > the "layers < (MAX_LEVEL - 1)" test. It doesn't allocate the > new layer but still calls sub_alloc() which relies on havi

idr_get_new_above() limitation?

Hello, For ehca device driver we're intending to utilize idr_get_new_above() and have written a test case, which I'm attaching at the end. Basically it tries to get an idr token above a lower boundary by calling idr_get_new_above() and then uses idr_find() to check if the returned token can be fo

[PATCH 2.6.22] ehca: return proper error code if register_mr fails

This patch sets the return code of ehca_register_mr() to ENOMEM if corresponding firmware call fails due to out of resources. Some of error codes were mapped to EINVAL. They are now mapped to default case, which already returns EINVAL anyway. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTEC

Re: [ofa-general] [PATCH][RFC] IB: Return "maybe missed event" hint from ib_req_notify_cq()

Hi Roland! As far as this concerns ehca this looks great. Thanks Nam [EMAIL PROTECTED] wrote on 27.04.2007 00:43:19: > > - "IB: Return "maybe missed event" hint from ib_req_notify_cq()" > > This extends the API in a way that lets us implement NAPI, but may > > be useful for other thi

Re: [PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq

> > +#include > This can just be , because you're only using > wait_queue_head_t and not struct completion, right? > I fixed this up before merging. Yes, right. Thanks for your help! Regards Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

[PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq

ehca_cq_idr_lock. - Replace yield by wait_event on the counter above to become zero Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |6 - ehca_cq.c | 16 +-- ehca_irq.c

[PATCH 1/2] ibmebus: dynamic addiiton/removal of adapters, uevent, root device based on struct device

From: Joachim Fenkes <[EMAIL PROTECTED]> This adds two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT "ibm,loc-code" property) into the "probe" attribu

[PATCH 2/2] ibmebus: whitespace fixes

From: Joachim Fenkes <[EMAIL PROTECTED]> This fixes whitespacing in ibmebus.[ch] - no functionality changed. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 126 +- include/asm-powerpc/ibmebus.h | 42 +++-

[PATCH 2/2] ibmebus: dynamic add/remove, uevent, root device and whitespace

This is the aforementioned whitespace fix which applies on top of part 1/2. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 126 +- include/asm-powerpc/ibmebus.h | 42 +++--- diff -urp b/arch/powerpc/kern

[PATCH 1/2] ibmebus: dynamic add/remove, uevent, root device and whitespace

The first part of this patch summarizes the patches of the previous days, namely: - Add dynamic addition/removal of adapters (with spiffy error reporting) - Implement the uevent interface using Sylvain's generic function - Base fake root device on device instead of of_device The first part will

[PATCH 2.6.21-rc1] ibmebus: more error reporting in dynamic add/remove code

Writing the ibmebus probe and remove attributes now throws an appropriate error if something goes wrong. This way, userspace tools can check for success or failure of an addition or removal. The write will block until the probe/remove operation completes, so, when the write operation returns withou

[PATCH 2.6.21-rc1] ibmebus: make root device not of_device-based

The fake root device doesn't have an associated device tree node, so it should not be an of_device. This patch makes it a normal, bus-less device and thus saves a lot of checks later on. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- ibmebus.c | 33 ++--- 1

[PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- of_device.c |4 1 files changed, 4 insertions(+) diff -urp a/arch/powerpc/kernel/of_device.c b/arch/powerp

[PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()

This patch replaces ibmebus_uevent() by Sylvain's generic function. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- ibmebus.c | 37 +++-- 1 file changed, 3 insertions(+), 34 deletions(-) diff -urp a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/i

Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

Hi, > So I'm holding off on applying this for now. Please think it over and > either tell me the current patch is OK, or fix it up. There's not > really too much urgency because a change like this is something I > would be comfortable merging between 2.6.21-rc1 and -rc2. You're absolutely right.

[PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

This patch will add two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT "ibm,loc-code" property) into the "probe" attribute will notify ebus of addition

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

set port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_hca.c |3 +++ 1 files changed, 3 insertions(+) diff --git a/d

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

allow users to en/disable scaling code when loading ib_ehca module Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47 +-- ehca_main.c|4 4

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

remove yield() and use wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |3 +++ ehca_cq.c |5 +++-- ehca_irq.c |6 +++

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

fix a race condition in find_next_cpu_online() and some other locking issues in scaling code Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c | 68 + 1 files changed, 33 insertions(+), 35 deletions(-) diff

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

reworked irq handler to avoid/reduce missed irq events Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 18 +++- ehca_eq.c |1 ehca_irq.c | 214 +++-- ehca_irq.h |1 ehca_main.c

Re: [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

> Looks fine but this patch at least has serious whitespace > damage... please resend a fixed version. Sorry for this. Resending the patches 1-5. Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_hca.c |3 +++ 1 files changed, 3 inse

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |3 +++ ehca_cq.c

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c | 68 + 1 files changed, 33 inse

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h

[PATCH 2.6.21-rc1 0/5] ehca patch set for 2.6.21-rc1

Hello Roland! Here is a patch set for ehca with the following changes resp. bug fixes: * Reworked irq handler to avoid/reduce missed irq events * Fix race condition bug in find_next_online_cpu() and other potential locking issue of scaling code * Allow scaling code to be configurable (en-/disable

[PATCH 2.6.21 4/4] ehca: remove obsolete prototypes

Here is a patch for ehca_classes.h that removes obsolete prototypes. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 14 -- 1 files changed, 14 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cla

[PATCH 2.6.21 3/4] ehca: remove do_mmap()

-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 15 +- ehca_cq.c | 65 ++--- ehca_iverbs.h |8 - ehca_main.c|6 ehca_qp.c | 78 ++- ehca_uverbs.c | 395 +++-- 6 files changed, 204 insertions(+

[PATCH 2.6.21 1/4] ehca: fix improper use of yield with spinlock held

Here is a patch for ehca_cq.c that fixes improper use of yield with spinlock held. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehc

[PATCH 2.6.21 2/4] ehca: fix mismatched use of spin_unlock in irq handler

Here is a patch for ehca_irq.c that fixes mismatched use of spin_unlock in irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca

[PATCH 2.6.21 0/4] ehca: remove do_mmap() and some bug fixes

Hello Roland! Here is a patch set for ehca as a result of previous disscussions and comments: 1. fix improper use of yield within spinlock context 2. fix mismatched use of spin_unlock in irq handler 3. remove do_mmap() 4. remove obsolete prototypes PS: I've sent the first two recently for 2.6.20, b

Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

> I think the right thing to do is restructure this function so you > don't have lines starting 6 tab stops to the right. Yes. Have reworked this irq handler and still struggling with testing. When we feel comfortable with the test result, we'll post it here (soon) and hopefully it is easier to rea

Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

hmm, code line too long. please ignore the previous patch. here is the one with correct length of code line. Thanks Nam This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c |4 +

[PATCH 2.6.20 0/2] ehca: fix yield and spinlock conflicts

Hello Roland! Here is patch set for ehca with the following bug fixes: * Fix unproper use of yield within spinlock context * Fix mismatched spin_unlock in irq handler Thanks Nam ehca_cq.c |5 - ehca_irq.c |2 +- 2 files changed, 5 insertions(+), 2 deletions(-) - To unsubscribe from

[PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

Hello Roland! This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_ir

[PATCH 2.6.20 1/2] ehca: ehca_cq.c: fix unproper use of yield within spinlock context

Hello Roland! This is a patch for ehca_cq.c that fixes unproper use of yield within spinlock context. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehc

Re: [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

No problem. Will resend the full patch set for 2.6.21. Thanks Nam [EMAIL PROTECTED] wrote on 18.01.2007 13:56:01: > I've kind of lost the plot here. How does this patch fit in with the > previous series of patches you posted? Does it replace them or go on > top of them? > > Can please you resen

[PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

ll send another patch. Thanks! Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_uverbs.c | 266 +++--- 1 file changed, 146 insertions(+), 120 deletions(-) diff -Nurp infiniband/drivers/infiniband/hw/ehca/ehca_uverbs.c in

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

Hi, > > + if (my_cq->ownpid != cur_pid) { > > + ehca_err(device, "Invalid caller pid=%x ownpid=%x " > > +"cq_num=%x", > > +cur_pid, my_cq->ownpid, my_cq->cq_number); > > + return -EINVAL; > > +

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

In addition of yield issue this patch also fixes an unproper use of spin_unlock() in ehca_irq.c. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c |5 - ehca_irq.c |4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff -Nurp infiniband_orig/d

[PATCH/RFC 2.6.21 5/5] ehca: ehca_main.c: version numbering

Hello Roland! This is a patch for ehca_main.c. It mainly updates ehca version appropriately. Also the abi_version is increased in order to distinguish this from earlier releases. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_main.c |6 +++--- 1 files chan

[PATCH/RFC 2.6.21 4/5] ehca: queue pair: remove use of do_mmap()

Hello Roland and Christoph H.! This is a patch for ehca_qp.c. It removes all direct calls of do_mmap()/munmap() when creating and destroying a queue pair respectively. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_qp.c

[PATCH/RFC 2.6.21 2/5] ehca: ehca_uverbs.c: "proper" use of mmap

- The actual mmap() call/trigger is now controlled by user space, ie. libehca, for which I will send a separate patch for later review This patch also removes superfluous resp. obsolete functions. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_uverbs.c

[PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

Hello Roland and Christoph H.! This is a patch for ehca_cq.c. It removes all direct calls of do_mmap()/munmap() when creating and destroying a completion queue respectively. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c

[PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

Hello Roland and Christoph H.! This is a patch for ehca structs. It enhances completion queue and queue pair with use counters for associated mmap-ed resources, ie. hardware register block and queue pages. Furthermore it removes redundant prototypes. Thanks Nam Signed-off-by Hoang-Nam Nguyen

[PATCH/RFC 2.6.21 0/5] ehca: remove use of do_mmap() from kernel space

Hello Roland and Christoph H.! Here is a set of patches for ehca, whose main purpose is to remove unproper use of do_mmap() in ehca kernel space as suggested by Christoph H. Other "small" changes are: * Remove "dead" prototype declarations (those without code implementation) Now detail on mmap()

Re: [PATCH 2.6.21 0/8] ehca: remove use of do_mmap() from kernel space and minor cleanup

Please ignore this. Pushed the send button to fast again. Regards Nam On Thursday 11 January 2007 18:07, Hoang-Nam Nguyen wrote: > Hello Roland and Christoph H.! > Here is a set of patches for ehca, whose main purpose is to remove unproper > use of > do_mmap() in ehca kernel space

[PATCH 2.6.21 0/8] ehca: remove use of do_mmap() from kernel space and minor cleanup

Hello Roland and Christoph H.! Here is a set of patches for ehca, whose main purpose is to remove unproper use of do_mmap() in ehca kernel space as suggested by Christoph H. Other "small" changes are: * Remove "dead" prototype declarations (those without code implementation) * Use SLAB_ defines i

[PATCH 2.6.20] ehca: use proper flag for get_zeroed_page() to prevent BUG:scheduling while atomic...

HCA error data block. Use of GFP_ATOMIC prevents this issue. Since this has a good chance of crashing the kernel every time HCA error data is fetched, it would be great if you pushed this patch upstream. Regards Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca

Re: [PATCH] ehca: fix do_mmap() error check

Hi Akinobu! > The return value of do_mmap() should be checked by IS_ERR(). Thanks again. Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

Re: [PATCH] ehca: fix kthread_create() error check

Hi, > The return value of kthread_create() should be checked by > IS_ERR(). create_comp_task() returns the return value from > kthread_create(). Good catch. Appreciate your help! Regards Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI