Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/

2019-01-30 Thread Hin-Tak Leung
op -I without > parameter"). > I also removed one header search path > in:   > drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile > I was able to compile without it. > [1]: https://patchwork.kernel.org/patch/9632347/ > Signed-off-by: Masahiro Yamada Acked-by: Hin-Tak Leung Looks okay for the rtl818x parts.

Re: [PATCH] rtl8187: Fix NULL pointer dereference in priv->conf_mutex

2018-02-28 Thread Hin-Tak Leung
On Thu, 15/2/18, Sudhir Sreedharan wrote: ... > Cc: sta...@vger.kernel.org > Signed-off-by: Sudhir Sreedharan Acked-by: Hin-Tak Leung

Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15

2017-12-04 Thread Hin-Tak Leung
being greater than 15 is redundant and > can be removed. > Detected by CoverityScan, CID#744303 > ("Logically dead code") > Signed-off-by: Colin Ian King Acked-by: Hin-Tak Leung

Re: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id

2017-08-25 Thread Hin-Tak Leung
On Tue, 8/8/17, Arvind Yadav wrote: Subject: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id To: kv...@codeaurora.org, her...@canonical.com, ht...@users.sourceforge.net, larry.fin...@lwfinger.net Cc: linux-kernel@vger.kernel.org,

Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_probe()

2014-04-07 Thread Hin-Tak Leung
cremented > incorrectly and usb_dev can be used after memory deallocation. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > >Acked-by: Larry Finger > >Thanks, > >Larry Acked-by: Hin-Tak Leung Hin-Ta

Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_init_urbs()

2013-09-01 Thread Hin-Tak Leung
-- On Mon, Sep 2, 2013 05:06 BST Alexey Khoroshilov wrote: >On 01.09.2013 10:51, Hin-Tak Leung wrote: >> -- >> On Sat, Aug 31, 2013 22:18 BST Alexey Khoroshilov wrote: >> >> In case of __dev_alloc_skb() failure r

Re: [PATCH] rtl8187: fix use after free on failure path in rtl8187_init_urbs()

2013-09-01 Thread Hin-Tak Leung
-- On Sat, Aug 31, 2013 22:18 BST Alexey Khoroshilov wrote: >In case of __dev_alloc_skb() failure rtl8187_init_urbs() >calls usb_free_urb(entry) where 'entry' can points to urb >allocated at the previous iteration. That means refcnt will be >decremented incorrectly and

Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

2013-04-14 Thread Hin-Tak Leung
--- On Mon, 15/4/13, Joe Perches wrote: > On Mon, 2013-04-15 at 04:46 +0100, > Hin-Tak Leung wrote: > > > By converting this dprint() to pr_debug(), it > would > > > print out on a multiple lines, one for each read. > > > > > > That&#x

Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

2013-04-14 Thread Hin-Tak Leung
--- On Mon, 15/4/13, Joe Perches wrote: > On Mon, 2013-04-15 at 02:56 +0100, > Hin-Tak Leung wrote: > > --- On Mon, 15/4/13, Joe Perches > wrote: > > > On Mon, 2013-04-15 at 01:53 +0100, > > > Hin-Tak Leung wrote: > > > > --- On Mon, 8/4/13, Joe P

Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

2013-04-14 Thread Hin-Tak Leung
--- On Mon, 15/4/13, Joe Perches wrote: > On Mon, 2013-04-15 at 01:53 +0100, > Hin-Tak Leung wrote: > > --- On Mon, 8/4/13, Joe Perches > wrote: > > > Use a more current logging style. > [] > > I have been sitting on a patch which changes this part > of the

Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg

2013-04-14 Thread Hin-Tak Leung
--- On Mon, 8/4/13, Joe Perches wrote: > Use a more current logging style. > > Rename macro and uses. > Add do {} while (0) to macro. > Add DBG_ to macro. > Add and use hfs_dbg_cont variant where appropriate. > > Signed-off-by: Joe Perches > +++ b/fs/hfs/hfs_fs.h > @@ -34,8 +34,18 @@ > //#

Re: [PATCH] hfs: add error checking for hfs_find_init()

2013-03-30 Thread Hin-Tak Leung
inux-fsde...@vger.kernel.org, linux-kernel@vger.kernel.org, > ldv-proj...@linuxtesting.org, "Hin-Tak Leung" > Date: Saturday, 30 March, 2013, 11:35 > Hi Alexey, > > On Mar 30, 2013, at 12:44 AM, Alexey Khoroshilov wrote: > > > hfs_find_init() may fail with ENO

Re: [v3 1/1] driver-core: Shut up dev_dbg_reatelimited() without DEBUG

2012-08-25 Thread Hin-Tak Leung
uot;. This shouldn't print anything without DEBUG. > > With CONFIG_DYNAMIC_DEBUG, the print should be configured as > expected. > > Signed-off-by: Hiroshi Doyu > Reported-by: Hin-Tak Leung > Tested-by: Antti Palosaari > Acked-by: Hin-Tak Leung Tested-by: Hin-Tak Leung

Re: [PATCH 1/1] driver-core: Shut up dev_dbg_reatelimited() without DEBUG

2012-08-23 Thread Hin-Tak Leung
--- On Wed, 22/8/12, Antti Palosaari wrote: > On 08/22/2012 04:57 PM, Hin-Tak Leung > wrote: > > Antti Palosaari wrote: > >> Hello Hiroshi, > >> > >> On 08/21/2012 10:02 AM, Hiroshi Doyu wrote: > >>> Antti Palosaari > wrote @ Mon, 20 Aug 20

Re: [PATCH 1/1] driver-core: Shut up dev_dbg_reatelimited() without DEBUG

2012-08-22 Thread Hin-Tak Leung
amic debugs. It was Hin-Tak who originally reported that bug for me after I added few ratelimited debugs for DVB stack. Thank you! Reported-by: Hin-Tak Leung Tested-by: Antti Palosaari regards Antti This is with mediatree/for_v3.7-8 , playing DVB-T video with mplayer. echo 'file ...media

Re: [PATCH net-next 4/8] wireless: Use eth_random_addr

2012-07-12 Thread Hin-Tak Leung
ingerde" > , "Helmut Schaa" , "Herton > Ronaldo Krzesinski" , "Hin-Tak Leung" > , "Larry Finger" > Cc: "Johannes Berg" , > linux-wirel...@vger.kernel.org, net...@vger.kernel.org, > linux-kernel@vger.kernel.org, us...@rt2x00