Re: [PATCH 3/3] net: wireless: rt2x00: Space Required

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 11:11 PM, Paul McQuade wrote: > Space needed before open parenthesis > > Signed-off-by: Paul McQuade Looks valid to me. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 1/3] net: wireless: rt2x00: Space issue

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade wrote: > Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade Looks valid to me as well. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt2x00.h | 24 > 1 file chan

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

2016-01-21 Thread Helmut Schaa
On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa wrote: > On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade wrote: >> Removed empty spaces before/after parenthesis >> >> Signed-off-by: Paul McQuade > > Just noticed these did not get applied by Kalle yet. Kalle, can you fix

Re: [PATCH 2/3] net: wireless: rt2x00: Pointer issue

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade wrote: > Code Style: pointer is declared wrong > > Signed-off-by: Paul McQuade Thanks for fixing this code style issue. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00/rt2x00.h | 4 ++-- > 1 file changed, 2 insertio

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

2016-01-21 Thread Helmut Schaa
On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade wrote: > Removed empty spaces before/after parenthesis > > Signed-off-by: Paul McQuade Just noticed these did not get applied by Kalle yet. Looks good to me. Acked-by: Helmut Schaa > --- > drivers/net/wireless/rt2x00

Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

2016-01-05 Thread Helmut Schaa
On Tue, Jan 5, 2016 at 2:27 AM, Jia-Ju Bai wrote: > On 01/05/2016 12:50 AM, Helmut Schaa wrote: >> >> On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai wrote: >>> >>> The driver calls pci_set_mwi to enable memory-write-invalidate when it >>> is initialized,

Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

2016-01-04 Thread Helmut Schaa
On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai wrote: > The driver calls pci_set_mwi to enable memory-write-invalidate when it > is initialized, but does not call pci_clear_mwi when it is removed. Many > other drivers calls pci_clear_mwi when pci_set_mwi is called, such as > r8169, 8139cp and e1000. >

Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree

2014-06-18 Thread Helmut Schaa
van Doorn > Cc: Helmut Schaa > Signed-off-by: Fabian Frederick > --- > drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c > b/drivers/net/wireless/rt2x00/rt2x00dev.

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Helmut Schaa
On Mon, Jan 7, 2013 at 4:04 PM, Andreas Hartmann wrote: > The solution would be IMHO, to implement an own aggregation handling, > maybe the same way as it was done for carl9170, which had the same problem: > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/100793/focus=1405 > > I pref