Re: [PATCH] Improve Documentation/stable_api_nonsense.txt v2

2008-02-03 Thread Heikki Orsila
> The whole article explains why apis are change for very good reasons > (evolution of hardware, security, we now know better, etc.) That's the > whole point of the document... ... And the new paragraph supports that goal by assuring others that we don't do unnecessary

[PATCH] Improve Documentation/stable_api_nonsense.txt v2

2008-02-02 Thread Heikki Orsila
This is version 2 of the patch. Address Gregs, Matts and Andis comments. Retain the word "exact" due to request of Greg. Use "the exact same" as per "Matt Mackall". * Change wording * Make a remark about necessary changes in interfaces Signed-off-by: H

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt

2008-01-29 Thread Heikki Orsila
> How about this (scrap the whole paragraph): > > > > Changing an interface can be delicate work and it can take significant > > amount of developer effort. Therefore, an interface is not changed > > unless the change is regarded as very important by the developers. >

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt

2008-01-29 Thread Heikki Orsila
CC'ing Andi as he commented also.. On Mon, Jan 28, 2008 at 08:48:05PM -0800, Greg KH wrote: > On Tue, Jan 29, 2008 at 01:09:59AM +0200, Heikki Orsila wrote: > > * Make a remark about avoiding unnecessary changes in interfaces > > * Improve wording > > Well, "improv

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt

2008-01-28 Thread Heikki Orsila
On Tue, Jan 29, 2008 at 01:09:59AM +0200, Heikki Orsila wrote: > * Make a remark about avoiding unnecessary changes in interfaces > * Improve wording Forgot to CC Greg. - Heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

[PATCH] Improve Documentation/stable_api_nonsense.txt

2008-01-28 Thread Heikki Orsila
* Make a remark about avoiding unnecessary changes in interfaces * Improve wording Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> --- Documentation/stable_api_nonsense.txt | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Documen

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Heikki Orsila
On Fri, Jan 25, 2008 at 02:13:00AM +0300, Dmitri Vorobiev wrote: > Care to explain why? Because functions are always external objects in C. I just verified that from K&R. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let

Re: [PATCH 5/9] bfs: move function prototype to the proper header file

2008-01-24 Thread Heikki Orsila
nctions should not be externed, remove extern keyword. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [RFC] Documentation about unaligned memory access

2007-11-25 Thread Heikki Orsila
2 > > `No' for >= 68020. > `Yes' for < 68020. My bad, yes.. mc68020+No No (mc68000/010 No 2) (not for Linux) -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let'

Re: [RFC] Documentation about unaligned memory access

2007-11-23 Thread Heikki Orsila
ble of ISAs: ISA NeedNeed natural alignment alignment by x m68kNo 2 powerpc/ppc Yes Word size x86 No No x86_64 No No

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-16 Thread Heikki Orsila
f74e0b74fbe39a > Author: Linus Torvalds <[EMAIL PROTECTED]> > Date: Thu Nov 15 08:44:36 2007 -0800 > > Revert "skge: fix ram buffer size calculation" > > This reverts commit 7fb7ac241162dc51ec0f7644d4a97b2855213c32. > > Heikki Or

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Heikki Orsila
that was hard to read). I'm not suggesting this is a proper fix. In fact, I think it's not, because we can not explain the problem. It would _very_ nice to get to the bottom of this issue, so I would favor reverting the patch and trying and debugging carefully before creating quick and d

Re: [patch 00/16] 2.6.23-stable review, network driver changes

2007-11-15 Thread Heikki Orsila
f4275f92). It hangs the network on high speed transfers. This the same regression that happened for 2.6.24-rc*: http://bugzilla.kernel.org/show_bug.cgi?id=9321 The driver in 2.6.23.1 works for me. Afaik, Stephen Hemminger is working on it. -- Heikki Orsila Barbie

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Heikki Orsila
se revert skge changes, the commit that broke driver is 7fb7ac241162dc51ec0f7644d4a97b2855213c32 See http://bugzilla.kernel.org/show_bug.cgi?id=9321 for more information. I think Stephen Hemminger is working on the skge fix, but it has been several days since I've heard anything from him. -- Heikki Orsila

Re: Strage buffer behaviour

2007-11-12 Thread Heikki Orsila
On Mon, Nov 12, 2007 at 12:44:53PM -0700, Denys Vlasenko wrote: > IIRC only mounted partitions' reads are cached. That seems to be the case. Thanks. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!"

Re: Strage buffer behaviour

2007-11-11 Thread Heikki Orsila
100 MB from each partition two times in a row. It > looks like sda1 and sda2 are not bufferd (the first 4 dd runs), but > sda3 and sda4 are (the last 4 dd runs). Strange.. I'm running 2.6.24-rc1 here. Reading data from /dev/hda1 caches well, but not from /dev/sd[ab]1. PS. you can flush c

Re: net: skge breakage on 2.6.24-rc1

2007-11-07 Thread Heikki Orsila
On Wed, Nov 07, 2007 at 03:06:21PM -0800, Andrew Morton wrote: > > On Wed, 7 Nov 2007 23:50:30 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > > wrote: > > On Wednesday, 7 of November 2007, Heikki Orsila wrote: > > > On Wed, Nov 07, 2007 at 11:46:21P

Re: net: skge breakage on 2.6.24-rc1

2007-11-07 Thread Heikki Orsila
On Wed, Nov 07, 2007 at 11:46:21PM +0200, Heikki Orsila wrote: > After some bisecting, I found that net skge driver broke on > > commit 7fb7ac241162dc51ec0f7644d4a97b2855213c32 > > My network card is: > > :00:0e.0 Ethernet controller: 3Com Corporation 3c940 10/100/1

net: skge breakage on 2.6.24-rc1

2007-11-07 Thread Heikki Orsila
x86_64 GNU/Linux -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: Strange freezes (seems like SATA related)

2007-11-01 Thread Heikki Orsila
ntroller (rev 02) 00:1f.3 SMBus: Intel Corporation 82801EB/ER (ICH5/ICH5R) SMBus Controller (rev 02) 01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400/G450 (rev 04) 02:04.0 RAID bus controller: VIA Technologies, Inc. VT6410 ATA133 RAID controller (rev 06) 02:

Re: Major SATA / EXT3 Issue?

2007-10-31 Thread Heikki Orsila
On Wed, Oct 31, 2007 at 03:25:54AM -0400, Theodore Tso wrote: > On Tue, Oct 30, 2007 at 03:59:24PM +0200, Heikki Orsila wrote: > > 3. fsck -p on boot failed > > > > (it is very probable not many files were corrupted at this stage) > > Maybe... The system wouldn't

Re: Major SATA / EXT3 Issue?

2007-10-30 Thread Heikki Orsila
journal Remounting filesystem read-only __journal_remove_journal_head: freeing b_committed_data 2. I rebooted 3. fsck -p on boot failed (it is very probable not many files were corrupted at this stage) 4. I ran fsck.ext3 -y => that corrupted lots and lots of files. This went into a loop,

Re: [PATCH 5/5] mthca: allow setting "dmabarrier" on user-allocated memory

2007-10-02 Thread Heikki Orsila
ms like a very odd place to #define something new.. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: Revised signalfd man-page

2007-09-27 Thread Heikki Orsila
On Thu, Sep 27, 2007 at 02:19:05PM +0200, Michael Kerrisk wrote: > uint28_t pad[\fIX\fP]; /* Pad size to 128 bytes (allow space > additional fields in the future) */ I think you mean uint8_t.. -- Heikki Orsila Barbie's law: [EMAI

On thread scheduling

2007-09-14 Thread Heikki Orsila
Is there are function to just disable scheduling of a single thread without having other side-effects (such as terminal stuff)? Functions like pthread_disable_scheduling(thread) and pthread_enable_scheduling(thread) would be good for this.. -- Heikki Orsila Barbie

Re: [PATCH 1/7] manpage for fallocate

2007-07-10 Thread Heikki Orsila
ENOSPC > There is not enough space left on the device containing the file > referred to by > .IR fd. > .TP > .B ESPIPE > .I fd > refers to a pipe of file descriptor. > .B ENOSYS > The filesystem underlying the file descriptor does not support this > operation. EINTR?

Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)

2007-07-06 Thread Heikki Orsila
te_scc and write_scc_data */ -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: RSA support into kernel?

2007-07-06 Thread Heikki Orsila
On Thu, Jul 05, 2007 at 05:53:11PM -0700, Gautam Singaraju wrote: > Is there any attempt being made to provide software based RSA > cryptographic support in kernel? I fail to see how it would be useful. RSA is such a slow operation that doing it in userspace is efficient and safer. --

[PATCH] Documentation: improvement to volatile considered harmful (resubmit)

2007-07-01 Thread Heikki Orsila
I'm resubmitting this as I didn't get any replies, this time CCeing proper people, sorry.. Kernel locking/synchronization primitives are better than volatile types from code readability point of view also. This patch is against 2.6.22-rc6. Signed-off-by: Heikki Orsila <[EM

Man page correction: epoll (7)

2007-07-01 Thread Heikki Orsila
Here's a bit of email I exchanged with Davide Libenzi on epoll (7) man page. There is an error in answer 9: Davide Libenzi wrote: > On Mon, 25 Jun 2007, Heikki Orsila wrote: >> >From epoll man page: >> >>Q9 Do I need to continuously read/wri

[PATCH] Documentation: improvement to volatile considered harmful

2007-06-26 Thread Heikki Orsila
Kernel locking/synchronization primitives are better than volatile types from code readability point of view also. This patch is against 2.6.22-rc6. Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> diff --git a/Documentation/volatile-considered-harmful.txt b/Documentation/volatile-cons

[PATCH] remove unnecessary ARM SHA-1 preprocessor directive

2007-06-09 Thread Heikki Orsila
Remove an unnecessary C style preprocessor directive from ARM SHA-1 assember implementation. It confuses sloccount. Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> diff --git a/arch/arm/lib/sha1.S b/arch/arm/lib/sha1.S index ff6ece4..67c2bf4 100644 --- a/arch/arm/lib/sha1.S +++ b/arch/a

Re: [RFC][PATCH] IO-APIC blacklist

2007-06-02 Thread Heikki Orsila
e Documentation/SubmittingPatches) -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [PATCH -mm] LZO: Further cleanup of the kernel LZO library headers

2007-05-18 Thread Heikki Orsila
y that. Guptas implementation is much cleaner, work with that. Putting a few bound checks into Guptas version will solve crashes and overruns by returning an error. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http

Re: [RFC] LZO1X de/compression support

2007-05-18 Thread Heikki Orsila
+ > + The LZO library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have r

Re: usb-storage nice value

2007-05-18 Thread Heikki Orsila
h performance, but yet have plenty of clean pages for other purposes. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe l

On __pure and __attribute_pure__

2007-05-15 Thread Heikki Orsila
__attribute_pure__ so we could do a replacement. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] ALSA sound driver for SEGA Dreamcast AICA (pcm)

2007-05-14 Thread Heikki Orsila
nd_kcontrol *kcontrol, > + struct snd_ctl_elem_info *uinfo) > +{ > + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; > + uinfo->count = 1; > + uinfo->value.integer.min = 0; > + uinfo->value.integer.max = 0xFF; > + return 0;

Re: [PATCH] ALSA sound driver for SEGA Dreamcast AICA (pcm)

2007-05-14 Thread Heikki Orsila
(unlikely(!dreamcastcard->card)) { > + kfree(dreamcastcard); > + return -ENODEV; > + } > + strcpy(dreamcastcard->card->driver, "snd_aica"); > + strcpy(dreamcastcard->card->shortname, SND_AICA_DRIVER); > + strcpy(dreamcastcar

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Heikki Orsila
anges over time. I think the most important reason for portable code is that new readers are more familiar with effects of the code. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To uns

Re: [PATCH] "volatile considered harmful" document

2007-05-09 Thread Heikki Orsila
> + whole system. In C, it's "data" that is volatile, but that is > + insane. Data isn't volatile - _accesses_ are volatile. So it may > + make sense to say "make this particular _access_ be careful", but > + not "make all access

[PATCH] scsi: eata.c potential namespace collision and optimisation

2007-02-24 Thread Heikki Orsila
+), 9 deletions(-) Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd diff -upr linux-2.6.20-org/drivers/scsi/eata.c linux-2.6.20/drivers/s

[RFC] New driver information

2007-02-16 Thread Heikki Orsila
; hardware by using grep et al. What do you think? Useless annotations or useful information? -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line &

Re: [PATCH 000/196] V4L/DVB updates

2007-02-15 Thread Heikki Orsila
27;t these submitted in smaller batches? Why were all these patches held back before releasing any? Heikki Orsila - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] saa7134: cleanup

2007-02-09 Thread Heikki Orsila
A cleanup patch against 2.6.20 for saa7134 video4linux driver: - use generic sort instead of bubblesort - removed useless saa7134_video_fini function - small coding style changes Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> -- Heikki Orsila Barbie's

Re: PROBLEM: KB->KiB, MB -> MiB, ... (IEC 60027-2)

2007-01-21 Thread Heikki Orsila
roper SI units (k, M, G, ...) makes life easier as they are taught in school to everyone. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line &qu

Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c

2006-11-17 Thread Heikki Orsila
On Fri, Nov 17, 2006 at 04:36:37PM +0800, Peer Chen wrote: > I didn't get any comment from you guys for new patch, does someone take > care this patch, do we still need some modification upon it? Or do we > need re-submit it in other thread? One small change suggestion: > +static inline bool nv_s

Re: diabling interrupts on pentium 4 processor

2006-11-16 Thread Heikki Orsila
On Thu, Nov 16, 2006 at 11:23:12AM +, ranjith kumar wrote: > Hi, > How to disable interrupts on pentium 4 (or any > i386) > machine? > > I tried to include "cli" instruction in a kernel > module. But got runtime error. Read Documentation/cli-sti-removal.txt. - Heikki - To unsub

Re: [RFC, Patch 1/1] OProfile for Cell: Initial profiling support -- new patch

2006-11-16 Thread Heikki Orsila
On Wed, Nov 15, 2006 at 12:51:08PM -0600, Maynard Johnson wrote: > +/* This function is called once for all cpus combined */ > +static void > +cell_reg_setup(struct op_counter_config *ctr, > +struct op_system_config *sys, int num_ctrs) > +{ > [SNIP] > + for (i = 0; i < num_ctrs; ++i

Re: Edge triggered epoll with pts devices acts as level triggered

2005-08-13 Thread Heikki Orsila
1 trigger for each input. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: NCQ support NVidia NForce4 (CK804) SATAII

2005-08-11 Thread Heikki Orsila
well. Only one crash in a year, and that was with a recent 2.6.13-rc[2-5] TCP bug, which has already been fixed. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from thi

Re: fcntl(F_GETLEASE) semantics??

2005-08-11 Thread Heikki Orsila
ed the lease notification is executed. So you're talking about the kernel side.. I was talking about userspace perspective on the syscall. It would be rather odd to let a syscall block other applications involuntarily (and thus achieving synchronous action in your meaning)..

Re: fcntl(F_GETLEASE) semantics??

2005-08-11 Thread Heikki Orsila
erface for userspace programs because it relies on signals and thus can't be conveniently put into shared libraries.. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscrib

Re: fcntl(F_GETLEASE) semantics??

2005-08-11 Thread Heikki Orsila
ould be used to detected changes in any file. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH] net/ipv4 debug cleanup, kernel 2.6.13-rc5

2005-08-10 Thread Heikki Orsila
ke a good idea. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [E

Re: Linux-2.6.13-rc6: aic7xxx testers please..

2005-08-07 Thread Heikki Orsila
org/lkml/2005/8/7/63 -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread Heikki Orsila
Heikki Orsila wrote: > There were big changes in tcp_output.c between rc1 and rc2, and the > bug is triggered when using e1000 with rc2 or later. And because the > bug does not happen on skge (new sk98 driver) it makes me guess it's a > race condition of sorts.. I am surprise

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread Heikki Orsila
c on rc2 and later (which doesn't happen on rc1). See my other post in this thread. -- Heikki Orsila Barbie's law: [EMAIL PROTECTED] "Math is hard, let's go shopping!" http://www.iki.fi/shd - To unsubscribe from this list: send the line &

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread Heikki Orsila
nt 2.12i module-init-tools 3.0 e2fsprogs 1.38 jfsutils 1.1.4 reiserfsprogs line reiser4progs line xfsprogs 2.6.25 nfs-utils 1.0.6 Linux C Library2.3.5 Dynamic linker (ldd) 2.3.5 Procps

[PATCH] net/ipv4 debug cleanup, kernel 2.6.13-rc5

2005-08-07 Thread Heikki Orsila
Here's a small patch to cleanup NETDEBUG() use in net/ipv4/ for Linux kernel 2.6.13-rc5. Also weird use of indentation is changed in some places. Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> --- diff -urp linux-2.6.13-rc5-org/net/ipv4/icmp.c linux-2.6.13-rc5/net/ipv4/icmp.c --- l