Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-13 Thread Hauke Mehrtens
On 4/13/21 12:24 AM, Martin Blumenstingl wrote: Hi Andrew, On Mon, Apr 12, 2021 at 1:16 AM Andrew Lunn wrote: On Sun, Apr 11, 2021 at 10:55:11PM +0200, Martin Blumenstingl wrote: Add support for .get_regs_len and .get_regs so it is easier to find out about the state of the ports on the GSWIP

Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-11 Thread Hauke Mehrtens
current port status (as well as the result of the auto polling mechanism). Other global and per-port registers which are also considered useful are included as well. Acked-by: Hauke Mehrtens Signed-off-by: Martin Blumenstingl --- drivers/net/dsa/lantiq_gswip.c | 83

Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

2021-04-07 Thread Hauke Mehrtens
On 4/7/21 2:32 AM, Andrew Lunn wrote: case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID: miicfg |= GSWIP_MII_CFG_MODE_RGMII; + + if (phylink_autoneg_

Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

2021-04-06 Thread Hauke Mehrtens
ew of the GSWIP_MII_CFG register. Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.org Suggested-by: Hauke Mehrtens Acked-by: Hauke Mehrtens Signed-off-by: Martin Blumenstingl --- drivers/net/dsa/lantiq_gswip.c | 22

Re: [PATCH v3 2/3] net: dsa: lantiq: verify compatible strings against hardware

2021-03-21 Thread Hauke Mehrtens
On 3/21/21 6:39 PM, Aleksander Jan Bajkowski wrote: Verify compatible string against hardware. Signed-off-by: Aleksander Jan Bajkowski Acked-by: Hauke Mehrtens

Re: [PATCH v3 1/3] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2021-03-21 Thread Hauke Mehrtens
-off-by: Aleksander Jan Bajkowski Acked-by: Hauke Mehrtens

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

2021-03-10 Thread Hauke Mehrtens
On 3/10/21 5:57 PM, Arnd Bergmann wrote: On Wed, Mar 10, 2021 at 8:30 AM Pavel Machek wrote: Hi! I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away. The following message to was undeliverable. : Recipient +address rejected: User un

Re: [PATCH] phy: lantiq: rcu-usb2: wait after clock enable

2021-01-07 Thread Hauke Mehrtens
y to let the phy get up and running. There isn't any documentation how much time is required, the value was chosen based on tests. Cc: # v5.7+ Signed-off-by: Mathias Kresin Acked-by: Hauke Mehrtens I do not know how long you have to wait here, but this looks ok, when it works. Hauke

Re: [PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access

2021-01-02 Thread Hauke Mehrtens
because there's really only three (one for each of the following ports: 0, 1, 5). Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.org Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lant

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-02 Thread Hauke Mehrtens
Add Lantiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.org Suggested-by: Hauke Mehrtens Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dsa/lantiq_gs

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Hauke Mehrtens
On 12/21/20 7:04 PM, Andrew Lunn wrote: On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: The declaration of request_irq() in is marked as __must_check. Witho

Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-04 Thread Hauke Mehrtens
On 12/4/20 2:49 AM, Andrew Lunn wrote: static const struct of_device_id gswip_of_match[] = { { .compatible = "lantiq,xrx200-gswip", .data = &gswip_xrx200 }, + { .compatible = "lantiq,xrx300-gswip", .data = &gswip_xrx300 }, + { .compatible = "lantiq,xrx330-gswip", .data = &gs

Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-03 Thread Hauke Mehrtens
Hi, This looks good. I haven't checked all the differences between the SoCs, but found some minor problems in the code for the port configuration. On 12/3/20 11:03 PM, Aleksander Jan Bajkowski wrote: From: Aleksander Jan Bajkowski This patch allows you to use all phs on GRX300 and GRX330.

Re: [PATCH v2] net: lantiq: Wait for the GPHY firmware to be ready

2020-11-15 Thread Hauke Mehrtens
by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- Changes since v1: - move the msleep() closer to the actual loop over all GPHY instances as suggested by Andrew - added Andrew's Reviewed-by (thank you!) drivers/net/dsa/lantiq_gswip.c | 11 +++ 1 file changed, 11 insertions

Re: [PATCH AUTOSEL 5.4 10/58] mips: vdso: fix 'jalr t9' crash in vdso code

2020-08-29 Thread Hauke Mehrtens
On 8/29/20 3:56 PM, Sasha Levin wrote: > On Sat, Aug 29, 2020 at 03:08:01PM +0200, Hauke Mehrtens wrote: >> On 3/5/20 6:13 PM, Sasha Levin wrote: >>> From: Victor Kamensky >>> >>> [ Upstream commit d3f703c4359ff06619b2322b91f69710453e6b6d ] >>> >

Re: [PATCH AUTOSEL 5.4 10/58] mips: vdso: fix 'jalr t9' crash in vdso code

2020-08-29 Thread Hauke Mehrtens
On 3/5/20 6:13 PM, Sasha Levin wrote: > From: Victor Kamensky > > [ Upstream commit d3f703c4359ff06619b2322b91f69710453e6b6d ] > > Observed that when kernel is built with Yocto mips64-poky-linux-gcc, > and mips64-poky-linux-gnun32-gcc toolchain, resulting vdso contains > 'jalr t9' instructions i

Re: [PATCH] MIPS: lantiq: xway: sysctrl: fix the GPHY clock alias names

2020-06-07 Thread Hauke Mehrtens
eff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Cc: sta...@vger.kernel.org > Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens > --- > arch/mips/lantiq/xway/sysctrl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > di

Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

2020-06-07 Thread Hauke Mehrtens
mprove > the cases where someone made a mistake. > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 3 ++- > 1 file changed, 2 i

Re: [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers

2020-04-28 Thread Hauke Mehrtens
On 4/28/20 1:10 PM, Daniel Schwierzeck wrote: > > > Am 24.04.20 um 12:42 schrieb Dilip Kota: >> Synchronize tx, rx and error interrupts by registering to the >> same interrupt handler. Interrupt handler will recognize and process >> the appropriate interrupt on the basis of interrupt status regis

Re: [musl] [PATCH] arm64: uapi: Fix user space compile with musl libc

2019-10-19 Thread Hauke Mehrtens
On 10/19/19 10:29 PM, Rich Felker wrote: > On Sat, Oct 19, 2019 at 10:17:17PM +0200, Hauke Mehrtens wrote: >> musl libc also defines the structures in their arch/aarch64/bits/signal.h >> header file. Some applications like strace and gdb include both of them >> and then the

[PATCH] arm64: uapi: Fix user space compile with musl libc

2019-10-19 Thread Hauke Mehrtens
will also update musl libc to define these constants. Signed-off-by: Hauke Mehrtens Cc: sta...@vger.kernel.org --- arch/arm64/include/uapi/asm/sigcontext.h | 13 + include/uapi/linux/libc-compat.h | 20 2 files changed, 33 insertions(+) diff --git a/arch

Re: [PATCH AUTOSEL 5.2 17/42] MIPS: lantiq: update the clock alias' for the mainline PCIe PHY driver

2019-09-29 Thread Hauke Mehrtens
On 9/29/19 7:32 PM, Sasha Levin wrote: > From: Martin Blumenstingl > > [ Upstream commit ed90302be64a53d9031c8ce05428c358b16a5d96 ] > > The mainline PCIe PHY driver has it's own devicetree node. Update the > clock alias so the mainline driver finds the clocks. > > The first PCIe PHY is located

Re: [PATCH v2] ethernet: lantiq_xrx200: Use devm_platform_ioremap_resource() in xrx200_probe()

2019-09-20 Thread Hauke Mehrtens
_get_resource” and “devm_ioremap_resource” directly. > > * Thus reduce also a bit of exception handling code here. > * Delete the local variable “res”. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Hauke Mehrtens But this can al

Re: [PATCH 5/5] MIPS: dts: lantiq: danube: easy50712: route the PCI_INTA IRQ through EBU

2019-07-29 Thread Hauke Mehrtens
tly (using IRQ_TYPE_LEVEL_LOW, this was previously hardcoded in >> the PCI driver) and ACKed properly. >> >> Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens >> --- >> arch/mips/boot/dts/lantiq/easy50712.dts | 4 +++- >> 1 file changed, 3 in

Re: [PATCH 2/3] net: dsa: lantiq_gswip: fix OF child-node lookups

2019-01-16 Thread Hauke Mehrtens
ntiq / Intel DSA driver for vrx200") > Cc: stable# 4.20 > Cc: Hauke Mehrtens > Signed-off-by: Johan Hovold Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) >

Re: [PATCH 3/3] net: dsa: lantiq_gswip: drop bogus drvdata check

2019-01-16 Thread Hauke Mehrtens
On 1/16/19 11:23 AM, Johan Hovold wrote: > The platform-device driver data is set on successful probe and will > never be NULL on remove (or we have much bigger problems). > > Signed-off-by: Johan Hovold Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c

Re: [PATCH 1/3] net: dsa: lantiq_gswip: fix use-after-free on failed probe

2019-01-16 Thread Hauke Mehrtens
4fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") >> Cc: stable # 4.20 >> Cc: Hauke Mehrtens >> Signed-off-by: Johan Hovold >> --- >> drivers/net/dsa/lantiq_gswip.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >>

Re: [PATCH 1/3] net: dsa: lantiq_gswip: fix use-after-free on failed probe

2019-01-16 Thread Hauke Mehrtens
Cc: stable# 4.20 > Cc: Hauke Mehrtens > Signed-off-by: Johan Hovold Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gsw

Re: [PATCH mips-fixes] MIPS: BCM47XX: Setup struct device for the SoC

2019-01-02 Thread Hauke Mehrtens
eric dma noncoherent ops for simple noncoherent platforms") Cc: Christoph Hellwig Cc: sta...@vger.kernel.org # v4.19+ Signed-off-by: Rafał Miłecki Acked-by: Hauke Mehrtens I assume that the old ssb based devices also have such problems did you had a look into those? --- arch/mips/b

Re: [PATCH AUTOSEL 4.19 28/57] watchdog: lantiq: update register names to better match spec

2018-11-05 Thread Hauke Mehrtens
On 11/04/2018 02:51 PM, Sasha Levin wrote: > From: Hauke Mehrtens > > [ Upstream commit 1f59f8aff98f200af7a6882184add7b85f5da741 ] > > Some of the names of the bits were confusing to me. > Now the bits share the same prefix as the register they are set on. > > The LTQ_W

Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

2018-10-07 Thread Hauke Mehrtens
On 10/04/2018 11:08 PM, René Kjellerup wrote: > Hi Hauke, > > thank you for suggesting adding the dts patch to mainline kernel, > so here it is. > I feel Rafal technically still have the copyrights, this is pretty > much just a few string updates for the ea6500v2. However with this > dts in latest

[PATCH] phy: lantiq: Fix compile warning

2018-09-25 Thread Hauke Mehrtens
This local variable is unused, remove it. Fixes: dea54fbad332 ("phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module") Signed-off-by: Hauke Mehrtens --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/lantiq/phy-

Re: [PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

2018-08-25 Thread Hauke Mehrtens
s Tynkkynen I didn't runtime tested this and didn't checked the board, but this looks good. Acked-by: Hauke Mehrtens > --- > arch/mips/bcm47xx/workarounds.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/bcm47xx/workarounds.c b

Re: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open coded version

2018-08-25 Thread Hauke Mehrtens
On 08/16/2018 05:58 PM, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Hauke Mehrtens > --- > drivers/phy/lantiq/phy-lantiq-rcu-us

Re: [PATCH v2 04/18] MIPS: dts: Add initial support for Intel MIPS SoCs

2018-08-04 Thread Hauke Mehrtens
On 08/03/2018 05:02 AM, Songjun Wu wrote: > From: Hua Ma > > Add dts files to support Intel MIPS SoCs: > - xrx500.dtsi is the chip dts > - easy350_anywan.dts is the board dts > > Signed-off-by: Hua Ma > Signed-off-by: Songjun Wu > --- > > Changes in v2: > - New patch split from previous patch

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-04 Thread Hauke Mehrtens
On 08/03/2018 12:30 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 03, 2018 at 03:33:38PM +0800, Wu, Songjun wrote: >> >> >> On 8/3/2018 1:56 PM, Greg Kroah-Hartman wrote: >>> On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: Previous implementation uses platform-dependent API to get th

[PATCH] freevxfs: Do not inline vxfs_put_page()

2018-06-16 Thread Hauke Mehrtens
vxfs_put_page() is not implemented in a header file, but in a normal c file and used in multiple functions in different c files. Remove the inline attribute as it does not make sense here and causes a link error when LTO is activated. Signed-off-by: Hauke Mehrtens --- fs/freevxfs/vxfs_subr.c

Re: [PATCH] ARM: dts: BCM5301X: Relicense most DTS files to the GPL 2.0+ / MIT

2018-05-02 Thread Hauke Mehrtens
be made separately and will > require approve from more/other developers. > > Signed-off-by: Rafał Miłecki Acked-by: Hauke Mehrtens > --- > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts| 13 + > arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts| 13 +--

Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts

2018-04-22 Thread Hauke Mehrtens
a workaround for a wrong syscon-reboot mask. With a > mask set which includes the GPHY resets, these resets aren't required > any more. > > Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU > syscon-mfd") > Cc: sta...@vger.kernel.org # 4.14+

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-20 Thread Hauke Mehrtens
On 01/18/2018 09:49 AM, Jonas Bonn wrote: > On 01/17/2018 11:34 PM, Daniel Wagner wrote: >> >> On 01/17/2018 11:20 PM, Hauke Mehrtens wrote: >>> >>> Do we want to do any changes to the kernel header files? I do not know >>> of any clean workarou

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-17 Thread Hauke Mehrtens
On 01/17/2018 08:31 PM, Neil MacLeod wrote: > All > > Further to my previous reply (reproduced below having been bounced by > linux-kernel) I have successfully built LibreELEC when using the > ConnMan patch from Jonas - there were no other failures. > > I have also built a number of network relat

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-17 Thread Hauke Mehrtens
On 01/17/2018 08:59 AM, Daniel Wagner wrote: > Hi Neil, > > On 01/16/2018 07:51 PM, Neil MacLeod wrote: >> Since this commit in 4.15-rc8: >> >> https://github.com/torvalds/linux/commit/6926e041a8920c8ec27e4e155efa760aa01551fd >> >> >> building connman 1.35 with glibc 2.26 now fails as follows: >

[PATCH v4] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
g glibc are still correct, but this file is not only used for glibc any more. Signed-off-by: Felix Janda Reviewed-by: Hauke Mehrtens --- v4: Extend patch description with comment about glibc comments v3: Fix typos, add a comment to the file and use #ifndef. v2: The only change to the previ

Re: [PATCHv3 resend] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
ample the following compiler errors when is >> included after musl's : >> >> ./linux/in6.h:32:8: error: redefinition of 'struct in6_addr' >> ./linux/in6.h:49:8: error: redefinition of 'struct sockaddr_in6' >> ./linux/in6.h:59:8: error: redefin

Re: [PATCH] ARM: dts: sun8i: add support for Orange Pi R1

2017-12-28 Thread Hauke Mehrtens
Hi, I tried this device tree file with my Orange Pi R1 and then the Ethernet chip connected to the USB controller is not working. When I set PAD 20 to high the device is found on the USB bus. On 11/12/2017 01:41 PM, Icenowy Zheng wrote: > Orange Pi R1 is a board design based on Orange Pi Zero,

Re: [PATCHv3 resend] uapi libc compat: add fallback for unsupported libcs

2017-12-03 Thread Hauke Mehrtens
6.h:49:8: error: redefinition of 'struct sockaddr_in6' > ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq' > > Signed-off-by: Felix Janda > Reviewed-by: Hauke Mehrtens > --- > v3: Fix typos, add a comment to the file and use #if

Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs

2017-10-01 Thread Hauke Mehrtens
On 07/29/2017 04:02 PM, Felix Janda wrote: > libc-compat.h aims to prevent symbol collisions between uapi and libc > headers for each supported libc. This requires continuous coordination > between them. > > The goal of this commit is to improve the situation for libcs (such as > musl) which are n

Re: linux-next: Signed-off-by missing for commits in the mips tree

2017-09-04 Thread Hauke Mehrtens
Hi Ralf and Martin, On 09/03/2017 11:14 PM, Martin Blumenstingl wrote: > Hi Hauke, Hi Ralf, > > On Sun, Sep 3, 2017 at 6:13 PM, Stephen Rothwell > wrote: >> Hi all, >> >> Commits >> >> bb19a5e5205b MIPS: lantiq: Remove the arch/mips/lantiq/xway/reset.c >> implementation >> f6a4de1654c9 MIPS: l

Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs

2017-08-26 Thread Hauke Mehrtens
6.h:49:8: error: redefinition of 'struct sockaddr_in6' > ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq' > > Signed-off-by: Felix Janda Reviewed-by: Hauke Mehrtens With this patch + a patch which protects "struct ethhdr" I was able to b

Re: [musl] [PATCHv2] uapi libc compat: add fallback for unsupported libcs

2017-07-08 Thread Hauke Mehrtens
On 07/08/2017 10:27 PM, Felix Janda wrote: > libc-compat.h aims to prevent symbol collisions between uapi and libc > headers for each supported libc. This requires continuous coordination > between them. > > The goal of this commit is to improve the situation for libcs (such as > musl) which are

Re: [PATCH] MIPS: Lantiq: Fix ASC0/ASC1 clocks

2017-06-03 Thread Hauke Mehrtens
On 05/30/2017 06:34 AM, Martin Schiller wrote: > ASC1 is available on every Lantiq SoC (also AmazonSE) and should be > enabled like the other generic xway clocks instead of ASC0, which is > only available for AR9 and Danube. This is correct. > Signed-off-by: Martin Schiller Ack

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2017-04-24 Thread Hauke Mehrtens
On 03/08/2017 05:39 PM, Carlos O'Donell wrote: > Any header needing compat with a libc includes libc-compat.h (per the > documented way the model works). With this patch any included linux kernel > header that also includes libc-compat.h would immediately define all > the __UAPI_DEF_* constants t

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2017-04-24 Thread Hauke Mehrtens
On 03/08/2017 01:46 PM, David Woodhouse wrote: > On Fri, 2016-11-11 at 07:08 -0500, Felix Janda wrote: >> Currently, libc-compat.h detects inclusion of specific glibc headers, >> and defines corresponding _UAPI_DEF_* macros, which in turn are used in >> uapi headers to prevent definition of confl

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-21 Thread Hauke Mehrtens
On 04/20/2017 10:36 PM, David Miller wrote: > From: David Woodhouse > Date: Thu, 20 Apr 2017 21:14:37 +0100 > >> I agree, except I don't think you're going far enough. Those "standard >> names" you mention... some of this stuff actually depends on __GLIBC__, >> and *that* isn't right either. >

[PATCH v2 1/3] uapi glibc compat: add libc compat code when not build for kernel

2017-04-18 Thread Hauke Mehrtens
based on an older patch from David Heidelberger Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index

[PATCH v2 3/3] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-04-18 Thread Hauke Mehrtens
: Hauke Mehrtens --- include/uapi/linux/if_ether.h| 3 +++ include/uapi/linux/libc-compat.h | 11 +++ 2 files changed, 14 insertions(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index 5bc9bfd816b7..fb5ab8c1e753 100644 --- a/include/uapi/linux

[PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-18 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. Changes since v1: - fix typo in commit message - combine two changes David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (2): uapi

[PATCH v2 2/3] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-04-18 Thread Hauke Mehrtens
defines. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 43a81136ea6e..ce2fa8a4ced6 100644 --- a/include/uapi/linux/libc

[PATCH resend 1/4] uapi glibc compat: add libc compat code when not build for kernel

2017-04-12 Thread Hauke Mehrtens
Instead of checking if this header file is used in the glibc, check if iti is not used in kernel context, this way it will also work with other libc implementations like musl. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 8 1 file changed

[PATCH resend 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-04-12 Thread Hauke Mehrtens
__USE_MISC is glibc specific and not available in musl libc. Only do this check when glibc is used. This fixes a problem with musl libc. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH resend 4/4] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-04-12 Thread Hauke Mehrtens
: Hauke Mehrtens --- include/uapi/linux/if_ether.h| 3 +++ include/uapi/linux/libc-compat.h | 11 +++ 2 files changed, 14 insertions(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index 5bc9bfd816b7..fb5ab8c1e753 100644 --- a/include/uapi/linux

[PATCH resend 2/4] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-04-12 Thread Hauke Mehrtens
defines. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 7c1fead03c50..49a8cc3138ae 100644 --- a/include/uapi/linux/libc

[PATCH resend 0/4] uapi glibc compat: fix musl libc compatibility

2017-04-12 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (3): uapi glibc compat: add libc compat code when not build for kernel uapi

Re: [PATCH 0/4] uapi glibc compat: fix musl libc compatibility

2017-03-28 Thread Hauke Mehrtens
On 2017-03-12 23:00, Hauke Mehrtens wrote: The code from libc-compat.h depends on some glibc specific defines and causes compile problems with the musl libc. These patches remove some of the glibc dependencies. With these patches the LEDE (OpenWrt) base user space applications can be build with

Re: [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-03-17 Thread Hauke Mehrtens
On 03/16/2017 09:26 AM, Mikko Rapeli wrote: > On Thu, Mar 16, 2017 at 07:59:12AM +, David Woodhouse wrote: >> On Sun, 2017-03-12 at 23:00 +0100, Hauke Mehrtens wrote: >>> __USE_MISC is glibc specific and not available in musl libc. Only do >>> this check when

Re: [PATCH] MIPS: smp-mt: fix missing task_stack_page compile error

2017-03-12 Thread Hauke Mehrtens
On 03/12/2017 07:15 PM, Hauke Mehrtens wrote: > arch/mips/include/asm/processor.h references task_stack_page, but it is > not defined anywhere. Including linux/sched/task_stack.h directly in > asm/processor.h caused a different compile warning. > > This fixes the folowing compile

[PATCH 4/4] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-03-12 Thread Hauke Mehrtens
From: David Heidelberger Musl provides its own ethhdr struct definition. Add a guard to prevent its definition of the appropriate musl header has already been included. Signed-off-by: John Spencer Tested-by: David Heidelberger Signed-off-by: Jonas Gorski --- include/uapi/linux/if_ether.h

[PATCH 0/4] uapi glibc compat: fix musl libc compatibility

2017-03-12 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (3): uapi glibc compat: add libc compat code when not build for kernel uapi glibc

[PATCH 1/4] uapi glibc compat: add libc compat code when not build for kernel

2017-03-12 Thread Hauke Mehrtens
Instead of checking if this header file is used in the glibc, check if iti is not used in kernel context, this way it will also work with other libc implementations like musl. Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 8 1 file changed, 4 insertions(+), 4

[PATCH 2/4] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-03-12 Thread Hauke Mehrtens
defines. Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 7c1fead03c50..49a8cc3138ae 100644 --- a/include/uapi/linux/libc-compat.h +++ b/include/uapi

[PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-03-12 Thread Hauke Mehrtens
__USE_MISC is glibc specific and not available in musl libc. Only do this check when glibc is used. This fixes a problem with musl libc. Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux

[PATCH] MIPS: smp-mt: fix missing task_stack_page compile error

2017-03-12 Thread Hauke Mehrtens
recipe for target 'arch/mips/kernel/smp-mt.o' failed Fixes: f3ac60671954 ("sched/headers: Move task-stack related APIs from to ") Signed-off-by: Hauke Mehrtens --- arch/mips/kernel/smp-mt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/kernel/smp-mt.

Re: [PATCH v2] MAINTAINERS: Add Jon Mason to BCM5301X maintainers

2017-02-21 Thread Hauke Mehrtens
On 02/09/2017 12:43 AM, Jon Mason wrote: > Adding myself as a maintainer for Broadcom Northstar SoCs. Also, adding > a regex entry to discover the SVK DTs already present. > > Signed-off-by: Jon Mason Acked-by: Hauke Mehrtens > --- > MAINTAINERS | 2 ++ > 1 file

Re: [PATCH] spi: lantiq-ssc: fix platform_no_drv_owner.cocci warnings

2017-02-19 Thread Hauke Mehrtens
cci > > CC: Hauke Mehrtens > Signed-off-by: Fengguang Wu Acked-by: Hauke Mehrtens > --- > > spi-lantiq-ssc.c |1 - > 1 file changed, 1 deletion(-) > > --- a/drivers/spi/spi-lantiq-ssc.c > +++ b/drivers/spi/spi-lantiq-ssc.c > @@ -970,7 +970,6 @@ stati

[PATCH] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-01-21 Thread Hauke Mehrtens
defines. Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 44b8a6bd5fe1..dbf16a3de4d2 100644 --- a/include/uapi/linux/libc-compat.h +++ b/include/uapi

Re: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c

2016-12-24 Thread Hauke Mehrtens
On 12/22/2016 12:27 AM, kbuild test robot wrote: > Hi Paul, > > [auto build test ERROR on mtd/master] > [also build test ERROR on v4.9 next-20161221] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci

Re: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c

2016-12-24 Thread Hauke Mehrtens
On 12/22/2016 10:01 AM, Boris Brezillon wrote: > +Brian > > On Wed, 21 Dec 2016 16:19:00 +0100 > Hauke Mehrtens wrote: > >> On 12/20/2016 10:18 PM, Paul Gortmaker wrote: >>> In commit d47529b2e9fe0ec2eb1f072afad8849f52e385c4 ("gpio: don't >>&

Re: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c

2016-12-21 Thread Hauke Mehrtens
On 12/20/2016 10:18 PM, Paul Gortmaker wrote: > In commit d47529b2e9fe0ec2eb1f072afad8849f52e385c4 ("gpio: don't > include module.h in shared driver header") we fixed a bunch of > implicit includes and then did what the shortlog says -- remove > module.h from a gpio header. > > In parallel, comm

Re: [PATCH dt V2] ARM: BCM5301X: Enable UART by default for BCM4708(1), BCM4709(4) & BCM53012

2016-12-04 Thread Hauke Mehrtens
the reference boards. ;-) > It seems to be easier to enable it by default and just disable it if we > ever see a device with different hardware design. > > Signed-off-by: Rafał Miłecki Acked-by: Hauke Mehrtens > --- > V2: Update bcm94708.dts bcm94709.dts bcm953012er.dts &

Re: [PATCH v3 0/4] MIPS: Remote processor driver

2016-10-17 Thread Hauke Mehrtens
On 10/11/2016 03:42 PM, Matt Redfearn wrote: > > The MIPS remote processor driver allows non-Linux firmware to take > control of and execute on one of the systems VPEs. The CPU must be > offlined from Linux first. A sysfs interface is created which allows > firmware to be loaded and changed at run

Re: [PATCH V2] usb: xhci: add support for performing fake doorbell

2016-10-17 Thread Hauke Mehrtens
On 10/17/2016 10:30 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Broadcom's Northstar XHCI controllers seem to need a special start > procedure to work correctly. There isn't any official documentation of > this, the problem is that controller doesn't detect any connected > devices with def

Re: [PATCH v3 4/4] MIPS: Deprecate VPE Loader

2016-10-12 Thread Hauke Mehrtens
This interface is currently used by the Intel / Lantiq voice Firmware. This firmware is used by all Intel / Lantiq MIPS SoCs when they should support analog voice. What is the proposed timeline for the removal of this interface? Hauke On 10/11/2016 03:42 PM, Matt Redfearn wrote: > The MIPS remot

ubifs: regression: unable to mount ubifs

2016-06-18 Thread Hauke Mehrtens
The commit 322ea0bb "mtd: switch ubi_open_volume_path() to vfs_stat()" breaks mounting ubifs volumes for me. On kernel 4.7-rc3 I am getting the following error when trying to mount an ubifs volume. This volume in on a ubi file system which exports it as a mtd partition. root@lede:/# mkdir /tmp/te

Re: Unclear BSD licensing (headers, MODULE_LICENSE, versions)

2016-05-15 Thread Hauke Mehrtens
On 05/15/2016 12:44 AM, Rafał Miłecki wrote: > Hi, .. > Another problem is text of BSD license > > 1) Some BSD 2-clause licensed sources don't link to its content. > > In case of GPLv2 some sources simply mention this license and refer to > COPYING. Few examples: > a) drivers/bcma/main.c

Re: [PATCH] ARM: BCM5301X: Add DT for Luxul XAP-1510

2016-05-05 Thread Hauke Mehrtens
On 05/05/2016 12:36 AM, Rafał Miłecki wrote: > On 4 May 2016 at 20:53, Florian Fainelli wrote: >> On 03/05/16 10:28, Dan Haab wrote: >>> Luxul XAP-1510 is an AP device based on BCM4708 SoC. It uses flash >>> memory connected to the SPI controller. >> >> Looks fine, except one nit: >> >>> diff --gi

Re: [PATCH] phy: bcm-ns-usb2: new driver for USB 2.0 PHY on Northstar

2016-04-07 Thread Hauke Mehrtens
On 04/05/2016 09:34 PM, Jon Mason wrote: > > > On Wed, Mar 30, 2016 at 5:32 PM, Jon Mason > wrote: > > On Tue, Mar 29, 2016 at 10:01 AM, Rafał Miłecki > wrote: > > Northstar is a family of SoCs used in home routers. They

Re: [PATCH v2] drivers/firmware/broadcom/bcm47xx_nvram.c: fix incorrect __ioread32_copy

2016-03-23 Thread Hauke Mehrtens
On 03/16/2016 12:06 AM, Aaro Koskinen wrote: > Commit 1f330c327900 ("drivers/firmware/broadcom/bcm47xx_nvram.c: use > __ioread32_copy() instead of open-coding") switched to use a generic copy > function, but failed to notice that the header pointer is updated between > the two copies, resulting in

Re: vdso clock_gettime() sometimes broken after sleep

2016-02-20 Thread Hauke Mehrtens
On 01/29/2016 10:32 PM, Hauke Mehrtens wrote: > When using the vdso clock_gettime() it looks like that the clock is > sometimes not going forward when the process sleeps and the clock also > sleeps. This problem only happens with the vdso clock and not with the > normal syscall clock.

Re: [PATCH 15/15] Revert "of/platform: export of_default_bus_match_table"

2016-01-27 Thread Hauke Mehrtens
On 01/27/2016 05:27 AM, Kefeng Wang wrote: > This reverts commit b80443c2211c7daaabd20fbbe9e7beb3fa3408e0. > > After covering to use helper of_platform_default_populate() to populate > the default bus, no need to export of_default_bus_match_table anymore. > > Cc: Masahiro Yamada > Cc: Rob Herrin

Re: [PATCH v3 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2016-01-25 Thread Hauke Mehrtens
On 10/21/2015 10:57 AM, Markos Chandras wrote: > From: Alex Smith > > Add user-mode implementations of gettimeofday() and clock_gettime() to > the VDSO. This is currently usable with 2 clocksources: the CP0 count > register, which is accessible to user-mode via RDHWR on R2 and later > cores, or t

Re: [PATCH v4 5/5] ARM: BCM: Add SMP support for Broadcom 4708

2015-12-02 Thread Hauke Mehrtens
On 12/01/2015 05:24 PM, Kapil Hali wrote: > From: Jon Mason > > Add SMP support for Broadcom's 4708 SoCs. > > Signed-off-by: Jon Mason > Acked-by: Hauke Mehrtens > Tested-by: Hauke Mehrtens > Signed-off-by: Kapil Hali > --- > arch/arm/boot/dts/bcm47

Re: [PATCH v4 4/5] PCI: iproc: Add iProc PCIe MSI support

2015-12-02 Thread Hauke Mehrtens
On 11/27/2015 06:37 PM, Ray Jui wrote: > This patch adds PCIe MSI support for both PAXB and PAXC interfaces on > all iProc based platforms > > The iProc PCIe MSI support deploys an event queue based implementation. > Each event queue is serviced by a GIC interrupt and can support up to 64 > MSI ve

Re: [PATCH v3 1/3] ARM: dts: enable clock support for BCM5301X

2015-11-21 Thread Hauke Mehrtens
e changed, 71 insertions(+), 21 deletions(-) > Acked-by: Hauke Mehrtens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-21 Thread Hauke Mehrtens
On 11/20/2015 10:53 PM, Arend van Spriel wrote: > On 11/19/2015 08:48 AM, Kalle Valo wrote: >> Hauke Mehrtens writes: >> >>> On 11/18/2015 03:45 PM, Kalle Valo wrote: >>>> Part of reorganising wireless drivers directory and Kconfig. Note >>>> that

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-18 Thread Hauke Mehrtens
On 11/18/2015 03:45 PM, Kalle Valo wrote: > Part of reorganising wireless drivers directory and Kconfig. Note that I had > to > edit Makefiles from subdirectories to use the new location. > > Signed-off-by: Kalle Valo > --- I would prefer to remove the brcm80211 directory in this process and cr

Re: [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC

2015-11-17 Thread Hauke Mehrtens
IPROC_BCMA. > > Signed-off-by: Arnd Bergmann > Fixes: 4785ffbdc9b5 ("PCI: iproc: Add BCMA PCIe driver") > Acked-by: Hauke Mehrtens Thanks for spotting and fixing this. hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708

2015-11-06 Thread Hauke Mehrtens
On 11/07/2015 12:27 AM, Hauke Mehrtens wrote: > On 11/06/2015 11:54 PM, Jon Mason wrote: >> On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: >>> On 11/06/2015 10:11 PM, Kapil Hali wrote: >>>> From: Jon Mason >>>> >>>> Add SMP

Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708

2015-11-06 Thread Hauke Mehrtens
On 11/06/2015 11:54 PM, Jon Mason wrote: > On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: >> On 11/06/2015 10:11 PM, Kapil Hali wrote: >>> From: Jon Mason >>> >>> Add SMP support for Broadcom's 4708 SoCs. >>> >>> Signed-

Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708

2015-11-06 Thread Hauke Mehrtens
On 11/06/2015 10:11 PM, Kapil Hali wrote: > From: Jon Mason > > Add SMP support for Broadcom's 4708 SoCs. > > Signed-off-by: Jon Mason > Acked-by: Hauke Mehrtens > Tested-by: Hauke Mehrtens > Signed-off-by: Kapil Hali I tested this on a Netgear R625

Re: [PATCH RESEND 0/4] SMP support for Broadcom NSP

2015-11-05 Thread Hauke Mehrtens
On 11/05/2015 10:34 AM, Russell King - ARM Linux wrote: > On Thu, Nov 05, 2015 at 12:51:17AM -0500, Kapil Hali wrote: >> Hi, >> >> This series adds SMP support for Broadcom's Northstar Plus SoC. >> >> There are similar SMP enablement methods for many ARMv7 bsed SoCs. >> BCM NSP SoC, has a typical s

  1   2   >