On Tue, Oct 17, 2017 at 12:15 AM, Sean Paul wrote:
> On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma
> wrote:
>> Replace instances of drm_framebuffer_reference/unreference() with
>> *_get/put() suffixes and drm_dev_unref with *_put() suffix
>> because get/put is shorter
@
identifier s.i,s.f;
expression s.e;
statement S;
@@
list_for_each_entry(i,e,f)
- {
S
- }
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
b
@
identifier s.i,s.f;
expression s.e;
statement S;
@@
list_for_each_entry(i,e,f)
- {
S
- }
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/omapdrm/dss/display.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
b/dri
;
@@
(
-drm_framebuffer_unreference(ex);
+drm_framebuffer_put(ex);
|
-drm_dev_unref(ex);
+drm_dev_put(ex);
|
-drm_framebuffer_reference(ex);
+drm_framebuffer_get(ex);
)
Signed-off-by: Harsha Sharma
---
Changes in v5:
-rebase drm_dev_put change on drm-tip
Changes in v4:
-change one instance of *_put to *_get
Changes in
Done with following coccinelle patch
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Harsha Sharma
---
Changes in v4:
-Removed git diff warning "No newline at end of file"
Changes in v3:
-Remove
Done with following coccinelle patch
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Harsha Sharma
---
Changes in v3:
-Removed unnecessary lines
-Remove more useless casts
Changes in v2:
-Remove unnecess
Done with following coccinelle patch
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Remove unnecessary parentheses
-Remove one more useless cast
drivers/gpu/drm/
On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma
wrote:
> Replace instances of drm_framebuffer_reference/unreference() with
> *_get/put() suffixes and drm_dev_unref with *_put() suffix
> because get/put is shorter and consistent with the
> kernel use of *_get/put suffixes.
> Done
Done with following coccinelle patch
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c| 6 +++---
drivers/gpu/drm/amd/powerplay/hw
Prefer kcalloc over kzalloc to allocate an array.
This patch fixes checkcpatch issue.
Signed-off-by: Harsha Sharma
---
Changes in v2:
-kcalloc will take 3 arguments
drivers/gpu/drm/drm_crtc_helper.c | 4 ++--
drivers/gpu/drm/drm_fb_helper.c| 2 +-
drivers/gpu/drm/drm_plane_helper.c | 2
ccinelle.T2 = T[:-2];
else:
coccinelle.T2 = T;
print T, coccinelle.T2
@r2@
type r1.T;
identifier c1.T2;
@@
-typedef
struct
+ T2
{ ... }
-T
;
@r3@
type r1.T;
identifier c1.T2;
@@
-T
+struct T2
Signed-off-by: Harsha Sharma
---
net/netfilter/nf_conntrack_h323_asn1.c | 80 +---
Prefer kcalloc over kzalloc to allocate an array.
This patch fixes checkcpatch issue.
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/drm_crtc_helper.c | 4 ++--
drivers/gpu/drm/drm_fb_helper.c| 2 +-
drivers/gpu/drm/drm_plane_helper.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions
;
@@
(
-drm_framebuffer_unreference(ex);
+drm_framebuffer_put(ex);
|
-drm_dev_unref(ex);
+drm_dev_put(ex);
|
-drm_framebuffer_reference(ex);
+drm_framebuffer_get(ex);
)
Signed-off-by: Harsha Sharma
---
Changes in v4:
-change one instance of *_put to *_get
Changes in v3:
-Removed changes in selftests
Changes in v2
;
@@
(
-drm_framebuffer_unreference(ex);
+drm_framebuffer_put(ex);
|
-drm_dev_unref(ex);
+drm_dev_put(ex);
|
-drm_framebuffer_reference(ex);
+drm_framebuffer_get(ex);
)
Signed-off-by: Harsha Sharma
---
Changes in v3:
-Removed changes in selftests
Changes in v2:
-Added cocinelle patch in log message
-cc to all driver
Space is required after ',' according to linux-kernel coding style.
Signed-off-by: Harsha Sharma
---
Other patches from this patchset have already been merged and only
this one is remaining.
Changes in v3:
-Change log message and rebase against staging-testing
Changes in v2:
-Reba
On Fri, Sep 29, 2017 at 10:00 AM, Harsha Sharma
wrote:
> Replace instances of drm_framebuffer_reference/unreference() with
> *_get/put() suffixes and drm_dev_unref with *_put() suffix
> because get/put is shorter and consistent with the
> kernel use of *_get/put suffixes.
> Done
On Wed, Sep 13, 2017 at 2:11 AM, Greg KH wrote:
> On Tue, Sep 12, 2017 at 07:05:23PM +0530, Harsha Sharma wrote:
>> Space required after ','
>>
>> Signed-off-by: Harsha Sharma
>> ---
>> Changes in v2:
>> -Rebase against staging-testing and solve
Convert instances of dev_error to DRM_DEV_ERROR as we have
DRM_DEV_ERROR variants of drm print macros.
Signed-off-by: Harsha Sharma
---
Changes in v3:
-Solve merge conflicts
Changes in v2:
-Fix alignment issues
drivers/gpu/drm/tinydrm/mi0283qt.c | 8
drivers/gpu/drm/tinydrm
Update shell/run-tests.sh to refer /src/nft with a relative path
Signed-off-by: Harsha Sharma
---
tests/shell/run-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
index 4eba0a8..dbddd8d 100755
--- a/tests/shell/run
Add configure with lixtables in INSTALL and required dependencies for
the same
Signed-off-by: Harsha Sharma
---
INSTALL | 11 +++
1 file changed, 11 insertions(+)
diff --git a/INSTALL b/INSTALL
index 3e9a6ad..04981f1 100644
--- a/INSTALL
+++ b/INSTALL
@@ -18,6 +18,12 @@ Installation
Comparisons should place the constant on the right side of the test
as per linux-kernel coding style
Signed-off-by: Harsha Sharma
---
src/evaluate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index 5624ca2..b783054 100644
--- a/src
static const char * array should probably be static const char * const
array
as per linux-kernel coding style
Signed-off-by: Harsha Sharma
---
src/evaluate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index b783054..f48801a 100644
Code indent should use tabs wherever possible
Signed-off-by: Harsha Sharma
---
src/evaluate.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index e767542..5624ca2 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -122,7 +122,7
Issues found using checkpatch.pl
As per linux-kernel coding style, code indent should use tabs wherever
possible and avoid unnecessary spaces.
Comparisons shoukd place the constant on the right side of the test.
static const char * array should be static const * char const array
Harsha Sharma
Add support for IPV6 type 0 routing header reserved field and address
unable to test it with nft-test.py
Signed-off-by: Harsha Sharma
---
include/exthdr.h | 2 ++
src/exthdr.c | 7 +--
tests/py/ip6/rt.t | 2 ++
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/include
Convert instances of dev_error to DRM_DEV_ERROR as we have
DRM_DEV_ERROR variants of drm print macros.
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Fix alignment issues
drivers/gpu/drm/tinydrm/mi0283qt.c | 8
drivers/gpu/drm/tinydrm/repaper.c | 26
;
@@
(
-drm_framebuffer_unreference(ex);
+drm_framebuffer_put(ex);
|
-drm_dev_unref(ex);
+drm_dev_put(ex);
|
-drm_framebuffer_reference(ex);
+drm_framebuffer_get(ex);
)
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Added coccinelle patch in log message
-cc to all driver-specific mailing lists
Replace instances of drm_framebuffer_reference/unreference() with
*_get/put() suffixes and drm_dev_unref with *_put() suffix
because get/put is shorter and consistent with the
kernel use of *_get/put suffixes .
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/i915/i915_pci.c
;
expression e;
position p;
@@
e = i@p
@bad@
position p != {r1.p,ok1.p};
identifier r1.i;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct option i[] = { ... };
Signed-off-by: Harsha Sharma
---
iptables/ip6tables.c | 2 +-
iptables/iptables.c | 2
The contents of the header file are used only by this single source file.
Moved content into iio-trig-bfin-timer.c and removed iio-trig-bfin-timer.h
Signed-off-by: Harsha Sharma
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 20 ++-
drivers/staging/iio/trigger/iio-trig
Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/
ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros
Done using following coccinelle semantic patch
@r@
@@
(
-dev_info
+DRM_DEV_INFO
|
-dev_err
+DRM_DEV_ERROR
|
-dev_dbg
+DRM_DEV_DEBUG
)
Signed-off-by: Harsha Sharma
Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/
ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros
Done using following coccinelle semantic patch
@r@
@@
(
-dev_info
+DRM_DEV_INFO
|
-dev_err
+DRM_DEV_ERROR
|
-dev_dbg
+DRM_DEV_DEBUG
)
Signed-off-by: Harsha Sharma
Convert instances of dev_error to DRM_DEV_ERROR as we have
DRM_DEV_ERROR variants of drm print macros.
Signed-off-by: Harsha Sharma
---
drivers/gpu/drm/tinydrm/mi0283qt.c | 8
drivers/gpu/drm/tinydrm/repaper.c | 26 +-
drivers/gpu/drm/tinydrm/st7586.c | 6
ccinelle.T2 = T[:-2];
else:
coccinelle.T2 = T;
print T, coccinelle.T2
@r2@
type r1.T;
identifier c1.T2;
@@
-typedef
struct
+ T2
{ ... }
-T
;
@r3@
type r1.T;
identifier c1.T2;
@@
-T
+struct T2
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Convert structure name to lowercase
.../vc04_se
ccinelle.T2 = T[:-2];
else:
coccinelle.T2 = T;
print T, coccinelle.T2
@r2@
type r1.T;
identifier c1.T2;
@@
-typedef
struct
+ T2
{ ... }
-T
;
@r3@
type r1.T;
identifier c1.T2;
@@
-T
+struct T2
Signed-off-by: Harsha Sharma
---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 44 +++-
e2;
|
(<+...++e1...+>)=e2;
|
(<+...--e1...+>)=e2;
|
e1=e2;
e1 = <+...e1...+>;
|
*e1=e2;
*e1=e3;
)
Signed-off-by: Harsha Sharma
---
drivers/staging/rtlwifi/base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
Remove unused variable ret as it is not used anywhere.
Remove multiple blank lines.
Done using following coccinelle semantic patch
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl
Merge assignment with return statement to directly return the value.
Done using following coccinelle semantic patch
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 20
Space required after ','
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Rebase against staging-testing and solve merge conflicts
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl872
Space between function name and open parentheses '(' is prohibited.
Space is required around most binary operators '=', '==', '+=',
'<', ':', '+', '-'
Space required before '&', '*'
Space i
Remove space between function name and open parenthesis '('
Remove space before ';', '++', ','
Signed-off-by: Harsha Sharma
---
Change in v3:
-Fix small spelling mistake
Change in v2:
-Merge patches 07/10 and 08/10
drivers/staging/rtl8723bs/os_dep/os_i
Remove space between function name and open parenthesis '('
Remove space before ';', '++', ','
Signed-off-by: Harsha Sharma
---
Change in v2:
-Merge patches 07/10 and 08/10
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file change
This coding style (foo *bar) is more common for the kernel code.
Change foo* bar to foo *bar.
Change foo * bar to foo *bar.
Change (foo*) to (foo *).
Signed-off-by: Harsha Sharma
---
Change in v3:
-Rebase against staging-testing branch
Change in v2:
-Updated log message and subject
drivers
Blank lines aren't necessary after an open brace and before a close brace
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/o
Follow linux-kernel code style for conditional statements
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 63 +
1 file changed, 19 insertions(+), 44 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers
Remove space before ';', '++', ','
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/o
Remove space between function name and open parenthesis '('
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl872
Space required after ','
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
ind
Use spaces between concatenated strings
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 50 ++---
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs
No spaces at the start of a line
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 5ceccd7..97ff3ab
Use spaces around most binary operators
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index
Use one space around most binary operators
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
Use one space around (on each side of) '=' operator
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging
e a single
statement will do and put the opening brace last on the line, and put
the closing brace first. Unnecessary spaces and blank lines should be
avoided.
Harsha Sharma (10):
staging: rtl8723bs: Add spaces around '='
staging: rtl8723bs: Add spaces around '+', '|
Use one space around most binary operators
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs
This coding style (foo *bar) is more common for the kernel code.
Change foo* bar to foo *bar.
Change foo * bar to foo *bar.
Change (foo*) to (foo *).
Signed-off-by: Harsha Sharma
---
Change in v2:
-Updated log message and subject
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +-
1
This coding style (foo *bar) is more common for the kernel code.
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs
Static variables are initialised to 0 by gcc
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 48 ++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
b/drivers/staging/rtl8723bs
This was reported by checkpatch.pl
Signed-off-by: Harsha Sharma
---
drivers/staging/sm750fb/sm750_cursor.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_cursor.c
b/drivers/staging/sm750fb/sm750_cursor.c
index aa47a16..6b27b06 100644
--- a/drivers/staging
State explicitly that individual entries in array will not change.
Signed-off-by: Harsha Sharma
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys
Make code more concise and readable
Signed-off-by: Harsha Sharma
---
Change in v3:
-Change in subject and log message
Change in v2:
-Change in subject
-Change in log message
drivers/staging/typec/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Makes code more concise and readable
Signed-off-by: Harsha Sharma
---
Change in v2:
-Change in subject
-Change in log message
drivers/staging/typec/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index
Fixes coding style issue
Signed-off-by: Harsha Sharma
---
drivers/staging/typec/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 630fe75..9f4a5a5 100644
--- a/drivers/staging/typec/tcpm.c
+++ b/drivers
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
Signed-off-by: Harsha Sharma
---
Changes in v6:
-Added changes from other versions
Changes in v5:
-Signed-off properly with correct author name in .gitconfig
Changes in v4:
-Correct the format of the s
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
Signed-off-by: Harsha Sharma
---
Changes in v5:
-Correct the format of the subject.
-Signed-off properly with correct author name in .gitconfig
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed
65 matches
Mail list logo