[PATCH] staging:kpc2000: Fix long constant sparse warning

It fixed following warning in kpc2000 driver "constant is so big it is unsigned long" Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 18 +- drivers/staging/kpc2000/kpc2000/core.c | 18 +- drivers/staging/kpc20

[PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

Bitwise OR(|) operation with 0 always yield same result. It fixes dubious x | !y sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc2000_i2c.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b

[PATCH 2/2] staging:kpc2000:Fix integer as null pointer warning

It fixes "Using plain integer as NULL pointer" sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c b/drivers/staging/kpc20

[PATCH 0/2] staging:kpc2000:Fix integer as null pointer warning

It fixes sparse warning in kpc2000 driver. Harsh Jain (2): staging:kpc2000:Fix symbol not declared warning staging:kpc2000:Fix integer as null pointer warning drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1

[PATCH 1/2] staging:kpc2000:Fix symbol not declared warning

It fixes "symbol was not declared. Should it be static?" sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c b/drivers/stagi

Re: [PATCH 0/2] staging:kpc2000:Fix integer as null pointer warning

On Fri, Jun 28, 2019 at 10:31 PM Harsh Jain wrote: > > From: root Again sent with wrong user. Please ignore this series. Will send the updated one. > > It fixes sparse warning in kpc2000 driver. > > Harsh Jain (2): > staging:kpc2000:Fix symbol not declared warning &g

[PATCH 2/2] staging:kpc2000:Fix integer as null pointer warning

From: root It fixes "Using plain integer as NULL pointer" sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c b/drivers/stagi

[PATCH 1/2] staging:kpc2000:Fix symbol not declared warning

From: root It fixes "symbol was not declared. Should it be static?" sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c

[PATCH 0/2] staging:kpc2000:Fix integer as null pointer warning

From: root It fixes sparse warning in kpc2000 driver. Harsh Jain (2): staging:kpc2000:Fix symbol not declared warning staging:kpc2000:Fix integer as null pointer warning drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1

[PATCH] staging:kpc2000:Fix sparse warnings

From: root Fix following sparse warning symbol was not declared. Should it be static? Using plain integer as NULL pointer Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

Re: linux-next: Signed-off-by missing for commit in the crypto tree

On 23-12-2018 18:00, Herbert Xu wrote: > On Sun, Dec 23, 2018 at 11:13:04PM +1100, Stephen Rothwell wrote: >> Hi Herbert, >> >> Commit >> >> 6501ab5ed4d9 ("crypto: chelsio - Reset counters on cxgb4 Detach") >> >> is missing a Signed-off-by from its author. > Hi Stephen: > > I believe the issue

Re: [PATCH] crypto: chelsio: move chcr_ahash_continue declation out of header

Hi, Fix for that is already submitted in below patch. https://patchwork.kernel.org/patch/10292333/ Thanks On 28-03-2018 19:35, Arnd Bergmann wrote: > static function declarations don't belong in a header file, as shown > by this compiler warning: > > In file included from /git/arm-soc/drivers/

Re: linux-next: build warning after merge of the crypto tree

to: chelsio -Split Hash requests for large scatter > gather list") > Hi Stephen/Herbert, I will submit the fix to cryptodev tree. Thanks & Regards Harsh Jain

Re: linux-next: build warning after merge of the crypto tree

Hi Herbert, It's an indentation issue. Seems checkpatch and default compile options does not report this warning. How would you like to take the fix. Should I sent whole series again with fix or only indentation patch. On 19-01-2018 07:19, Stephen Rothwell wrote: > Hi Herbert, > > After mergi

Re: [PATCH] iommu/vt-d: Fix scatterlist offset handling

> > To that end, fix the intel_map_sg() path to line up the mapping > correctly (in units of MM pages rather than VT-d pages to match the > aligned_nrpages() calculation) regardless of the offset, and use > sg_phys() consistently for clarity. > > Reported-by: Harsh Jain > Sign

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

21e9c02fe ro intel_iommu=sp_off crashkernel=auto rhgb quiet rhgb quiet console=ttyS0,115200, console=tty0 LANG=en_US.UTF-8 > > On Thu, Sep 28, 2017 at 07:08:21PM +0530, Harsh Jain wrote: >> >> Today I tried with "Intel_iommu=sp_off" boot option. Traffic runs without >>

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 28-09-2017 02:59, Casey Leedom wrote: > Hey Raj, > > Let us know if you need help in gathering more debugging information. For > the time being we've decided to ERRATA the use of the Intel I/O MMU with > IPsec till we Root Cause the issue. But this is still at the top of Harsh's > bug list

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 28-09-2017 03:43, Casey Leedom wrote: > | From: Raj, Ashok > | Sent: Wednesday, September 27, 2017 12:07 PM > | > | looking at the debug output i got from Harsh it still looks like a bug in > | the code. > | > | [ 538.284589] __domain_mapping nr_pages 0x1 > | [ 538.284600] __domain_mapping sg

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 26-09-2017 01:41, Dan Williams wrote: > On Mon, Sep 25, 2017 at 1:05 PM, Casey Leedom wrote: >> | From: Dan Williams >> | Sent: Monday, September 25, 2017 12:31 PM >> | ... >> | IIUC it looks like this has been broken ever since commit e1605495c716 >> | "intel-iommu: Introduce domain_sg_mapp

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

Find attached new set of log. After repeated tries it panics. On 26-09-2017 09:16, Harsh Jain wrote: > On 26-09-2017 00:16, Casey Leedom wrote: >> | From: Raj, Ashok >> | Sent: Monday, September 25, 2017 8:54 AM >> | >> | Not sure how the page->offset would end u

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 26-09-2017 00:15, David Woodhouse wrote: > On Wed, 2017-09-20 at 16:01 +0800, Herbert Xu wrote: >> Harsh Jain wrote: >>>   >>> While debugging DMA mapping error in chelsio crypto driver we >> observed that when scatter/gather list received by driver has some

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 26-09-2017 00:16, Casey Leedom wrote: > | From: Raj, Ashok > | Sent: Monday, September 25, 2017 8:54 AM > | > | Not sure how the page->offset would end up being greater than page-size? Refer below > | > | If you have additional traces, please send them by. > | > | Is this a new driver? wonderi

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 20-09-2017 13:31, Herbert Xu wrote: > Harsh Jain wrote: >> While debugging DMA mapping error in chelsio crypto driver we observed that >> when scatter/gather list received by driver has some entry with page->offset >> > 4096 (PAGE_SIZE). It starts giving DMA err

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

On 20-09-2017 15:42, Robin Murphy wrote: > On 20/09/17 09:01, Herbert Xu wrote: >> Harsh Jain wrote: >>> While debugging DMA mapping error in chelsio crypto driver we observed that >>> when scatter/gather list received by driver has some entry with >>>

DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

received sg list. 3) Since Without IOMMU every thing works fine. We are expecting IOMMU bugs. Regards Harsh Jain

Re: [PATCH v7 00/19] simplify crypto wait for async op

On Sun, Sep 3, 2017 at 11:47 AM, Gilad Ben-Yossef wrote: > On Thu, Aug 31, 2017 at 3:31 PM, Harsh Jain wrote: >> HI Gilad, >> >> I think we need an update in ESP also. Now EBUSY return means driver >> has accepted, Packet should not be dropped in >> >> esp

Re: [PATCH v7 00/19] simplify crypto wait for async op

HI Gilad, I think we need an update in ESP also. Now EBUSY return means driver has accepted, Packet should not be dropped in esp_output_tail() function. . Regards Harsh Jain On Thu, Aug 24, 2017 at 7:48 PM, Gilad Ben-Yossef wrote: > Many users of kernel async. crypto services hav

Re: [PATCH 08/22] crypto: chcr: Make use of the new sg_map helper function

On Fri, Apr 14, 2017 at 3:35 AM, Logan Gunthorpe wrote: > The get_page in this area looks *highly* suspect due to there being no > corresponding put_page. However, I've left that as is to avoid breaking > things. chcr driver will post the request to LLD driver cxgb4 and put_page is implemented the

Re: [PATCH 2/2] crypto: chcr - Fix error checking

On Thu, Apr 13, 2017 at 8:20 PM, Christophe JAILLET wrote: > Le 13/04/2017 à 16:04, Dan Carpenter a écrit : >> >> On Thu, Apr 13, 2017 at 02:14:30PM +0200, Christophe JAILLET wrote: >>> >>> If 'chcr_alloc_shash()' a few lines above fails, 'base_hash' can be an >>> error pointer when we 'goto out'.