Re: [PATCH v12 04/36] remoteproc: k3-m4: Don't assert reset in detach routine

2025-05-20 Thread Hari Nagalla
end this patch on its own and then the series (without this patch) with a note in the cover letter that it depends on the fix. That way we get the best of both worlds. Sure. If I get any comments/reviews on this version, I will re-spin this patch separately than the series. Thanks, Beleswar

Re: [PATCH 1/3] remoteproc: k3-r5: Fix checks in k3_r5_rproc_{mbox_callback/kick}

2024-12-27 Thread Hari Nagalla
On 12/24/24 03:14, Beleswar Padhi wrote: /** @@ -194,8 +196,11 @@ static void k3_r5_rproc_mbox_callback(struct mbox_client *client, void *data) const char *name = kproc->rproc->name; u32 msg = omap_mbox_message(data); - /* Do not forward message from a detached core */ -

Re: [PATCH] rpmsg: char: Export alias for RPMSG ID rpmsg-raw from table

2024-08-08 Thread Hari Nagalla
the original "rpmsg_chrdev" ID. This was the ID used for this driver before it was upstreamed (as reflected by the module alias). Signed-off-by: Andrew Davis Acked/Tested-by: Hari Nagalla --- drivers/rpmsg/rpmsg_char.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

Re: [PATCH 1/7] remoteproc: keystone: Use devm_kasprintf() to build name string

2024-08-08 Thread Hari Nagalla
On 8/2/24 13:22, Andrew Davis wrote: This is simpler and removes the need to assume the id length to be 1 digit, which then removes a W=1 compile warning about the same. Signed-off-by: Andrew Davis Acked/Tested-by: Hari Nagalla --- drivers/remoteproc/keystone_remoteproc.c | 6 +- 1

Re: [PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

2024-07-01 Thread Hari Nagalla
On 6/21/24 10:00, Richard Genoud wrote: Richard Genoud (4): remoteproc: k3-r5: Fix IPC-only mode detection remoteproc: k3-r5: Introduce PM suspend/resume handlers remoteproc: k3-r5: k3_r5_rproc_stop: code reorder remoteproc: k3-r5: support for graceful stop of remote cores IMO, the pa

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-07-01 Thread Hari Nagalla
our assessment seems to be correct. That said I'd like to have an RB or a TB from someone in the TI delegation - guys please have a look. Agree with Richard's assessment, and the proposed fix looks good. Reviewed-by: Hari Nagalla

[PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-06-04 Thread Hari Nagalla
The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It does not have an addressable l1dram . So, remove this optional sram property from the bindings to fix device tree build warnings. Signed-off-by: Hari Nagalla --- Changes in v3: *) Use allOf keyword with separate ifs for each

[PATCH v2] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-05-30 Thread Hari Nagalla
The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It does not have an addressable l1dram . So, remove this optional sram property from the bindings to fix device tree build warnings. Signed-off-by: Hari Nagalla --- Changes from v1 to v2: *) Kept back memory-regions property, as

Re: [PATCH 13/13] mailbox: omap: Remove kernel FIFO message queuing

2024-04-01 Thread Hari Nagalla
On 3/25/24 12:20, Andrew Davis wrote: The kernel FIFO queue has a couple issues. The biggest issue is that it causes extra latency in a path that can be used in real-time tasks, such as communication with real-time remote processors. The whole FIFO idea itself looks to be a leftover from before

Re: [PATCH 12/13] mailbox: omap: Reverse FIFO busy check logic

2024-04-01 Thread Hari Nagalla
On 3/25/24 12:20, Andrew Davis wrote: static int omap_mbox_chan_send_noirq(struct omap_mbox *mbox, u32 msg) { - int ret = -EBUSY; + if (mbox_fifo_full(mbox)) + return -EBUSY; - if (!mbox_fifo_full(mbox)) { - omap_mbox_enable_irq(mbox, IRQ_RX); -

[PATCH v7 3/5] remoteproc: k3: Move out functions common with M4 driver

2024-02-02 Thread Hari Nagalla
From: Martyn Welch In the next commit we will be adding the M4F driver which shares a lot of commonality with the DSP driver. Move this shared functionality out so that it can be used by both drivers. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla --- Changes since v2: - New patch

[PATCH v7 4/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-02-02 Thread Hari Nagalla
and the other, a local reset is only for the M4F processing core. When loading the image, the driver first releases the subsystem reset, loads the firmware image and then releases the local reset to let the M4F processing core run. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla

[PATCH v7 1/5] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

2024-02-02 Thread Hari Nagalla
e M4F subsystems. The YAML binding document provides the various node properties to be configured by the consumers of the M4F subsystem. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla --- Changes since v1: - Spelling corrections - Corrected to pass DT checks Changes since v2: - Missed spe

[PATCH v7 5/5] arm64: defconfig: Enable TI K3 M4 remote proc driver

2024-02-02 Thread Hari Nagalla
Enable CONFIG_TI_K3_M4_REMOTEPROC Some K3 platform devices (AM64x, AM62x) have a Cortex M4 core. Build the M4 remote proc driver as a module for these platforms. Signed-off-by: Hari Nagalla --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs

[PATCH v7 2/5] remoteproc: k3: Move out data structures common with M4 driver

2024-02-02 Thread Hari Nagalla
From: Martyn Welch We will be adding the M4F driver which shares a lot of commonality with the DSP driver. Common data structures are introduced here. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla --- Changes since v5: - Created a separate patch for data structures to ease review

[PATCH v7 0/5] TI K3 M4F support on AM64x and AM62x SoCs

2024-02-02 Thread Hari Nagalla
/5ba77847343f22b5f9ec2b7aeabc410aaf8cdf45 Hari Nagalla (2): dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs arm64: defconfig: Enable TI K3 M4 remote proc driver Martyn Welch (3): remoteproc: k3: Move out data structures common with M4 driver remoteproc: k3: Move out functions common with M4

Re: [PATCH v3 3/5] remoteproc: k3-r5: Add support for IPC-only mode for all R5Fs

2023-12-08 Thread Hari Nagalla
On 11/2/23 11:43, Jan Kiszka wrote: RTI1 watchdog also powers up R5F core 1. And this could happen either in When writing "... also powers up...", other than R5F core 1, what else is being powered? Would be a question for the SoC vendor - I assumed that only mcu_rti1 [1] goes on when enabling i

Re: [PATCH v6 1/4] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

2023-09-13 Thread Hari Nagalla
$id:http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# >> +$schema:http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI K3 M4F processor subsystems >> + >> +maintainers: >> + - Hari Nagalla >> + - Mathieu Poirier > Are you sure

[PATCH v6 3/4] remoteproc: k3: Split out functions common with M4 driver

2023-09-13 Thread Hari Nagalla
From: Martyn Welch In the next commit we will be adding the M4F driver which shares a lot of commonality with the DSP driver. Split this shared functionality out so that it can be used by both drivers. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla --- Changes since v2: - New patch

[PATCH v6 0/4] TI K3 M4F support on AM64x and AM62x SoCs

2023-09-13 Thread Hari Nagalla
2022) for further details: https://www.ti.com/lit/pdf/SPRUIV7A Hari Nagalla (1): dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs Martyn Welch (3): remoteproc: k3: Split out data structures common with M4 driver remoteproc: k3: Split out functions common with M4 driver remoteproc: k3-m4

[PATCH v6 4/4] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2023-09-13 Thread Hari Nagalla
and the other, a local reset is only for the M4F processing core. When loading the image, the driver first releases the subsystem reset, loads the firmware image and then releases the local reset to let the M4F processing core run. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla

[PATCH v6 1/4] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

2023-09-13 Thread Hari Nagalla
e M4F subsystems. The YAML binding document provides the various node properties to be configured by the consumers of the M4F subsystem. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla --- Changes since v1: - Spelling corrections - Corrected to pass DT checks Changes since v2: - Missed spe

[PATCH v6 2/4] remoteproc: k3: Split out data structures common with M4 driver

2023-09-13 Thread Hari Nagalla
From: Martyn Welch We will be adding the M4F driver which shares a lot of commonality with the DSP driver. Common data structures are introduced here. Signed-off-by: Martyn Welch Signed-off-by: Hari Nagalla --- Changes in v6: - Created a separate patch for data structures to ease review