[PATCHv2] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

Len field is already set to zero, but not the from field which is sent as 0xfe00. This makes no sense, and may cause confuse server implementations doing sanity checks (qemu-nbd is an example.) Signed-off-by: Hani Benhabiles --- Compared to v1: * Zero the request structure instead

Re: [PATCH] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

On Sun, May 25, 2014 at 02:11:13PM -0400, Paul Clements wrote: > On Sun, May 25, 2014 at 6:18 AM, Hani Benhabiles wrote: > > On Sun, May 18, 2014 at 10:11:13AM +0100, Hani Benhabiles wrote: > >> On Fri, May 16, 2014 at 10:56:33PM -0400, Paul Clements wrote: > >> &g

Re: [PATCH] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

On Sun, May 18, 2014 at 10:11:13AM +0100, Hani Benhabiles wrote: > On Fri, May 16, 2014 at 10:56:33PM -0400, Paul Clements wrote: > > Agreed. But better yet, the request structure should just be zeroed when > > it's allocated. > > > > It is already initia

Re: [PATCH] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

fffe00 after the left shifts.) This is the only (non-ugly / non-intrusive) way to do it afaict. > -- > Paul > > > On Fri, May 16, 2014 at 7:43 PM, Hani Benhabiles wrote: > > > Len field is already set to zero, but not the from field which is sent as > >

[PATCH] nbd: Zero from and len fields in NBD_CMD_DISCONNECT.

Len field is already set to zero, but not the from field which is sent as 0xfe00. This makes no sense, and may cause confuse server implementations doing sanity checks (qemu-nbd is an example.) Signed-off-by: Hani Benhabiles --- drivers/block/nbd.c | 2 +- 1 file changed, 1