Backlight off at boot

-reviews/NaicvV6KQUs -- Guillermo Rodriguez Garcia guille.rodrig...@gmail.com

Re: pwm: atmel: Fix disabling of PWM channels

(resending to MLs for the record -- previous message bounced) El viernes, 10 de junio de 2016, Alexandre Belloni escribió: > > Hi, > > On 13/05/2016 at 13:09:37 +0200, Guillermo Rodriguez wrote : > > When disabling a PWM channel, the PWM clock was being stopped > > immediately after writing to PW

Re: [PATCH] pwm: atmel: Fix disabling of PWM channels

*/ > + timeout = jiffies + 2 * HZ; > + while ((atmel_pwm_readl(atmel_pwm, PWM_SR)& (1 << pwm->hwpwm)) && > + time_before(jiffies, timeout)) { > + usleep_range(10, 100); > + } > + > clk_disable(atmel_pwm->clk); > } > > -- > 1.7.9.5 > -- Guillermo Rodriguez Garcia guille.rodrig...@gmail.com

Re: pwm: atmel: PWM may not properly disable

Hello, 2016-05-12 15:24 GMT+02:00 Guillermo Rodriguez Garcia : > 2016-05-12 14:14 GMT+02:00 Thierry Reding : >> On Thu, May 12, 2016 at 01:49:12PM +0200, Guillermo Rodriguez Garcia wrote: >>> Hello, >>> >>> [...] >>> >>> One thing that I&

Re: pwm: atmel: PWM may not properly disable

2016-05-12 14:14 GMT+02:00 Thierry Reding : > On Thu, May 12, 2016 at 01:49:12PM +0200, Guillermo Rodriguez Garcia wrote: >> Hello, >> >> [...] >> >>> One thing that I'd request is that instead of the cpu_relax() you use a >> >>> usleep_rang

Re: pwm: atmel: PWM may not properly disable

while preparing this. If I use usleep_range I keep running into "BUG: scheduling while atomic". This is because I am using the PWM to drive a buzzer with pwm-beeper, and pwm-beeper currently crashes if the PWM driver sleeps. Apparently this patch is needed: https://lkml.org/lkml/2016/2/22/757 However this has not been merged yet. How should I proceed ? Guillermo Rodriguez Garcia guille.rodrig...@gmail.com

Re: pwm: atmel: PWM may not properly disable

2016-05-11 16:31 GMT+02:00 Guillermo Rodriguez Garcia : > Hello, > > 2016-05-11 15:39 GMT+02:00 Thierry Reding : >> On Wed, May 11, 2016 at 10:48:38AM +0200, Guillermo Rodriguez Garcia wrote: >>> Hello all, >>> >>> I am seeing a problem with the atmel-pw

Re: pwm: atmel: PWM may not properly disable

Hello, 2016-05-11 15:39 GMT+02:00 Thierry Reding : > On Wed, May 11, 2016 at 10:48:38AM +0200, Guillermo Rodriguez Garcia wrote: >> Hello all, >> >> I am seeing a problem with the atmel-pwm driver where disabling a PWM >> channel sometimes leaves the output at the

pwm: atmel: PWM may not properly disable

clk); Is this acceptable? Should I submit an updated patch? [1]: http://lxr.free-electrons.com/source/drivers/pwm/pwm-atmel.c#L253 [2]: https://lkml.org/lkml/2014/10/1/605 (If possible, please CC me in any replies) -- Guillermo Rodriguez Garcia guille.rodrig...@gmail.com