Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

#x27;s what will make you and Sudip stop complaining.. just as soon as you fix checkpatch.pl to know an existing error from a new one. -- Greg Donald -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

t/log/?qt=grep&q=gdonald On Mon, Jun 22, 2015 at 6:10 AM, Sudip Mukherjee wrote: > On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote: >> Fix checkpatch.pl "space required before the open parenthesis '('" errors >> >> Signed-off-by: Greg

[PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

Fix checkpatch.pl "space required before the open parenthesis '('" errors Signed-off-by: Greg Donald --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 ++ 1 file changed, 44 insertions(+), 53 deletions(-) diff --git a/drivers/stagin

[PATCH] drivers: staging: sm750fb: Fix "'foo * bar' should be 'foo *bar'" errors

Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors Signed-off-by: Greg Donald --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_help.c | 4 ++-- drivers/staging/sm750fb/ddk750_help.h | 2 +- drivers/staging/sm750fb/ddk

[PATCH] drivers: staging: rtl8723au: Fix "'foo * bar' should be 'foo *bar'" errors

Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors Signed-off-by: Greg Donald --- .../rtl8723au/include/rtl8723a_bt-coexist.h| 177 +++-- drivers/staging/rtl8723au/include/rtl8723a_recv.h | 4 +- drivers/staging/rtl8723au/

[PATCH] drivers: staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors

Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 22 +- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 11 --- ..

[PATCH] drivers: staging: lustre: Fix "spaces required around that '='" errors

Fix checkpatch.pl "spaces required around that '='" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/llite/super25.c | 2 +- drivers/staging/lustre/lustre/obdclass/genops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH] drivers: staging: lustre: Fix "'foo * bar' should be 'foo *bar'" errors

Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/include/dt_object.h | 2 +- drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +- drivers/staging/lustre/lustre/inc

[PATCH] drivers: staging: lustre: Fix 'that open brace { should be on the previous line' errors

Fix checkpatch.pl 'that open brace { should be on the previous line' errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 3 +-- drivers/staging/lustre/lustre/libcfs/hash.c| 25 + 2 files changed, 10 insertions(+), 18

[PATCH] drivers: staging: lustre: Fix "space prohibited before that close parenthesis ')'" errors

Fix checkpatch.pl "space prohibited before that close parenthesis ')'" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/include/lustre_capa.h | 2 +- drivers/staging/lustre/lustre/llite/dir.c | 2 +- drivers/staging/lustre/lustre/llite

[PATCH] drivers: staging: rtl8723au: Fix "open brace '{' following struct go on the same line" errors

Fix checkpatch.pl "open brace '{' following struct go on the same line" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_security.c | 3 +-- drivers/staging/rtl8723au/include/rtl8723a_dm.h | 3 +-- drivers/staging/rtl8723au/include/rtl8723a_rec

[PATCH] drivers: staging: lustre: Fix "else should follow close brace '}'" errors

Fix checkpatch.pl "else should follow close brace '}'" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 ++ drivers/staging/lustre/lustre/llite/dir.c | 3 +-- drivers/staging/lustre/l

[PATCH] drivers: staging: rtl8723au: core: Fix "'foo * bar' should be 'foo *bar'" errors

Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_ap.c| 2 +- drivers/staging/rtl8723au/core/rtw_led.c | 3 ++- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 +-

[PATCH] drivers: staging: lustre: Fix "'foo* bar' should be 'foo *bar'" errors

Fix checkpatch.pl "'foo* bar' should be 'foo *bar'" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/include/dt_object.h | 2 +- drivers/staging/lustre/lustre/include/lu_object.h | 4 ++-- drivers/staging/lustre/lustre/include/lustre_lib.h

[PATCH] drivers: staging: lustre: Fix "open brace '{' following struct go on the same line" errors

Fix checkpatch.pl "open brace '{' following struct go on the same line" errors Signed-off-by: Greg Donald --- .../lustre/include/linux/libcfs/libcfs_private.h | 3 +- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 66 -- .../staging/lustr

Re: [PATCH] scripts: checkpatch.pl: Fix existing typedef false positive warning

On Sun, Sep 21, 2014 at 9:31 PM, Joe Perches wrote: > On Sun, 2014-09-21 at 20:32 -0500, Greg Donald wrote: >> Fixing an "open brace '{' following struct go on the same line" error causes >> a >> false positive warning "do not add new typedefs&qu

[PATCH] scripts: checkpatch.pl: Fix existing typedef false positive warning

Fixing an "open brace '{' following struct go on the same line" error causes a false positive warning "do not add new typedefs". Fix existing typedef false positive warning. Signed-off-by: Greg Donald --- scripts/checkpatch.pl | 16 +--- 1 file changed,

[PATCH] drivers: staging: rtl8723au: Fix "space required after that ','" errors

Fix checkpatch.pl "space required after that ','" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_mlme.c| 39 drivers/staging/rtl8723au/include/odm.h | 2 +- drivers/staging/rtl8723au/include/odm_HWConfig

[PATCH] drivers: staging: lustre: Cleanup src/dst comparisons in obdo_cmp_md()

Cleanup obdo_cmp_md() src/dst comparisons using bitwise OR assignments Suggested-by: Joe Perches Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/obdclass/obdo.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/lustre

[PATCH] drivers: staging: rtl8723au: Fix 'code indent should use tabs where possible' errors

Fix checkpatch.pl 'code indent should use tabs where possible' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_cmd.c | 4 ++-- drivers/staging/rtl8723au/core/rtw_led.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme.c | 12 ++-

[PATCH] drivers: staging: lustre: Fix 'code indent should use tabs where possible' errors

Fix checkpatch.pl 'code indent should use tabs where possible' errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/llite/file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lus

[PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors

Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald --- .../lustre/lustre/obdclass/linux/linux-module.c| 4 ++-- drivers/staging/lustre/lustre/obdclass/obdo.c | 28 +++--- 2 files changed,

[PATCH] drivers: staging: rtl8723au: Fix '"(foo*)" should be "(foo *)"' errors

Fix checkpatch.pl '"(foo*)" should be "(foo *)"' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_ap.c| 14 -- drivers/staging/rtl8723au/core/rtw_cmd.c | 6 +++--- drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH] drivers: staging: rtl8821ae: Fix '"(foo*)" should be "(foo *)"' errors

Fix checkpatch.pl '"(foo*)" should be "(foo *)"' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8821ae/base.h | 26 +++--- drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 8 +++ drivers/staging/rtl8821ae

[PATCH] drivers: staging: rtl8821ae: Fix "space required before that '*'" errors

Fix checkpatch.pl "space required before that '*'" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 6 +++--- drivers/staging/rtl8821ae/btcoexist/habtc8723a1ant.h | 6 +++--- drivers/staging/rtl8821ae/btcoexist/h

[PATCH] drivers: staging: rtl8723au: Fix "space required before that '*'" errors

Fix checkpatch.pl "space required before that '*'" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_recv.c | 2 +- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/st

[PATCH] drivers: staging: rtl8192u: Fix "space required before that '*'" errors

Fix checkpatch.pl "space required before that '*'" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 6 +++--- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 8 driv

[PATCH] drivers: staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors

Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 18 +++- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 4 +-- drivers/staging/rtl8192u/ieee80211/

[PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors

Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/lmv/lmv_internal.h | 2 +- .../lustre/lustre/obdclass/linux/linux-module.c| 4 ++-- drivers/staging/lustre/lustre/obdcl

[PATCH] drivers: staging: lustre: Fix 'do not use C99 // comments' errors

Fix checkpatch.pl 'do not use C99 // comments' errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++-- drivers/staging/lustre/lustre/include/lustre_cfg.h | 2 +- drivers/staging/lustre/lustre/include/lustre_disk.h | 2 +

[PATCH] drivers: staging: rtl8723au: Fix return is not a function, parentheses are not required error

Fix checkpatch.pl return is not a function, parentheses are not required error Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/include/osdep_service.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/osdep_service.h b/drivers

[PATCH] drivers: staging: ft1000: Fix return is not a function, parentheses are not required errors

Fix checkpatch.pl return is not a function, parentheses are not required errors Signed-off-by: Greg Donald --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 9 + drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH] drivers: staging: lustre: Fix return is not a function, parentheses are not required errors

Fix checkpatch.pl return is not a function, parentheses are not required errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/include/lustre_log.h | 2 +- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 2 +- drivers/staging/lustre/lustre/lov/lov_internal.h | 2 +- drivers

Re: [PATCH] new page link in SubmittingPatches

s+off+a+kernel+subsystem+maintainer :) -- Greg Donald -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] drivers: staging: lustre: Fix space required after that ',' errors

Fix checkpatch.pl space required after that ',' errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 2 +- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 6 +++--- .../staging/lustre/lnet/klnds/socklnd/socklnd_proto.c | 6 -

Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

On Mon, Aug 25, 2014 at 8:15 AM, Joe Perches wrote: > On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote: >> Fix checkpatch.pl spaces required around that '?' errors > > It'd be better to convert all parts of the > ternary at the same time. Wouldn't &q

[PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors

Fix checkpatch.pl spaces required around that '?' errors Signed-off-by: Greg Donald --- .../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c | 33 +++--- .../staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.h | 2 +- .../staging/rtl8821ae/btcoexist/habtc8723a1ant.c | 12 ++--- .

[PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '<' errors

Fix checkpatch.pl spaces required around that '<' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8821ae/btcoexist/halbtc8723b2ant.c | 2 +- drivers/staging/rtl8821ae/rtl8821ae/phy.c | 18 +- drivers/staging/rtl8821ae/rtl8821ae/rf.c

[PATCH] drivers: staging: rtl8192u: Fix switch and case should be at the same indent errors

Fix checkpatch.pl switch and case should be at the same indent errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/r8192U_core.c | 510 - 1 file changed, 252 insertions(+), 258 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCH] drivers: staging: rtl8192u: Fix space required after that ',' errors

Fix checkpatch.pl space required after that ',' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 +- .../staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 20 ++--- .../stagin

[PATCH] drivers: staging: rtl8723au: Fix space prohibited before that close parenthesis ')' errors

Fix checkpatch.pl space prohibited before that close parenthesis ')' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_efuse.c| 2 +- drivers/staging/rtl8723au/include/osdep_service.h | 2 +- drivers/staging/rtl8723au/include/rtl8723a_spec.h | 6 +++--

[PATCH] drivers: staging: rtl8723au: Fix "(foo*)" should be "(foo *)" errors

Fix checkpatch.pl "(foo*)" should be "(foo *)" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_ap.c| 8 drivers/staging/rtl8723au/core/rtw_cmd.c | 6 +++--- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- drivers/st

[PATCH] drivers: staging: rtl8723au: Fix "foo* bar" should be "foo *bar" errors

Fix checkpatch.pl "foo* bar" should be "foo *bar" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8723au/core/rtw_ap.c | 2 +- drivers/staging/rtl8723au/core/rtw_cmd.c | 4 ++-- drivers/staging/rtl8723au/core/rtw_ieee80211.c| 4 ++-- drive

[PATCH] drivers: staging: lustre: Fix space required before the open parenthesis '(' errors

Fix checkpatch.pl space required before the open parenthesis '(' errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 2 +- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 2 +- drivers/staging/lustre/lnet/selftest/framework.c

[PATCH] drivers: staging: lustre: lustre: Fix "foo * bar" should be "foo *bar" errors

Fix checkpatch.pl "foo * bar" should be "foo *bar" errors Signed-off-by: Greg Donald --- drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 4 ++-- drivers/staging/lustre/lustre/include/lustre_net.h | 2 +- drivers/staging/lustre/lustre/include/lustr

Re: find_busiest_group divide error

: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe pebs bts cid bogomips: 3987.42 clflush size: 64 cache_alignment : 128 address sizes : 36 bits physical, 32 bits virtual power management: -- Greg Donald signature.asc Description: Digital signature

Re: find_busiest_group divide error

umask_clear(sched_group_cpus(sg)); - sg->sgp->power = 0; cpumask_setall(sched_group_mask(sg)); for_each_cpu(j, span) { Thanks. -- Greg Donald signature.asc Description: Digital signature

find_busiest_group divide error

[1.] One line summary of the problem: find_busiest_group divide error [2.] Full description of the problem/report: Around June 7th I found I could no longer boot a mainline kernel. I posted about it here on June 9th: http://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-June/010914.html

[PATCH] Docs: Fix elisp code so tabbing more than once works

The example elisp code breaks tabbing more than once on the same line. Aligning equal signs in a struct becomes problematic. Fix it. Signed-off-by: Greg Donald --- Documentation/CodingStyle | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/CodingStyle b/Documentation