[PATCH] lib/string: sysfs_streq works case insensitively

2021-04-12 Thread Gioh Kim
As the name shows, it checks the strings inputed from sysfs. It should work for both case-sensitive filesystem and case-insensitive filesystem. Therefore sysfs_streq should work case-insensitively. Signed-off-by: Gioh Kim --- lib/string.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-09 Thread Gioh Kim
On Fri, Apr 9, 2021 at 9:11 AM Andy Shevchenko wrote: > > > > On Friday, April 9, 2021, Andrew Morton wrote: >> >> On Thu, 8 Apr 2021 15:06:05 +0200 Gioh Kim wrote: >> >> > As the name shows, it checks if strings are equal in case insensitive >> >

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Gioh Kim
On Thu, Apr 8, 2021 at 3:14 PM Jinpu Wang wrote: > > On Thu, Apr 8, 2021 at 3:06 PM Gioh Kim wrote: > > > > As the name shows, it checks if strings are equal in case insensitive > > manner. > > > > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c us

Re: [PATCH v3] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Gioh Kim
Hi Jinpu, I removed #ifdef CONFIG_SYSFS ~ #endif. Could you please review again? On Thu, Apr 8, 2021 at 12:50 PM Jinpu Wang wrote: > > On Thu, Apr 8, 2021 at 11:34 AM Gioh Kim wrote: > > > > As the name shows, it checks if strings are equal in case insensitive > > man

[PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Gioh Kim
es using strncasecmp to check the entire string such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks "disable" command with strncasecmp but it would also work if the command is "disable-wrong". Signed-off-by: Gioh Kim --- include/linux/stri

[PATCH v3] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Gioh Kim
es using strncasecmp to check the entire string such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks "disable" command with strncasecmp but it would also work if the command is "disable-wrong". Signed-off-by: Gioh Kim --- include/linux/stri

Re: [PATCH] lib/string: Introduce sysfs_streqcase

2021-04-08 Thread Gioh Kim
On Wed, Apr 7, 2021 at 10:07 PM Nick Desaulniers wrote: > > On Tue, Apr 6, 2021 at 11:15 PM Gioh Kim wrote: > > > > As the name shows, it checks if strings are equal in case insensitive > > manner. > > > > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-s

[PATCH] lib/string: Introduce sysfs_streqcase

2021-04-06 Thread Gioh Kim
es using strncasecmp to check the entire string such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks "disable" command with strncasecmp but it would also work if the command is "disable-wrong". Signed-off-by: Gioh Kim --- include/linux/string.h | 1 + lib/string.c

Re: [PATCH] lib/string: Introduce sysfs_streqcase

2021-04-02 Thread Gioh Kim
On Fri, Apr 2, 2021 at 8:24 PM Kees Cook wrote: > > On Fri, Apr 02, 2021 at 11:17:13AM -0700, Nick Desaulniers wrote: > > Thanks for the patch! > > > > + akpm (please remember to run ./scripts/get_maintainer.pl on your patch > > files) > > > > On F

Re: [PATCH] lib/string: Introduce sysfs_streqcase

2021-04-02 Thread Gioh Kim
On Fri, Apr 2, 2021 at 8:17 PM Nick Desaulniers wrote: > > Thanks for the patch! > > + akpm (please remember to run ./scripts/get_maintainer.pl on your patch > files) > > On Fri, Apr 2, 2021 at 2:41 AM Gioh Kim wrote: > > > > As the name shows, it checks if stri

[PATCH] lib/string: Introduce sysfs_streqcase

2021-04-02 Thread Gioh Kim
ot;mi". But it would work even-if the input is "min-wrongcommand". And also drivers/pnp/interface.c checks "disable" command with strncasecmp but it would also work if the command is "disable-wrong". Signed-off-by: Gioh Kim --- lib/string.c | 23 ++

Re: can the idle value of /proc/stat decrease?

2021-03-03 Thread Gioh Kim
> The results of the two readings from /proc/stat are shown as below, the > interval between the two readings is 150 ms: > > cat /proc/stat > cpu0 5536 10 14160 4118960 0 0 227128 0 0 0 > > cat /proc/stat > cpu0 5536 10 14160 4118959 0 0 227143 0 0 0 -- Gioh Kim Cloud server

[PATCH 2/2] RDMA/rtrs: check before free

2020-10-01 Thread Gioh Kim
From: Gioh Kim If rtrs_iu_alloc failed to allocate buffer or map dma, there are some allocated addresses and some NULL addresses in the array. rtrs_iu_free should check data before free. Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/rtrs/rtrs.c | 8 ++-- 1 file changed, 6 insertions

[PATCH 1/2] RDMA/rtrs: remove unnecessary argument dir of rtrs_iu_free

2020-10-01 Thread Gioh Kim
From: Gioh Kim The direction of DMA operation is already in the rtrs_iu. Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 14 ++ drivers/infiniband/ulp/rtrs/rtrs-pri.h | 3 +-- drivers/infiniband/ulp/rtrs/rtrs-srv.c | 14 ++ drivers/infiniband/ulp

[PATCH] RDMA/rtrs: remove unused field of rtrs_iu

2020-09-30 Thread Gioh Kim
From: Gioh Kim list field is not used anywhere Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/rtrs/rtrs-pri.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-pri.h b/drivers/infiniband/ulp/rtrs/rtrs-pri.h index 0a93c87ef92b..b8e43dc4d95a 100644 --- a

[PATCH] block/rnbd: send_msg_close if any error occurs after send_msg_open

2020-09-18 Thread Gioh Kim
From: Gioh Kim After send_msg_open is done, send_msg_close should be done if any error occurs and it is necessary to recover what has been done. Signed-off-by: Gioh Kim --- drivers/block/rnbd/rnbd-clt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/rnbd

[RFC] replace comments for bvl_vec with bio_vec

2018-06-15 Thread Gioh Kim
I think bvl_vec means bio_vec_list that was replaced with bio_vec long time ago. If I am correct, I think some comments for blk_vec need to be replaced with bio_vec. Signed-off-by: Gioh Kim --- include/linux/blk_types.h | 2 +- include/linux/bvec.h | 2 +- 2 files changed, 2 insertions

[PATCH] md/raid1: add error handling of read error from FailFast device

2018-05-02 Thread Gioh Kim
should handle the read IO error and write IO error equally. So I think read IO error should set rdev faulty. Signed-off-by: Gioh Kim --- drivers/md/raid1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index e9e3308cb0a7..4445179aa4c8 100644 --- a

[PATCH] setlocalversion: use any tag

2018-03-07 Thread Gioh Kim
lversion script uses both of annotated tag and lightweight tag, it would be more convenient because it is common to set lightweight tag during developmene process. Signed-off-by: Gioh Kim --- scripts/setlocalversion | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/setlo

[PATCH v2] mm/memblock.c: make the index explicit argument of for_each_memblock_type

2017-09-13 Thread Gioh Kim
more obious. This patch is a mere cleanup and it shouldn't introduce any functional change. Acked-by: Michal Hocko Signed-off-by: Gioh Kim --- include/linux/memblock.h | 8 mm/memblock.c| 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/inc

[PATCH] mm/memblock.c: make the index explicit argument of for_each_memblock_type

2017-09-13 Thread Gioh Kim
for_each_memblock_type macro function uses idx variable that is the local variable of caller. This patch makes for_each_memblock_type use only its own arguments. Signed-off-by: Gioh Kim --- include/linux/memblock.h | 8 mm/memblock.c| 8 2 files changed, 8

[RFC] guarantee inode of alias's parent

2017-07-07 Thread Gioh Kim
another process? I checked kernel code of v4.10. It also does not have any lock before accessing alias->d_parent. Therefore I'm attaching a patch to show my idea, not solve a problem. This patch is based on v4.10.0 Signed-off-by: Gioh Kim --- fs/dcache.c | 5 + 1 file changed, 5 ins

Re: [RFC] KVM: SVM: ignore type when setting segment registers

2017-05-30 Thread Gioh Kim
On Tue, May 30, 2017 at 02:54:21PM +0200, Radim Krčmář wrote: > 2017-05-29 15:24+0200, Gioh Kim: > > Current code sets unusable as 1 if present is 1 and type is 0. > > In Long mode, type value in segment descriptor is ignored. > > So I think type should be ignored whe

[PATCH] KVM: SVM: ignore type when setting segment registers

2017-05-30 Thread Gioh Kim
an be 0 if it is read-only data segment. Therefore type value is not related to unusable flag. This patch is based on linux-next v4.12.0-rc3. Signed-off-by: Gioh Kim --- arch/x86/kvm/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/s

[RFC] KVM: SVM: ignore type when setting segment registers

2017-05-29 Thread Gioh Kim
Current code sets unusable as 1 if present is 1 and type is 0. In Long mode, type value in segment descriptor is ignored. So I think type should be ignored when setting the segment registers, if type means the descriptor type in the segment descriptor. Is the type field of struct kvm_segment the d

[PATCHv2] mdadm.c: fix compile error "switch condition has boolean value"

2017-03-30 Thread Gioh Kim
Remove a boolean expression in switch condition to prevent compile error of some compilers, for example, gcc version 5.2.1 20151010 (Ubuntu 5.2.1-22ubuntu2). Signed-off-by: Gioh Kim --- mdadm.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/mdadm.c b/mdadm.c

Re: [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value"

2017-03-30 Thread Gioh Kim
On Thu, Mar 30, 2017 at 08:38:35AM +1100, NeilBrown wrote: > On Thu, Mar 30 2017, jes.soren...@gmail.com wrote: > > > Gioh Kim writes: > >> Remove a boolean expression in switch condition > >> to prevent compile error of some compilers. > > > > Plea

Re: [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value"

2017-03-29 Thread Gioh Kim
On Wed, Mar 29, 2017 at 11:47:28AM -0400, jes.soren...@gmail.com wrote: > Gioh Kim writes: > > Remove a boolean expression in switch condition > > to prevent compile error of some compilers. > > Please be specific, which compile is unable to handle this? > >

[PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value"

2017-03-29 Thread Gioh Kim
Remove a boolean expression in switch condition to prevent compile error of some compilers. Signed-off-by: Gioh Kim --- mdadm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mdadm.c b/mdadm.c index 08ddcab..a98a051 100644 --- a/mdadm.c +++ b/mdadm.c @@ -1905,11

[PATCH 1/2] super1: replace hard-coded values with bit definitions

2017-03-29 Thread Gioh Kim
Some hard-coded values for disk status are replaced with bit definitions. Signed-off-by: Gioh Kim --- super1.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/super1.c b/super1.c index f3520ac..e8b9f61 100644 --- a/super1.c +++ b/super1.c @@ -1010,7 +1010,7 @@ static

Re: [PATCHv2 0/2] mdadm: setting device role of raid1 disk with failfast

2017-03-27 Thread Gioh Kim
Hi, Is nobody interested in those patches? On Mon, Mar 20, 2017 at 10:51:55AM +0100, Gioh Kim wrote: > Hi, > > I've found a case that failfast option of mdadm set a disk faulty wrongly. > Following is my test case. > > mdadm --create /dev/md100 -l 1 --failfast -e 1.2

[PATCHv2 0/2] mdadm: setting device role of raid1 disk with failfast

2017-03-20 Thread Gioh Kim
t was spare. This patch fixes a corner case for setting device role and prints device role if it's faulty. This patch is based on "mdadm - v4.0-8-g72b616a - 2017-03-07". v2: fix a typo of v1 Gioh Kim (1): super1: ignore failfast flag for setting device role Jack Wang (1): supe

[PATCHv2 1/2] super1: ignore failfast flag for setting device role

2017-03-20 Thread Gioh Kim
There is corner case for setting device role, if new device has failfast flag. The failfast flag should be ignored. Signed-off-by: Gioh Kim Signed-off-by: Jack Wang --- super1.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/super1.c b/super1.c index 882cd61

[PATCHv2 2/2] super1: check and output faulty dev role

2017-03-20 Thread Gioh Kim
From: Jack Wang Output the real dev role in examine_super1, it will help to find problem. Signed-off-by: Jack Wang Reviewed-by: Gioh Kim --- super1.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/super1.c b/super1.c index f3520ac..c903371 100644 --- a/super1.c

[PATCH 1/2] super1: ignore failfast flag for setting device role

2017-03-17 Thread Gioh Kim
There is corner case for setting device role, if new device has failfast flag. The failfast flag should be ignored. Signed-off-by: Gioh Kim Signed-off-by: Jack Wang --- super1.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/super1.c b/super1.c index 882cd61

[PATCH 2/2] super1: check and output faulty dev role

2017-03-17 Thread Gioh Kim
From: Jack Wang Output the real dev role in examine_super1, it will help to find problem. Signed-off-by: Jack Wang Reviewed-by: Gioh Kim --- super1.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/super1.c b/super1.c index 1da33ef..0bf4715 100644 --- a/super1.c

[PATCH 0/2] mdadm: setting device role of raid1 disk with failfast

2017-03-17 Thread Gioh Kim
t was spare. This patch fixes a corner case for setting device role and prints device role if it's faulty. This patch is based on "mdadm - v4.0-8-g72b616a - 2017-03-07". Gioh Kim (1): super1: ignore failfast flag for setting device role Jack Wang (1): super1: check and output faul

[PATCH 1/2] staging: wlan-ng: introduce a macro read_u16

2017-03-13 Thread Gioh Kim
read_u16 is wrapper of le16_to_cpu to read u16 variable, rather than __le16. Signed-off-by: Gioh Kim --- drivers/staging/wlan-ng/prism2mgmt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h index 88b979f

[PATCH 2/2] staging: wlan-ng: prism2sta.c: apply read_u16 macro

2017-03-13 Thread Gioh Kim
Remove Sparse warnings "warning: cast to restricted __le16" Signed-off-by: Gioh Kim --- drivers/staging/wlan-ng/prism2sta.c | 128 ++-- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/stagi

[PATCH 0/2] staging: wlan-ng: remove Sparse warnings for reading __le16

2017-03-13 Thread Gioh Kim
ng, and convert it into u32 type. I hope this could help. Gioh Kim (2): taging: wlan-ng: introduce a macro read_u16 staging: wlan-ng: prism2sta.c: apply read_u16 macro drivers/staging/wlan-ng/prism2mgmt.h | 3 + drivers/staging/wlan-ng/prism2sta.c | 128 +

[PATCH 2/2] staging: greybus: fix symbolic permission coding style issues

2017-02-09 Thread Gioh Kim
Fix "Octal permissions are preffered than symbolic ones" issues. Signed-off-by: Gioh Kim --- drivers/staging/greybus/es2.c | 4 ++-- drivers/staging/greybus/loopback.c | 2 +- drivers/staging/greybus/svc.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) di

[PATCH 1/2] staging: greybus: fix "line over 80 characters" coding style issues

2017-02-09 Thread Gioh Kim
This patch fixes only obvious lines. There are still more issues. Signed-off-by: Gioh Kim --- drivers/staging/greybus/arche-apb-ctrl.c | 5 +++- drivers/staging/greybus/arche-platform.c | 43 +--- drivers/staging/greybus/audio_codec.c| 5 +++- drivers/staging

[PATCH] staging: fbtft: fix some coding style issues

2017-02-09 Thread Gioh Kim
There are many coding style issues. I fixed only obvious issues. Fixied issues: - Use 4 digit octal (0777) not decimal permissions - line over 80 characters - Avoid unnecessary line continuations I checked all files were built without error. Signed-off-by: Gioh Kim --- drivers/staging/fbtft

[PATCH] staging: greybus: es2.c: fix some coding style issues

2017-02-09 Thread Gioh Kim
Fix two coding style issues: 1. line over 80 characters 2. Octal permissions are preffered than symbolic ones Signed-off-by: Gioh Kim --- drivers/staging/greybus/es2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/es2.c b/drivers/staging

[RFC] Too low cache-misses ratio

2016-12-19 Thread Gioh Kim
Hi, Some of my AMD servers often reported "L3 ECC error and L2 cache error". I thought I could generated the errors if I set the machines on the heavy load. So I ran stress-ng tool with various options but system did not generate any error. I wanted to check the stress-ng tool really generate

Re: [RFC] IB/srp: export reset-host via sysfs

2016-10-04 Thread Gioh Kim
On 04.10.2016 16:24, Bart Van Assche wrote: On 10/04/16 07:00, Gioh Kim wrote: Standard SCSI device has host_reset sysfs interface. This patch exports the host_reset interface for upper layer. Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/srp/ib_srp.c | 10 ++ 1 file changed

[RFC] IB/srp: export reset-host via sysfs

2016-10-04 Thread Gioh Kim
Standard SCSI device has host_reset sysfs interface. This patch exports the host_reset interface for upper layer. Signed-off-by: Gioh Kim --- drivers/infiniband/ulp/srp/ib_srp.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers

Re: [PATCH v1 03/19] fs/anon_inodes: new interface to create new inode

2016-03-11 Thread Gioh Kim
On 11.03.2016 09:05, Al Viro wrote: On Fri, Mar 11, 2016 at 04:30:07PM +0900, Minchan Kim wrote: From: Gioh Kim The anon_inodes has already complete interfaces to create manage many anonymous inodes but don't have interface to get new inode. Other sub-modules can create anonymous

Re: [PATCH 0/5] Add Korean translation of memory-barriers.txt

2016-03-11 Thread Gioh Kim
deletions(-) create mode 100644 Documentation/ko_KR/memory-barriers.txt Hello SeongJae, This document is a little bit difficult to me. Your translation should be very helpful. Let me read it in detail for weekend and give you feedback. I thank you for your contribution. -- Best regards, Gioh Kim

[PATCH] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-27 Thread Gioh Kim
Add bit masking to read ApmTdpLimit precisely Signed-off-by: Gioh Kim --- drivers/hwmon/fam15h_power.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c index f77eb97..4f695d8 100644 --- a/drivers/hwmon

[RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-25 Thread Gioh Kim
The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. Signed-off-by: Gioh Kim --- drivers/hwmon/fam15h_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/fam15h_power.c b/dr

[PATCH] include/linux/genhd.h: remove comments for deprecated function

2015-11-12 Thread Gioh Kim
Remove comments about disk_stat_* functions which are deprecated. Signed-off-by: Gioh Kim --- include/linux/genhd.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 847cc1d..f34a767 100644 --- a/include/linux/genhd.h

Re: [PATCH 1/1] staging: ion: Fix error handling in ion_buffer_create

2015-09-30 Thread Gioh Kim
return ERR_PTR(ret); Suggested-by: Pintu Kumar Reviewed-by: Pintu Kumar It's nice! Reviewed-by: Gioh Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/4] enable migration of driver pages

2015-07-29 Thread Gioh Kim
2015-07-29 오후 9:46에 Daniel Vetter 이(가) 쓴 글: On Wed, Jul 29, 2015 at 01:16:14PM +0100, Mel Gorman wrote: On Wed, Jul 29, 2015 at 12:55:54PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 11:49:45AM +0100, Mel Gorman wrote: On Mon, Jul 13, 2015 at 05:35:15PM +0900, Gioh Kim wrote: My

Re: [PATCH 4/4] mm: remove direct calling of migration

2015-07-27 Thread Gioh Kim
2015-07-27 오후 10:58에 Vlastimil Babka 이(가) 쓴 글: On 07/13/2015 10:35 AM, Gioh Kim wrote: From: Gioh Kim Migration is completely generalized so that migrating mobile page is processed with lru-pages in move_to_new_page. Signed-off-by: Gioh Kim Acked-by: Rafael Aquini Why not just fold

Re: [PATCH 2/4] mm/compaction: enable mobile-page migration

2015-07-27 Thread Gioh Kim
On Mon, Jul 27, 2015 at 4:55 PM, Vlastimil Babka wrote: On 07/13/2015 10:35 AM, Gioh Kim wrote: From: Gioh Kim Add framework to register callback functions and check page mobility. There are some modes for page isolation so that isolate interface has arguments of page address and

Re: [PATCH 0/4] enable migration of driver pages

2015-07-13 Thread Gioh Kim
2015-07-13 오후 6:24에 Konstantin Khlebnikov 이(가) 쓴 글: On Mon, Jul 13, 2015 at 11:35 AM, Gioh Kim wrote: From: Gioh Kim Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (se

Re: [RFCv3 2/5] mm/compaction: enable mobile-page migration

2015-07-13 Thread Gioh Kim
@@ -51,6 +54,66 @@ extern void compaction_defer_reset(struct zone *zone, int order, bool alloc_success); extern bool compaction_restarting(struct zone *zone, int order); +static inline bool mobile_page(struct page *page) +{ + return page->mapping && pag

[PATCH 4/4] mm: remove direct calling of migration

2015-07-13 Thread Gioh Kim
From: Gioh Kim Migration is completely generalized so that migrating mobile page is processed with lru-pages in move_to_new_page. Signed-off-by: Gioh Kim Acked-by: Rafael Aquini --- mm/migrate.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c

[PATCH 3/4] mm/balloon: apply mobile page migratable into balloon

2015-07-13 Thread Gioh Kim
From: Gioh Kim Apply mobile page migration into balloon driver. The balloong driver has an anonymous inode that manages address_space_operation for page migration. Compaction calls interfaces of mobile page migration instead of calling balloon migration directly. Signed-off-by: Gioh Kim Acked

[PATCH 2/4] mm/compaction: enable mobile-page migration

2015-07-13 Thread Gioh Kim
From: Gioh Kim Add framework to register callback functions and check page mobility. There are some modes for page isolation so that isolate interface has arguments of page address and isolation mode while putback interface has only page address as argument. Signed-off-by: Gioh Kim Acked-by

[PATCH 0/4] enable migration of driver pages

2015-07-13 Thread Gioh Kim
From: Gioh Kim Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days) test. Sometimes even order-3 page allocation failed. It has memory size 512MB ~ 1024MB. 30% ~ 40% m

[PATCH 1/4] fs/anon_inodes: new interface to create new inode

2015-07-13 Thread Gioh Kim
From: Gioh Kim The anon_inodes has already complete interfaces to create manage many anonymous inodes but don't have interface to get new inode. Other sub-modules can create anonymous inode without creating and mounting it's own pseudo filesystem. Signed-off-by: Gioh Kim Acked-

Re: [RFCv3 3/5] mm/balloon: apply mobile page migratable into balloon

2015-07-09 Thread Gioh Kim
@@ -124,6 +130,7 @@ static inline void balloon_page_insert(struct balloon_dev_info *balloon, struct page *page) { __SetPageBalloon(page); + page->mapping = balloon->inode->i_mapping; SetPagePrivate(page); set_page_private(p

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-09 Thread Gioh Kim
2015-07-09 오후 10:08에 Daniel Vetter 이(가) 쓴 글: Also there's a bit a lack of gpu drivers from the arm world in upstream, which is probabyl why this patch series doesn't come with a user. Might be better to first upstream the driver before talking about additional infrastructure that it needs. -Dan

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-07 Thread Gioh Kim
2015-07-08 오전 9:07에 Andrew Morton 이(가) 쓴 글: On Wed, 08 Jul 2015 09:02:59 +0900 Gioh Kim wrote: 2015-07-08 __ 7:37___ Andrew Morton ___(___) ___ ___: On Tue, 7 Jul 2015 13:36:20 +0900 Gioh Kim wrote: From: Gioh Kim Hello, This series try to enable migration of non-LRU pages

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-07 Thread Gioh Kim
2015-07-08 오전 7:37에 Andrew Morton 이(가) 쓴 글: On Tue, 7 Jul 2015 13:36:20 +0900 Gioh Kim wrote: From: Gioh Kim Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several

[RFCv3 2/5] mm/compaction: enable mobile-page migration

2015-07-06 Thread Gioh Kim
From: Gioh Kim Add framework to register callback functions and check page mobility. There are some modes for page isolation so that isolate interface has arguments of page address and isolation mode while putback interface has only page address as argument. Signed-off-by: Gioh Kim --- fs

[RFCv3 1/5] fs/anon_inodes: new interface to create new inode

2015-07-06 Thread Gioh Kim
From: Gioh Kim The anon_inodes has already complete interfaces to create manage many anonymous inodes but don't have interface to get new inode. Other sub-modules can create anonymous inode without creating and mounting it's own pseudo filesystem. Signed-off-by: Gioh Kim --- fs/ano

[RFCv3 5/5] mm: remove direct calling of migration

2015-07-06 Thread Gioh Kim
From: Gioh Kim Migration is completely generalized so that migrating mobile page is processed with lru-pages in move_to_new_page. Signed-off-by: Gioh Kim --- mm/balloon_compaction.c | 8 mm/migrate.c| 13 - 2 files changed, 21 deletions(-) diff --git a/mm

[RFCv3 0/5] enable migration of driver pages

2015-07-06 Thread Gioh Kim
From: Gioh Kim Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days) test. Sometimes even order-3 page allocation failed. It has memory size 512MB ~ 1024MB. 30% ~ 40% m

[RFCv3 3/5] mm/balloon: apply mobile page migratable into balloon

2015-07-06 Thread Gioh Kim
From: Gioh Kim Apply mobile page migration into balloon driver. The balloong driver has an anonymous inode that manages address_space_operation for page migration. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c| 3 ++ include/linux/balloon_compaction.h | 15 +++-- mm

[RFCv3 4/5] mm: call generic migration callbacks

2015-07-06 Thread Gioh Kim
From: Gioh Kim Compaction calls interfaces of mobile page migration instead of calling balloon migration directly. Signed-off-by: Gioh Kim --- mm/compaction.c | 8 mm/migrate.c| 19 ++- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/mm

[PATCHv4 2/2] staging: ion: debugfs to shrink pool

2015-07-05 Thread Gioh Kim
complete. This patch completes and enables it. Reading the file returns pool size in page unit and writing the number of pages shrinks pool. It flushes all pages to write zero at the file. Signed-off-by: Gioh Kim Reviewed-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 22

[PATCHv4 0/2] staging: ion: enable shrinking of pool

2015-07-05 Thread Gioh Kim
hrink - Add more description about the reason - Remove a patch to limit pool size This patchset is based on v4.1 Gioh Kim (2): staging: ion: shrink page-pool by page unit staging: ion: debugfs to shrink pool drivers/staging/android/ion/ion.c | 22 +- drivers/sta

[PATCHv4 1/2] staging: ion: shrink page-pool by page unit

2015-07-05 Thread Gioh Kim
then ion_system_heap_shrink() to work on pages. Signed-off-by: Gioh Kim Reviewed-by: Laura Abbott --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c | 16 ++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git

[PATCHv3 2/2] staging: ion: debugfs to shrink pool

2015-07-01 Thread Gioh Kim
pages to write zero at the file. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..9327e8a 100644 --- a

[PATCHv3 0/2] staging: ion: enable shrinking of pool

2015-07-01 Thread Gioh Kim
ased on v4.1 Gioh Kim (2): staging: ion: shrink page-pool by page unit staging: ion: debugfs to shrink pool drivers/staging/android/ion/ion.c | 22 +- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_h

[PATCHv3 1/2] staging: ion: shrink page-pool by page unit

2015-07-01 Thread Gioh Kim
then ion_system_heap_shrink() to work on pages. Signed-off-by: Gioh Kim --- drivers/staging/android/ion/ion_page_pool.c |5 +++-- drivers/staging/android/ion/ion_system_heap.c | 16 ++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android

[RFCv2 3/5] mm/balloon: apply driver page migratable into balloon

2015-06-26 Thread Gioh Kim
Apply driver page migration into balloon driver. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c| 3 +++ fs/proc/page.c | 3 +++ include/linux/balloon_compaction.h | 33 + include/uapi/linux/kernel-page-flags.h

[RFCv2 2/5] fs/anon_inodes: get a new inode

2015-06-26 Thread Gioh Kim
A inode is necessary for some drivers that needs special address_space and address_space_operation for page migration. Each drivers can create inode with the anon_inodefs. Signed-off-by: Gioh Kim --- fs/anon_inodes.c| 6 ++ include/linux/anon_inodes.h | 1 + 2 files changed, 7

[RFCv2 4/5] mm/compaction: compaction calls generic migration

2015-06-26 Thread Gioh Kim
Compaction calls interfaces of driver page migration instead of calling balloon migration directly. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c | 1 + mm/compaction.c | 9 + mm/migrate.c| 21 - 3 files changed, 18

[RFCv2 5/5] mm: remove direct calling of migration

2015-06-26 Thread Gioh Kim
Migration is completely generalized. Signed-off-by: Gioh Kim --- mm/balloon_compaction.c | 8 mm/migrate.c| 15 --- 2 files changed, 23 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index df72846..a7b7c79 100644 --- a/mm

[RFCv2 1/5] mm/compaction: enable driver page migration

2015-06-26 Thread Gioh Kim
Add framework to register callback functions and check pages migratable. There are some modes of page isolation so that isolate interface has an arguments of page address and isolation mode. Signed-off-by: Gioh Kim --- include/linux/compaction.h | 11 +++ include/linux/fs.h | 2

[RFCv2 0/5] enable migration of driver pages

2015-06-26 Thread Gioh Kim
removed. This patch-set is based on v4.1 Gioh Kim (5): mm/compaction: enable driver page migration fs/anon_inode: get a new inode mm/balloon: apply driver page migratable into balloon driver mm/compaction: compaction calls generic migration mm: remove direct calling of migrat

Re: [RFC 0/4] enable migration of non-LRU pages

2015-06-09 Thread Gioh Kim
2015-06-10 오전 9:08에 Minchan Kim 이(가) 쓴 글: Hello Gioh, On Tue, Jun 02, 2015 at 04:27:40PM +0900, Gioh Kim wrote: Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days)

Re: [RFC 0/4] enable migration of non-LRU pages

2015-06-05 Thread Gioh Kim
On Tue, Jun 02, 2015 at 04:27:40PM +0900, Gioh Kim wrote: Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days) test. Sometimes even order-3 page allocation failed. I

Re: [RFC 2/4] mm/balloon: apply driver page migratable into balloon driver

2015-06-02 Thread Gioh Kim
On Tue, Jun 2, 2015 at 10:27 AM, Gioh Kim wrote: Apply driver page migration into balloon driver. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c| 2 ++ fs/proc/page.c | 4 +-- include/linux/balloon_compaction.h | 42

[RFC 2/4] mm/balloon: apply driver page migratable into balloon driver

2015-06-02 Thread Gioh Kim
Apply driver page migration into balloon driver. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c| 2 ++ fs/proc/page.c | 4 +-- include/linux/balloon_compaction.h | 42 --- include/linux/mm.h | 19

[RFC 1/4] mm/compaction: enable driver page migration

2015-06-02 Thread Gioh Kim
Add framework to register callback functions and check migratable pages. There are some modes to isolate page so that isolate interface has arguments of page address and isolation mode. Signed-off-by: Gioh Kim --- include/linux/compaction.h | 13 + include/linux/fs.h | 2

[RFC 3/4] mm/compaction: compaction calls generic migration

2015-06-02 Thread Gioh Kim
Compaction calls interfaces of driver page migration instead of calling balloon migration directly. Signed-off-by: Gioh Kim --- mm/compaction.c | 9 + mm/migrate.c| 22 +- 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/mm/compaction.c b/mm

[RFC 0/4] enable migration of non-LRU pages

2015-06-02 Thread Gioh Kim
al seconds check more than 512MB is used with free command - command "balloon 512" in qemu monitor - check hundreds MB of pages are migrated Next kernel compaction code can call generic migration callbacks instead of balloon driver interface. Finally calling migration of balloon driver is re

[RFC 4/4] mm: remove direct calling of migration

2015-06-02 Thread Gioh Kim
Migration is completely generalized. Signed-off-by: Gioh Kim --- mm/balloon_compaction.c | 8 mm/migrate.c| 15 --- 2 files changed, 23 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index f98a500..d29270aa 100644 --- a/mm

Re: [PATCH] add generic callbacks into compaction

2015-04-12 Thread Gioh Kim
2015-04-07 오전 9:59에 Minchan Kim 이(가) 쓴 글: Hello Gioh, I wanted to have such feature for zsmalloc. Thanks for the work. On Wed, Apr 01, 2015 at 08:11:30AM +0900, Gioh Kim wrote: I sent a patch about page allocation for less fragmentation. http://permalink.gmane.org/gmane.linux.kernel.mm

Re: [RFCv3] mm: page allocation for less fragmentation

2015-04-01 Thread Gioh Kim
2015-04-01 오후 9:16에 Vlastimil Babka 이(가) 쓴 글: On 03/26/2015 09:45 AM, Gioh Kim wrote: My platform is suffering with the external fragmentation problem. If I run a heavy load test for a few days in 1GB memory system, I cannot allocate even order=3 pages because-of the external fragmentation

Re: [PATCH] add generic callbacks into compaction

2015-03-31 Thread Gioh Kim
I'm sorry. But if mm developers agree with this approach, I will complete this patch. I would do appreciate any feedback. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c|2 ++ include/linux/balloon_compaction.h | 23 +--- include/linux/fs.h

[PATCH] add generic callbacks into compaction

2015-03-31 Thread Gioh Kim
edback. Signed-off-by: Gioh Kim --- drivers/virtio/virtio_balloon.c|2 ++ include/linux/balloon_compaction.h | 23 +--- include/linux/fs.h |3 ++ include/linux/pagemap.h| 26 ++ mm/balloon_compaction.c

Re: [RFCv2] mm: page allocation for less fragmentation

2015-03-26 Thread Gioh Kim
2015-03-26 오후 7:28에 Mel Gorman 이(가) 쓴 글: On Thu, Mar 26, 2015 at 06:16:22AM +0900, Gioh Kim wrote: 2015-03-25 ?? 7:56??? Mel Gorman ???(???) ??? ???: On Wed, Mar 25, 2015 at 11:39:15AM +0900, Gioh Kim wrote: My driver allocates more than 40MB pages via alloc_page() at a time and maps

[RFCv3] mm: page allocation for less fragmentation

2015-03-26 Thread Gioh Kim
atetype should be changed into gfpflags_to_migratetype for v4.0. Changelog since v1: - change argument of page order into page count Changelog since v2: - bug fix - do not allocate page in different migratetype pageblock - add new test result of mixed block count Signed-off-by: Gioh Kim CC: Andrew Morton CC

Re: [RFCv2] mm: page allocation for less fragmentation

2015-03-25 Thread Gioh Kim
2015-03-26 오전 7:16에 Vlastimil Babka 이(가) 쓴 글: On 25.3.2015 3:39, Gioh Kim wrote: My driver allocates more than 40MB pages via alloc_page() at a time and maps them at virtual address. Totally it uses 300~400MB pages. If I run a heavy load test for a few days in 1GB memory system, I cannot

  1   2   3   >