On Mon, 14 Dec 2015 17:39:09 -0800
Florian Fainelli wrote:
> On 14/12/15 16:19, Gilad Avidov wrote:
>
> [snip]
>
> > + "sgmii_irq";
> > + qcom,emac-gpio-mdc = <&msmgpio 123 0>;
> > + qcom,emac-gpio-mdio =
erver, ACPI, ethtool,
ptp/1588, etc.
2) This size seems comparable to first patches of existing Ethernet
drivers.
>
> On Mon, Dec 7, 2015 at 4:58 PM, Gilad Avidov
> wrote:
>
> > + qcom,emac-gpio-mdc = <&msmgpio 123 0>;
> > + qcom,emac-g
On Tue, 8 Dec 2015 00:33:04 +0100
Felix Fietkau wrote:
> On 2015-12-07 23:58, Gilad Avidov wrote:
> > +/* RRD (Receive Return Descriptor) */
> > +union emac_rrd {
> > + struct {
> > + /* 32bit word 0 */
> > + u32 xsum:16;
> > +
On Fri, 4 Sep 2015 17:50:11 -0700
Stephen Boyd wrote:
> On 09/04, Gilad Avidov wrote:
> > On Thu, 3 Sep 2015 17:16:30 -0700
> > Stephen Boyd wrote:
> >
> > > On 09/03, Gilad Avidov wrote:
> > > > +supported by HW.
On Thu, 3 Sep 2015 17:16:30 -0700
Stephen Boyd wrote:
> On 09/03, Gilad Avidov wrote:
> > +supported by HW. Default (minimum
> > supported) is 128. +
> > +Example V1 PMIC-Arbiter:
> >
> > spmi {
> > compatible = &q
The current driver implementation supports only 128 peripherals.
Adding support for configurable number of peripherals since the
spmi-pmic-arb v2 HW has sub-versions which support from 128 to 512
PMIC peripherals.
Signed-off-by: Gilad Avidov
Reviewed-by: Sagar Dharia
---
.../bindings/spmi/qcom
On Thu, 28 May 2015 18:15:59 -0700
Stephen Boyd wrote:
> On 05/28/2015 04:02 PM, Gilad Avidov wrote:
> > On Wed, 27 May 2015 13:06:29 -0700
> > Stephen Boyd wrote:
> >
> >> On 05/27, Ankit Gupta wrote:
> >>>> How is this any better than irq tracep
On Wed, 27 May 2015 13:06:29 -0700
Stephen Boyd wrote:
> On 05/27, Ankit Gupta wrote:
> > >
> > > How is this any better than irq tracepoints that we already have
> > > for generic irqs?
> > >
> > It is better than generic irq tracepoints because it provides bus
> > specific information (sid and
te to use
it to configure the controller fields (on v1) or unmap it (on v2).
Changes from v4 to v5:
* remove the unmap added in v4 since it is used again and the mapping is
managed.
* correct printf formatting for 64bit compilers.
* correct base address for reading the channel table.
Gilad A
command registers.
Reviewed-by: Sagar Dharia
Signed-off-by: Gilad Avidov
---
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c | 319 +
2 files changed, 265 insertions(+), 60 deletions(-)
diff --git a/Documentation
c: ga...@codeaurora.org
Reviewed-by: Stephen Boyd
Reviewed-by: Sagar Dharia
Acked-by: Josh Cartwright
Signed-off-by: Gilad Avidov
---
drivers/spmi/spmi.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 1d92f51..9493843 100644
Hi Ivan,
On Mon, 23 Feb 2015 11:59:14 +0200
"Ivan T. Ivanov" wrote:
> Hi Gilad,
>
> On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:
> > Qualcomm PMIC Arbiter version-2 changes from version-1 are:
> >
> > - Some different register offsets.
> >
Hi Ivan,
On Mon, 23 Feb 2015 18:06:10 +0200
"Ivan T. Ivanov" wrote:
>
> Hi Gilad,
>
> On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:
>
> >
> > +
> > +static u32 pmic_arb_fmt_cmd_v1(u8 opc, u8 sid, u16 addr, u8 bc)
> > +{
> > +
Hi Ivan,
On Tue, 24 Feb 2015 13:01:08 +0200
"Ivan T. Ivanov" wrote:
>
> Hi Gilad,
>
> One more comment :-).
>
> On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:
>
>
>
>
> -static int pmic_arb_wait_for_done(struct spmi_controller *ctrl)
c: ga...@codeaurora.org
Reviewed-by: Stephen Boyd
Reviewed-by: Sagar Dharia
Acked-by: Josh Cartwright
Signed-off-by: Gilad Avidov
---
drivers/spmi/spmi.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 1d92f51..9493843 100644
as we know that it will not be used
(on v2 it is used only to read the hw version in probe).
3. Assign the core reg space to a local until we know if it appropriate to use
it to configure the controller fields (on v1) or unmap it (on v2).
Gilad Avidov (2):
spmi: remove wakeup command before
command registers.
Acked-by: Sagar Dharia
Signed-off-by: Gilad Avidov
---
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c | 315 +
2 files changed, 264 insertions(+), 57 deletions(-)
diff --git a/Documentation
On Wed, 18 Feb 2015 11:17:13 -0800
Stephen Boyd wrote:
> On 02/18/15 07:39, Josh Cartwright wrote:
> > On Mon, Feb 09, 2015 at 03:51:11PM -0700, Gilad Avidov wrote:
> >> According to spmi spec a slave powers up into startup state and
> >> then transitions into act
Hi Josh,
Thank you for the review.
On Wed, 18 Feb 2015 09:34:46 -0600
Josh Cartwright wrote:
> Hey Gilad-
>
> On Mon, Feb 09, 2015 at 03:51:12PM -0700, Gilad Avidov wrote:
> > Qualcomm PMIC Arbiter version-2 changes from version-1 are:
> >
> > - Some different
Hi Stephen,
On Mon, 09 Feb 2015 15:08:58 -0800
Stephen Boyd wrote:
> On 02/09/15 14:51, Gilad Avidov wrote:
> > pmic_arb v2 has no support for spmi non-data commands and thus
> > returns -EOPNOTSUPP on .cmd callback. This causes a failure in
> > spmi_drv_probe() which send
On Mon, 09 Feb 2015 15:08:58 -0800
Stephen Boyd wrote:
> On 02/09/15 14:51, Gilad Avidov wrote:
> > pmic_arb v2 has no support for spmi non-data commands and thus
> > returns -EOPNOTSUPP on .cmd callback. This causes a failure in
> > spmi_drv_probe() which sends a wakeup
command registers.
Acked-by: Sagar Dharia
Signed-off-by: Gilad Avidov
---
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c | 312 +
2 files changed, 261 insertions(+), 57 deletions(-)
diff --git a/Documentation
a bug since spmi master controllers, such as spmi-pmic-arb,
which have no support for wakeup command return an error on that
command and thus fail before reaching a slave driver probe.
Cc: ga...@codeaurora.org
Reviewed-by: Sagar Dharia
Signed-off-by: Gilad Avidov
---
drivers/spmi/spmi.c | 9 ++-
that a slaves
default state is active and doesn't need a wakeup.
Gilad Avidov (2):
spmi: remove wakeup command before slave probe
spmi: pmic_arb: add support for hw version 2
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c
Hi Stan,
On Tue, 03 Feb 2015 11:36:56 +0200
Stanimir Varbanov wrote:
> On 01/31/2015 02:46 AM, Gilad Avidov wrote:
> > According to spmi spec a slave powers up into startup state and then
> > transitions into active state. Thus, the wakeup command is not
> > required befor
Hi Stan,
Thank you for the review.
On 2/3/2015 2:59 AM, Stanimir Varbanov wrote:
Hi Gilad,
Thanks for the patch.
On 01/31/2015 02:46 AM, Gilad Avidov wrote:
Qualcomm PMIC Arbiter version-2 changes from version-1 are:
- Some different register offsets.
- New channel register space, one per
a bug since spmi master controllers, such as spmi-pmic-arb,
which have no support for wakeup command return an error on that
command and thus fail before reaching a slave driver probe.
Cc: ga...@codeaurora.org
Acked-by: Sagar Dharia
Signed-off-by: Gilad Avidov
---
drivers/spmi/spmi.c | 8 +---
1
command registers.
Signed-off-by: Gilad Avidov
Acked-by: Sagar Dharia
---
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c | 310 +
2 files changed, 260 insertions(+), 56 deletions(-)
diff --git a/Documentation
that a slaves
default state is active and doesn't need a wakeup.
Gilad Avidov (2):
spmi: remove wakeup command before slave probe
spmi: pmic_arb: add support for hw version 2
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c
On 1/23/2015 10:03 AM, Stanimir Varbanov wrote:
Hi Gilad,
On 01/20/2015 03:10 AM, Gilad Avidov wrote:
Qualcomm PMIC Arbiter version-2 changes from version-1 are:
- Some diffrent register offsets.
- New channel register space, one per PMIC peripheral (ppid).
All tx tarffic uses these
Hi Stephen,
On 1/21/2015 11:56 AM, Stephen Boyd wrote:
On 01/19/2015 05:10 PM, Gilad Avidov wrote:
Qualcomm PMIC Arbiter version-2 changes from version-1 are:
- Some diffrent register offsets.
s/diffrent/different/
will correct the spelling. Thank you for pointing them out.
- New
Hi Ivan,
On 1/21/2015 7:32 AM, Ivan T. Ivanov wrote:
Hi Gilad,
Just few comments.
On Mon, 2015-01-19 at 18:10 -0700, Gilad Avidov wrote:
Qualcomm PMIC Arbiter version-2 changes from version-1 are:
- Some diffrent register offsets.
- New channel register space, one per PMIC peripheral (ppid
command registers.
Signed-off-by: Gilad Avidov
Acked-by: Sagar Dharia
---
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 11 +-
drivers/spmi/spmi-pmic-arb.c | 295 ++---
2 files changed, 263 insertions(+), 43 deletions(-)
diff --git a/Documentation
On 11/6/2014 12:54 AM, Ivan T. Ivanov wrote:
On Wed, 2014-11-05 at 17:36 -0800, Bjorn Andersson wrote:
On Wed, Nov 5, 2014 at 10:31 AM, Ivan T. Ivanov wrote:
On Wed, 2014-11-05 at 10:11 -0800, Bjorn Andersson wrote:
On Tue, Nov 4, 2014 at 5:33 AM, Ivan T. Ivanov
wrote:
[..]
@@ -28,11 +144,2
Compact API for populating variables with values
from Device-Tree properties.
Change-Id: Ib0f17d32941605b0c431a1815cfcf5e8b76fb07c
Signed-off-by: Gilad Avidov
---
Documentation/devicetree/of_property_map.txt | 76 ++
drivers/of/Makefile |2
gt;id = ret;
}
The Device-Tree node and alias which are read by the above code snippets:
aliases {
i2c0 = &i2c_0; /* I2C0 controller device */
};
i2c_0: i2c@78b6000 { /* BLSP1 QUP2 */
compatible = "qcom,i2c-msm-v2";
reg-names = "qup_phys_addr", "bam_phys_a
36 matches
Mail list logo
