Hi Geliang,
> On 28 Nov 2016, at 15:15, Geliang Tang wrote:
>
> On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote:
>> Hi Geliang,
>>
>> thanks for the simplification. Did you find those by manual inspection, or
>> did you use a tool?
>>
/misc/genwqe/card_utils.c
> @@ -36,7 +36,6 @@
> #include
> #include
> #include
> -#include
> #include
>
> #include "genwqe_driver.h"
> --
> 2.9.3
>
thanks for the simplification. Did you find those by manual inspection, or did
you use a tool?
Acked-by: Frank Haverkamp
Hi Greg,
> On 19 Oct 2016, at 13:44, Greg KH wrote:
>
> On Wed, Oct 19, 2016 at 12:29:41PM +0200, Frank Haverkamp wrote:
>> From: Gerald Schaefer
>>
>> When interrupting an application which was allocating DMAable
>> memory, it was possible, that the DM
Hi Greg,
it would be nice, if you could review/integrate the following small change
provided by Gerald. It fixes a stability problem, which might occur, if an
application using our driver, is stopped unexpectedly (which they did during
testing).
Thanks
Frank
Gerald Schaefer (1):
GenWQE: Fix
03d100c856c0 count:-1 mapcount:0 mapping: (null) index:0x0
flags: 0x3fffc00()
page dumped because: nonzero _count
Signed-off-by: Gerald Schaefer
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_utils.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff
a/MAINTAINERS b/MAINTAINERS
> index bd69bc0ed717..db20c3204606 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5220,6 +5220,12 @@ M: Joe Perches
> S:Maintained
> F:scripts/get_maintainer.pl
>
> +GENWQE (IBM Generic Workqueue Card)
> +M: Frank Hav
if (get_order(size) > MAX_ORDER)
> return NULL;
>
> - return dma_alloc_coherent(&cd->pci_dev->dev, size, dma_handle,
> - GFP_KERNEL);
> + return dma_zalloc_coherent(&cd->pci_dev->dev, size, dma_handle,
> + GFP_KERNEL);
> }
>
> void __genwqe_free_consistent(struct genwqe_dev *cd, size_t size,
> --
> 2.5.5
>
I think this should be fine.
Signed-off-by: Frank Haverkamp
Hi Greg,
it would be nice, if you could review/integrate the following small change:
The genwqe device should be rw for normal users. This avoids adding
genwqe specific udev config files for Linux distributors.
Thanks
Frank
Frank Haverkamp (1):
GenWQE: Change default access rights for
Since it should always be ok for normal users to operate the accelerator,
it makes sense to change it in our driver, rather than adding udev rules
for all Linux distributions.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_base.c | 15 +++
1 file changed, 15 insertions
;cd->pci_dev->dev, size, dma_handle,
> + GFP_KERNEL);
> }
>
> void __genwqe_free_consistent(struct genwqe_dev *cd, size_t size,
> @@ -229,7 +230,7 @@ void __genwqe_free_consistent(struct gen
> if (vaddr == NULL)
> return;
m->page_list); /* ptrs to pages */
> + if (rc < 0)
> + goto fail_get_user_pages;
>
> /* assumption: get_user_pages can be killed by signals. */
> if (rc < m->nr_pages) {
Regards
Frank
Acked-by: Frank Haverkamp
Hi Greg,
Am Freitag, den 12.09.2014, 08:39 +0200 schrieb Frank Haverkamp:
> Hi Greg,
>
> Am Mittwoch, den 10.09.2014, 16:37 +0200 schrieb Frank Haverkamp:
> > We tested "misc/GenWQE: fix pci_enable_msi usage" from Sebastian Ott
> > successfully on our machine. The
Hi Greg,
Am Mittwoch, den 10.09.2014, 16:37 +0200 schrieb Frank Haverkamp:
> We tested "misc/GenWQE: fix pci_enable_msi usage" from Sebastian Ott
> successfully on our machine. The modification of the return code is
> now fixed too. The driver version as sysfs entry was re
Hi Bjorn and Sebastian,
Am Mittwoch, den 16.07.2014, 15:10 -0600 schrieb Bjorn Helgaas:
> [+cc linux-pci]
>
> On Wed, Jul 09, 2014 at 12:46:39PM +0200, Sebastian Ott wrote:
> > GenWQE used to call pci_enable_msi_block to allocate a desired number
> > of MSI's. If that was not possible pci_enable_
t; 0)
> > > + return rc;
> > > +
> > > + cd->flags |= GENWQE_FLAG_MSI_ENABLED;
> > > + return 0;
> > > }
> > >
> > > /**
> > > --
> > > 1.9.3
> > >
> >
> > Reviewed-by: Alexander Gordeev
&
Hi Greg,
Am Donnerstag, den 26.06.2014, 10:55 +0200 schrieb Frank Haverkamp:
> Hi Kleber,
>
> Am Mittwoch, den 25.06.2014, 13:22 -0300 schrieb Kleber Sacilotto de
> Souza:
> > Hi,
> >
> > I'm sending a v2 of this patch series, removing the patch that bumps
d, 285 insertions(+), 19 deletions(-)
>
Thanks for resubmitting the patches.
Acked-by: Frank Haverkamp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Greg,
Am Freitag, den 06.06.2014, 14:07 +0200 schrieb Frank Haverkamp:
> Hi Greg,
>
> Am Donnerstag, den 05.06.2014, 09:00 -0700 schrieb Greg KH:
> > On Thu, Jun 05, 2014 at 11:23:04AM +0200, Frank Haverkamp wrote:
> > > Hi Greg,
> > >
> > > Am Mit
Hi Greg,
Am Donnerstag, den 05.06.2014, 09:00 -0700 schrieb Greg KH:
> On Thu, Jun 05, 2014 at 11:23:04AM +0200, Frank Haverkamp wrote:
> > Hi Greg,
> >
> > Am Mittwoch, den 04.06.2014, 08:54 -0700 schrieb Greg KH:
> > > On Wed, Jun 04, 2014 at 10:57:53AM -0300, K
Hi Greg,
Am Mittwoch, den 04.06.2014, 08:54 -0700 schrieb Greg KH:
> On Wed, Jun 04, 2014 at 10:57:53AM -0300, Kleber Sacilotto de Souza wrote:
> > Increase genwqe driver version number.
> >
> > Signed-off-by: Kleber Sacilotto de Souza
> > ---
> > drivers/misc/genwqe/genwqe_driver.h |2 +-
>
rivers/misc/genwqe/card_utils.c
> b/drivers/misc/genwqe/card_utils.c
> index d049d27..61846dd 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -53,12 +53,17 @@
> */
> int __genwqe_writeq(struct genwqe_dev *cd, u64 byte_offs, u64 val)
&
e to wait
> + * for an external recovery procedure to take care of it.
> + */
> + rc = genwqe_platform_recovery(cd);
> + if (!rc)
> + goto health_thread_begin;
> }
>
> dev_err(&pci_dev->dev,
Thanks for contributing those additions to our driver.
Acked-by: Frank Haverkamp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ne DRV_VERS_STRING "2.0.15"
> +#define DRV_VERS_STRING "2.0.21"
>
> /*
> * Static minor number assignement, until we decide/implement
Thanks for contributing those additions to our driver.
Acked-by: Frank Haverkamp
--
To unsubscribe f
g if valid in VF
> @@ -239,6 +263,7 @@ static struct attribute *genwqe_attributes[] = {
> &dev_attr_status.attr,
> &dev_attr_freerunning_timer.attr,
> &dev_attr_queue_working_time.attr,
> + &dev_attr_reload_bitstream.attr,
> NULL,
> };
>
> diff --gi
_dev *cd, struct
> genwqe_sgl *sgl,
> */
> int genwqe_free_sync_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl)
> {
> - int rc;
> + int rc = 0;
> struct pci_dev *pci_dev = cd->pci_dev;
>
> if (sgl->fpage) {
Acked-by: Frank Haverkamp
--
To
btimeout_msec", i);
>
> file = debugfs_create_u32(name, 0666, root,
> &cd->vf_jobtimeout_msec[i]);
Thanks for contributing the fix for our driver. I do not see that this
would ever be able to cause a problem. Or do I oversee something?
Reg
Hi Greg,
Am Donnerstag, den 03.04.2014, 11:05 -0700 schrieb Greg KH:
> On Thu, Apr 03, 2014 at 08:25:27AM +0200, Frank Haverkamp wrote:
> > Updated email address of co-author and updated the copyright notice
> > with the current year.
>
> Why update the copyright notice, it
Updated email address of co-author and updated the copyright notice
with the current year.
Signed-off-by: Frank Haverkamp
Signed-off-by: Michael Jung
---
drivers/misc/genwqe/card_base.c |6 +++---
drivers/misc/genwqe/card_base.h |4 ++--
drivers/misc/genwqe/card_ddcb.c
_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev
> Cc: Frank Haverkamp
> Cc: Greg Kroah-Hartman
> ---
> drivers/misc/genwqe/card_utils.c |2 +-
> 1 files changed, 1 insertio
In addition to the two flash partitions we used so far, there is a 3rd
one which is enabled for usage by this fix.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_dev.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--- a/drivers/misc/genwqe/card_dev.c
+++ b/drivers
Increase genwqe driver version number.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/genwqe_driver.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/genwqe/genwqe_driver.h
+++ b/drivers/misc/genwqe/genwqe_driver.h
@@ -36,7 +36,7 @@
#include
#include
. The data is copied from user-space into those
pages and results are copied back when the DDCB-request is
successfully finished.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_base.h | 58 -
drivers/misc/genwqe/card_dev.c | 38 ++--
drivers/misc/genwqe
Needed to add wmb() before we send the DDCB for execution.
Without the syncronizing it failed on System p.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_ddcb.c |4
1 file changed, 4 insertions(+)
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
: Colin Ian King
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_ddcb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
@@ -1310,7 +1310,7 @@ static int queue_wake_up_all(struct genw
*/
int
t; "[%s] genwqe_user_vmap rc=%d\n", __func__, rc);
> + kfree(dma_map);
> return rc;
> }
>
thanks for discovering and fixing the problem.
Acked-by: Frank Haverkamp
--
To unsubscribe from this list: send the line "unsub
dma_addr_t was not used, where it should have been used.
Some format strings were not optimal.
Reported-by: kbuild test robot
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_dev.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
--- a/drivers/misc
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_dev.c | 172 ++---
1 file changed, 43 insertions(+), 129 deletions(-)
--- a/drivers/misc/genwqe/card_dev.c
+++ b/drivers/misc/genwqe/card_dev.c
@@ -516,17 +516,11 @@ static int do_flash_update(struct
The header which contained the declaration for kcalloc() was not
inlcuded.
Reported-by: kbuild test robot
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_base.h |1 +
drivers/misc/genwqe/card_ddcb.c |1 +
2 files changed, 2 insertions(+)
--- a/drivers/misc/genwqe
Hi Dan,
Am Dienstag, den 07.01.2014, 15:45 +0300 schrieb Dan Carpenter:
> Oops sorry... I'm also still catching up from the holidays. I think I
> was even CC'd on your earlier fix.
No problem. Let me send my latest set of patches for our GenWQE driver
which includes the ioctl return code fix an
cd->card_idx);
> - if (cd->dev == NULL) {
> - rc = -ENODEV;
> + if (IS_ERR(cd->dev)) {
> + rc = PTR_ERR(cd->dev);
> goto err_cdev;
> }
>
>
Thanks for finding this potential problem and pro
Hi Dan,
Am Dienstag, den 07.01.2014, 09:41 +0300 schrieb Dan Carpenter:
> Could you also fix this Smatch warning?
> drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return
> -EFAULT instead of the bytes remaining?
I thought i fixed this already in my posting:
[PATCH] GenWQE: R
h
> +++ b/drivers/misc/genwqe/card_base.h
> @@ -34,7 +34,6 @@
> #include
> #include
> #include
> -#include
> #include
>
> #include
>
Thanks for removing the obsolete includes.
Acked-by: Frank Haverkamp
--
To unsubscribe from this list: send th
Fix a casting to u32 where u64 would be appropriate.
The bad casting made the driver unusable.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_utils.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe
Hi Greg,
Am Freitag, den 20.12.2013, 16:26 +0100 schrieb Frank Haverkamp:
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -59,7 +59,7 @@ int __genwqe_writeq(struct genwqe_dev *c
> if (cd->mmio == NULL)
> return -EIO;
>
> - __raw_writeq(cpu_to_b
Hi Greg,
Am Freitag, den 20.12.2013, 07:33 -0800 schrieb Greg KH:
> On Fri, Dec 20, 2013 at 04:26:11PM +0100, Frank Haverkamp wrote:
> > As requested by Greg, replacing the hexdump function from dynamic_debug.h
> > with one defined in printk.h. I hope I picked the right one.
>
As requested by Greg, replacing the hexdump function from dynamic_debug.h
with one defined in printk.h. I hope I picked the right one.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/genwqe_driver.h |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/drivers/misc/genwqe
, and
making a proposal how to fix them.
I included the missing header file to fix the
implicit-function-declaration warning when using dynamic_hex_dump.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/card_ddcb.c | 16 +++--
drivers/misc/genwqe/card_dev.c | 97
Hi Greg,
Am Mittwoch, den 18.12.2013, 16:52 -0800 schrieb Greg KH:
> On Wed, Dec 18, 2013 at 04:51:17PM +0100, Frank Haverkamp wrote:
> > ping
>
> Looks good, now applied, thanks for all of the revisions.
>
> Now the real work starts :)
>
thank you very much for revie
Hi Greg,
Am Mittwoch, den 18.12.2013, 16:55 -0800 schrieb Greg KH:
> > ---
> > include/linux/crc32.h |2 2 + 0 - 0 !
> > lib/crc32.c | 10 10 +0 - 0 !
> > lib/crc32defs.h |5 5 + 0 - 0 !
> > lib/gen_crc32table.c | 39
ping
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
polynom in addition to the other 3 crc tables. I wanted to figure out
if it is possible in principle to use the generic code.
Is the consumption of 1KiB for a little table justifyable if it
currently has just one user?
Signed-off-by: Frank Haverkamp
---
include/linux/crc32.h |2 2 + 0
Instead of reimplementing the CRC, make use of the generic CRC kernel
infrastructure. Note that GenWQE seems currently the only one using
this particular polynomial.
This change requires a previous patch which adds the GenWQE crc32 to
the generic kernel crc32 support.
Signed-off-by: Frank
Hi,
Am Freitag, den 06.12.2013, 09:39 +0100 schrieb Frank Haverkamp:
> Hi Arnd,
>
> Am Donnerstag, den 05.12.2013, 21:31 +0100 schrieb Arnd Bergmann:
> > On Thursday 05 December 2013, Frank Haverkamp wrote:
> > > > > Was wrong, as already
Miscelanous functionality used in the other GenWQE driver parts.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/genwqe/card_utils.c | 947 ++
1 files changed, 947
Sysfs interfaces for the GenWQE card. There are attributes to query
the version of the bitstream as well as some for the driver. For
debugging, please also see the debugfs interfaces of this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung
exchanged with user-space. The sysfs interface is described in
Documentation/ABI/testing/sysfs-driver-genwqe.
Now the driver has also a debugfs interface. This is described in
Documentation/ABI/testing/debugfs-driver-genwqe.
Frank Haverkamp (6):
GenWQE PCI support, health monitoring and recovery
Debugfs interfaces for the GenWQE card. Help to debug potential
problems. Dump internal chip state for debugging and failure
determination.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
Documentation/ABI/testing
Enable possiblity to configure and build this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/Kconfig |1 +
drivers/misc/Makefile|1 +
drivers/misc/genwqe/Kconfig | 13
Hi Arnd,
Am Donnerstag, den 05.12.2013, 21:31 +0100 schrieb Arnd Bergmann:
> On Thursday 05 December 2013, Frank Haverkamp wrote:
> > > > Was wrong, as already pointed out before. It is now:
> > > >
> > > > struct genwqe_mem {
> > > >
Sysfs interfaces for the GenWQE card. There are attributes to query
the version of the bitstream as well as some for the driver. For
debugging, please also see the debugfs interfaces of this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung
exchanged with user-space. The sysfs interface is described in
Documentation/ABI/testing/sysfs-driver-genwqe.
Now the driver has also a debugfs interface. This is described in
Documentation/ABI/testing/debugfs-driver-genwqe.
Frank Haverkamp (6):
GenWQE PCI support, health monitoring and recovery
Debugfs interfaces for the GenWQE card. Help to debug potential
problems. Dump internal chip state for debugging and failure
determination.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
Documentation/ABI/testing
Enable possiblity to configure and build this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/Kconfig |1 +
drivers/misc/Makefile|1 +
drivers/misc/genwqe/Kconfig | 13
Miscelanous functionality used in the other GenWQE driver parts.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/genwqe/card_utils.c | 947 ++
1 files changed, 947
Hi Arnd,
Am Donnerstag, den 05.12.2013, 03:38 +0100 schrieb Arnd Bergmann:
> On Wednesday 04 December 2013, Frank Haverkamp wrote:
> > Hi Arnd & Greg,
> >
> > please let me know if my following changes are ok:
> >
> > Am Dienstag, den 03.12.2013
Hi Arnd,
Am Donnerstag, den 05.12.2013, 03:27 +0100 schrieb Arnd Bergmann:
> On Wednesday 04 December 2013, Frank Haverkamp wrote:
> > Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp:
> > > + */
> > > +struct genwqe_mem {
> > > + unsign
Hi Arnd & Greg,
please let me know if my following changes are ok:
Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp:
> +/* Read/write from/to registers */
> +struct genwqe_regs_io {
> + __u32 num; /* register offset/address */
&g
Hi,
Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp:
> + */
> +struct genwqe_mem {
> + unsigned long addr;
> + unsigned long size;
> + int direction;
> +};
> +
> +#define GENWQE_PIN_MEM _IOWR(GENWQE_IOC_CODE, 40, struct
&g
Hi Arnd,
thanks for helping to review the code.
Am Dienstag, den 03.12.2013, 16:05 +0100 schrieb Arnd Bergmann:
> On Tuesday 03 December 2013, Frank Haverkamp wrote:
> > Ohh, sorry __u64 of course:
> >
> > /* common struct for chip image exchange */
> &
Am Dienstag, den 03.12.2013, 06:30 -0800 schrieb Greg KH:
> On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote:
> > > > +/* common struct for chip image exchange */
> > > > +struct chip_bitstream {
> > > > + uint8_t __user *p
Sysfs interfaces for the GenWQE card. There are attributes to query
the version of the bitstream as well as some for the driver. For
debugging, please also see the debugfs interfaces of this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung
Miscelanous functionality used in the other GenWQE driver parts.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/genwqe/card_utils.c | 949 ++
1 files changed, 949
exchanged with user-space. The sysfs interface is described in
Documentation/ABI/testing/sysfs-driver-genwqe.
Now the driver has also a debugfs interface. This is described in
Documentation/ABI/testing/debugfs-driver-genwqe.
Frank Haverkamp (6):
GenWQE PCI support, health monitoring and recovery
Enable possiblity to configure and build this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/Kconfig |1 +
drivers/misc/Makefile|1 +
drivers/misc/genwqe/Kconfig | 13
Debugfs interfaces for the GenWQE card. Help to debug potential
problems. Dump internal chip state for debugging and failure
determination.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
Documentation/ABI/testing
Hi Greg,
Am Mittwoch, den 27.11.2013, 11:20 -0800 schrieb Greg KH:
> On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote:
> > +/*
> > + * Flags for extended output (dbg_print)
> > + * We define different levels of debugging for the appropriate unit.
> >
Hi Greg,
Am Mittwoch, den 27.11.2013, 11:16 -0800 schrieb Greg KH:
> On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote:
> > --- /dev/null
> > +++ b/include/linux/genwqe/genwqe_card.h
> > @@ -0,0 +1,547 @@
> > +#ifndef __GENWQE_CARD_H__
>
Hi Greg,
Am Mittwoch, den 27.11.2013, 11:26 -0800 schrieb Greg KH:
> On Wed, Nov 06, 2013 at 01:45:40PM +0100, Frank Haverkamp wrote:
> > +/**
> > + * init_crc32() - Prepare a lookup table for fast crc32 calculations
> > + *
> > + * Existing kernel functions seem
Hi Greg,
thanks for taking your time to review our code once more.
Am Mittwoch, den 27.11.2013, 11:22 -0800 schrieb Greg KH:
> On Wed, Nov 06, 2013 at 01:45:42PM +0100, Frank Haverkamp wrote:
> > +/**
> > + * genwqe_init_sysfs() - Setup sysfs entries of the card device
&g
Hi Greg,
Am Freitag, den 22.11.2013, 08:52 -0800 schrieb Greg KH:
> On Fri, Nov 22, 2013 at 02:37:30PM +0100, Frank Haverkamp wrote:
> > Hello Greg and others,
> >
> > is the patchset ok this way, or do you see anything more I should
> > change/improve?
>
>
Hello Greg and others,
is the patchset ok this way, or do you see anything more I should
change/improve?
Regards
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.or
Hi Pavel,
Am Dienstag, den 12.11.2013, 14:50 +0100 schrieb Pavel Machek:
> Hi!
>
> > The GenWQE device is a PCIe card used to acclerate different tasks.
> > Since it is configurable, it can be adjusted to different purposes.
> > Our initial task for the card is to do zlib style compression/decomp
Sysfs interfaces for the GenWQE card. There are attributes to query
the version of the bitstream as well as some for the driver. For
debugging, please also see the debugfs interfaces of this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung
Miscelanous functionality used in the other GenWQE driver parts.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/genwqe/card_utils.c | 983 ++
1 files changed, 983
Enable possiblity to configure and build this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/Kconfig |1 +
drivers/misc/Makefile|1 +
drivers/misc/genwqe/Kconfig | 13
Debugfs interfaces for the GenWQE card. Help to debug potential
problems. Dump internal chip state for debugging and failure
determination.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
Documentation/ABI/testing
exchanged with user-space. The sysfs interface is described in
Documentation/ABI/testing/sysfs-driver-genwqe.
Now the driver has also a debugfs interface. This is described in
Documentation/ABI/testing/debugfs-driver-genwqe.
Frank Haverkamp (6):
GenWQE PCI support, health monitoring and recovery
Hi Ryan,
Am Mittwoch, den 06.11.2013, 07:43 +1100 schrieb Ryan Mallon:
> On 05/11/13 19:44, Frank Haverkamp wrote:
>
> > Sysfs interfaces for the GenWQE card. There are attributes to query
> > the version of the bitstream as well as some for the driver. For
> > debugg
Hi Ryan,
Am Mittwoch, den 06.11.2013, 14:43 +1100 schrieb Ryan Mallon:
> On 05/11/13 19:44, Frank Haverkamp wrote:
> > Debugfs interfaces for the GenWQE card. Help to debug potential
> > problems. Dump internal chip state for debugging and failure
> > determination.
> &g
Hi Ryan,
Am Dienstag, den 05.11.2013, 08:55 +1100 schrieb Ryan Mallon:
> On 05/11/13 04:08, Frank Haverkamp wrote:
> > Selecting interface names via configuration option is obsolete.
>
> Don't do this. You are adding completely new code, so there is no reason
> to post a
Debugfs interfaces for the GenWQE card. Help to debug potential
problems. Dump internal chip state for debugging and failure
determination.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
Documentation/ABI/testing
Miscelanous functionality used in the other GenWQE driver parts.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/genwqe/card_utils.c | 983 ++
1 files changed, 983
Enable possiblity to configure and build this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung ,
Michael Ruettger
---
drivers/misc/Kconfig |1 +
drivers/misc/Makefile|1 +
drivers/misc/genwqe/Kconfig | 13
exchanged with user-space. The sysfs interface is described in
Documentation/ABI/testing/sysfs-driver-genwqe.
Now the driver has also a debugfs interface. This is described in
Documentation/ABI/testing/debugfs-driver-genwqe.
Frank Haverkamp (6):
GenWQE PCI support, health monitoring and recovery
Sysfs interfaces for the GenWQE card. There are attributes to query
the version of the bitstream as well as some for the driver. For
debugging, please also see the debugfs interfaces of this driver.
Signed-off-by: Frank Haverkamp
Co-authors: Joerg-Stephan Vogt ,
Michael Jung
Am Montag, den 04.11.2013, 14:12 -0800 schrieb Greg KH:
> On Mon, Nov 04, 2013 at 06:08:01PM +0100, Frank Haverkamp wrote:
> > +if GENWQE
> > +
> > +config GENWQE_DEVNAME
> > +string "Name for sysfs and device nodes"
> > + default "
Hi Greg,
Am Montag, den 04.11.2013, 14:15 -0800 schrieb Greg KH:
> > I am using sysfs_create_group() now, but do I understand you
> correctly
> > that setting the const struct attribute_group **groups; in my device
> > (where in my struct pci_device.dev?) is an even better way to
> establish
> > m
module parameters are now constants:
genwqe_pf_jobtimeout_msec
genwqe_health_check_interval
Signed-off-by: Frank Haverkamp
---
Documentation/ABI/testing/debugfs-driver-genwqe | 13 +++
drivers/misc/genwqe/card_base.c | 93 ++-
drivers/misc/genwqe/card_
The removed constants should not be part of the user-space kernel
interface.
Signed-off-by: Frank Haverkamp
---
include/linux/genwqe/genwqe_card.h | 12
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/include/linux/genwqe/genwqe_card.h
b/include/linux/genwqe
Selecting interface names via configuration option is obsolete.
Signed-off-by: Frank Haverkamp
---
drivers/misc/genwqe/Kconfig| 14 ++
include/linux/genwqe/genwqe_card.h |6 +-
2 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/misc/genwqe
1 - 100 of 126 matches
Mail list logo
