Re: [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible

2021-02-02 Thread Firo Yang
The 01/20/2021 08:32, Jorgen Hansen wrote: > VMCI queue pair allocation is disabled, if a VM is in FT mode. In > these cases, VMware Tools may still once in a while attempt to > create a vSocket stream connection, resulting in multiple > warnings in the kernel logs. Therefore downgrade the error lo

[PATCH v3 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Firo Yang
pped it for the first frag. As such we need to always sync before possibly performing a page unmap operation. Fixes: f3213d932173 ("ixgbe: Update driver to make use of DMA attributes in Rx path") Reviewed-by: Alexander Duyck Signed-off-by: Firo Yang --- Changes from v2: * Added details on

Re: [Intel-wired-lan] [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Firo Yang
The 08/07/2019 09:06, Alexander Duyck wrote: > On Wed, Aug 7, 2019 at 7:09 AM Maciej Fijalkowski > wrote: > > > > On Wed, 7 Aug 2019 08:38:43 + > > Firo Yang wrote: > > > > > The 08/07/2019 15:56, Jacob Wen wrote: > > > > I think the descri

Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-07 Thread Firo Yang
the swiotlb buffer for the > NIC. > > The unmap operation is used to copy the swiotlb buffer to the pages that are > allocated by ixgbe. > > On 8/7/19 10:49 AM, Firo Yang wrote: > > In Xen environment, if Xen-swiotlb is enabled, ixgbe driver > > could possibly alloca

[PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

2019-08-06 Thread Firo Yang
page unmap operation. Fixes: f3213d932173 ("ixgbe: Update driver to make use of DMA attributes in Rx path") Reviewed-by: Alexander Duyck Signed-off-by: Firo Yang --- Changes from v1: * Imporved the patch description. * Added Reviewed-by: and Fixes: as suggested by Alexander Duyck

[PATCH 1/1] ixgbe: sync the first fragment unconditionally

2019-08-06 Thread Firo Yang
those two pages. Otherwise, we may get an incomplete skb. To fix this problem, sync the first fragment no matter the first fargment is makred as "page_released" or not. Signed-off-by: Firo Yang --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 +--- 1 file changed, 9

[PATCH v3] hdlcdrv: Fix divide by zero in hdlcdrv_ioctl

2017-05-26 Thread Firo Yang
syszkaller fuzzer triggered a divide by zero, when set calibration through ioctl(). To fix it, test 'bitrate' if it is negative or 0, just return -EINVAL. Reported-by: Andrey Konovalov Signed-off-by: Firo Yang --- v2->v3: Just fix divide error and remove netif_r

[PATCH] mm, vmstat: Fix NULL pointer dereference during pagetypeinfo print

2017-05-19 Thread Firo Yang
During showing the pagetypeinfo, we forgot to save the found page and dereference a invalid page address from the stack. To fix it, save and reference the page address returned by pfn_to_online_page(). Signed-off-by: Firo Yang --- mm/vmstat.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] hpfs: Remove unessary cast

2015-04-23 Thread Firo Yang
Avoid a pointless kmem_cache_alloc() return value cast in fs/hpfs/super.c::hpfs_alloc_inode() Signed-off-by: Firo Yang --- fs/hpfs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c index 7cd00d3..ccace08 100644 --- a/fs/hpfs/super.c

[PATCH] minix: No need to cast alloction return value in minix

2015-04-23 Thread Firo Yang
Remove unneeded kmem_cache_alloc() return value casts in fs/minix/inode.c::minix_alloc_inode(). Signed-off-by: Firo Yang --- fs/minix/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 3f57af1..8898633 100644 --- a/fs/minix

[PATCH] ncpfs: Remove pointless cast

2015-04-23 Thread Firo Yang
Remove explicit casts of kmem_cache_alloc return values in fs/ncpfs/inode.c::ncp_alloc_inode(). Signed-off-by: Firo Yang --- fs/ncpfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c index 01a9e16..a3aab17 100644 --- a/fs/ncpfs