RE: [PATCH V2] poweroff: fix bug in orderly_poweroff

2012-09-20 Thread Feng Hong
is much more safe, if the user application really fails, we just complain the application itself, it seems a better choice here. // -- Best Regards, Feng Hong Application Processor Software

RE: [PATCH V2] poweroff: fix bug in orderly_poweroff

2012-09-20 Thread Feng Hong
ere is no "/sbin/poweroff" existed. On the other hand, UMH_WAIT_PROC is not suitable here as Eric analysis; if using UMH_WAIT_EXEC, and the user application fail, I'd prefer to complain bad application. So using UMH_WAIT_EXEC and UMH_WAIT_PROC has a tradeoff here, what do you think so

RE: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Feng Hong
Hi, Eric, I agree with your idea, I'll prepare another patch, thanks for remind this possible issue. -- Best Regards, Feng Hong Application Processor Software Engnieer Marvell Technology (Shanghai) Ltd -Original Message- From: Eric W. Biederman [mailto:ebied...@xmission.com]

RE: [PATCH] poweroff: fix bug in orderly_poweroff

2012-09-18 Thread Feng Hong
* poweroff asap. Or not even bother syncing if we're doing an * emergency shutdown? */ emergency_sync(); kernel_power_off(); } return ret; }1 -- Best Regards, Feng Hong Application Processor Software Engnieer Marvell Technology (Shangha