Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread FanWu
On 06/04/2014 12:49 AM, Stephen Warren wrote: On 06/03/2014 01:37 AM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_

Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-06-03 Thread FanWu
On 06/03/2014 03:37 PM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. 3.Remove the disable ops in s

Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-05-29 Thread FanWu
On 05/30/2014 03:19 AM, Stephen Warren wrote: On 05/25/2014 08:43 PM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_

Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-05-28 Thread FanWu
On 05/26/2014 10:52 AM, FanWu wrote: On 05/26/2014 10:43 AM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting

Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

2014-05-25 Thread FanWu
On 05/26/2014 10:43 AM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. The reason why to do this is

Re: [PATCH v2] pinctrl: add params in disable_setting for different usage

2014-05-22 Thread FanWu
On 05/23/2014 07:13 AM, Stephen Warren wrote: On 05/21/2014 09:10 PM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_

Re: [PATCH v2] pinctrl: add params in disable_setting for different usage

2014-05-21 Thread FanWu
On 05/22/2014 11:10 AM, f...@marvell.com wrote: From: Fan Wu What the patch did: 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of calling pinctrl_select_state 2.Remove the HW disable operation in in pinmux_disable_setting function. The reason why to do this is

Re: [PATCH] pinctrl: add params in disable_setting for different usage

2014-05-20 Thread FanWu
On 05/21/2014 02:42 AM, Stephen Warren wrote: On 05/19/2014 09:05 PM, FanWu wrote: On 05/20/2014 04:55 AM, Stephen Warren wrote: On 05/18/2014 08:54 PM, FanWu wrote: On 05/17/2014 03:53 AM, Stephen Warren wrote: On 05/16/2014 10:21 AM, Linus Walleij wrote: On Wed, May 14, 2014 at 4:01 AM

Re: [PATCH] pinctrl: add params in disable_setting for different usage

2014-05-19 Thread FanWu
On 05/20/2014 04:55 AM, Stephen Warren wrote: On 05/18/2014 08:54 PM, FanWu wrote: On 05/17/2014 03:53 AM, Stephen Warren wrote: On 05/16/2014 10:21 AM, Linus Walleij wrote: On Wed, May 14, 2014 at 4:01 AM, wrote: From: Fan Wu The patch added params in disable_setting to differ the two

Re: [PATCH] pinctrl: add params in disable_setting for different usage

2014-05-18 Thread FanWu
On 05/17/2014 03:53 AM, Stephen Warren wrote: On 05/16/2014 10:21 AM, Linus Walleij wrote: On Wed, May 14, 2014 at 4:01 AM, wrote: From: Fan Wu The patch added params in disable_setting to differ the two possible usage, 1.Only want to disable the pin setting in SW aspect, param can be set

Re: [PATCH] pinctrl: add params in disable_setting to differ difference usage

2014-05-13 Thread FanWu
On 05/14/2014 09:54 AM, f...@marvell.com wrote: From: Fan Wu The patch added params in disable_setting to differ the two possible usage, 1.Only want to disable the pin setting in SW aspect, param can be set to "0" 2.Want to disable the pin setting in both HW and SW aspect, param can be set to

Re: [Pinctrl] A suggestion to avoid duplicated enabling operation on a pin's setting

2014-05-12 Thread FanWu
On 05/13/2014 04:20 AM, Stephen Warren wrote: On 05/07/2014 02:02 AM, FanWu wrote: ... I think the glitch you mentioned is indeed a problem for the vendors who define the "pinctrl-single,function-off" which will be activated when disabling setting. "pinctrl-single,funct

Re: [Pinctrl] A suggestion to avoid duplicated enabling operation on a pin's setting

2014-05-07 Thread FanWu
On 05/06/2014 01:41 AM, Stephen Warren wrote: FanWu, Questions about the Linux kernel should be sent to the public mailing lists so that anyone can see the discussion, join in, and/or see the result of the discussion in the list archives. Also, please use plain-text email, since that makes it