Re: [PATCH v2 2/4] watchdog: at91sam9_wdt: update device tree doc

2013-10-03 Thread Fabio Porcedda
On Thu, Oct 3, 2013 at 10:23 AM, boris brezillon wrote: > Hello Fabio, > > > On 03/10/2013 10:08, Fabio Porcedda wrote: >> >> On Fri, Jun 21, 2013 at 9:23 AM, Boris BREZILLON >> wrote: >>> >>> Add new at91sam9 watchdog properties to the docum

Re: [PATCH v2 2/4] watchdog: at91sam9_wdt: update device tree doc

2013-10-03 Thread Fabio Porcedda
icetree/bindings/watchdog/atmel-wdt.txt > @@ -9,11 +9,37 @@ Required properties: > > Optional properties: > - timeout-sec: contains the watchdog timeout in seconds. Why are you removing the documentation about this property? Regards -- Fabio Porcedda -- To unsubscribe from this list: s

Re: [PATCH v2 0/7] pcmcia: at91_cf: clean up and add DT support

2013-04-17 Thread Fabio Porcedda
- move to module_platform_driver_probe() > - little trivial indentation fix > > Fabio Porcedda (1): > pcmcia: at91_cf: use module_platform_driver_probe() > > Joachim Eastwood (5): > pcmcia: at91_cf: fix gpio_get_value in at91_cf_get_status > pcmcia: at91_cf: convert to de

Re: [PATCH 08/10] drivers: mfd: use module_platform_driver_probe()

2013-04-09 Thread Fabio Porcedda
On Tue, Apr 9, 2013 at 10:06 AM, Samuel Ortiz wrote: > Hi Fabio, > > On Thu, Mar 14, 2013 at 02:11:29PM +0100, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler.

[PATCH 2/3] driver core: platform.c: fix checkpatch errors and warnings

2013-03-26 Thread Fabio Porcedda
Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman --- drivers/base/platform.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index ef2afb1..9eda842 100644 --- a/drivers/base/platform.c +++ b/drivers

[PATCH 1/3] driver core: warn that platform_driver_probe can not use deferred probing

2013-03-26 Thread Fabio Porcedda
Add documentation that platform_driver_probe() is incompatible with deferred probing. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Geert Uytterhoeven --- drivers/base/platform.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 3/3] driver core: platform_device.h: fix checkpatch errors and warnings

2013-03-26 Thread Fabio Porcedda
Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman --- include/linux/platform_device.h | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index c082c71..139e000 100644 --- a/include

[PATCH 0/3] driver core: documentation and checkpatch complaints

2013-03-26 Thread Fabio Porcedda
Hi all, one patch is to improve documentation about deferred probing and two patches are to fix checkpatch complaints. Best regards Fabio Porcedda (3): driver core: warn that platform_driver_probe can not use deferred probing driver core: platform.c: fix checkpatch errors and warnings

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-21 Thread Fabio Porcedda
On Wed, Mar 20, 2013 at 12:46 PM, Arnd Bergmann wrote: > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> >> On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: >> > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> >> I think we can check

Re: [PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-21 Thread Fabio Porcedda
On Thu, Mar 21, 2013 at 10:55 AM, Herbert Xu wrote: > On Thu, Mar 14, 2013 at 06:09:33PM +0100, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Sig

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Fabio Porcedda
On Wed, Mar 20, 2013 at 11:20 AM, Arnd Bergmann wrote: > On Wednesday 20 March 2013, Fabio Porcedda wrote: >> I think we can check inside the deferred_probe_work_func() >> if the dev->probe function pointer is equal to platform_drv_probe_fail(). > > I think it's t

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-20 Thread Fabio Porcedda
On Tue, Mar 19, 2013 at 6:59 PM, Arnd Bergmann wrote: > On Tuesday 19 March 2013, Fabio Porcedda wrote: >> On Tue, Mar 19, 2013 at 5:48 PM, Arnd Bergmann wrote: >> > On Tuesday 19 March 2013, Geert Uytterhoeven wrote: >> >> Hmm, so we may have drivers that

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Fabio Porcedda
alized, except when they are > using platform_driver_probe() > >> I guess we need a big fat WARN_ON(-EPROBE_DEFER) in >> platform_driver_probe() to catch these? > > Yes, very good idea. > > Arnd If it's fine, I'll send a patch for that. Regards -- Fabio

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-19 Thread Fabio Porcedda
On Mon, Mar 18, 2013 at 12:28 PM, Arnd Bergmann wrote: > On Monday 18 March 2013, Fabio Porcedda wrote: >> >> On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: >> > On Monday 18 March 2013, Fabio Porcedda wrote: >> >> Since by using p

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann wrote: > On Monday 18 March 2013, Fabio Porcedda wrote: >> Since by using platform_driver_probe() the function >> ep93xx_pwm_probe() is freed after initialization, >> is better to use module_platform_drive_probe(). >>

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
king it would save a couple lines of code. Since by using platform_driver_probe() the function ep93xx_pwm_probe() is freed after initialization, is better to use module_platform_drive_probe(). IMHO i don't see any good reason to use module_platform_driver() for this driver. Best regards Fabio Porcedda >> I&#x

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
On Fri, Mar 15, 2013 at 12:28 PM, Arnd Bergmann wrote: > On Friday 15 March 2013, Fabio Porcedda wrote: >> >> * Regarding the use of module_platform_driver_probe, I'm a little worried >> >> about >> >> the interactions with deferred probing. I

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
On Thu, Mar 14, 2013 at 3:06 PM, Sascha Hauer wrote: > On Thu, Mar 14, 2013 at 01:58:05PM +, Arnd Bergmann wrote: >> On Thursday 14 March 2013, Fabio Porcedda wrote: >> > This patch converts the drivers to use the >> > module_platform_driver_probe() macro which

[PATCH] parport: amiga: use module_platform_driver_probe()

2013-03-15 Thread Fabio Porcedda
Use module_platform_driver_probe() macro which makes the code smaller and simpler. Signed-off-by: Fabio Porcedda Cc: Matt Porter Cc: Greg Kroah-Hartman --- drivers/parport/parport_amiga.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/parport

Re: [PATCH v2 4/8] drivers: input: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
On Thu, Mar 14, 2013 at 6:30 PM, Dmitry Torokhov wrote: > Hi Fabio, > > On Thursday, March 14, 2013 06:09:34 PM Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler.

[PATCH v2 1/8] drivers: media: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Mauro Carvalho Chehab Cc: Josh Wu Cc: Guennadi Liakhovetski Cc: Hans Verkuil Cc: linux-me

[PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Matt Mackall Cc: Herbert Xu Cc: Fabio Estevam Cc: Sascha Hauer --- drivers/char/hw_random/mxc-rnga.c

[PATCH v2 6/8] drivers: mfd: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Linus Walleij Cc: Samuel Ortiz Cc: linux-arm-ker...@lists.infradead.org --- drivers/mfd

[PATCH v2 2/8] drivers: ata: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Jeff Garzik Cc: linux-...@vger.kernel.org --- drivers/ata/pata_at32.c | 13 + 1 file changed, 1

[PATCH v2 0/8] Use module_platform_driver_probe() part 2

2013-03-14 Thread Fabio Porcedda
Hi all, this patch set is the second part for the conversion to use new module_platform_driver_probe() macro. v2: - rebased againg next and so dropped the already converted drivers. Fabio Porcedda (8): drivers: media: use module_platform_driver_probe() drivers: ata: use

[PATCH v2 7/8] drivers: video: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Richard Purdie Cc: Florian Tobias Schandinat Cc: linux-fb...@vger.kernel.org --- drivers/video

[PATCH v2 8/8] drivers: misc: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Arnd Bergmann --- drivers/misc/atmel_pwm.c | 12 +--- drivers/misc/ep93xx_pwm.c | 13

[PATCH v2 5/8] drivers: memory: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Benoit Cousson Cc: Aneesh V --- drivers/memory/emif.c | 12 +--- 1 file changed, 1 insertion(+), 11

[PATCH v2 4/8] drivers: input: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Dmitry Torokhov Cc: Mark Brown Cc: Liam Girdwood Cc: Bill Pemberton Cc: Linus Walleij Cc: David Howells

Re: [PATCH 04/10] drivers: hwmon: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
On Thu, Mar 14, 2013 at 3:01 PM, Guenter Roeck wrote: > On Thu, Mar 14, 2013 at 02:11:25PM +0100, Fabio Porcedda wrote: >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >&

Re: [PATCH 01/10] drivers: media: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
On Thu, Mar 14, 2013 at 2:25 PM, Guennadi Liakhovetski wrote: > Hi Fabio > > On Thu, 14 Mar 2013, Fabio Porcedda wrote: > >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >&

[PATCH] drivers: misc: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Arnd Bergmann --- drivers/misc/arm-charlcd.c | 13 + drivers/misc/atmel_pwm.c | 12

[PATCH 03/10] drivers: char: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Matt Mackall Cc: Herbert Xu Cc: Fabio Estevam Cc: Sascha Hauer --- drivers/char/hw_random/mxc-rnga.c

[PATCH 08/10] drivers: mfd: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Linus Walleij Cc: Samuel Ortiz Cc: linux-arm-ker...@lists.infradead.org --- drivers/mfd

[PATCH 00/10] Use module_platform_driver_probe() part 2

2013-03-14 Thread Fabio Porcedda
Hi all, this patch set is the second part for the conversion to use new module_platform_driver_probe() macro. I will send a part 3 for the remaining drivers. Fabio Porcedda (10): drivers: media: use module_platform_driver_probe() drivers: ata: use module_platform_driver_probe() drivers

[PATCH 02/10] drivers: ata: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Jeff Garzik Cc: linux-...@vger.kernel.org --- drivers/ata/pata_at32.c | 13 + drivers/ata

[PATCH 07/10] drivers: memory: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Benoit Cousson Cc: Aneesh V --- drivers/memory/emif.c | 12 +--- 1 file changed, 1 insertion(+), 11

[PATCH 06/10] drivers: input: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Dmitry Torokhov Cc: Mark Brown Cc: Liam Girdwood Cc: Bill Pemberton Cc: Linus Walleij Cc: David Howells

[PATCH 09/10] drivers: video: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Richard Purdie Cc: Florian Tobias Schandinat Cc: linux-fb...@vger.kernel.org --- drivers/video/backlight

[PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Arnd Bergmann --- drivers/misc/atmel_pwm.c | 12 +--- drivers/misc/ep93xx_pwm.c | 13

[PATCH 05/10] drivers: ide: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: "David S. Miller" Cc: linux-...@vger.kernel.org --- drivers/ide/gayle.c | 15 +-

[PATCH 04/10] drivers: hwmon: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Jean Delvare Cc: Guenter Roeck Cc: lm-sens...@lm-sensors.org --- drivers/hwmon/mc13783-adc.c | 13

[PATCH 01/10] drivers: media: use module_platform_driver_probe()

2013-03-14 Thread Fabio Porcedda
This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman Cc: Mauro Carvalho Chehab Cc: Josh Wu Cc: Guennadi Liakhovetski Cc: Hans Verkuil Cc: linux-me

Re: [PATCH 10/19] watchdog: at91sam9: at91_wdt_dt_ids cannot be __init

2013-01-28 Thread Fabio Porcedda
iver references >> the (unknown reference) __initconst (unknown) >> >> Signed-off-by: Arnd Bergmann >> Cc: Wim Van Sebroeck >> Cc: linux-watch...@vger.kernel.org >> Cc: Nicolas Ferre > > Acked-by: Nicolas Ferre > > Thanks, > >> Cc: Fabio

Re: [PATCH 10/19] watchdog: at91sam9: at91_wdt_dt_ids cannot be __init

2013-01-28 Thread Fabio Porcedda
r fixing my commit. Best regards > Signed-off-by: Arnd Bergmann > Cc: Wim Van Sebroeck > Cc: linux-watch...@vger.kernel.org > Cc: Nicolas Ferre > Cc: Fabio Porcedda > --- > drivers/watchdog/at91sam9_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 1/3] driver core: add helper macro for platform_driver_probe() boilerplate

2013-01-10 Thread Fabio Porcedda
Hi Greg, I'm sorry, In the previous email I used your wrong email address, in this email I've used your correct email address. Best regards Fabio Porcedda On Wed, Jan 9, 2013 at 12:15 PM, Fabio Porcedda wrote: > For simple modules that contain a single platform_driver without any

[PATCH 2/3] watchdog: convert drivers/watchdog/* to use module_platform_driver_probe

2013-01-09 Thread Fabio Porcedda
This makes the code a bit smaller by getting rid of some boilerplate code. Signed-off-by: Fabio Porcedda Cc: linux-watch...@vger.kernel.org Cc: Wim Van Sebroeck Cc: Linus Walleij --- drivers/watchdog/at32ap700x_wdt.c | 12 +--- drivers/watchdog/at91sam9_wdt.c | 13

[PATCH 3/3] usb: converto drivers/usb/* to use module_platform_driver_probe()

2013-01-09 Thread Fabio Porcedda
This patch converts the drivers in drivers/usb/* to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Signed-off-by: Fabio Porcedda Cc: linux-...@vger.kernel.org Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Nicolas Ferre Cc: Eric Miao Cc: Russell

[PATCH 0/3] Add and use new macro module_platform_driver_probe()

2013-01-09 Thread Fabio Porcedda
. This macro use the same idea of module_platform_driver(). This macro is useful to stop the misuse of module_platform_driver() for removing the platform_driver_probe() boilerplate. Convert drivers/usb/* and drivers/watchdog/* to use module_platform_driver_probe(). Best regards Fabio Porcedda

[PATCH 1/3] driver core: add helper macro for platform_driver_probe() boilerplate

2013-01-09 Thread Fabio Porcedda
macro use the same idea of module_platform_driver(). This macro is useful to stop the misuse of module_platform_driver() for removing the platform_driver_probe() boilerplate. Signed-off-by: Fabio Porcedda Cc: Greg Kroah-Hartman --- include/linux/platform_device.h | 18 ++ 1

Re: [v3 PATCH 7/9] watchdog/at91sam9_wdt: Use module_platform_driver()

2013-01-08 Thread Fabio Porcedda
Still, setting up platform_driver.probe and removing __init from all probe >functions is not the right thing to do, as this make (non-__init) kernel code >size bigger, while none of these devices are hotpluggable and thus cannot >appear after bootup. That's why we have platform_driver_pro

Re: [ 102/105] usb: gadget: at91_udc: fix dt support

2012-10-28 Thread Fabio Porcedda
mit: d1494a340807c9b77aa44bc8d8166353df4cf1c3 so i think it's best to doesn't apply this patch. Best regards -- Fabio Porcedda > -- > > From: Fabio Porcedda > > commit 9c6d196d5aa35e07482f23c3e37755e7a82140e0 upstream. > > Don't fail the initiali