[PATCH V2 4/5 net-next] vxlan: check rtnl_configure_link return code correctly

2020-09-25 Thread Fabian Frederick
rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxla

[PATCH V2 5/5 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

2020-09-25 Thread Fabian Frederick
Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++

[PATCH V2 2/5 net-next] vxlan: add unlikely to vxlan_remcsum check

2020-09-25 Thread Fabian Frederick
small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/dr

[PATCH V2 3/5 net-next] vxlan: move encapsulation warning

2020-09-25 Thread Fabian Frederick
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers

[PATCH V2 1/5 net-next] vxlan: don't collect metadata if remote checksum is wrong

2020-09-25 Thread Fabian Frederick
call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c

[PATCH V2 0/5 net-next] vxlan: clean-up

2020-09-25 Thread Fabian Frederick
This small patchet does some clean-up on vxlan. Second version removes VXLAN_NL2FLAG macro relevant patches as suggested by Michal and David I hope to have some feedback/ACK from vxlan developers. Fabian Frederick (5): vxlan: don't collect metadata if remote checksum is wrong vxlan

[PATCH 7/7 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

2020-08-26 Thread Fabian Frederick
Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++

[PATCH 6/7 net-next] vxlan: merge VXLAN_NL2FLAG use in vxlan_nl2conf()

2020-08-26 Thread Fabian Frederick
Sort flag assignment to add readability. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e9b561b9d23e1..1501a5633a97e 100644 --- a/drivers

[PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

2020-08-26 Thread Fabian Frederick
Replace common flag assignment with a macro. This could yet be simplified with changelink/supported but it would remove clarity Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 113 +--- include/net/vxlan.h | 10 2 files changed, 23

[PATCH 4/7 net-next] vxlan: check rtnl_configure_link return code correctly

2020-08-26 Thread Fabian Frederick
rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxla

[PATCH 3/7 net-next] vxlan: move encapsulation warning

2020-08-26 Thread Fabian Frederick
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers

[PATCH 2/7 net-next] vxlan: add unlikely to vxlan_remcsum check

2020-08-26 Thread Fabian Frederick
small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/dr

[PATCH 1/7 net-next] vxlan: don't collect metadata if remote checksum is wrong

2020-08-26 Thread Fabian Frederick
call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c

[PATCH 3/7 linux-next] coda: use SIZE() for stat

2018-10-19 Thread Fabian Frederick
max_t expression was already defined in coda sources Signed-off-by: Fabian Frederick --- fs/coda/upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c index d0d0fed..1323793 100644 --- a/fs/coda/upcall.c +++ b/fs/coda/upcall.c @@ -553,7

[PATCH 5/7 linux-next] coda: remove sysctl object from module when unused

2018-10-19 Thread Fabian Frederick
Inspired by NFS sysctl process Signed-off-by: Fabian Frederick --- fs/coda/Makefile | 3 ++- fs/coda/coda_int.h | 10 ++ fs/coda/coda_linux.h | 4 fs/coda/sysctl.c | 11 --- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/coda/Makefile b/fs

[PATCH 6/7 linux-next] coda: remove sb test in coda_fid_to_inode()

2018-10-19 Thread Fabian Frederick
coda_fid_to_inode() is only called by coda_downcall() where sb is already being tested. Signed-off-by: Fabian Frederick --- fs/coda/cnode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/coda/cnode.c b/fs/coda/cnode.c index 845b5a6..c42d340 100644 --- a/fs/coda/cnode.c +++ b/fs/coda

[PATCH 2/7 linux-next] coda: destroy mutex in put_super()

2018-10-19 Thread Fabian Frederick
we can safely destroy vc_mutex at the end of umount process. Signed-off-by: Fabian Frederick --- fs/coda/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/coda/inode.c b/fs/coda/inode.c index dd819c1..69bb64d 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c @@ -244,6 +244,7

[PATCH 7/7 linux-next] coda: ftoc validity check integration

2018-10-19 Thread Fabian Frederick
This patch moves cfi check in coda_ftoc() instead of repeating it in the wild. Module size textdata bss dec hex filename 282971040 700 300377555 fs/coda/coda.ko.before 28263 980 700 2994374f7 fs/coda/coda.ko.after Signed-off-by: Fabian Frederick

[PATCH 0/7 linux-next] coda: fs clean-up

2018-10-19 Thread Fabian Frederick
This small patchset applies some sparse clean-up / optimizations Fabian Frederick (7): coda: remove CODA_FREE coda: destroy mutex in put_super() coda: use SIZE() for stat coda: add __init to init_coda_psdev() coda: remove sysctl object from module when unused coda: remove sb test in

[PATCH 4/7 linux-next] coda: add __init to init_coda_psdev()

2018-10-19 Thread Fabian Frederick
init_coda_psdev() was only called by __init function. Signed-off-by: Fabian Frederick --- fs/coda/psdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index cbdddf4..6d1c95f 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c @@ -352,7

[PATCH 1/7 linux-next] coda: remove CODA_FREE

2018-10-19 Thread Fabian Frederick
Since commit 1d5cfdb07628 ("tree wide: use kvfree() than conditional kfree()/vfree()") size in CODA_FREE is no longer used and that macro hides nothing more than kvfree() Signed-off-by: Fabian Frederick --- fs/coda/coda_linux.h | 2 -- fs/coda/psdev.c | 8 fs/cod

[tip:efi/core] efi/capsule: Remove NULL test on kmap()

2017-06-05 Thread tip-bot for Fabian Frederick
Commit-ID: 171fd0222957abe28e6d78de667f457376f45cf1 Gitweb: http://git.kernel.org/tip/171fd0222957abe28e6d78de667f457376f45cf1 Author: Fabian Frederick AuthorDate: Fri, 2 Jun 2017 13:52:01 + Committer: Ingo Molnar CommitDate: Mon, 5 Jun 2017 17:50:40 +0200 efi/capsule: Remove NULL

Re: [PATCH 00/11 linux-next] super magic values consolidation

2017-05-28 Thread Fabian Frederick
> On 28 May 2017 at 11:34 Christoph Hellwig wrote: > > > On Sun, May 21, 2017 at 05:39:47PM +0200, Fabian Frederick wrote: > > This small patchset reorganizes magic.h and fixes filesystems > > which defined locally super magic values. > > And what's the poin

[PATCH 11/11 linux-next] hfsplus: export super magic value

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/hfsplus/hfsplus_raw.h | 1 - include/uapi/linux/magic.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/hfsplus_raw.h b/fs/hfsplus

[PATCH 10/11 linux-next] fs: define hfs super magic values globally

2017-05-21 Thread Fabian Frederick
hfs values were defined twice (in hfs and hfsplus) This patch exports values globally and include magic.h in hfs.h and hfsplus_raw.h where other magic are going to be exported as well. Signed-off-by: Fabian Frederick --- fs/hfs/hfs.h | 4 ++-- fs/hfsplus/hfsplus_raw.h | 1 + fs

[PATCH 09/11 linux-next] freevxfs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/freevxfs/vxfs.h | 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/freevxfs/vxfs.h b/fs/freevxfs

[PATCH 08/11 linux-next] fuse: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/fuse/control.c | 3 +-- fs/fuse/inode.c| 3 +-- include/uapi/linux/magic.h | 2 ++ 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH 05/11 linux-next] ubifs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/ubifs/ubifs.h | 4 +--- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h

[PATCH 07/11 linux-next] ocfs2: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/ocfs2/ocfs2_fs.h| 5 ++--- include/uapi/linux/magic.h | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2

[PATCH 06/11 linux-next] jfs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/jfs/jfs_incore.h| 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_incore.h b/fs/jfs

[PATCH 04/11 linux-next] orangefs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/orangefs/protocol.h | 3 +-- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/orangefs/protocol.h b/fs/orangefs

[PATCH 03/11 linux-next] ceph: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/ceph/super.h| 4 +--- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ceph/super.h b/fs/ceph/super.h

[PATCH 01/11 linux-next] uapi: reorganize magic.h

2017-05-21 Thread Fabian Frederick
-Sort magic.h in alphabetical order as there were no real logic in this file. -Replace all spaces with tabs -Remove excessive comments for reiserfs Signed-off-by: Fabian Frederick --- include/uapi/linux/magic.h | 92 -- 1 file changed, 40 insertions

[PATCH 02/11 linux-next] exofs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/exofs/common.h | 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/exofs/common.h b/fs/exofs

[PATCH 00/11 linux-next] super magic values consolidation

2017-05-21 Thread Fabian Frederick
This small patchset reorganizes magic.h and fixes filesystems which defined locally super magic values. Fabian Frederick (11): uapi: reorganize magic.h exofs: use magic.h ceph: use magic.h orangefs: use magic.h ubifs: use magic.h jfs: use magic.h ocfs2: use magic.h fuse: use

[PATCH linux-next] fs: remove void * casting in init_once()

2017-05-16 Thread Fabian Frederick
See Documentation/process/coding-style.rst: "Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language." This will stop copy/paste cascade warnings. Signed-off-by: Fabian

[PATCH 3/3 linux-next] fs/affs: stat: return block number

2017-05-15 Thread Fabian Frederick
stat doesn't give any block number as it's filesystem specific. Add getattr wrapper to return i_blkcnt calculated during affs_iget() Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 2 ++ fs/affs/file.c | 1 + fs/affs/inode.c | 11 +++ 3 files changed, 14 insertion

[PATCH 2/3 linux-next] fs/affs: remove affs_set_blocksize()

2017-05-15 Thread Fabian Frederick
That function was only calling sb_set_blocksize() Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 5 - fs/affs/super.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 87b17b5..fd99f28 100644 --- a/fs/affs/affs.h +++ b/fs

[PATCH 1/3 linux-next] fs/affs: normalize inode function prototypes

2017-05-15 Thread Fabian Frederick
Use the same style as other function blocks Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 773749b..87b17b5 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h @@ -179,14

[PATCH 0/3 linux-next] fs/affs: add blocknumber to stat

2017-05-15 Thread Fabian Frederick
stat doesn't give any block number as it's filesystem specific. This small patchset adds getattr wrapper to return i_blkcnt calculated during affs_iget() and does some clean-up in affs.h Fabian Frederick (3): fs/affs: normalize inode function prototypes fs/affs: remove affs_set

[PATCH linux-next] device-dax: fix BLOCK dependency

2017-05-13 Thread Fabian Frederick
plicit declaration of function 'get_start_sect' [-Werror=implicit-function-declaration] Signed-off-by: Fabian Frederick --- drivers/dax/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig index b79aa8f..1806628 100644 --- a/drivers/dax/Kconfi

[PATCH linux-next] jffs2: reduce stack usage in jffs2_build_xattr_subsystem()

2017-05-09 Thread Fabian Frederick
dynamic,bounded Also update definition when CONFIG_JFFS2_FS_XATTR is not enabled Tested with an MTD mount point and some user set/getfattr. Signed-off-by: Fabian Frederick --- fs/jffs2/build.c | 5 - fs/jffs2/xattr.c | 14 ++ fs/jffs2/xattr.h | 4 ++-- 3 files changed, 16 insertions

[PATCH 2/2 linux-next] fs/affs: add rename exchange

2017-05-05 Thread Fabian Frederick
Process RENAME_EXCHANGE in affs_rename2() adding static affs_xrename() based on affs_rename(). We remove headers from respective directories then affect bh to other inode directory entries for swapping. Signed-off-by: Fabian Frederick --- fs/affs/namei.c | 58

[PATCH 1/2 linux-next] fs/affs: add rename2 to prepare multiple methods

2017-05-05 Thread Fabian Frederick
Currently AFFS only supports RENAME_NOREPLACE. This patch isolates that method to a static function to prepare RENAME_EXCHANGE addition. Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 2 +- fs/affs/dir.c | 2 +- fs/affs/namei.c | 25 - 3 files changed, 18

[PATCH linux-next RESEND] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-05-04 Thread Fabian Frederick
This script removes NULL check on kmap() and all process involved (OOM message ...) Thanks to Jan Kara for explanations. Acked-by: Julia Lawall Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc/kmap.cocci | 43 ++ 1 file changed, 43 insertions

[PATCH V3 linux-next] nfs: use kmap/kunmap directly

2017-05-03 Thread Fabian Frederick
, all subsequent error checks were removed as well as unused labels. Signed-off-by: Fabian Frederick --- V3: -Remove nfs_readdir_get_array()/release_array() (suggested by Trond Myklebust) -Remove subsequent checks V2: -Remove ptr and return kmap(page) directly (suggested by

[PATCH 2/2 linux-next] gfs2: remove unused flags parameter

2017-05-03 Thread Fabian Frederick
We already assumed rename flags when calling gfs2_exchange() Signed-off-by: Fabian Frederick --- fs/gfs2/inode.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9698796..b5858a3 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c

[PATCH 1/2 linux-next] gfs2: check rename2 flags at once

2017-05-03 Thread Fabian Frederick
There's no need to update flags in gfs2_rename2() This will ease whiteout addition. Signed-off-by: Fabian Frederick --- fs/gfs2/inode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9f605ea..9698796 100644 --- a/fs/gfs2/in

[PATCH V2 linux-next] nfs: kmap can't fail

2017-04-26 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- V2: Remove ptr and return kmap(page) directly (Suggested by Anna Schumaker) fs/nfs/dir.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3a188cb..12ed806b 100644 --- a/fs

[PATCH V2 linux-next] staging: media: atomisp: kmap() can't fail

2017-04-26 Thread Fabian Frederick
There's no need to check kmap() return value because it won't fail. If it's highmem mapping, it will receive virtual address or a new one; if it's lowmem, all kernel pages are already being mapped. (Thanks to Jan Kara for explanations) Signed-off-by: Fabian Frederick --- V2:

[PATCH 1/1 linux-next] btrfs: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- fs/btrfs/check-integrity.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index ab14c2e..496eb00 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs

[PATCH 1/1 linux-next] nfs: kmap can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- fs/nfs/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3a188cb..f89e54c 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -179,8 +179,6 @@ struct nfs_cache_array *nfs_readdir_get_array

[PATCH 1/1 linux-next] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-04-25 Thread Fabian Frederick
This script removes NULL check on kmap() and all process involved (OOM message ...) Thanks to Jan Kara for explanations. Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc/kmap.cocci | 43 ++ 1 file changed, 43 insertions(+) create mode 100644

[PATCH 1/1 linux-next] efi/capsule: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- drivers/firmware/efi/capsule-loader.c | 5 - drivers/firmware/efi/capsule.c| 4 2 files changed, 9 deletions(-) diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c index

[PATCH 1/1 linux-next] staging: media: atomisp: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci

[PATCH 2/2 linux-next] fs/affs: bugfix: Write files greater than page size on OFS

2017-04-24 Thread Fabian Frederick
ned-off-by: Fabian Frederick --- fs/affs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index e5c5de6..196ee7f 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -679,7 +679,7 @@ static int affs_write_end_ofs(struct file *file, struct add

[PATCH 1/2 linux-next] fs/affs: bugfix: enable writes on OFS disks

2017-04-24 Thread Fabian Frederick
found here: https://bugzilla.kernel.org/show_bug.cgi?id=114961 Signed-off-by: Fabian Frederick --- fs/affs/file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index 0deec9c..e5c5de6 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c

[PATCH 1/2 linux-next] udf: use octal for permissions

2017-04-23 Thread Fabian Frederick
According to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead") Signed-off-by: Fabian Frederick --- fs/udf/inode.c | 14 +++--- fs/udf/namei.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/udf/inode.c b/fs/u

[PATCH 2/2 linux-next] udf: use kmap_atomic for memcpy copying

2017-04-23 Thread Fabian Frederick
Use temporary mapping for memory copying operations. To avoid any sleeping problem, mark_inode_dirty(inode) was moved after kunmap() in udf_adinicb_readpage() down_write(&iinfo->i_data_sem) set before kmap_atomic() in udf_expand_file_adinicb() Signed-off-by: Fabian Frederick ---

[PATCH 1/1 linux-next] fs/affs: remove node generation check

2017-04-14 Thread Fabian Frederick
node generation has to be stored on disk. AFAICS we won't be able to manage it on AFFS. This patch removes relevant check in affs_nfs_get_inode() Signed-off-by: Fabian Frederick --- fs/affs/namei.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/affs/namei.c b/fs/affs/namei.c

[PATCH 1/1 linux-next] fs/affs: bugfix: make symbolic links work again

2017-04-14 Thread Fabian Frederick
g inode size when reading symbolic link from disk or creating a new one. Result was zero allocation in pagecache. ln -s file symlink ls -lrt file symlink -> This patch adds inode isize information on inode get and symbolic link addition. Signed-off-by: Fabian Frederick --- fs/affs/inode.c | 1

[PATCH 1/1 linux-next] fs/affs: import amigaffs.h

2017-04-14 Thread Fabian Frederick
Have that file in global include/linux is not needed. Signed-off-by: Fabian Frederick --- fs/affs/affs.h| 2 +- {include/linux => fs/affs}/amigaffs.h | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename {include/linux => fs/affs}/amigaffs.h (100%) diff --gi

[PATCH 1/1 linux-next] fs/affs: free affs_sb_info in put_super()

2017-03-30 Thread Fabian Frederick
kill_block_super() calls generic_shutdown_super() calling FS put_user() where we generally free superblock specific information. This removes unneeded affs_kill_sb() sbi is automatically reserved in fill_super() so there is no need to test it. Signed-off-by: Fabian Frederick --- fs/affs

[PATCH 1/1 linux-next] befs: make export work with cold dcache

2017-03-28 Thread Fabian Frederick
based on commit b3b42c0deaa1 ("fs/affs: make export work with cold dcache") This adds get_parent function so that nfs client can still work after cache drop (Tested on NFS v4 with echo 3 > /proc/sys/vm/drop_caches) Signed-off-by: Fabian Frederick --- fs/befs/linuxvfs.c | 15 +

Re: [PATCH 01/14] locking/atomic: import atomic_dec_not_zero()

2017-02-01 Thread Fabian Frederick
> On 01 February 2017 at 10:25 Peter Zijlstra wrote: > > > On Tue, Jan 31, 2017 at 09:55:08PM +0100, Fabian Frederick wrote: > > Once again it's just about readability: > > I feel APIs should be about common use-cases, not about sporadic weird cases. > > &g

Re: [PATCH 01/14] locking/atomic: import atomic_dec_not_zero()

2017-01-31 Thread Fabian Frederick
> On 31 January 2017 at 20:17 Peter Zijlstra wrote: > > > On Tue, Jan 31, 2017 at 06:41:28PM +0100, Fabian Frederick wrote: > > > > > > > On 31 January 2017 at 11:41 Peter Zijlstra wrote: > > > > > > > > > On Mon, Jan 30, 2017 at 07:

Re: [PATCH 01/14] locking/atomic: import atomic_dec_not_zero()

2017-01-31 Thread Fabian Frederick
> On 31 January 2017 at 11:41 Peter Zijlstra wrote: > > > On Mon, Jan 30, 2017 at 07:39:38PM +0100, Fabian Frederick wrote: > > complementary definition to atomic_inc_not_zero() featured in > > lib/fault-inject.c > > Why? Maybe this commit message should be ok

Re: [PATCH 14/14] xfs: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
> On 31 January 2017 at 01:30 "Darrick J. Wong" wrote: > > > On Mon, Jan 30, 2017 at 07:48:44PM +0100, Fabian Frederick wrote: > > instead of atomic_add_unless(value, -1, 0) > > > > Signed-off-by: Fabian Frederick > > --- > >  fs/xfs/xfs

[PATCH 04/14] m5mols: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/media/i2c/m5mols/m5mols_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c index acb804b..3aab2ca

[PATCH 05/14] omap3isp: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/media/platform/omap3isp/ispstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index 47cbc7e

[PATCH 09/14] kdb: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- kernel/debug/kdb/kdb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index ca18391..095e6d8 100644 --- a/kernel/debug/kdb

[PATCH 08/14] ipmi: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 9f69995..961d677 100644 --- a

[PATCH 11/14] PM: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- kernel/power/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/power/user.c b/kernel/power/user.c index 22df9f7..c478572 100644 --- a/kernel/power/user.c +++ b/kernel/power/user.c

[PATCH 10/14] PM / Hibernate: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- kernel/power/hibernate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index b26dbc4..cfa7930 100644 --- a/kernel/power/hibernate.c +++ b

[PATCH 06/14] s390/qeth: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/s390/net/qeth_core_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 315d8a2..9595b90 100644 --- a/drivers

[PATCH 07/14] PM / RUNTIME: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/base/power/runtime.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 872eac4..8ed435f 100644 --- a/drivers/base/power

[PATCH 14/14] xfs: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index ac3b4db..51b2167 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1684,7 +1684,7

[PATCH 13/14] ext4: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- fs/ext4/ext4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 164a2e0..3184c25 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2916,7 +2916,7 @@ static

[PATCH 12/14] s390/topology: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- arch/s390/kernel/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c index 7b2b19b..820ef64 100644 --- a/arch/s390/kernel

[PATCH 03/14] drm/omap: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index 3cab066..abd0b15

[PATCH 02/14] drm/exynos: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 745cfbd..0e191b6

[PATCH 01/14] locking/atomic: import atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
complementary definition to atomic_inc_not_zero() featured in lib/fault-inject.c Signed-off-by: Fabian Frederick --- include/linux/atomic.h | 2 ++ lib/fault-inject.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/atomic.h b/include/linux/atomic.h index

[PATCH 00/14] use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
complementary definition to atomic_inc_not_zero() featured in lib/fault-inject.c. This small patchset moves it to include/linux/atomic.h using it instead of atomic_add_unless(value, -1, 0) s390 patches were not compile-tested. Fabian Frederick (14): locking/atomic: import atomic_dec_not_zero

[PATCH 2/3 linux-next] udf: simplify udf_ioctl()

2017-01-24 Thread Fabian Frederick
"out" label was only returning error code. Signed-off-by: Fabian Frederick --- fs/udf/file.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index d44b3cb..00931fa 100644 --- a/fs/udf/file.c ++

[PATCH 1/3 linux-next] udf: fix ioctl errors

2017-01-24 Thread Fabian Frederick
by Jan Kara, if arg is NULL with a correct ioctl, we return -VM_FAULT_SIGBUS to report error. Signed-off-by: Fabian Frederick --- fs/udf/file.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index dbcb3a4a..d44b3cb 100644 --- a/fs/udf

[PATCH 3/3 linux-next] udf: remove else after return in udf_ioctl()

2017-01-24 Thread Fabian Frederick
else after return is not needed. Signed-off-by: Fabian Frederick --- fs/udf/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index 00931fa..a1fec1b 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c @@ -194,8 +194,7 @@ long udf_ioctl(struct

Re: [PATCH 1/1 linux-next] jfs: atomically read inode size

2017-01-23 Thread Fabian Frederick
> On 23 January 2017 at 19:43 Dave Kleikamp wrote: > > > On 01/23/2017 11:50 AM, Fabian Frederick wrote: > > See i_size_read() comments in include/linux/fs.h > > Is this fixing a real problem? Can the bd_inode size change while we're > mounting or resizing the fi

[PATCH 1/1 linux-next] ext4: atomically read inode size

2017-01-23 Thread Fabian Frederick
See i_size_read() comments in include/linux/fs.h Signed-off-by: Fabian Frederick --- fs/ext4/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9d15a62..3746f77 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3798,7

[PATCH 1/1 linux-next] hfsplus: atomically read inode size

2017-01-23 Thread Fabian Frederick
See i_size_read() comments in include/linux/fs.h Signed-off-by: Fabian Frederick --- fs/hfsplus/wrapper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c index ebb85e5..e254fa0 100644 --- a/fs/hfsplus/wrapper.c +++ b/fs/hfsplus

[PATCH 1/1 linux-next] hfs: atomically read inode size

2017-01-23 Thread Fabian Frederick
See i_size_read() comments in include/linux/fs.h Signed-off-by: Fabian Frederick --- fs/hfs/mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfs/mdb.c b/fs/hfs/mdb.c index a3ec3ae..482081b 100644 --- a/fs/hfs/mdb.c +++ b/fs/hfs/mdb.c @@ -38,7 +38,7 @@ static int

[PATCH 1/1 linux-next] jfs: atomically read inode size

2017-01-23 Thread Fabian Frederick
See i_size_read() comments in include/linux/fs.h Signed-off-by: Fabian Frederick --- fs/jfs/resize.c | 4 ++-- fs/jfs/super.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c index bd9b641..7ddcb44 100644 --- a/fs/jfs/resize.c +++ b/fs

[PATCH 1/1 linux-next] fs/reiserfs: atomically read inode size

2017-01-23 Thread Fabian Frederick
See i_size_read() comments in include/linux/fs.h Signed-off-by: Fabian Frederick --- fs/reiserfs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index e314cb3..feabcde 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs

[PATCH 1/1 linux-next] udf: return inappropriate ioctl instead of argument error

2017-01-19 Thread Fabian Frederick
on ..." If arg is NULL, we return specific operation error anyway. Signed-off-by: Fabian Frederick --- fs/udf/file.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index dbcb3a4a..964620b 100644 --- a/fs/udf/file.c +++ b/fs/udf/file

Re: [PATCH V2 0/7 linux-next] make FS exportable plus some clean-up

2017-01-18 Thread Fabian Frederick
> On 09 January 2017 at 20:12 Fabian Frederick wrote: > > > This small patchset makes AFFS work with NFS for standard operations. > V2 adds a new patch suggested by Alexander Viro in order to work with cold > dcache. > > Fabian Frederick (7): >   fs/affs: remove r

[RFC 1/1 linux-next] udf: allow implicit blocksize specification during mount

2017-01-18 Thread Fabian Frederick
other values but maybe VRS is not mandatory there ? Tested with 512, 1024, 2048 and 4096 blocksize Reported-by: Jan Kara Signed-off-by: Fabian Frederick --- fs/udf/super.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c

[PATCH 1/1 linux-next] Documentation/filesystems/proc.txt: add VmPin

2017-01-14 Thread Fabian Frederick
Commit bc3e53f682d9 ("mm: distinguish between mlocked and pinned pages") added VmPin in /proc//status. Report that in Documentation/filesystems/proc.txt Also move Umask after Name to keep correct order. Signed-off-by: Fabian Frederick --- Documentation/filesystems/proc.txt | 5 +++

[PATCH V2 6/7 linux-next] fs/affs/namei.c: forward declarations clean-up

2017-01-09 Thread Fabian Frederick
move dentry_operations structures and remove forward declarations Signed-off-by: Fabian Frederick --- fs/affs/namei.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/fs/affs/namei.c b/fs/affs/namei.c index 906ff5b..fb88446 100644 --- a/fs

[PATCH V2 5/7 linux-next] fs/affs: add prefix to some functions

2017-01-09 Thread Fabian Frederick
secs_to_datestamp(time64_t secs, struct affs_date *ds); prot_to_mode(u32 prot); mode_to_prot(struct inode *inode); were declared without affs_ prefix Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 6 +++--- fs/affs/amigaffs.c | 6 +++--- fs/affs/inode.c| 9 + fs/affs

[PATCH V2 2/7 linux-next] fs/affs: add validation block function

2017-01-09 Thread Fabian Frederick
avoid repeating 4 times the same calculation. Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 899256b..efe6839 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h @@ -212,6

[PATCH V2 7/7 linux-next] fs/affs: make export work with cold dcache

2017-01-09 Thread Fabian Frederick
This adds get_parent function so that nfs client can still work after cache drop (Tested on NFS v4 with echo 3 > /proc/sys/vm/drop_caches) Suggested-by: Alexander Viro Signed-off-by: Fabian Frederick --- fs/affs/namei.c | 19 +++ 1 file changed, 19 insertions(+) diff --gi

  1   2   3   4   5   6   7   8   9   10   >