Re: [PATCH v3 2/5] w1_therm: adding sysfs entry to check device power

Hi 29.04.2020, 16:47, "Greg KH" : >>  +What: /sys/bus/w1/devices/.../w1_slave >>  +Date: Apr 2020 >>  +Contact: Akira Shimahara >>  +Description: >>  + (RW) return the temperature in 1/1000 degC. >>  + *read*: return 2 lines with the hexa output data sent on the >>  + bus, return the CRC check a

Re: [PATCH 2/2] w1: fix the resume command API

Hi everyone Mariusz, thank you for the patch, a small comment on it logic 19.03.2019, 16:21, "Jean-Francois Dagenais" : >>  --- >>  drivers/w1/w1_io.c | 11 +-- >>  1 file changed, 9 insertions(+), 2 deletions(-) >> >>  diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c >>  index 0364d3

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

Hi 09.05.2018, 16:11, "Jonathan Corbet" : > On Wed, 9 May 2018 09:32:18 -0300 > Mauro Carvalho Chehab wrote: > >>  > Looks good to me, thank you! >>  > What tree should this be forwarded to, or folks from linux doc will pick >> it up? >>  >

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

ank you! What tree should this be forwarded to, or folks from linux doc will pick it up? Acked-by: Evgeniy Polyakov > --- >  drivers/w1/w1_io.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c > index 075d120e7b88..0364d3329c5

Re: [PATCH v2] w1: mxc_w1: Enable clock before calling clk_get_rate() on it

i.MX27 / i.MX31") > Signed-off-by: Stefan Potyra Looks good to me, thank you! Greg, please pull it into your tree, this also sounds like stable material, is it? Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/mxc_w1.c | 20 +--- >  1 file changed, 13 inserti

Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

e pull this patch into your tree. Should it be stable material? Acked-by: Evgeniy Polyakov > --- >   drivers/w1/w1.c | 2 +- >   1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index ab0931e..aa458f2 100644 > --- a/drivers/

Re: [PATCH] Enable clock before calling clk_get_rate() on it.

r driver for i.MX27 / i.MX31 > Signed-off-by: Stefan Potyra Acked-by: Evgeniy Polyakov Greg, please pull it into your tree. Is this a stable material? > --- >  drivers/w1/masters/mxc_w1.c | 8 >  1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dr

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

ntly, so it looks safe. David, please pull it into your tree, or should it go via different path? Acked-by: Evgeniy Polyakov >>  I don't see how it breaks UAPI. The point is that structures >>  coredump_proc_event and exit_proc_event are members of *union* >>  event_da

Re: [PATCH] Fixed typo in onewire generic doc

Hi everyone I'm really sorry for that long delay. Was this patch accepted or should I push it upstream? 20.12.2017, 22:09, "Gergo Huszty" : > Onewire devices has 6 byte long unique serial numbers, 1 byte family > code and 1 byte CRC. Linux sysfs presents the device folder in the > form of family

Re: [PATCH] w1: w1-gpio: Convert to use GPIO descriptors

Hi Linus Sorry for late reply 20.11.2017, 11:47, "Linus Walleij" : > The w1 master driver includes a complete open drain emulation > reimplementation among other things. > > This converts the driver and all board files using it to use > GPIO descriptors associated with the device to look up the >

Re: [PATCH] w1: remove redundant assignments to search_bit and last_rn

rs tree if you haven't yet. > Signed-off-by: Colin Ian King Acked-by: Evgeniy Polyakov > --- >  drivers/w1/w1.c | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 0c2a5a8327bd..c29f6c5dda3c 100644 > --- a/drivers/w1/w1

Re: [PATCH v2] w1: driver for serial linkUSB, linkOEM, LINK devices

critical code > areas has therefore been changed from local spinlocks to a more toplevel > mutex-based system to enforce serialisation. I have not run into any problems > with unexpected feedback from the link device since. This looks good to me, thank you! Greg, please pull it into yo

Re: [PATCH] w1 driver for serial linkUSB, linkOEM, LINK devices

Hi 17.10.2017, 23:01, "Hans-Frieder Vogt" : > attached is a driver that supports the serial OneWire masters from > iButtonLink(TM) in the w1 kernel driver. In order to be usable it needs an > updated userland tool (patch included in documentation file). The patch is > against linux-next. Please

Re: [PATCH] w1: keep balance of mutex locks and refcnts

sleeping waiting for the bus master to complete operation, and during this period family driver has to be referenced. But we can easily grab the reference earlier and then try to lock the bus, so the second variant will work. > -- > Alexey > > On 01.10.2017 08:55, Evgeniy Polyakov wro

Re: [PATCH v5 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

to I2C master bridge. > > Signed-off-by: Jan Kandziora > Acked-by: Evgeniy Polyakov > --- > Changes in v5 against v4 in this subpatch: >   - adapted to linux-4.14-rc1 > > Changes in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 > > Changes in v3 against v

Re: [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs

Hi 26.09.2017, 20:59, "Mauro Carvalho Chehab" : > Describe nested struct/union fields > > NOTE: This is a pure test patch, meant to validate if the > parsing logic for nested structs is working properly. > > I've no idea if the random text I added there is correct! It looks correct, although I wo

Re: [PATCH] w1: keep balance of mutex locks and refcnts

Hi Alex 29.09.2017, 23:23, "Alexey Khoroshilov" : > w1_therm_eeprom() and w1_DS18B20_precision() decrement THERM_REFCNT > on error paths, while they did not increment it yet. > > read_therm() unlocks bus mutex on some error paths, > while it is not acquired. > > The patch makes sure all the functi

Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

Hi 28.08.2017, 12:25, "chen.l...@zte.com.cn" : > Hi > > Q: > > But w1_reg_num has a different layout for be/le systems, isn't it enough? > > A: > > sure, it's right only under the assumption that 'rn' is a  correct layout id. > > Here's my example in be system which I encounter before. > > buf[0]

Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error

space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Looks good to me, thank you kernel-janitors@ please queue this up Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/ds2490.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v4 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

previously since I missed it. Acked-by: Evgeniy Polyakov > --- > Changes in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 > > Changes in v3 against v2 in this subpatch: >   - fixed a bug in using the i2c_adapter_quirks structure > > Changes in v2 against v1 i

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

ned-off-by: Markus Elfring Looks good to me, thanks Markus. There is virtually zero useful information in this print if we are in the situation, when kernel can not allocate a few bytes to run connector queue. Acked-by: Evgeniy Polyakov kernel-janitors@ please queue this patch up > --

Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

Hi Chen 19.07.2017, 10:58, "Chen Lin" : > The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must > be the same with the byterorder defined in struct w1_reg_num. > > The rn read from 'rv = w1_read_block(dev, (u8 *)&rn, 8)' is a byte > serial and not cpu endian relative, it need to cha

Re: [PATCH linux v5 0/3] Export 1-wire thermal sensors as hwmon device

Hi 18.07.2017, 02:09, "Jaghathiswari Rankappagounder Natarajan" : > Hi Greg, > Please pull in this patchset into the tree. Thanks! Here is a patchset, is it visible in your mailbox? If so, please pull it into your tree. > Summary of what this patchset does: > > Our board has 4 DS18B20 1-wire tem

Re: [PATCH v4 1/2] wire: export w1_touch_bit

v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 Greg, please pull this patch series into the tree, it has been adopted to the latest vanilla tree to date. Acked-by: Evgeniy Polyakov

Re: [PATCH v4 0/5] w1: ds1wm: register access patch

Hi everyone 25.07.2017, 14:27, "Johannes Poehlmann" : > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > with a register offset multiplier of 4 I had to make some changes to > Version 4 of the patchset >    work on Greg Kroah-Hartmanns comments: > o added changelog to

Re: [PATCH v2 1/2] power: supply: move HDQ interface for bq27xxx from w1 to power/supply

Hi everyone Sorry for long delay 25.07.2017, 16:48, "Sebastian Reichel" : > Here is a signed immutable branch for Andrew's patch, which moves > bq27000 w1 driver to the power-supply subsystem. I guess git will > figure everything out without this, but better safe than sorry :) > > The following c

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

Hi 13.07.2017, 18:36, "Evgeniy Polyakov" : > I believe this is a resend of your previous patchet, isn't it? > Greg, if you hadn't yet, please pull it into the tree. Aaand it looks like we have a discussion now, so please postpone it for a while :)

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

Hi 13.07.2017, 00:41, "Jaghathiswari Rankappagounder Natarajan" : > Our board has 4 DS18B20 1-wire temperature sensors. Each 1-wire bus and the > sensor under it is already configured against the Linux 1-wire driver > (called w1). They have a sysfs file(e.g. > /sys/bus/w1/devices/w1_bus_master1/28

Re: [PATCH v4 1/2] wire: export w1_touch_bit

later for writing drivers for other Onewire chips > which do single-bit communication. > > Signed-off-by: Jan Kandziora Greg, please pull this patchset into the tree, I missed it last time and it stuck in the queues for a too long. Thank you. Acked-by: Evgeniy Polyakov > --- > F

Re: [PATCH v2 0/4] w1: ds1wm: register access patch

Hi everyone Greg, please pull this into your tree 23.06.2017, 13:47, "Johannes Poehlmann" : > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > with a register offset multiplier of 4 I had to make some changes to > >    drivers/w1/masters/ds1wm.c > and include/linu

Re: [PATCH linux v1 0/3] Export 1-wire thermal sensors as hwmon device

Looks good to me, thank you. Acked-by: Evgeniy Polyakov

Re: [PATCH] w1: w1-gpio: Fix double-free of platform_data

Hi Alexey 25.03.2017, 20:08, "Alexey Ignatov" : > struct w1_gpio_platform_data was allocated using devres when using > device tree. Then it was assigned to dev.platform_data, which leaded > to double free on device removal by devres and by direct > kfree(platform_data) in platform_device_release)

Re: [PATCH v2 21/23] MAINTAINERS: Add file patterns for w1 device tree bindings

nto. If it is ok, Greg, please pull it into your one, or I see devicetree@ mail in copy... Stumbled > Signed-off-by: Geert Uytterhoeven > Cc: Evgeniy Polyakov > Cc: Greg Kroah-Hartman > --- > Please apply this patch directly if you want to be involved in device > tree bindin

Re: [PATCH v2 0/4] w1: add DS2438 support, documentation and small fixes

Hi everyone 23.02.2017, 09:38, "Mariusz Bialonczyk" : > This is my second version of my w1 patchset. > It mainly adds support for the DS2438. There is also a documentation > for it and also a missing one for DS2413. Looks good to me, thank you Greg, please pull it into your tree

Re: [PATCH] i2c: w1: Add devicetree match for DS2482

Hi Colin 22.01.2017, 20:55, "Colin Godsey" : > Adds the OF devicetree match for the DS2482 I2C-1wire master and adds a > listing to the I2C trivial devicetree bindings doc. Based on a proposed patch > by Hector Palacios. Looks good to me. Acked-by: Evgeniy Polyakov

Re: [PATCH] w1: omap_hdq: Free resources on error path

d by '_omap_hdq_reset()' instead of returning -EINVAL > unconditionally. > > Signed-off-by: Christophe JAILLET Looks good to me. If kernel-janitors@ will not push it upstream feel free to send to to GregKH and add me to copy. Acked-by: Evgeniy Polyakov > --- >  drivers

Re: [PATCH] [RFC] proc connector: add namespace events

Hi everyone 08.09.2016, 18:39, "Alban Crequy" : > The act of a process creating or joining a namespace via clone(), > unshare() or setns() is a useful signal for monitoring applications. > + if (old_ns->mnt_ns != new_ns->mnt_ns) > + proc_ns_connector(tsk, CLONE_NEWNS, PROC_NM_REASON_CLONE, old_mn

Re: [PATCH v2] w1: fix typo in parameter description

Hi 11.08.2016, 03:03, "Wei Yongjun" : > Fix typo in parameter description. > > Signed-off-by: Wei Yongjun Looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov > --- > v1 -> v2: make it as one line, comments from Evgeniy Polya

Re: [PATCH] w1: fix timeout_us parameter description

Hi 10.08.2016, 06:22, "Wei Yongjun" : >>  08.08.2016, 16:52, "Wei Yongjun" : >>>  Fix 'timeout_us' parameter description. >>>   MODULE_PARM_DESC(timeout, "time in seconds between automatic slave >>> searches"); >>>   module_param_named(timeout_us, w1_timeout_us, int, 0); >>>  -MODULE_PARM_DESC(t

Re: [PATCH] w1: fix timeout_us parameter description

Hi 08.08.2016, 16:52, "Wei Yongjun" : > Fix 'timeout_us' parameter description. > > Signed-off-by: Wei Yongjun > --- >  drivers/w1/w1.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index bb34362..e213c67 100644 > --- a/drivers/w1

Re: [PATCH] w1: Remove unneeded header file

Hi 28.06.2016, 16:50, "Julia Lawall" : >>  24.06.2016, 09:18, "Amitoj Kaur Chawla" : >>  > The Coccinelle semantic patch used to make this change is as follows: >>  > @ includesmodule @ >>  > @@ >>  > >>  > #include >>  > >>  > @ depends on includesmodule @ >>  > @@ >>  > >>  > - #include >>  >

Re: [PATCH] w1: Remove unneeded header file

Hi 24.06.2016, 09:18, "Amitoj Kaur Chawla" : > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include > > @ depends on includesmodule @ > @@ > > - #include > > Signed-off-by: Amitoj Kaur Chawla Lo

Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery

Hi Aaron 24.06.2016, 16:07, "Aaron Campbell" : > The proc connector messages include a sequence number, allowing userspace > programs to detect lost messages. However, performing this detection is > currently more difficult than necessary, since netlink messages can be > delivered to the applicati

Re: [PATCH] w1: add ability to set (SRAM) and store (EEPROM) configuration for temp sensors like DS18B20

precision when running on a kernel based device (unlike the Dallas > 1Wire library for e.g. Arduino, which supports writing the > configuration/scratchpad). This looks good to me, Greg, please pull it into your tree > Signed-off-by: x29a <0.x29...@gmail.com> Acked-by: Evgeniy

Re: [patch] w1: silence an uninitialized variable warning

Hi Dan 14.04.2016, 12:36, "Dan Carpenter" : > If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Looks good to me, please pull it into janitors tree > Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polaykov > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 89a7847..bb34362 10

Re: [PATCH] w1: w1_process() is not freezable kthread

Hi 28.10.2015, 08:26, "Jiri Kosina" : > On Tue, 27 Oct 2015, Evgeniy Polyakov wrote: > >>  > w1_process() calls try_to_freeze(), but the thread doesn't mark itself >>  > freezable through set_freezable(), so the try_to_freeze() call is useless. >> &g

Re: [PATCH] w1: w1_process() is not freezable kthread

Hi 26.10.2015, 08:53, "Jiri Kosina" : > From: Jiri Kosina > > w1_process() calls try_to_freeze(), but the thread doesn't mark itself > freezable through set_freezable(), so the try_to_freeze() call is useless. I believe it is better to mark it freezable, what do you think? Its task is useless if

Re: [PATCH] w1: Use module_pci_driver

Hi everyone Patch looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov 07.07.2015, 09:55, "Vaishali Thakkar" : > Use module_pci_driver for drivers whose init and exit functions > only register and unregister, respectively. > Sign

Re: [PATCH] w1: Drop owner assignment from i2c_driver

Hi Krzysztof Patch looks good to me, thank you. Greg, please pull it into your tree. Acked-by: Evgeniy Polyakov 10.07.2015, 09:38, "Krzysztof Kozlowski" : > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-b

Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show()

therm') > Signed-off-by: Dan Carpenter Looks good to me, Greg please pull this serie into your tree, if you hadn't yet. Am I right that this is a stable tree material too? Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

Hi 25.05.2015, 08:15, "Vignesh R" : >>  HDQ mode remains unchanged. >> >>  Signed-off-by: Vignesh R I have no experience with omap_hdq platform, but there are quite a few questions related to IO - you never check whether write was successful or read returned actually valid data, is it ok? I mea

Re: [PATCH] w1: ds2482: Add i2c module alias name

Hi everyone 27.05.2015, 01:38, "Ludek Hlavacek" : > Add i2c alias to enable autoloading of the module for device specified > in device-tree. > > Signed-off-by: Ludek Hlavacek This looks good to me, Greg, please pull to your tree. Thank you. Acked-by: Evgeniy Polyakov

Re: [PATCH] w1: Fix typo in MODULE_DESCRIPTION in matrox_w1.c

Hi 21.05.2015, 16:41, "Masanari Iida" : > This patch fix spelling typo in matrox_w1.c > > Signed-off-by: Masanari Iida Looks good to me, please pull it into the tree Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/matrox_w1.c | 2 +- >  1 file changed

Re: [PATCH v3] w1: introduce an ability to specify microseconds bus scanning intervals

by: Dmitry Khromov Greg, please pull it upstream Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND] w1: masters: omap_hdq: Add support for 1-wire mode

sent for v4.1 but was never picked up. >>  Here is the link to the previous patch >>  http://www.spinics.net/lists/linux-omap/msg116228.html > > Hi Andrew, Evgeniy Polyakov, > > Gentle ping > This patch has been waiting since 4.1 merge window. I believe it should go via omap t

Re: [PATCH] w1_therm reference count family data

e when it is no longer detected. > If that happens the sl->family_data will be freed and set to NULL > causing w1_slave_show to crash when it wakes up. > > Signed-off-by: David Fries > Reported-By: Thorsten Bschorr > Tested-by: Thorsten Bschorr > Acked-by: Evgeniy Polyakov

Re: [PATCH]Add support for DS28EA00 sequence to w1-therm

Hi 28.04.2015, 14:44, "Matt Campbell" : > This patch provides support for the DS28EA00 digital thermometer. Patch looks good, Greg, please pull this patch into you tree -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] signals: Generate warning when flush_signals() is called from non-kthread context

Hi Ingo 01.05.2015, 22:38, "Ingo Molnar" : > * Linus Torvalds wrote: >>  On Fri, May 1, 2015 at 10:40 AM, Alex Williamson >>   wrote: >>>  - Flush signals on interrupted wait to retain polling interval (Alex >>> Williamson) >>  This cannot *possibly* be right. If I read this patch right, you're

Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

HI Marek 28.04.2015, 23:25, "Marek Belisko" : > bq2700 slave driver depends on bq27x00-battery driver thus adding this > dependency to config. When bq2700 is build as module bq27x00-battery > will be loaded automatically. > > Signed-off-by: Marek Belisko Patch looks good to me, but you should ad

Re: [PATCH]Add support for DS28AE00 sequence to w1-therm

Hi everyone 27.04.2015, 16:32, "Matt Campbell" : > This patch provides support for the DS28AE00 digital thermometer. Greg, please pull it into you tree, everything looks good to me -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: [PATCH v2] w1: introduce an ability to specify microseconds bus scanning intervals

Hi Looks good to me. Greg, please pull it into your tree. Acked-by: Evgeniy Polyakov 23.04.2015, 00:56, "Dmitry Khromov" : > Signed-off-by: Dmitry Khromov > --- >  drivers/w1/w1.c | 17 - >  1 file changed, 16 insertions(+), 1 deletion(-) > > di

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi 16.04.2015, 15:00, "Thorsten Bschorr" : >> Let's push this patch upstream as a temporal fix until we are ready with the >> new solution. >> Thorsten, does it fix your crash? > > I'm running David's refcounting-patch for about 3 weeks now on my 3.18.y > kernel, and did not observe any problems

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi David 16.04.2015, 06:52, "David Fries" : > It has not been solved.  Evgeniy would like to make use of the sysfs > device management instead of the current reference counting, however I > haven't heard any volunteers to do that work.  I posted a quick fix > patch, it was very easy to crash witho

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi 18.03.2015, 07:20, "David Fries" : >  static void w1_therm_remove_slave(struct w1_slave *sl) >  { > + int refcnt = atomic_sub_return(1, THERM_REFCNT(sl->family_data)); > + while(refcnt) { > + msleep(1000); > + refcnt = atomic_read(THERM_REFCNT(sl->family_data)); > + } >  kfree(sl->famil

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi David 12.03.2015, 03:54, "David Fries" : > Would that be removing all four refcnt, w1_slave, w1_master, > w1_family, w1_cb_block, or just some of them?  It sounds good to me, > if that had bugs there would be much more than just the w1 system > relying on it.  I don't know enough about that sys

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi 10.03.2015, 02:09, "David Fries" : > diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c > index 1f11a20..39a9e6a 100644 > --- a/drivers/w1/slaves/w1_therm.c > +++ b/drivers/w1/slaves/w1_therm.c > @@ -59,9 +59,20 @@ MODULE_ALIAS("w1-family-" __stringify(W1_THERM_DS28EA00))

Re: [PATCH netfilter-next] xt_osf: Use continue to reduce indentation

ank you. Which tree should this patch go through? Please pull it in. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [patch V2 35/64] connector: Use ktime_get_ns()

Hi 17.07.2014, 01:04, "Thomas Gleixner" : > Replace the ever recurring: > ts = ktime_get_ts(); > ns = timespec_to_ns(&ts); > with > ns = ktime_get_ns(); > > Signed-off-by: Thomas Gleixner > Cc: Evgeniy Polyakov Looks good to me,

Re: [PATCH 0/3] "printk" related fixes for the 1-wire (w1) subsystem

_*" > function but also minor issues such as indentation and whitespace problems > in the immediate vicinity were addressed. Looks good to me Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: revised driver: w1_ds2406

y submitted. > > Signed-off-by: Scott Alfter Greg, this patch looks good, please pull it into your tree. If you already applied previous ds2406, let us know. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: new driver: w1_ds2406

Hi everyone Greg, please pull this patch into the tree 06.06.2014, 21:47, "Scott Alfter" : > On Thu, June 5, 2014 10:44, Evgeniy Polyakov wrote: >>  04.06.2014, 08:25, "Scott Alfter" : >>>  I have a project for which I needed support for the DS2406 address

Re: [PATCH] drivers/w1/w1_int.c: Fix style errors.

appropriate. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC] w1: fixes and bundling replies

Hi David 07.04.2014, 18:13, "David Fries" : > Evgeniy, > Could you review this set of patches in this thread?  Thanks. I've checked it and it looks good, please resend it to lkml and Greg Kroah-Hartman, he will pull it into the tree. Feel free to add my Acked-by. -- To unsubscribe from this list

Re: [PATCH 1/4] w1: Remove excess dependencies on W1 for masters and slaves

Hi everyone 22.02.2014, 11:30, "Alexander Shiyan" : > Configuration for masters and slaves is included only if W1 symbol > enabled, so no reason to check it once more. > > Signed-off-by: Alexander Shiyan > --- >  drivers/w1/masters/Kconfig | 3 +-- >  drivers/w1/slaves/Kconfig  | 5 - >  2 file

Re: [PATCH] w1: bundle reply if the request was bundled

Hi 19.02.2014, 11:19, "David Fries" : > A program can bundle multiple messages and commands together when > making one wire requests, which is going to be much more efficient > than sending lots of little packets one write at a time.  With this > change the kernel will then bundle responses to req

Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better

t > controller). In this case you still want to retry probing later instead > of ignoring the problem. > > Does that make it clearer? Well, yes, thank you :) Greg, please pull this patch into your tree. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "

Re: [patch v2] w1: small type cleanup in sysfs

his is more of a problem for static checkers than a real life issue, > but it's simple enough to fix. > > Acked-by: David Fries > Signed-off-by: Dan Carpenter Looks good to me, thank you Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 16/16] hold bus_mutex in netlink and search

arch.  This was causing the ds2490 hardware to stop > responding when both netlink and /sys slaves were executing bus > commands at the same time. > > Signed-off-by: David Fries Looks good to me, thank you. Greg, please pull the whole set if you hadn't yet Acked-by: Evgeniy Polyakov

Re: [PATCH 00/14] w1: async netlink, search, fixes, and improvements

Hi 29.12.2013, 10:46, "David Fries" : > This patch series aims to extend and improve the netlink interface to > the one wire system.  Netlink is exposed as a socket interface which I've reviewed all your patches and everything looks good. Thank you David Acked-by: Ev

Re: [PATCH 4/4] w1: call put_device if device_register fails

Hi 19.12.2013, 03:47, "Greg KH" : > I don't seem to have this patch anywhere, can someone please resend it > to me? Andrew Morton picked it up http://www.spinics.net/lists/mm-commits/msg101101.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [PATCH 4/4] w1: call put_device if device_register fails

device right after it fails. Looks good to me, thank you Greg, please pull it into your treee > Signed-off-by: Levente Kurusa Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

Hi 29.11.2013, 15:40, "Alexander Shiyan" : > Private field "clkdiv" is not used outside "probe", so there are > no reason to keep it in driver. The whole serie looks good, thank you Greg, please pull it into your tree > Signed-off-by: Alexander Shi

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

Hi 13.11.2013, 08:07, "David Fries" : >>>>   Strong pullup is emulated by driving pin logic high after write >>>>   command when >>>>   using tri-state push-pull GPIO. > > Acked-by: David Fries > > Looks good to me. Ok, thank you Acke

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

Hi 12.11.2013, 03:32, "Evgeny Boger" : >> Why did you drop this check? It has nothing with w1-gpio driver > This check prevents master from implementing "set_pullup"  provided it does > support only "write_bit" method. > The comment above states that >>  w1_io.c would need to support calling set_

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

Hi 11.11.2013, 18:37, "Evgeny Boger" : >  Strong pullup is emulated by driving pin logic high after write command when >  using tri-state push-pull GPIO. > > Signed-off-by: Evgeny Boger > --- >  drivers/w1/masters/w1-gpio.c | 22 ++ >  drivers/w1/w1_int.c  | 12

Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

Hi everyone 31.10.2013, 13:12, "Michal Nazarewicz" : >>>   int ttl; >>  ... w1_slave.ttl? For noisy lines this was a 'timeout' after which system considered attached device as failed, the noisier line is the longer is timeout I experimented with meters-long w1 wires and it required seve

Re: [PATCH] w1: ds1wm: remove deprecated IRQF_DISABLED

them into your tree Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/2] w1 fixes for broken subsystem

s for most of devices, I would introduce them everywhere... But anyway, your patches fix those problems, thanks a lot. Greg, please queue them into appropriate trees. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 1/2] w1: w1-gpio: use dev_get_platdata()

Signed-off-by: Jingoo Han Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] w1: use default attribute groups for w1 slave devices

hi Greg 22.08.2013, 00:24, "Greg Kroah-Hartman" : > As we have 2 sysfs files for the w1 slave devices, let the driver core > create / destroy them automatically by setting the default attribute > group for them, saving code and housekeeping logic. > > Cc: Evgeniy Polyak

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

ropriate. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] w1-gpio: Let device core handle pinctrl

v); > - if (IS_ERR(pinctrl)) > - dev_warn(&pdev->dev, "unable to select pin group\n"); > - > if (of_have_populated_dt()) { > err = w1_gpio_probe_dt(pdev); > if (err < 0) { > -- > 1.8.1.2 >

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

ere? That's transform is only used to cast structure to uint64_t, nothing fancy. In-memory structure should be ok because of above definition on every endian. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH] w1: ds2482: add device tree probe support

Hi On Mon, Mar 25, 2013 at 05:21:34PM +0100, Hector Palacios (hector.palac...@digi.com) wrote: > It adds device tree probe support for ds2482 driver. > > Signed-off-by: Hector Palacios Looks good, thank you Acked-by: Evgeniy Polyakov Greg, please pull it into your tree,

Re: [PATCH] 1-wire: in-kernel notification on device events

informed > of subsequent device insertions and removals. > > The framework is copied from USB subsystem. > > Signed-off-by: Sergey Yanovich Thanks Sergey, patch looks good to me Acked-by: Evgeniy Polyakov Greg, please pull it into your tree. Thank you -- Evgeniy Po

Re: [PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

On Tue, Mar 12, 2013 at 02:28:11PM -0400, Jean-François Dagenais (jeff.dagen...@gmail.com) wrote: > Thoughts? > /jfd Well, sounds reasonable. Please submit patches to Greg Kroah-Hartman , he will push them upstream. Acked-by: Evgeniy Polyakov -- Evgeniy Polyakov -- To unsub

Re: [PATCH 1/2] w1: mxc_w1: Convert to devm_ioremap_resource()

m Both patches look good to me, thank you Greg, please pull it into you tree Acked-by: Evgeniy Polyakov -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH 1/2] w1-gpio: remove erroneous __exit and __exit_p()

n markers for probe and remove > (to __devinit/exit, which have since been removed). A later commit fixed > the section mismatch for probe, but left remove marked with __exit. > > Signed-off-by: Johan Hovold Both patches look good to me, thank you Greg, please pull it into yo

Re: [PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

ameter? -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/1] w1: fix oops when w1_search is called from netlink connector

Hi Marcin, thanks a lot for the fix, I have to sorry I'm not on this bug yet :( Sven confirmed patch fixes it, Greg please pull it into your tree. I believe this is stable material. Thanks everyone. Acked-by: Evgeniy Polyakov On Sat, Mar 02, 2013 at 02:50:15PM +0100, Marcin Jurkowski (

  1   2   3   4   5   6   7   8   9   >