Re: [PATCH] net: wirelesse: wcn36xx: pull allocation outside of critical section

2013-12-08 Thread Eugene Krasnikov
t; drivers/net/wireless/ath/wcn36xx/smd.c | 28 +++- > 1 file changed, 15 insertions(+), 13 deletions(-) > > On Thu, Dec 05 2013, Eugene Krasnikov wrote: >> I think code will look neater if error case will be handled in "else" >> statement som

Re: [PATCHv2] net: wireless: wcn36xx: fix potential NULL pointer dereference

2013-12-05 Thread Eugene Krasnikov
> + if (msg_ind) > + break; > + /* FIXME: Do something smarter then just printing an error. */ > + wcn36xx_err("Run out of memory while handling SMD_EVENT > (%d)\n", I think code will look neater if error case will be handled in "els

Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-06 Thread Eugene Krasnikov
less work to do = less bugs:) Suggestion is to send a patch with semicolon fix only and have a second round of convincing ath guys to change printing code. How does that sound? On Wed, Nov 6, 2013 at 5:55 PM, Joe Perches wrote: > On Wed, 2013-11-06 at 07:49 +, Eugene Krasnikov wrote: >&

Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-05 Thread Eugene Krasnikov
Hm... when it comes to semicolon the patch seems to be good. When it comes to dynamic debugging i think we should have a separate discussion about that. I personally like the whole idea about dynamic debug but if you want to change it i would suggest to have some kind of framework for all ath drive

Re: Version number policy!

2013-04-08 Thread Eugene Krasnikov
with initial. How did carl9170 track such a situation in feature bitmap? 2013/4/8 Adrian Chadd : > On 8 April 2013 08:33, Christian Lamparter wrote: >> On Monday, April 08, 2013 11:10:30 AM Eugene Krasnikov wrote: >>> It’s a good idea to pack bitmap into the tail/header of the f

Re: Version number policy!

2013-04-08 Thread Eugene Krasnikov
/4/6 Adrian Chadd : > On 5 April 2013 22:52, Kalle Valo wrote: >> Eugene Krasnikov writes: >> >>> Good point regarding timestamp. >>> >>> When it comes to feature bitmap do you have an example of such a >>> bitmap from carl9170? Why not to rel

Re: Version number policy!

2013-04-05 Thread Eugene Krasnikov
Good point regarding timestamp. When it comes to feature bitmap do you have an example of such a bitmap from carl9170? Why not to rely always on major version? 2013/4/5 Christian Lamparter : > On Friday 05 April 2013 10:19:00 Luis R. Rodriguez wrote: >> On Thu, Apr 4, 2013 at 11:27 AM, Adrian Cha

Re: Version number policy!

2013-04-05 Thread Eugene Krasnikov
Hi Adrian, This is the patch with new wmi command to support build number. Please let me know if it's ok so i can send it as pull request: >From 2591efa83bd24a807e3d93c4c8e1bf5c570737e1 Mon Sep 17 00:00:00 2001 From: Eugene Krasnikov Date: Fri, 5 Apr 2013 18:37:26 +0200 Subject: [PA