On Wed, 2014-10-29 at 19:12 -0500, Eric Rost wrote:
> Removes skein_debug.h include since skein_debug.h is nonexistent.
> Removes unneeded debug empty macro defines and their uses.
>
> Signed-off-by: Eric Rost
> ---
Jason,
I wanted you to take one last look at this before I put
Removes skein_debug.h include since skein_debug.h is nonexistent.
Removes unneeded debug empty macro defines and their uses.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.c | 18 -
drivers/staging/skein/skein_base.h | 17 -
drivers/staging/skein
Removes skein_debug.h include since skein_debug.h is nonexistent.
Removes unneeded debug empty macro defines and their uses.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.c | 18 --
drivers/staging/skein/skein_base.h | 17 -
drivers/staging
Removes skein_debug.h include since skein_debug.h is nonexistent.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 0111fa4
Removes unneeded #define SKEIN_PORT_CODE since skein_port.h is
nonexistent.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/skein/skein_base.c
b/drivers/staging/skein/skein_base.c
index e0994ea..ebc436a 100644
Adds loadable module support to the Skein Hashing Algorithm driver.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 2 +-
drivers/staging/skein/Makefile| 13 +++--
drivers/staging/skein/skein_generic.c | 19 ++-
3 files changed, 26
Inlines the rotl_64 macro.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 9f10af9..0111fa4 100644
--- a
Adds CryptoAPI support to the Skein Hashing Algorithm driver.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Makefile| 3 +-
drivers/staging/skein/skein_base.h| 5 +
drivers/staging/skein/skein_generic.c | 199 ++
3 files changed, 206
Renames skein.c to skein_base.c and skein.h to skein_base.h in
preparation for naming loadable module skein.ko
Signed-off-by: Eric Rost
---
drivers/staging/skein/Makefile | 2 +-
drivers/staging/skein/skein_api.h | 2 +-
drivers/staging/skein/{skein.c
Adds CryptoAPI and loadable module support to the Skein Hashing
Algorithm. Collapses threefish module into skein module. Renames skein.c
and skein.h to skein_base.c and skein_base.h so module can be named
skein.ko. Inlines rotl_64 macro. Removes unneeded #define and
skein_debug.h include.
Eric
Collapses threefish module into skein module.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 22 +++---
drivers/staging/skein/Makefile | 11 +--
2 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/skein/Kconfig b/drivers/staging
Removes skein_debug.h include since skein_debug.h is nonexistent.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 0111fa4
Removes unneeded #define SKEIN_PORT_CODE since skein_port.h is
nonexistent.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/skein/skein_base.c
b/drivers/staging/skein/skein_base.c
index e0994ea..ebc436a 100644
Inlines the rotl_64 macro.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 9f10af9..0111fa4 100644
--- a
Adds CryptoAPI support to the Skein Hashing Algorithm driver.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Makefile| 3 +-
drivers/staging/skein/skein_generic.c | 191 ++
2 files changed, 193 insertions(+), 1 deletion(-)
create mode 100644
Adds loadable module support to the Skein Hashing Algorithm driver.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 2 +-
drivers/staging/skein/Makefile| 13 +++--
drivers/staging/skein/skein_generic.c | 19 ++-
3 files changed, 26
Collapses threefish module into skein module.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 22 +++---
drivers/staging/skein/Makefile | 11 +--
2 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/skein/Kconfig b/drivers/staging
Renames skein.c to skein_base.c and skein.h to skein_base.h
Signed-off-by: Eric Rost
---
drivers/staging/skein/Makefile| 2 +-
drivers/staging/skein/skein.c | 883 -
drivers/staging/skein/skein.h | 346 -
drivers/staging
Adds CryptoAPI and Module support to Skein Hash Algorithm. Also inlines
rotl_64 macro, and removes nonexistent header references.
Eric Rost (7):
staging: skein: Collapses threefish module
staging: skein: Renames skein to skein_base
staging: skein: Adds CryptoAPI Support
staging: skein
On Fri, 2014-10-24 at 06:16 -0500, Eric Rost wrote:
> Adds CryptoAPI and Module support to Skein Hash Algorithm. Also inlines
> rotl_64 macro, and removes nonexistent header references.
This should be [PATCH v5], sorry.
--
To unsubscribe from this list: send the line "unsubscribe l
Removes skein_debug.h include since skein_debug.h is nonexistent.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 0111fa4
Removes unneeded #define SKEIN_PORT_CODE since skein_port.h is
nonexistent.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/skein/skein_base.c
b/drivers/staging/skein/skein_base.c
index e0994ea..ebc436a 100644
Inlines the rotl_64 macro.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 9f10af9..0111fa4 100644
--- a
Adds loadable module support to the Skein Hashing Algorithm driver.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 2 +-
drivers/staging/skein/Makefile| 13 +++--
drivers/staging/skein/skein_generic.c | 19 ++-
3 files changed, 26
Adds CryptoAPI support to the Skein Hashing Algorithm driver.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Makefile| 3 +-
drivers/staging/skein/skein_generic.c | 191 ++
2 files changed, 193 insertions(+), 1 deletion(-)
create mode 100644
Renames skein.c to skein_base.c and skein.h to skein_base.h
Signed-off-by: Eric Rost
---
drivers/staging/skein/Makefile| 2 +-
drivers/staging/skein/skein.c | 883 -
drivers/staging/skein/skein.h | 346 -
drivers/staging
Collapses threefish module into skein module.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 22 +++---
drivers/staging/skein/Makefile | 11 +--
2 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/skein/Kconfig b/drivers/staging
Adds CryptoAPI and Module support to Skein Hash Algorithm. Also inlines
rotl_64 macro, and removes nonexistent header references.
Eric Rost (7):
staging: skein: Collapses threefish module
staging: skein: Renames skein to skein_base
staging: skein: Adds CryptoAPI Support
staging: skein
Inlines the macro definition rotl_64 to avoid bugs.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_base.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/skein/skein_base.h
b/drivers/staging/skein/skein_base.h
index 9f10af9..769bcb4 100644
Adds loadable module support for the Skein Hashing Algorithm.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 2 +-
drivers/staging/skein/skein_generic.c | 19 ++-
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/skein/Kconfig
Adds CryptoAPI support for skein256, skein512, and skein1024
algorithms. Also collapses threefish algorithm into skein.o and removes
Kconfig option for Threefish.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 22 +-
drivers/staging/skein/Makefile| 13 +-
drivers
Adds CryptoAPI and Loadable Module support to the Skein Hash Algorithm.
Also inlines the rotl_64 macro.
Eric Rost (3):
staging: skein: Adds CryptoAPI Support
staging: skein: Adds Loadable Module Support
staging: skein: Inlines rotl_64
drivers/staging/skein/Kconfig | 24
Adds loadable module support for the Skein Hashing Algorithm.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 2 +-
drivers/staging/skein/skein_generic.c | 19 ++-
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/skein/Kconfig
Adds CryptoAPI support for skein256, skein512, and skein1024
algorithms. Also collapses threefish algorithm into skein.o and removes
Kconfig option for Threefish.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 22 +-
drivers/staging/skein/Makefile| 13 +-
drivers
Adds CryptoAPI and Loadable Module support to the Skein Hashing
Algorithm.
Eric Rost (2):
staging: skein: Adds CryptoAPI Support
staging: skein: Adds Loadable Module Support
drivers/staging/skein/Kconfig | 24 +-
drivers/staging/skein/Makefile| 13 +-
drivers/staging/skein
Adds loadable module support for skein_mod, containing skein256,
skein512, and skein1024 algorithms.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 2 +-
drivers/staging/skein/skein_generic.c | 122 ++
2 files changed, 123 insertions(+), 1
Adds crypto API support for the skein module. Also collapses the
threefish module into the skein module.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 22 +--
drivers/staging/skein/Makefile| 13 ++--
drivers/staging/skein/skein.c | 1 +
drivers
This patchset adds crypto api support and loadable module support to the
skein driver.
Eric Rost (2):
staging: skein: Add Crypto API support
staging: skein: Add Loadable Module Support
drivers/staging/skein/Kconfig | 24 +---
drivers/staging/skein/Makefile| 13 +-
drivers
On Wed, 2014-10-22 at 11:10 -0400, Jason Cooper wrote:
>
> If you don't mind, could you split this
> patch in two? The first integrating into the crypto API (such that
> userspace could call into it), and the second enabling loadable module
> support?
>
Will do!
>
Adds loadable module support for Skein256, Skein512, and Skein1024 Hash
Algorithms.
Signed-off-by: Eric Rost
---
drivers/staging/skein/Kconfig | 12 +
drivers/staging/skein/Makefile| 6 +++
drivers/staging/skein/skein.c | 11 +++-
drivers/staging/skein
ric.c
b/drivers/staging/skein/skein1024_generic.c
new file mode 100644
index 000..4152e61
--- /dev/null
+++ b/drivers/staging/skein/skein1024_generic.c
@@ -0,0 +1,88 @@
+/*
+ * Cryptographic API.
+ *
+ * Skein1024 Hash Algorithm.
+ *
+ * Derived from cryptoapi implementation, adapted for in-place
Reorganizes file to remove #defines from middle of functions. Also
removes #if'd loop declarations and adds ternary if driven loops.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 680 ++-
1 file changed, 351 insertions(+), 329 dele
Pretties up multiline #defines and many other whitespace issues
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 585 +++
1 file changed, 315 insertions(+), 270 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging
16)
+ for (r = 1; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
[...]
+ {
It also removes macro definitions from inside functions and cleans up
whitespace issues.
Eric Rost (2):
staging: skein: Whitespace cleanup
staging: skein: File Reorg
drivers/staging
On Tue, 2014-09-30 at 09:21 -0700, Greg KH wrote:
> On Tue, Sep 30, 2014 at 02:00:05AM -0500, Eric Rost wrote:
> > In progress commit
> > Signed-off-by: Eric Rost
> > ---
>
> What does this mean?
>
> And you need a blank line before your signed-off-by: line.
>
Reorganizes file to remove #defines from middle of functions. Also
removes #if'd loop declarations and adds ternary if driven loops.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 568 ++-
1 file changed, 291 insertions(+), 277 dele
In progress commit
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 132 +++
1 file changed, 70 insertions(+), 62 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging/skein/skein_block.c
index 71c14f5..b8e4bd8 100644
Pretties up multiline #defines and many other whitespace issues
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 585 +++
1 file changed, 315 insertions(+), 270 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging
; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
[...]
+ {
Eric Rost (3):
staging: skein: Whitespace cleanup
drivers: staging: skein: In progress
drivers: staging: skein: File Reorg
drivers/staging/skein/skein_block.c | 933 +++
1 file change
Reorganizes file to remove #defines from middle of functions. Also
removes #if'd loop declarations and adds ternary if driven loops.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 568 ++-
1 file changed, 291 insertions(+), 277 dele
In progress commit
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 132 +++
1 file changed, 70 insertions(+), 62 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging/skein/skein_block.c
index 71c14f5..b8e4bd8 100644
Fixes leading and trailing whitespace issues.
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging/skein/skein_block.c
index
Pretties up multiline #defines and many other whitespace issues
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c | 585 +++
1 file changed, 315 insertions(+), 270 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging
This patchset reorganizes skein_block.c to move macro definitions out of
functions, fixes whitspace issues, and removes the need for the #if'd
for loops.
Eric Rost (4):
drivers: staging: skein: Whitespace cleanup
drivers: staging: skein: Additional Whitespace Issues
drivers: staging:
> >I'll be looking to see that no object
> code has changed (./scripts/objdiff) across your patch series.
Hmm... I'm thinking of digging into it, but I'm not sure the #if's can
be gotten rid of sans object code changes, since its picking codeblocks
in the precompiler stage, right?
--
To unsubscri
Greg KH wrote:
> > > On Sun, Sep 28, 2014 at 04:54:26PM -0500, Eric Rost wrote:
> > > > My first patch, resent to appropriate multiple addresses!
> > >
> > > That's great, but it doesn't belong here in the body of the changelog :)
>
16)
+ for (r = 1; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
[...]
+ {
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c
b/drivers/staging/skein/skein_b
ode indent for conditional statements (16, 16)
+ for (r = 1; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
[...]
+ {
Signed-off-by: Eric Rost
---
drivers/staging/skein/skein_block.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s
58 matches
Mail list logo
