[trivial PATCH] Documentation/sparse: fix typo

2018-03-13 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/dev-tools/sparse.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/sparse.rst b/Documentation/dev-tools/sparse.rst index 78aa00a604a009071361..c401c952a340a50fa769 100644 --- a/Documentation/dev-tools

Re: [PATCH] video: fbdev: via: remove VLA usage

2018-03-09 Thread Eric Engestrom
Sorry for my reply on v1, I missed that Emil already replied to another post of the same patch (side note on that, making use of `-vX` and `--in-reply-to` helps track the evolution of patches) This looks good to me: Reviewed-by: Eric Engestrom > --- > drivers/video/fbdev/via/via_aux_sii164.c

Re: [PATCH] video: fbdev: via_aux_vt1636: remove VLA usage

2018-03-09 Thread Eric Engestrom
On Wednesday, 2018-03-07 13:47:03 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with a fixed-length array instead. Also, remove variable 'len'. > > Notice that no new IDs have been added in seven years. > > Signed-off-by: Gustavo A. R. Silva >

Re: [PATCH] locking/ww_mutex: add ww_mutex_is_owned_by function v4

2018-02-20 Thread Eric Engestrom
On Tuesday, 2018-02-20 15:49:46 +0100, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex internal

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

2017-09-08 Thread Eric Engestrom
tic struct drm_connector > *vc4_hdmi_connector_init(struct drm_device *dev, > { > struct drm_connector *connector = NULL; This `= NULL` isn't needed anymore either. Reviewed-by: Eric Engestrom > struct vc4_hdmi_connector *hdmi_connector; > -

Re: [PATCH] fbdev: make get_fb_unmapped_area depends of !MMU

2017-07-10 Thread Eric Engestrom
On Monday, 2017-07-10 16:48:55 +0200, Benjamin Gaignard wrote: > Even if CONFIG_FB_PROVIDE_GET_FB_UNMAPPED_AREA flag is selected > do not compile and use get_fb_unmapped_area() if CONFIG_MMU is > also set. This will avoid mmap errors when compiling multi > architectures at same time. > > Signed-of

Re: [PATCH] drm/pl111: Add a debugfs node to dump our registers.

2017-05-18 Thread Eric Engestrom
On Wednesday, 2017-05-17 17:56:40 -0700, Eric Anholt wrote: > While debugging an X11 display failure, I wanted to see where we were > actually scanning out from. This is probably generally useful to > others that might be working on this device. > > Signed-off-by: Eric Anholt > --- > drivers/gp

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

2017-04-26 Thread Eric Engestrom
On Wednesday, 2017-04-26 07:53:10 +0200, Gerd Hoffmann wrote: > On Di, 2017-04-25 at 12:18 +0900, Michel Dänzer wrote: > > On 24/04/17 03:25 PM, Gerd Hoffmann wrote: > > > Return correct fourcc codes on bigendian. Drivers must be adapted to > > > this change. > > > > > > Signed-off-by: Gerd Hoffm

Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

2017-03-03 Thread Eric Engestrom
On Friday, 2017-03-03 14:04:26 +0300, Dan Carpenter wrote: > On Thu, Mar 02, 2017 at 01:44:36PM -0800, Laura Abbott wrote: > > static struct sg_table *ion_map_dma_buf(struct dma_buf_attachment > > *attachment, > > enum dma_data_direction direction) > > { > >

Re: [PATCH] drm: drm_printer: add __printf validation

2017-02-20 Thread Eric Engestrom
On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: > drm_printf does not currently use the compiler to verify > format and arguments. Make it do so. > > Miscellanea: > > o Add appropriate #include files for __printf and struct va_format > o Convert dev_printk to dev_info I think these

Re: [PATCH v4] drm: add fourcc codes for 16bit R and RG

2017-01-04 Thread Eric Engestrom
On Wednesday, 2017-01-04 14:50:02 +0100, Rainer Hochecker wrote: > From: Rainer Hochecker > > Signed-off-by: Rainer Hochecker > --- > include/uapi/drm/drm_fourcc.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > in

Re: [Intel-gfx] [PATCH v2] drm: add fourcc codes for 16bit R and GR

2017-01-04 Thread Eric Engestrom
On Wednesday, 2017-01-04 11:06:09 +0200, Jani Nikula wrote: > On Wed, 04 Jan 2017, Daniel Vetter wrote: > > On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote: > >> From: Rainer Hochecker > >> > >> Now sent with git send-email: > >> > >> Signed-off-by: Rainer Hochecker > >> --- >

Re: [PATCH] drm: add fourcc codes for 16bit R and GR

2017-01-03 Thread Eric Engestrom
On Tuesday, 2017-01-03 17:56:10 +0100, Rainer Hochecker wrote: > On Mon, Jan 2, 2017 at 3:31 PM, Rainer Hochecker wrote: > > > > I chose GR16 because that matches with Mesa texture formats. Unfortunately > > RG16 is already taken by DRM_FORMAT_RGB565 > > So GR32 / RG32 might be better. All other c

[PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

2016-12-04 Thread Eric Engestrom
90d27a1 moved the lock before this error path but forgot to add an unlock here. Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") Cc: Pei Zhang Cc: Zhenyu Wang Signed-off-by: Eric Engestrom --- drivers/gpu/drm/i915/gvt/scheduler.c | 1 + 1 file changed, 1

[PATCH v4] drm: move allocation out of drm_get_format_name()

2016-11-11 Thread Eric Engestrom
le Syrjälä Signed-off-by: Eric Engestrom --- v4 - rebase on drm-next (d8c1abd968f1c880ad8c) - add missed `const` to the return value v3 - fix "Fixes" tag, replace it with an actual commit message - collect ack & r-b v2 - use single-field struct instead of typedef to let the co

Re: [PATCH] drm/atomic: fix memory leak when fetching format name

2016-11-11 Thread Eric Engestrom
On Friday, 2016-11-11 16:26:22 +, Colin King wrote: > From: Colin Ian King > > drm_get_format_name allocates memory that is not currently free'd > when printing the state. Fix this by kfree'ing the memory after > use. You are correct, but there are more cases of this, and another fix has bee

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-09 Thread Eric Engestrom
On Wednesday, 2016-11-09 14:13:40 +0100, Daniel Vetter wrote: > On Wed, Nov 9, 2016 at 12:42 PM, Eric Engestrom > wrote: > >> Well, had to drop it again since it didn't compile: > >> > >> > >> CC [M] drivers/gpu/drm/drm_blend.o

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-09 Thread Eric Engestrom
On Wednesday, 2016-11-09 02:13:25 +0100, Daniel Vetter wrote: > On Wed, Nov 09, 2016 at 02:09:16AM +0100, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 12:17:52AM +0000, Eric Engestrom wrote: > > > The function's behaviour was changed in 90844f00049e, without chang

[PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-08 Thread Eric Engestrom
le Syrjälä Signed-off-by: Eric Engestrom --- v3 - fix "Fixes" tag, replace it with an actual commit message - collect ack & r-b v2 - use single-field struct instead of typedef to let the compiler enforce the type (Christian König) --- include/drm/drm_fourcc.h

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

2016-11-07 Thread Eric Engestrom
On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote: > On Mon, 07 Nov 2016, Eric Engestrom wrote: > > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 > > > > drm: make drm_get_format_name thread-safe > > > > Signed-off-by: Eric Engestrom > >

Re: [PATCH] drm: move allocation out of drm_get_format_name()

2016-11-06 Thread Eric Engestrom
On Sunday, 2016-11-06 08:03:47 -0500, Rob Clark wrote: > On Sun, Nov 6, 2016 at 4:47 AM, Christian König > wrote: > > Am 05.11.2016 um 17:49 schrieb Rob Clark: > >> > >> On Sat, Nov 5, 2016 at 12:38 PM, Eric Engestrom wrote: > >>> > >>> O

[PATCH v2] drm: move allocation out of drm_get_format_name()

2016-11-06 Thread Eric Engestrom
Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: Christian König Suggested-by

Re: [PATCH] drm: move allocation out of drm_get_format_name()

2016-11-05 Thread Eric Engestrom
On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: > Am 05.11.2016 um 02:33 schrieb Eric Engestrom: > > +typedef char drm_format_name_buf[32]; > > Please don't use a typedef for this, just define the maximum size of > characters the function might write somewhe

[PATCH] drm: move allocation out of drm_get_format_name()

2016-11-04 Thread Eric Engestrom
Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter Suggested-by: Ville Syrjälä Signed-off-by: Eric

[PATCH variant 1] drm: make drm_get_format_name atomic/irq safe again

2016-11-04 Thread Eric Engestrom
Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter Note (Rob Clark): I think we need to be a bit

Re: [PATCH] i915: don't call drm_atomic_state_put on invalid pointer

2016-10-18 Thread Eric Engestrom
> Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state") > Cc: Chris Wilson > Cc: Daniel Vetter > Signed-off-by: Arnd Bergmann Reviewed-by: Eric Engestrom > --- > drivers/gpu/drm/i915/intel_display.c | 5 +++-- > 1 file changed, 3 inse

Re: [patch] drm/i915: fix a read size argument

2016-10-13 Thread Eric Engestrom
fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only > once on eDP") > Signed-off-by: Dan Carpenter Good catch! What tool did you use to find it, or did you find it by inspection? Reviewed-by: Eric Engestrom (btw, there's a missing `---` here, between the

[PATCH v2] debugfs: propagate release() call result

2016-09-21 Thread Eric Engestrom
The result was being ignored and 0 was always returned. Return the actual result instead. Signed-off-by: Eric Engestrom --- v2: add a commit message --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f

Re: [PATCH] debugfs: remove unused variable

2016-09-21 Thread Eric Engestrom
On Wed, Sep 21, 2016 at 10:50:38AM +0200, Nicolai Stange wrote: > Greg Kroah-Hartman writes: > > > On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote: > >> Signed-off-by: Eric Engestrom > >> --- > >> fs/debugfs/file.c | 3 +-- > >&

Re: [PATCH] debugfs: remove unused variable

2016-09-21 Thread Eric Engestrom
On Wed, Sep 21, 2016 at 10:01:11AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > fs/debugfs/file.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) >

[PATCH] debugfs: propagate release() call result

2016-09-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f..40e586f 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -209,7 +209,7 @@ static int full_proxy_release(struct

[PATCH] rcu: add missing prototype

2016-09-20 Thread Eric Engestrom
`make W=1` warns: kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes] unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp) ^~~ Signed-off-by: Eric Engestrom --- I couldn't figure out how this li

[PATCH] debugfs: remove unused variable

2016-09-20 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- fs/debugfs/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f..04eca0b 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -195,7 +195,6 @@ static int full_proxy_release(struct

[PATCH 2/2] ext4: remove unused variable

2016-09-20 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- fs/ext4/page-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index a6132a7..b4cbee9 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -405,14 +405,12 @@ int ext4_bio_write_page(struct

[PATCH 1/2] ext4: remove unused variable

2016-09-20 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 67415e0..acd76f1 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -627,7 +627,7 @@ int ext4_check_all_de(struct inode *dir, struct

Re: [PATCH v2] skd: fix assert typo

2016-09-16 Thread Eric Engestrom
On Fri, Sep 16, 2016 at 08:40:54AM -0400, Jeff Moyer wrote: > Eric Engestrom writes: > > > The assert was missing a `!` to become active, but since that would only > > turn > > it into a complicated codepath for a pr_err(), let's simply replace it. > > The s

[PATCH v2] skd: fix assert typo

2016-09-16 Thread Eric Engestrom
The assert was missing a `!` to become active, but since that would only turn it into a complicated codepath for a pr_err(), let's simply replace it. CC: Jeff Moyer Signed-off-by: Eric Engestrom --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] skd: fix assert typo

2016-08-30 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 3822eae..94a7425 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1905,7 +1905,7

[FIXUP] drm: remove `const` attribute to hint at caller that they now own the memory

2016-08-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- drivers/gpu/drm/drm_atomic.c| 2 +- drivers/gpu/drm/drm_crtc.c

Re: [PATCH] drm: make drm_get_format_name thread-safe

2016-08-15 Thread Eric Engestrom
On Mon, Aug 15, 2016 at 03:52:07PM +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2016 at 04:13:54PM +0300, Jani Nikula wrote: > > On Mon, 15 Aug 2016, Eric Engestrom wrote: > > > On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: > > >> On Mon, 15 A

Re: [PATCH] drm: make drm_get_format_name thread-safe

2016-08-15 Thread Eric Engestrom
On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: > On Mon, 15 Aug 2016, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > > > I moved the main bits to be the first diffs, shouldn't affect anything > > when applying the patch,

[PATCH] drm: make drm_get_format_name thread-safe

2016-08-14 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- I moved the main bits to be the first diffs, shouldn't affect anything when applying the patch, but I wanted to ask: I don't like the hard-coded `32` the appears in both kmalloc() and snprintf(), what do you think? If you don't like it either,

Re: [PATCH v3 4/5] staging/android: add Doc for SW_SYNC ioctl interface

2016-08-11 Thread Eric Engestrom
of this feature. > > v2: take in Eric suggestions for the Documentation > > Signed-off-by: Gustavo Padovan > Reviewed-by: Eric Engestrom > --- > drivers/staging/android/sw_sync.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff -

Re: [PATCH v2 6/6] dma-buf/sw_sync: de-stage SW_SYNC

2016-08-11 Thread Eric Engestrom
To create fences on this timeline the SW_SYNC_IOC_CREATE_FENCE > ioctl should be used. To increment the timeline value use SW_SYNC_IOC_INC. > > Also it exports Sync information on > > /sync/info > > Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom > -

Re: [PATCH v2 5/6] staging/android: add Doc for SW_SYNC ioctl interface

2016-08-11 Thread Eric Engestrom
t paragraph could use some love: comma before "SW_SYNC_IOC_INC", "that has seqno smaller or equal to it." > + * > + * struct sw_sync_ioctl_create_fence > + * @value: the seqno to initiate the fence with s/initiate/initialise/ With these fixed, Reviewed-by:

Re: [PATCH v2 4/6] staging/android: prepare sw_sync files for de-staging

2016-08-11 Thread Eric Engestrom
++ b/drivers/staging/android/sync_debug.h > @@ -1,5 +1,5 @@ > /* > - * include/linux/sync.h > + * Sync File validation framework "and debug information" With that added, Reviewed-by: Eric Engestrom > * > * Copyright (C) 2012 Google, Inc. > * > -- > 2.5.5

Re: [PATCH v2 3/6] staging/android: move trace/sync.h to sync_trace.h

2016-08-11 Thread Eric Engestrom
On Mon, Aug 08, 2016 at 06:24:19PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > The common behaviour for trace headers is to have them in the same folder > they are used, instead of creating a special trace/ directory. > > Signed-off-by: Gustavo Padovan

Re: [PATCH v2 0/6] de-stage SW_SYNC validation frawework

2016-08-11 Thread Eric Engestrom
On Mon, Aug 08, 2016 at 06:24:16PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi Greg, > > This is the last step in the Sync Framwork de-stage task. It de-stage > the SW_SYNC validation framework and the sync_debug info debugfs file. > > The first 2 patches are clean up and impro

[PATCH 2/2] netfilter: add missing macro

2016-07-08 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This can't compile without this macro… Is this header really used by anyone? Should it be removed, to avoid bit-rot? --- include/uapi/linux/netfilter/xt_sctp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/netfilter/xt_sctp

[PATCH 1/2] libnvdimm: add missing macros

2016-07-08 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- This can't compile without these macros… Is this header really used by anyone? Should it be removed, to avoid bit-rot? --- include/uapi/linux/ndctl.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/

Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-07 Thread Eric Engestrom
On Tue, Jul 05, 2016 at 01:47:05PM -0700, Markus Mayer wrote: > All functions return a pointer to the terminating '\0' character in the > modified string ("dst" or "s", respectively). I think this is going to be confusing. From the man: The strcpy() and strncpy() functions return a pointe

Re: [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver

2016-06-15 Thread Eric Engestrom
On Wed, Jun 15, 2016 at 03:51:35PM +0100, Liviu Dudau wrote: > Add MAINTAINERS entry for ARM Mali-DP driver and update the > HDLCD file matching pattern to cover only HDLCD rather than > the whole drivers/gpu/drm/arm directory. > > Signed-off-by: Liviu Dudau > --- > MAINTAINERS | 10 +- >

Re: [PATCH] drm/mm: avoid possible null pointer dereference

2016-05-23 Thread Eric Engestrom
On Mon, May 23, 2016 at 02:46:59PM +0100, Chris Wilson wrote: > On Mon, May 23, 2016 at 02:38:29PM +0100, Eric Engestrom wrote: > > On Mon, May 23, 2016 at 02:02:26PM +0100, Chris Wilson wrote: > > > On Mon, May 23, 2016 at 02:56:45PM +0200, Daniel Vetter wrote: > > > &

Re: [PATCH] drm/mm: avoid possible null pointer dereference

2016-05-23 Thread Eric Engestrom
On Mon, May 23, 2016 at 02:02:26PM +0100, Chris Wilson wrote: > On Mon, May 23, 2016 at 02:56:45PM +0200, Daniel Vetter wrote: > > On Mon, May 23, 2016 at 11:27:14AM +0100, Eric Engestrom wrote: > > > On Wed, May 18, 2016 at 10:17:19PM +0200, Heinrich Schuchardt wrote: > >

Re: [PATCH v2] dma-buf: use vma_pages().

2016-05-23 Thread Eric Engestrom
On Mon, May 23, 2016 at 05:08:42PM +0530, Muhammad Falak R Wani wrote: > Replace explicit computation of vma page count by a call to > vma_pages(). > Also, include All good! Reviewed-by: Eric Engestrom

Re: [PATCH] dma-buf: use vma_pages().

2016-05-23 Thread Eric Engestrom
With that fixed: Reviewed-by: Eric Engestrom

Re: [PATCH 1/1] drm/mediatek: do not dereference NULL

2016-05-23 Thread Eric Engestrom
(struct mtk_dpi *dpi, > unsigned int factor; > > if (!dpi) { > - dev_err(dpi->dev, "invalid argument\n"); > + dev_err(NULL, "invalid argument\n"); > return -EINVAL; > } > > -- > 2.1.4 Seems obvious ^^ Reviewed-by: Eric Engestrom

Re: [PATCH] drm/mm: avoid possible null pointer dereference

2016-05-23 Thread Eric Engestrom
->start + node->size; > + > /* Find the relevant hole to add our node to */ > drm_mm_for_each_hole(hole, mm, hole_start, hole_end) { > if (hole_start > node->start || hole_end < end) > -- > 2.1.4 Reviewed-by: Eric Engestrom

Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size.

2016-05-16 Thread Eric Engestrom
On Fri, May 13, 2016 at 11:06:40PM +0530, Muhammad Falak R Wani wrote: > It is preferred to use ARRAY_SIZE() for size calculation, instead > using sizeof(array)/sizeof(*array). It makes the code more readable. > > Signed-off-by: Muhammad Falak R Wani Reviewed-by: Eric Engestrom

Re: [PATCH] drm/amd/powerplay: use ARRAY_SIZE() for size of array

2016-05-12 Thread Eric Engestrom
On Wed, May 11, 2016 at 11:18:43PM +0530, Muhammad Falak R Wani wrote: > Use ARRAY_SIZE() for the size calculation of the array. Also move the > condition evaulation function out of the for loop. > Although, any respectable c-compiler would optimize this and evaluate > the function only once outsid

[PATCH v2] Fix CONFIG_PM_OPP without CONFIG_OF build failure

2016-05-05 Thread Eric Engestrom
From: Rufus Hamade A few `#ifdef CONFIG_OF` were missing, resulting in "unused function" warnings in core.c. Signed-off-by: Rufus Hamade Reviewed-by: Eric Engestrom Tested-by: Eric Engestrom --- v2: drop incorrect change in cpu.c (Viresh Kumar) On Thu, May 05, 2016 at 08:31:

[PATCH] Fix CONFIG_PM_OPP without CONFIG_OF build failure

2016-05-03 Thread Eric Engestrom
From: Rufus Hamade A few `#ifdef CONFIG_OF` were missing or misplaced, resulting in a few "unused function" warnings in core.c, and preventing the build of cpu.c because of the redefinition of `dev_pm_opp_set_sharing_cpus()`. Signed-off-by: Rufus Hamade Reviewed-by: Eric Engestrom

Re: [PATCH] drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment

2016-04-28 Thread Eric Engestrom
+ pr_err("Could not get lvl-vdd reg, %ld", ret); > ctrl->lvl_vreg = NULL; > - return PTR_ERR(ctrl->lvl_vreg); > + return ret; > } > > return 0; > -- > 2.1.4 Reviewed-by: Eric Engestrom

[tip:locking/core] locking/Documentation/lockdep: Fix spelling mistakes

2016-04-28 Thread tip-bot for Eric Engestrom
Commit-ID: 1d4093d3b3a70b947822cca76d6e4132767ce089 Gitweb: http://git.kernel.org/tip/1d4093d3b3a70b947822cca76d6e4132767ce089 Author: Eric Engestrom AuthorDate: Mon, 25 Apr 2016 07:36:54 +0100 Committer: Ingo Molnar CommitDate: Thu, 28 Apr 2016 10:40:57 +0200 locking/Documentation

[tip:perf/core] perf tools: Remove duplicate const qualifier

2016-04-27 Thread tip-bot for Eric Engestrom
Commit-ID: 3b556bced46aa6b1873da7faa18eff235e896adc Gitweb: http://git.kernel.org/tip/3b556bced46aa6b1873da7faa18eff235e896adc Author: Eric Engestrom AuthorDate: Mon, 25 Apr 2016 10:47:54 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Apr 2016 18:12:25 -0300 perf tools

[RFC] Add missing #include

2016-04-25 Thread Eric Engestrom
ke and was forgotten, I can send an actual patchset to fix this, but it feels like it was left out on purpose. Cheers, Eric Engestrom PS: If this is a cleanup that needs to be done, I might to it for other headers as well. --- include/linux/compiler-gcc.h | 2 ++ 1 file changed, 2 insertions(+) di

[PATCH] MAINTAINERS: remove defunct spear mailing list

2016-04-25 Thread Eric Engestrom
It looks like the email address for this mailing list doesn't exist anymore: : host mxb-00178001.gslb.pphosted.com[91.207.212.93] said: 550 5.1.1 User Unknown (in reply to RCPT TO command) Signed-off-by: Eric Engestrom --- Maybe it should be replaced with an updated address? In the mean

[PATCH v2] MAINTAINERS: fix Rajendra Nayak's address

2016-04-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- v2: replace with new address instead of just removing the old one --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..81ebdab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7978,7 +7978,7

Re: [PATCH 4/4] ARM: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
On Mon, Apr 25, 2016 at 10:12:16AM -0400, Nicolas Pitre wrote: > Beware. > > I added many of those exactly because gcc did not ignore them when > compiling with LTO where the lack of a const qualifier to qualify the > actual array content, and not only the reference to that content, > generated

Re: [PATCH 4/4] ARM: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
On Mon, Apr 25, 2016 at 01:38:18PM +0200, Arnd Bergmann wrote: > Maybe say you you found it (llvm, sparse, coccinelle?), and why this > is causing a problem for anyone. If it's just unnecessary but not > harmful, I'd probably ignore the patch. $ grep -rE '(^|\W)const(\s+\w+)+\s+const\s' I just ha

Re: [PATCH 4/4] ARM: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
On Mon, Apr 25, 2016 at 11:57:15AM +0200, Alexandre Belloni wrote: > Hi, > > this requires a commit message. OK? This seems rather pointless in this case (and even more so for the typo fix I sent yesterday), but I guess you have some general rule to enforce. Would this do then? "The second `const

[PATCH] MAINTAINERS: remove Rajendra Nayak

2016-04-25 Thread Eric Engestrom
I'm guessing he doesn't work there anymore: : host cluster5.us.messagelabs.com[216.82.242.147] said: 550 Invalid recipient (#5.1.1) (in reply to RCPT TO command) Signed-off-by: Eric Engestrom --- This needs a confirmation from someone at TI --- MAINTAINERS | 1 - 1 file changed,

[PATCH 2/4] drivers: firmware: psci: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- drivers/firmware/psci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c index 11bfee8..0ab477ba 100644 --- a/drivers/firmware/psci.c +++ b/drivers/firmware/psci.c @@ -563,7 +563,7 @@ static

[PATCH 3/4] dmaengine: pxa_dma: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- drivers/dma/pxa_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 77c1c44..315901d 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -1321,7 +1321,7 @@ static int

[PATCH 1/4] perf tools: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- tools/perf/util/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c index dfd00c6..de2036d 100644 --- a/tools/perf/util/thread.c +++ b/tools/perf/util/thread.c @@ -233,7 +233,7 @@ void

[PATCH 4/4] ARM: remove duplicate const qualifier

2016-04-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- arch/arm/mach-at91/pm.c | 2 +- arch/arm/mach-bcm/bcm_kona_smc.c| 2 +- arch/arm/mach-clps711x/board-autcpu12.c | 2 +- arch/arm/mach-cns3xxx/core.c| 2 +- arch/arm/mach-davinci/da8xx-dt.c| 2 +- arch/arm/mach-lpc32xx

Re: [patch] drm: atmel-hlcdc: fix a NULL check

2016-04-25 Thread Eric Engestrom
On Mon, Apr 25, 2016 at 12:04:54PM +0300, Dan Carpenter wrote: > If kmalloc() returned NULL we would end up dereferencing "state" a > couple lines later. > > Signed-off-by: Dan Carpenter Reviewed-by: Eric Engestrom

[PATCH 29/41] Documentation: lzo: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/lzo.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/lzo.txt b/Documentation/lzo.txt index ea45dd3..285c54f 100644 --- a/Documentation/lzo.txt +++ b/Documentation/lzo.txt @@ -69,9 +69,9 @@ Description

[PATCH 27/41] Documentation: laptops: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/laptops/toshiba_haps.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/laptops/toshiba_haps.txt b/Documentation/laptops/toshiba_haps.txt index 11dbcfd..0c1d88d 100644 --- a/Documentation/laptops/toshiba_haps.txt

[PATCH 31/41] Documentation: power: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/power/opp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/power/opp.txt b/Documentation/power/opp.txt index c6279c2..1721a86 100644 --- a/Documentation/power/opp.txt +++ b/Documentation/power/opp.txt @@ -146,7

[PATCH 32/41] Documentation: pps: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/pps/pps.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/pps/pps.txt b/Documentation/pps/pps.txt index 7cb7264..50022b3 100644 --- a/Documentation/pps/pps.txt +++ b/Documentation/pps/pps.txt @@ -98,7 +98,7

[PATCH 30/41] Documentation: networking: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/networking/altera_tse.txt | 6 +++--- Documentation/networking/ipvlan.txt | 6 +++--- Documentation/networking/pktgen.txt | 6 +++--- Documentation/networking/vrf.txt| 2 +- Documentation/networking/xfrm_sync.txt | 6 +++--- 5

[PATCH 36/41] Documentation: sound: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/sound/alsa/compress_offload.txt | 2 +- Documentation/sound/alsa/soc/dapm.txt | 2 +- Documentation/sound/alsa/soc/overview.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/sound/alsa

[PATCH 35/41] Documentation: scsi: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/scsi/ChangeLog.megaraid_sas | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/scsi/ChangeLog.megaraid_sas b/Documentation/scsi/ChangeLog.megaraid_sas index 18b5709..20dcf20 100644 --- a

[PATCH 33/41] Documentation: RCU: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/RCU/stallwarn.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt index 0f7fb42..e93d041 100644 --- a/Documentation/RCU/stallwarn.txt +++ b/Documentation/RCU

[PATCH 34/41] Documentation: robust-futexes: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/robust-futexes.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/robust-futexes.txt b/Documentation/robust-futexes.txt index af6fce2..61c22d6 100644 --- a/Documentation/robust-futexes.txt +++ b

[PATCH 40/41] Documentation: x86: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/x86/intel_mpx.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/x86/intel_mpx.txt b/Documentation/x86/intel_mpx.txt index 818518a..1a5a121 100644 --- a/Documentation/x86/intel_mpx.txt +++ b/Documentation/x86

[PATCH 39/41] Documentation: vm: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/vm/transhuge.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/vm/transhuge.txt b/Documentation/vm/transhuge.txt index d9cb65c..2f383f6 100644 --- a/Documentation/vm/transhuge.txt +++ b/Documentation/vm

[PATCH 38/41] Documentation: virtual: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/virtual/kvm/devices/s390_flic.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/virtual/kvm/devices/s390_flic.txt b/Documentation/virtual/kvm/devices/s390_flic.txt index e3e314c..13a1261 100644 --- a

[PATCH 37/41] Documentation: video4linux: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/video4linux/vivid.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/video4linux/vivid.txt b/Documentation/video4linux/vivid.txt index e35d376..8da5d2a 100644 --- a/Documentation/video4linux/vivid.txt +++ b

[PATCH 41/41] Documentation: xillybus: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/xillybus.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/xillybus.txt b/Documentation/xillybus.txt index 81d111b..1660145 100644 --- a/Documentation/xillybus.txt +++ b/Documentation/xillybus.txt @@ -215,7

[PATCH 28/41] Documentation: locking: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/locking/lockdep-design.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/locking/lockdep-design.txt b/Documentation/locking/lockdep-design.txt index 5001280..9de1c15 100644 --- a/Documentation/locking

[PATCH 25/41] Documentation: filesystems: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/filesystems/autofs4.txt | 6 +++--- Documentation/filesystems/cifs/CHANGES | 2 +- Documentation/filesystems/proc.txt | 4 ++-- Documentation/filesystems/vfs.txt | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a

[PATCH 23/41] Documentation: DocBook: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/DocBook/media/dvb/net.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/dvb/net.xml b/Documentation/DocBook/media/dvb/net.xml index d2e44b7..da095ed 100644 --- a/Documentation/DocBook/media/dvb

[PATCH 26/41] Documentation: kasan: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/kasan.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kasan.txt b/Documentation/kasan.txt index 7dd95b3..9c696e4 100644 --- a/Documentation/kasan.txt +++ b/Documentation/kasan.txt @@ -116,7 +116,7 @@ Memory

[PATCH 21/41] Documentation: dt: power: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/devicetree/bindings/power/qcom,coincell-charger.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt b/Documentation/devicetree/bindings/power/qcom,coincell

[PATCH 20/41] Documentation: dt: pinctrl: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt index

[PATCH 24/41] Documentation: fb: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/fb/udlfb.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/fb/udlfb.txt b/Documentation/fb/udlfb.txt index 57d2f29..c985cb6 100644 --- a/Documentation/fb/udlfb.txt +++ b/Documentation/fb/udlfb.txt @@ -9,7

[PATCH 19/41] Documentation: dt: opp: fix spelling mistake

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Documentation/devicetree/bindings/opp/opp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt index 601256f..ee91cbd 100644 --- a/Documentation

[PATCH 22/41] Documentation: dt: soc: fix spelling mistakes

2016-04-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- .../devicetree/bindings/soc/ti/keystone-navigator-qmss.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti

  1   2   >