Hi Andreas
On Wed, 10 Mar 2021 at 20:55, Andreas Schwab wrote:
> On Mär 09 2021, claudiu.bez...@microchip.com wrote:
> > I don't have a SiFive HiFive Unleashed to investigate this. Can you check
> > if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:
> >
> > git log --onelin
bling call from callable instruction
> with modified stack frame
>
> Use BUG() instead of unreachable() to avoid the undefined behavior
> if it does happen.
>
> Fixes: 65498c6ae241 ("spi: rockchip: support 4bit words")
> Signed-off-by: Arnd Bergmann
Acked-by: Emil Re
The following commit has been merged into the irq/core branch of tip:
Commit-ID: c260954177c4f1926b423823bca5728f19b40d67
Gitweb:
https://git.kernel.org/tip/c260954177c4f1926b423823bca5728f19b40d67
Author:Emil Renner Berthing
AuthorDate:Sat, 23 Jan 2021 19:24:56 +01:00
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/cb710-mmc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/d
ather than DECLARE_TASLKLET_OLD.
Signed-off-by: Emil Renner Berthing
---
drivers/net/wan/farsync.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index b50cf11d197d..686a25d3b512 100644
--- a/drivers/net/wan/farsync.c
+++
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/dw_mmc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/driver
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/omap.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/h
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/uniphier-sd.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/via-sdmmc.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/driver
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/wbsd.c | 35 +++
1 file changed, 15 insertions(+), 20 deletion
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/s3cmci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/driver
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/tifm_sd.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/driver
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/au1xmmc.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/d
ier match.tasklet;
identifier match.callback;
@@
- tasklet_init(&container->tasklet, callback, (unsigned long)container);
+ tasklet_setup(&container->tasklet, callback);
Emil Renner Berthing (9):
mmc: atmel-mci: Use new tasklet API
mmc: au1xmmc: Use new tasklet API
m
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/mmc/host/atmel-mci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/driver
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/lan78xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/hso.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/pegasus.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drive
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/r8152.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/u
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/rtl8150.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/u
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/ifb.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ifb.c
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/caif/caif_virtio.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/driver
This converts the async and synctty drivers to use the new tasklet API n
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/ppp/ppp_async.c | 8
drivers/net/ppp/ppp_synctty.c | 8
2 files
(patch1 || patch2) @
match.T *container;
identifier match.tasklet;
identifier match.callback;
@@
- tasklet_init(&container->tasklet, callback, (unsigned long)container);
+ tasklet_setup(&container->tasklet, callback);
Emil Renner Berthing (9):
arcnet: use new tasklet API
c
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/arcnet/arcnet.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/
more users of the old API left and we can remove the data
value and flag from the tasklet struct.
Signed-off-by: Emil Renner Berthing
---
Let me know if you know of a better way to get the usbnet device from
the cdc_ncn_ctx context.
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb
Previously a temporary tasklet structure was initialized on the stack
using DECLARE_TASKLET_OLD() and then copied over and modified. Nothing
else in the kernel seems to use this pattern, so let's just call
tasklet_init() like everyone else.
Signed-off-by: Emil Renner Berthing
---
ne
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
net/atm/pppoatm.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/atm/pppoatm.c
SABLED() rather than DECLARE_TASKLET_DISABLED_OLD().
Signed-off-by: Emil Renner Berthing
---
v2: Rebased on Greg's tty/tty-next tree.
---
drivers/tty/vt/keyboard.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.
On Wed, 27 Jan 2021 at 16:33, Kalle Valo wrote:
> ...
> Forgot to mention that I can remove the Fixes tags during commit, so no
> need to resend just because of those.
Cool, thanks.
> > I can definitely see how you can reasonably disagree, but I would not
> > be comfortable having code that only
On Wed, 27 Jan 2021 at 16:20, Kalle Valo wrote:
>
> Willem de Bruijn writes:
>
> > On Wed, Jan 27, 2021 at 5:23 AM Emil Renner Berthing
> > wrote:
> >>
> >> In commit d3ccc14dfe95 most of the tasklets in this driver was
> >> updated to the n
This converts the execlist selftest to use the new tasklet API in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
Hi Chris,
I seem to have missed some tasklist manipulation in the execlist
selftest. Feel free to squash th
ork_tasklet properly
and set rx_work_tasklet.use_callback = true so that the callback is
called as
t->callback(t);
without all the casting.
Fixes: 6b8c7574a5f8 ("rtlwifi: fix build warning")
Fixes: d3ccc14dfe95 ("rtlwifi/rtw88: convert tasklets to use new
tasklet_setup() API")
Si
On Tue, 26 Jan 2021 at 16:13, Chris Wilson wrote:
> Quoting Emil Renner Berthing (2021-01-26 15:01:55)
> > This converts the driver to use the new tasklet API introduced in
> > commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
> >
> >
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
v2: Rebased on drm-intel-next
Tested on my Dell XPS 13 9300.
---
drivers/gpu/drm/i915/gt/intel_engine_cs.
On Mon, 25 Jan 2021 at 12:03, Daniel Thompson
wrote:
>
> On Sat, Jan 23, 2021 at 07:42:37PM +0100, Emil Renner Berthing wrote:
> > This converts the kgdb_tasklet_breakpoint to use the new API in
> > commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
>
SABLED() rather than DECLARE_TASKLET_DISABLED_OLD().
Signed-off-by: Emil Renner Berthing
---
drivers/tty/vt/keyboard.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
index 52922d21a49f..6c85f024bec4 100644
--- a
T() rather than DECLARE_TASKLET_OLD().
Signed-off-by: Emil Renner Berthing
---
kernel/backtracetest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/backtracetest.c b/kernel/backtracetest.c
index 370217dd7e39..70a3da716f01 100644
--- a/kernel/backtracetest
ASKLET() rather than DECLARE_TASKLET_OLD().
Signed-off-by: Emil Renner Berthing
---
kernel/debug/debug_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index af6e8b4fb359..98d44c2bb0a4 100644
--- a/kernel/debug/deb
From: Emil Renner Berthing
This converts the resend_tasklet to use the new API in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
The new API changes the argument passed to the callback function, but
fortunately the argument isn't used so it is straight
From: Emil Renner Berthing
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
Tested on my Dell XPS 13 9300.
drivers/gpu/drm/i915/gt/intel_engine_cs.
From: Emil Renner Berthing
Initialize tasklet using tasklet_init() rather than open-coding it.
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/usbnet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index
From: Emil Renner Berthing
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing
---
drivers/net/usb/usbnet.c | 8
1 file changed, 4 insertions(+), 4 deletion
From: Emil Renner Berthing
This converts the usbnet driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
It is split into two commits for ease of reviewing.
Emil Renner Berthing (2):
net: usbnet: use tasklet_init
net: u
On Thu, 30 Jul 2020 at 20:53, Luke Nelson wrote:
>
> Thanks for the patch!
>
> > Also RISC-V has a number of instruction pairs to
> > generate 32bit immediates or jump/call offsets. Eg.:
> >
> > lui rd, hi20
> > addi rd, rd, lo12
>
> On RV64, both hi20 from lui and lo12 from addi are sign-exten
Like other arch's we use patch_text_nosync or equivalent
to patch the jump-labels, but also like other arch's we
need to hold the text_mutex before calling that.
Signed-off-by: Emil Renner Berthing
---
Fixes: b6e0878a4ec8 ("riscv: Add jump-label implementation")
..that is
ian RISC-V machine.
Fix rcv -> rvc typo while we're at it.
Signed-off-by: Emil Renner Berthing
---
arch/riscv/kernel/module.c | 155 +++--
1 file changed, 79 insertions(+), 76 deletions(-)
diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
unts to the same: imm - hi20 may be become
negative/underflow, but it doesn't change the lower 12 bits.
Signed-off-by: Emil Renner Berthing
---
My hope is that we can eventually factor out the code to generate
immediates and instructions so it can be reused both here, in the
jump-label code an
On Wed, 22 Jul 2020 at 10:38, Jon Lin wrote:
>
> The RXFLR is possible larger than rx_left in Rockchip SPI, fix it.
>
> Signed-off-by: Jon Lin
> Reviewed-by: Heiko Stuebner
In addition to my review and test you should probably also add
Fixes: 01b59ce5dac8 ("spi: rockchip: use irq rather than po
On Wed, 22 Jul 2020 at 10:41, Jon Lin wrote:
>
> The burst length can be adjusted according to the transmission
> length to improve the transmission rate
>
> Signed-off-by: Jon Lin
For the whole series you can add
Reviewed-by: Emil Renner Berthing
Tested-by: Emil
On Tue, 21 Jul 2020 at 06:04, Palmer Dabbelt wrote:
>
> On Tue, 14 Jul 2020 20:20:54 PDT (-0700), anshuman.khand...@arm.com wrote:
> >
> >
> > On 07/15/2020 02:56 AM, Emil Renner Berthing wrote:
> >> This allows the pgtable tests to be built.
> >>
man
> Reported-by: Palmer Dabbelt
Nice. This fixes the problems I saw both in Qemu and on the HiFive Unleashed.
Btw. I was the one who originally stumbled upon this problem and send
the mail to linux-riscv that Palmer CC'ed you on, so I think this
ought to be
Reported-by: Emil Renner Bert
On Wed, 15 Jul 2020 at 09:15, Anup Patel wrote:
> The current RISC-V timer driver is convoluted and implements two
> distinct timers:
> 1. S-mode timer: This is for Linux RISC-V S-mode with MMU. The
> clocksource is implemented using TIME CSR and clockevent device
> is implemented using S
This allows the pgtable tests to be built.
Signed-off-by: Emil Renner Berthing
---
The tests seem to succeed both in Qemu and on the HiFive Unleashed
Both with and without the recent additions in
https://lore.kernel.org/linux-riscv/1594610587-4172-1-git-send-email-anshuman.khand...@arm.com
Add jump-label implementation based on the ARM64 version
and add CONFIG_JUMP_LABEL=y to the defconfigs.
Signed-off-by: Emil Renner Berthing
Reviewed-by: Björn Töpel
Tested-by: Björn Töpel
---
Tested on the HiFive Unleashed board.
Changes since v2:
- Add missing asm/asm.h include.
Reported
These are needed for the __jump_table in modules using
static keys/jump-labels with the layout from
HAVE_ARCH_JUMP_LABEL_RELATIVE on 64bit kernels.
Signed-off-by: Emil Renner Berthing
Reviewed-by: Björn Töpel
Tested-by: Björn Töpel
---
Tested on the HiFive Unleashed board.
No changes since v2
Add jump-label implementation based on the ARM64 version
and add CONFIG_JUMP_LABEL=y to the defconfigs.
Signed-off-by: Emil Renner Berthing
Reviewed-by: Björn Töpel
---
Tested on the HiFive Unleashed board.
Changes since v1:
- WARN and give up gracefully if the jump offset cannot be
These are needed for the __jump_table in modules using
static keys/jump-labels with the layout from
HAVE_ARCH_JUMP_LABEL_RELATIVE on 64bit kernels.
Signed-off-by: Emil Renner Berthing
---
Tested on the HiFive Unleashed board.
This patch is new in v2. It fixes an error loading modules
On Wed, 8 Jul 2020 at 09:42, Björn Töpel wrote:
>
> On Tue, 7 Jul 2020 at 17:08, Emil Renner Berthing wrote:
> >
> > Add jump-label implementation based on the ARM64 version.
> >
> > Tested on the HiFive Unleashed board.
> >
>
> I took your p
On Wed, 8 Jul 2020 at 08:28, Björn Töpel wrote:
> On Tue, 7 Jul 2020 at 17:08, Emil Renner Berthing wrote:
> >
> > Add jump-label implementation based on the ARM64 version.
> >
>
> Thanks for working on this!
>
> > Tested on the HiFive Unleashed board.
> &g
Add jump-label implementation based on the ARM64 version.
Tested on the HiFive Unleashed board.
Signed-off-by: Emil Renner Berthing
---
Changes since RFC:
- Use RISCV_PTR and RISCV_LGPTR macros to match struct jump_table
also in 32bit kernels.
- Remove unneeded branch ? 1 : 0, thanks Björn
On Sat, 4 Jul 2020 at 13:23, Björn Töpel wrote:
> On Fri, 3 Jul 2020 at 17:43, Emil Renner Berthing wrote:
> > On Thu, 2 Jul 2020 at 22:07, Emil Renner Berthing wrote:
> > >
> > > Add basic jump-label implementation heavily based
> > > on the ARM64 versi
On Thu, 2 Jul 2020 at 22:07, Emil Renner Berthing wrote:
>
> Add basic jump-label implementation heavily based
> on the ARM64 version.
>
> Tested on the HiFive Unleashed.
>
> Signed-off-by: Emil Renner Berthing
> ---
>
> This seems to work on my HiFive Unleashed. A
Add basic jump-label implementation heavily based
on the ARM64 version.
Tested on the HiFive Unleashed.
Signed-off-by: Emil Renner Berthing
---
This seems to work on my HiFive Unleashed. At least boots, runs fine
and the static key self-tests doesn't complain, but I'm sure I
Hi Chris,
On Sat, 9 May 2020 at 02:10, Chris Ruehl wrote:
>
> Hi Emil,
>
> thanks for the review and your comments
>
> On 8/5/2020 9:13 pm, Emil Renner Berthing wrote:
> > Hi Chris,
> >
> > On Fri, 8 May 2020 at 10:47, Chris Ruehl wrote:
> >> This p
Hi Chris,
On Fri, 8 May 2020 at 15:13, Emil Renner Berthing
wrote:
> If you do something like this you won't need the temporary num_cs variable:
>
> if (of_property_read_u32(np, "num-cs", &master->num_chipselect))
> master->num_chipselect = 1;
Sorry
Hi Chris,
On Fri, 8 May 2020 at 10:47, Chris Ruehl wrote:
>
> This patch aim to add spi slave mode support to the rockchip driver.
> Fix the wrong usage of num_cs set fix to ROCKCHIP_SPI_MAX_CS_NUM,
> instead use max_native_cs flag to set the limit of native chip-select.
> Enable use_gpio_descrip
Hi Alex,
On Fri, 12 Jul 2019 at 17:02, Alex Dewar wrote:
> When I try to boot the screen just gets flooded with messages like this:
> http://users.sussex.ac.uk/~ad374/boot_fail.jpg
Those seem to be only audit messages. You can try booting with audit=0
on the kernel command line to get rid of tho
On Wed, 5 Jun 2019 at 21:55, Mark Brown wrote:
>
> On Wed, Jun 05, 2019 at 09:36:44PM +0200, Emil Renner Berthing wrote:
> > On Wed, 8 May 2019 at 12:34, Mark Brown wrote:
>
> > >spi: rockchip: turn down tx dma bursts
>
> > I've tried looking in the for
Hi Mark
On Wed, 8 May 2019 at 12:34, Mark Brown wrote:
>
> The patch
>
>spi: rockchip: turn down tx dma bursts
>
> has been applied to the spi tree at
>
>https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
>
> All being well this means that it will be integrated into the linux
igned to word."
So this relies on fifo_len being a multiple of 16 such that the
burst length (= fifo_len / 4) is a multiple of 4 and the addresses
will be word-aligned.
Fixes: dcfc861d24ec ("spi: rockchip: adjust dma watermark and burstlen")
Signed-off-by: Emil Renner Berthing
Hi Vicente,
On Sat, 6 Apr 2019 at 19:35, Vicente Bergas wrote:
>
> Hi,
> i have been experiencing issues writing to NOR-Flash SPI Memories
> from two RK3399-based platforms: gru-kevin and sapphire board.
> For kevin, this resulted in a bricked device because that memory
> is the only boot device.
Hi Paul,
Thanks for the patch!
On Sat, 20 Oct 2018 at 12:12, Paul Walmsley wrote:
> +/*
> + *
> + */
Interesting comment ;)
> +static int __init sifive_serial_console_setup(struct console *co, char
> *options)
Unfortunately I get this error unless I remove the __init:
...
GEN .version
Hi Mark,
On Tue, 13 Nov 2018 at 19:35, Mark Brown wrote:
> On Mon, Nov 12, 2018 at 03:27:36PM +0100, Emil Renner Berthing wrote:
>
> > I know the discussions about the sifive devicetree compatible
> > strings haven't come to a conclusion, so I'm sending this as
> &
From: Palmer Dabbelt
Add driver for the SiFive SPI controller
on the HiFive Unleashed board.
Signed-off-by: Palmer Dabbelt
Signed-off-by: Emil Renner Berthing
---
.../devicetree/bindings/spi/spi-sifive.txt| 29 ++
drivers/spi/Kconfig | 6 +
drivers/spi
From: Emil Renner Berthing
Use C99 designated initializers for dma slave config
structures. This also makes sure uninitialized fields
are zeroed so we don't need an explicit memset.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 26 ++
1
From: Emil Renner Berthing
The hardware supports 3 different variants of SPI
and there were some code around it, but nothing
to actually set it to anything but "Motorola SPI".
Just drop that code and always use that mode.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockc
From: Emil Renner Berthing
The state field is currently only used to make sure
only the last of the tx and rx dma callbacks issue
an spi_finalize_current_transfer.
Rather than using a spinlock we can get away
with just turning the state field into an atomic_t.
Signed-off-by: Emil Renner
From: Emil Renner Berthing
Just read transfer info directly from the spi device
and transfer structures rather than storing it in
driver data first.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 70 +-
1 file changed, 24 insertions
From: Emil Renner Berthing
Add missing support for lsb-first mode.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 9e47e81553a1..3912526ead66
From: Emil Renner Berthing
The spi master (aka spi controller) structure already
has two fields for storing the rx and tx dma channels.
Just use them rather than duplicating them in driver data.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 76
From: Emil Renner Berthing
We only need to know if we're using dma when setting
up the transfer, so just use a local variable for
that.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --
From: Emil Renner Berthing
The driver previously checked each transfer if the
requested speed was higher than possible with the
current spi clock rate and raised the clock rate
accordingly.
However, there is no check to see if the spi clock
was actually set that high and no way to dynamically
From: Emil Renner Berthing
In almost all cases we already have a pointer to the
spi master structure where we have the driver data.
The only exceptions are the dma callbacks which are
easily fixed by passing them the master and using
spi_master_get_devdata to retrieve the driver data.
Signed
From: Emil Renner Berthing
The hardware supports 4, 8 and 16bit spi words,
so add the missing support for 4bit words.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 41 +++---
1 file changed, 29 insertions(+), 12 deletions(-)
diff --git a
From: Emil Renner Berthing
Now that we no longer potentially change spi clock
at runtime we can precompute the rx sample delay
at probe time rather than for each transfer.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 36 ++--
1 file
From: Emil Renner Berthing
Successful transfers leave the spi disabled, so if
we just make sure to disable the spi on error
there should be no need to disable the spi from
master->unprepare_message.
This also flushes the tx and rx fifos,
so no need to do that manually.
Signed-off-by: E
From: Emil Renner Berthing
Register an interrupt handler to fill/empty the
tx and rx fifos rather than busy-looping.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 155 ++---
1 file changed, 92 insertions(+), 63 deletions(-)
diff --git a
From: Emil Renner Berthing
Hi,
I took another look at the rockchip spi driver and ended up
with more cleanups and implementing an interrupt handler
to fill/empty the tx and rx fifos rather than busy-looping.
I have two question though:
The driver sets the SPI_LOOP flag in master->mode_b
From: Emil Renner Berthing
The spi_enable_chip function takes a boolean
argument. Change the type to reflect that.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi
From: Huibin Hong
The rxconf and txconf structs are allocated on the
stack, so make sure we zero them before filling out
the relevant fields.
Signed-off-by: Huibin Hong
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a
other rockchips.
/Emil
Emil Renner Berthing (5):
arm64: dts: rockchip: add rk3399 SPI DMAs
spi: rockchip: remove unneeded dma_caps
spi: rockchip: mark use_dma as bool
spi: rockchip: directly use direction constants
spi: rockchip: simplify spi enable logic
Huibin Hong (2):
spi: rockchip
Add spi dma channels as specified by the rk3399 TRM.
Signed-off-by: Emil Renner Berthing
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index
The driver data has a u32 field use_dma which is
only ever used as a boolean, so change its type
to reflect that.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi
Let the dma/non-dma code paths handle the spi enable
flag themselves. This removes some logic to determine
if the flag should be turned on before or after dma
and also don't leave the spi enabled if the dma path
fails.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c
The dma direction for the tx and rx dma channels never
change, so just use the constants directly rather
than storing them in device data.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers
We no longer need the dma_caps since the dma driver
already clamps the burst length to the hardware limit,
so don't request and store dma_caps in device data.
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/sp
From: Huibin Hong
Signal tx dma when spi fifo is less than half full,
and limit tx bursts to half the fifo length.
Clamp rx burst length to 1 to avoid alignment issues.
Signed-off-by: Huibin Hong
Signed-off-by: Emil Renner Berthing
---
drivers/spi/spi-rockchip.c | 12 +++-
1 file
On Fri, 28 Sep 2018 at 14:15, Neil Armstrong wrote:
> On 27/09/2018 11:24, Emil Karlson wrote:
> > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard
> > events
> > be truncated on many chromebooks so that Left and Right keys on Column 12
> > were
> > always 0. This commit f
On 12 February 2018 at 23:29, Rob Herring wrote:
> On Mon, Feb 12, 2018 at 3:26 PM, Brian Norris
> wrote:
>> Hi,
>>
>> On Mon, Feb 12, 2018 at 10:43:41AM -0600, Rob Herring wrote:
>>> On Thu, Feb 8, 2018 at 3:23 PM, Enric Balletbo Serra
>>> wrote:
>>> > 2018-02-08 18:52 GMT+01:00 Rob Herring :
1 - 100 of 109 matches
Mail list logo
