Re: [PATCH v12 14/16] platform/x86: wmi: create userspace interface for drivers

Reviewed-by: Edward O'Callaghan On Thu, Nov 2, 2017 at 6:25 AM, Mario Limonciello wrote: > For WMI operations that are only Set or Query readable and writable sysfs > attributes created by WMI vendor drivers or the bus driver makes sense. > > For other WMI operations that

Re: [PATCH v12 01/16] platform/x86: dell-smbios: Prefix class/select with cmd_

Reviewed-by: Edward O'Callaghan On Thu, Nov 2, 2017 at 6:25 AM, Mario Limonciello wrote: > Later on these structures will be brought up to userspace. > the word "class" is a reserved word in c++ and this will prevent > uapi headers from being included directly in c++ pr

Re: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface

ens are now shared out to userspace so > applications don't need to define them in their own headers. > > Signed-off-by: Mario Limonciello > Reviewed-by: Edward O'Callaghan > --- > Documentation/ABI/testing/dell-smbios-wmi | 41 > driver

Re: [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI

Just my 2c, I like this simplification Mario. Reviewed-by: Edward O'Callaghan On Thu, Oct 19, 2017 at 9:27 AM, wrote: >> -Original Message- >> From: Limonciello, Mario >> Sent: Wednesday, October 18, 2017 8:56 AM >> To: 'Pali Rohár' ; Greg KH ; A

Re: [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI

Reviewed-by: Edward O'Callaghan On Wed, Oct 18, 2017 at 5:22 AM, Mario Limonciello wrote: > This application uses the character device /dev/wmi/dell-smbios > to perform SMBIOS communications from userspace. > > It offers demonstrations of a few simple tasks: > - Running a

Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

I like how this series turned out and I think it puts us in a exceedingly better position than the dcdbas path. This series is, Reviewed-by: Edward O'Callaghan On Sat, Oct 14, 2017 at 4:32 PM, Mario Limonciello wrote: > The existing way that the dell-smbios helper module and associated

Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn

;> 20 uses of pr_warn in drivers/gpu >> >> Signed-off-by: Joe Perches > > Acked-by: Christian König . Reviewed-by: Edward O'Callaghan > >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- >> drivers/gpu/drm/amd/powerplay/

Re: [PATCH] drm/amd/amdgpu: fix spelling mistake: "comleted" -> "completed"

Reviewed-by: Edward O'Callaghan On 12/30/2016 12:39 PM, Zhou, David(ChunMing) wrote: > +amd-gfx, patch is Reviewed-by: Chunming Zhou > > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, December 29, 2016 11:47 PM >

Re: [PATCH 1/3] drm/amdgpu: change function declarations and add missing header dependencies

This series is, Acked-by: Edward O'Callaghan On 10/22/2016 07:48 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/atombios_crtc.c:38:6: warning: no previous > prototype for 'amdgpu_atombios_crtc_overscan_setup

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

Oh dear, still more of these? Why not perhaps fix them all at once into a series? In any case, Acked-by: Edward O'Callaghan On 10/22/2016 07:56 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smu

Re: [PATCH 1/4] drm/amd/powerplay: mark symbols static where possible

This series is, Reviewed-by: Edward O'Callaghan On 09/25/2016 06:19 PM, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/cz_hwmgr.c:69:10: warning: no > previous prototype for 'cz_get_eclk_level

Re: [PATCH] drm: amdgpu: mark symbols static where possible

ctions, even their declarations > is different. Are you sure? Because apart from the crazy macro chain they look like they wind up being the same to me. > > On 3 September 2016 at 14:11, Edward O'Callaghan > mailto:funfunc...@folklore1984.net>> wrote: >

Re: [PATCH] drm: amdgpu: mark symbols static where possible

Reviewed-by: Edward O'Callaghan Also, I just noticed cz_write_smc_sram_dword() and if I am not mistaken they seems identical in both: drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c and, drivers/gpu/drm/amd/amdgpu/cz_smc.c with a personal preference to the powerplay version I su

[PATCH] arch/x86/kernel/rtc.c: Overzealous usage of 'const' keyword

Please merge. -- __ Edward O'Callaghan, Director and Principal consultant. https://www.alterapraxis.com | eocallag...@alterapraxis.com Altera Praxis Pty Ltd, // Discretions in cybersecurity ACN 165 42

[PATCH] Build fix for ARM. The UAPI changes split kernel API and userspace API content onto two separate header files and assumed a full linux build. This trips up embedded builds.

Signed-off-by: Edward O'Callaghan --- include/uapi/drm/drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8d1e2bb..73a99e4 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -36,7 +36,7 @@ #i

[PATCH] Trivial fix for ath9k dmesg typo.

Signed-off-by: Edward O'Callaghan --- drivers/net/wireless/ath/ath9k/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 07e2526..76da544 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c