[PATCH 1/2] net: hix5hd2_gmac: fix compatible strings name

2016-12-19 Thread Dongpo Li
ng in dt binding documentation and describe which generic version the SoC belongs to. Fixes: d0fb6ba75dc0 ("net: hix5hd2_gmac: add generic compatible string") Signed-off-by: Dongpo Li --- .../devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt | 13 - drive

[PATCH 2/2] ARM: dts: hix5hd2: don't change the existing compatible string

2016-12-19 Thread Dongpo Li
The SoC hix5hd2 compatible string has the suffix "-gmac" and we should not change it. We should only add the generic compatible string "hisi-gmac-v1". Fixes: 0855950ba580 ("ARM: dts: hix5hd2: add gmac generic compatible and clock names") Signed-off-by: Dongpo L

[PATCH 0/2] net: hix5hd2_gmac: keep the compatible string not changed

2016-12-19 Thread Dongpo Li
mac". Creating a new name suffix "-gemac" is unnecessary. Dongpo Li (2): net: hix5hd2_gmac: fix compatible strings name ARM: dts: hix5hd2: don't change the existing compatible string .../devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt | 13 +++

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-19 Thread Dongpo Li
On 2016/12/20 0:04, Rob Herring wrote: > On Mon, Dec 19, 2016 at 2:14 AM, Dongpo Li wrote: >> Hi Rob and David, >> >> On 2016/12/12 22:21, Rob Herring wrote: >>> On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >>>> Hi Rob, >>>> >>&g

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-19 Thread Dongpo Li
Hi Rob and David, On 2016/12/12 22:21, Rob Herring wrote: > On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >> Hi Rob, >> >> On 2016/12/10 6:35, Rob Herring wrote: >>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: >>>> The "hix5hd

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-12 Thread Dongpo Li
On 2016/12/12 22:21, Rob Herring wrote: > On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >> Hi Rob, >> >> On 2016/12/10 6:35, Rob Herring wrote: >>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: >>>> The "hix5hd2" is SoC name,

[PATCH 2/2] net: ethernet: hip04: Call SET_NETDEV_DEV()

2016-12-12 Thread Dongpo Li
The hip04 driver calls into PHYLIB which now checks for net_device->dev.parent, so make sure we do set it before calling into any MDIO/PHYLIB related function. Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a different owner") Signed-off-by: Dong

[PATCH 0/2] net: ethernet: hisilicon: set dev->dev.parent before PHY connect

2016-12-12 Thread Dongpo Li
rent before PHY connect. Dongpo Li (2): net: ethernet: hisi_femac: Call SET_NETDEV_DEV() net: ethernet: hip04: Call SET_NETDEV_DEV() drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +- drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.8.2

[PATCH 1/2] net: ethernet: hisi_femac: Call SET_NETDEV_DEV()

2016-12-12 Thread Dongpo Li
The hisi_femac driver calls into PHYLIB which now checks for net_device->dev.parent, so make sure we do set it before calling into any MDIO/PHYLIB related function. Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a different owner") Signed-off-by:

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-12 Thread Dongpo Li
Hi Rob, On 2016/12/10 6:35, Rob Herring wrote: > On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: >> The "hix5hd2" is SoC name, add the generic ethernet driver name. >> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds >&g

[PATCH v2 4/4] ARM: dts: hix5hd2: add gmac generic compatible and clock names

2016-12-05 Thread Dongpo Li
Add gmac generic compatible and clock names. Signed-off-by: Dongpo Li --- arch/arm/boot/dts/hisi-x5hd2.dtsi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi index fdcc23d..0da76c5 100644 --- a/arch

[PATCH v2 3/4] net: hix5hd2_gmac: add reset control and clock signals

2016-12-05 Thread Dongpo Li
isting is MAC core clock, and the new one is MAC interface clock. The MAC interface clock is optional to be backward compatible with the hix5hd2 SoC. Signed-off-by: Dongpo Li --- .../bindings/net/hisilicon-hix5hd2-gmac.txt| 20 ++- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 139 ++

[PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-05 Thread Dongpo Li
The "hix5hd2" is SoC name, add the generic ethernet driver name. The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds the SG/TXCSUM/TSO/UFO features. Signed-off-by: Dongpo Li --- .../devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt| 9 +

[PATCH v2 0/4] net: hix5hd2_gmac: add tx sg feature and reset/clock control signals

2016-12-05 Thread Dongpo Li
neric string as advised by Rob. - Make the MAC reset control signals and clock signals optional to be backward compatible with the hix5hd2 SoC. - Change the compatible string and give the clock a specific name in hix5hd2 dts file. Dongpo Li (4): net: hix5hd2_gmac: add generic compatible string net

[PATCH v2 2/4] net: hix5hd2_gmac: add tx scatter-gather feature

2016-12-05 Thread Dongpo Li
"hisi-gemac-v2" adds the SG/TXCSUM/TSO/UFO features. This patch only adds the SG(scatter-gather) driver for transmitting, the drivers of other features will be submitted later. Signed-off-by: Dongpo Li --- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 198

Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature

2016-08-15 Thread Dongpo Li
On 2016/8/16 0:18, Rob Herring wrote: > On Mon, Aug 15, 2016 at 1:50 AM, Dongpo Li wrote: >> Hi Rob, >> Many thanks for your review. >> >> On 2016/8/13 2:43, Rob Herring wrote: >>> On Thu, Aug 11, 2016 at 05:01:52PM +0800, Dongpo Li wrote: >>>>

Re: [PATCH 3/4] clk: hix5hd2: change ethernet clock type

2016-08-15 Thread Dongpo Li
; > url: > https://github.com/0day-ci/linux/commits/Dongpo-Li/net-hix5hd2_gmac-add-tx-sg-feature-and-reset-clock-control-signals/20160811-170826 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git > for-next > config: arm-multi_v7_defconfig (attached as .confi

Re: [PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals

2016-08-15 Thread Dongpo Li
Hi Rob, On 2016/8/13 2:48, Rob Herring wrote: > On Thu, Aug 11, 2016 at 05:01:53PM +0800, Dongpo Li wrote: >> From: Li Dongpo >> >> Add three reset control signals, "mac_core_rst", "mac_ifc_rst" and >> "phy_rst". >

Re: [PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature

2016-08-14 Thread Dongpo Li
Hi Rob, Many thanks for your review. On 2016/8/13 2:43, Rob Herring wrote: > On Thu, Aug 11, 2016 at 05:01:52PM +0800, Dongpo Li wrote: >> From: Li Dongpo >> >> The "hix5hd2" is SoC name, add the generic ethernet driver name. >> The "hisi-gemac-v1"

[PATCH 1/4] net: hix5hd2_gmac: add tx scatter-gather feature

2016-08-11 Thread Dongpo Li
her features will be submitted later. Signed-off-by: Dongpo Li --- .../bindings/net/hisilicon-hix5hd2-gmac.txt| 9 +- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 213 +++-- 2 files changed, 205 insertions(+), 17 deletions(-) diff --git a/Documentation/dev

[PATCH 4/4] ARM: dts: hix5hd2: add gmac clock and reset property

2016-08-11 Thread Dongpo Li
Add clock and reset property for gmac node. Signed-off-by: Dongpo Li --- arch/arm/boot/dts/hisi-x5hd2-dkb.dts | 2 ++ arch/arm/boot/dts/hisi-x5hd2.dtsi| 15 +++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/hisi-x5hd2-dkb.dts b/arch/arm/boot

[PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals

2016-08-11 Thread Dongpo Li
nts "phy reset signal", it does a hardware reset on the PHY chip. This reset signal is optinal if the PHY can work well without the hardware reset. Add one more clock signal, the existing is MAC core clock, and the new one is MAC interface clock. Signed-off-by: Dongpo Li --- .../binding

[PATCH 3/4] clk: hix5hd2: change ethernet clock type

2016-08-11 Thread Dongpo Li
ethernet clock is really a "complex" clock because it's obscure and hard to understand. Signed-off-by: Dongpo Li --- drivers/clk/hisilicon/clk-hix5hd2.c | 72 +++ include/dt-bindings/clock/hix5hd2-clock.h | 6 ++- 2 files changed, 20 insertions(+

[PATCH 0/4] net: hix5hd2_gmac: add tx sg feature and reset/clock control signals

2016-08-11 Thread Dongpo Li
will be submitted later. Add the MAC reset control signals and clock signals. As a result, the hix5hd2 ethernet clock can be abstracted as gate clock instead of self defined complex clock. Dongpo Li (2): clk: hix5hd2: change ethernet clock type ARM: dts: hix5hd2: add gmac clock and reset

Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver

2016-07-15 Thread Dongpo Li
Hi Arnd, On 2016/7/15 16:41, Arnd Bergmann wrote: > On Friday, July 15, 2016 4:26:32 PM CEST Dongpo Li wrote: >> This patch set adds a Hisilicon MDIO bus driver and >> a Fast Ethernet MAC(FEMAC) driver. >> We also abstract a general interface "of_phy_get_and_connect"

[PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver

2016-07-15 Thread Dongpo Li
s". - Use a smaller NAPI poll weight 16 for our Fast Ethernet MAC. - Use phy_ethtool_{get|set}_link_ksettings for ethtool ops. - Use phydev from struct net_device in MAC driver. Dongpo Li (3): net: Add MDIO bus driver for the Hisilicon FEMAC of_mdio: Abstract a general interface for phy con

[PATCH v1 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-15 Thread Dongpo Li
This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. The FEMAC supports max speed 100Mbps and has been used in many Hisilicon SoC. Signed-off-by: Dongpo Li Reviewed-by: Jiancheng Xue --- .../devicetree/bindings/net/hisilicon-femac.txt| 39 + drivers/net/ethernet/hisilicon

[PATCH v1 1/3] net: Add MDIO bus driver for the Hisilicon FEMAC

2016-07-15 Thread Dongpo Li
This patch adds a separate driver for the MDIO interface of the Hisilicon Fast Ethernet MAC. Signed-off-by: Dongpo Li Reviewed-by: Jiancheng Xue Acked-by: Rob Herring --- .../bindings/net/hisilicon-femac-mdio.txt | 22 +++ drivers/net/phy/Kconfig| 7

[PATCH v1 2/3] of_mdio: Abstract a general interface for phy connect

2016-07-15 Thread Dongpo Li
Abstract a general interface "of_phy_get_and_connect" for PHY connect. User will have no bother with getting "phy-mode" and "phy-handle" any more. Suggested-by: Arnd Bergmann Signed-off-by: Dongpo Li Reviewed-by: Jiancheng Xue ---

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-11 Thread Dongpo Li
On 2016/7/11 16:16, Arnd Bergmann wrote: > On Monday, July 11, 2016 11:44:23 AM CEST Dongpo Li wrote: >> Hi Arnd, >> >> On 2016/6/28 17:34, Arnd Bergmann wrote: >>> On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: >>>> On 2016/6/15 5:20, Arnd

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-07-10 Thread Dongpo Li
Hi Arnd, On 2016/6/28 17:34, Arnd Bergmann wrote: > On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: >> On 2016/6/15 5:20, Arnd Bergmann wrote: >>> On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: >>>> On 2016/6/13 17:06, Arnd Bergmann wrote: &g

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-28 Thread Dongpo Li
On 2016/6/15 5:20, Arnd Bergmann wrote: > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: >> On 2016/6/13 17:06, Arnd Bergmann wrote: >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: >>> You tx function uses BQL to optimize the queue length,

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-15 Thread Dongpo Li
On 2016/6/15 6:31, Rob Herring wrote: > On Mon, Jun 13, 2016 at 02:07:56PM +0800, Dongpo Li wrote: >> This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. >> The FEMAC supports max speed 100Mbps and has been used in many >> Hisilicon SoC. >> >> Reviewed

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-15 Thread Dongpo Li
On 2016/6/15 5:20, Arnd Bergmann wrote: > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: >> On 2016/6/13 17:06, Arnd Bergmann wrote: >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: >>> You tx function uses BQL to optimize the queue length,

[PATCH 2/3] ethtool: Add common functions for get and set settings

2016-06-12 Thread Dongpo Li
Currently, most drivers only support get and set PHY settings by PHY ethtool API. For those drivers, it's better to supply common functions for get_settings and set_settings. This patch adds common functions implementation. Reviewed-by: Jiancheng Xue Signed-off-by: Dongpo Li --- include/

[PATCH 1/3] net: Add MDIO bus driver for the Hisilicon FEMAC

2016-06-12 Thread Dongpo Li
This patch adds a separate driver for the MDIO interface of the Hisilicon Fast Ethernet MAC. Reviewed-by: Jiancheng Xue Signed-off-by: Dongpo Li --- .../bindings/net/hisilicon-femac-mdio.txt | 22 +++ drivers/net/phy/Kconfig| 8 + drivers/net/phy

[PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-12 Thread Dongpo Li
This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. The FEMAC supports max speed 100Mbps and has been used in many Hisilicon SoC. Reviewed-by: Jiancheng Xue Signed-off-by: Dongpo Li --- .../devicetree/bindings/net/hisilicon-femac.txt| 40 + drivers/net/ethernet/hisilicon

[PATCH 0/3] Add Hisilicon MDIO bus driver and FEMAC driver

2016-06-12 Thread Dongpo Li
This patch set adds a Hisilicon MDIO bus driver and a Fast Ethernet MAC(FEMAC) driver. We found that most ethernet mac drivers use the same ethtool get_settings and set_settings, so this patch set also adds common functions for get and set settings. Dongpo Li (3): net: Add MDIO bus driver for