Am Mon, Mar 01, 2021 at 06:38:47PM +0100 schrieb Uwe Kleine-König:
> pcmcia_device_remove() is only ever called by the driver core with
> dev->driver pointing to a valid driver. (And even if dev->driver was
> NULL, p_drv wouldn't be NULL as p_drv is assigned as follows:
>
> p_drv = to_pcmcia
Am Fri, Mar 12, 2021 at 11:02:33AM + schrieb Lee Jones:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (6):
> pcmcia: rsrc_nonstatic: Demote kernel-doc abuses
> pcmc
Linus,
A lone PCMCIA change since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62:
Linux 5.11-rc2 (2021-01-03 15:55:30 -0800)
is available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
for you to fetch changes up to 4ce6b242b78d355ba8
Am Tue, Feb 23, 2021 at 05:26:50PM +0800 schrieb Yang Li:
> fixed the following coccicheck:
> ./drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for
> kobj_to_dev()
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Sorry, an equivalent patch is already in pcmcia-next and about to be
Viresh,
Am Mon, Feb 01, 2021 at 01:35:51PM +0530 schrieb Viresh Kumar:
> The removal of such a driver is avoided if the driver carries the
> CPUFREQ_STICKY flag. This was added way back [1] in 2004 and perhaps no
> one should ever need it now. A lot of driver do set this flag, probably
> because t
_xyzzy()`, and so are all the helpers declared bellow it. Change the
> documentation to reflect this.
>
> Cc: Dominik Brodowski
> Fixes: 819671ff849b ("syscalls: define and explain goal to not call syscalls
> in the kernel")
> Signed-off-by: André Almeida
Reviewed-by: Dominik Brodowski
Thanks,
Dominik
Am Mon, Jan 04, 2021 at 09:59:30AM +0800 schrieb Tian Tao:
> fixed the following coccicheck:
> drivers/pcmcia/cistpl.c:1557:54-55: WARNING opportunity for kobj_to_dev()
> drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for kobj_to_dev()
>
> Signed-off-by: Tian Tao
Applied to pcmcia-next,
Linus,
The following changes since commit b3298500b23f0b53a8d81e0d5ad98a29db71f4f0:
Merge tag 'for-5.10/dm-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
(2020-12-04 13:28:39 -0800)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linu
Am Fri, Dec 11, 2020 at 11:24:12AM +0800 schrieb Yejune Deng:
> See Documentation/timers/timers-howto.rst, msleep() is not
> for (1ms - 20ms),use usleep_range() instead.
While technically correct, this branch is only taken if the "rootwait"
kernel parameter is passed -- and as the kernel is loopin
Am Wed, Jun 17, 2020 at 09:53:26PM +0200 schrieb Christophe JAILLET:
> 'status' is known to be 0 at this point. It must be set to a meaningful
> value in order to return an error code if one of the 'of_get_property()'
> call fails.
>
> Return -EINVAL in such a case.
>
> Fixes: 2b571a066a2f("pcmci
Am Fri, Dec 04, 2020 at 08:20:09PM +0100 schrieb Sebastian Andrzej Siewior:
> On 2020-11-19 18:06:24 [+0100], To linux-kernel@vger.kernel.org wrote:
> > On 2020-11-13 22:34:08 [+0100], To linux-kernel@vger.kernel.org wrote:
> > > This driver is the very definition of bitrotting:
> > > - Introduced
Am Thu, Sep 10, 2020 at 10:05:24PM +0800 schrieb Jason Yan:
> Eliminate the following coccicheck warning:
>
> drivers/pcmcia/db1xxx_ss.c:455:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot
> Signed-off-by: Jason Yan
Applied to pcmcia-next.
Thanks,
Dominik
Am Tue, Nov 24, 2020 at 12:07:30PM +0100 schrieb Alexandre Belloni:
> On Wed, 30 Sep 2020 20:48:02 +0200, Alexandre Belloni wrote:
> > struct at91_cf_data is only used in the driver since all the platforms moved
> > to device tree, move its definition locally.
>
> I've now applied those patches on
Am Tue, Nov 24, 2020 at 03:00:40PM +0800 schrieb Wei Li:
> When it fails to call of_get_property(), it just jumps to 'fail1',
> while the 'status' which will be returned is not updated.
>
> Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards")
> Signed-off-by: Wei Li
Thn
Am Wed, Nov 25, 2020 at 08:50:57PM +0800 schrieb Wang ShaoBo:
> Fix to return proper error code instaed of 0 in omap_cf_probe(), as done
> elsewhere in this function.
>
> Signed-off-by: Wang ShaoBo
Applied to pcmcia-next.
Thanks,
Dominik
Am Wed, Sep 16, 2020 at 10:16:29AM +0200 schrieb Sebastian Andrzej Siewior:
> This driver is the very definition of bitrotting:
> - Introduced in commit
> 79a140932c776 ("[PATCH] mips: vR41xx updates")
> which is 2.6.11-rc3.
>
> - Provides ->register_callback which was removed in commit
> 7f
On Tue, Sep 22, 2020 at 03:40:00PM +0200, Christoph Hellwig wrote:
> This value is only used by a PCMCIA driver and not very useful.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Dominik Brodowski
On Mon, Jun 08, 2020 at 10:46:41AM +0100, Catalin Marinas wrote:
> On Mon, Jun 08, 2020 at 10:49:25AM +0800, Wang ShaoBo wrote:
> > Currently arm64 personality syscall uses wrapper __arm64_sys_personality
> > to redirect to __arm64_sys_arm64_personality, it's easily confused,
> > Whereas using an n
pccard_loop_tuple() static (2020-05-18 11:16:39 +0200)
Two minor PCMCIA odd fixes, one replacing zero-length arrays with a
flexible-array member, and one making a local function static.
Thanks,
Dominik
Dominik Brodowski (1
On Thu, May 07, 2020 at 02:05:49PM -0500, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced i
On Tue, Oct 22, 2019 at 05:17:12AM +1100, Michael . wrote:
> Thank you Dominik for looking at this for us and passing it on.
>
> Good morning Bjorn, thank you also for looking into this for us and
> thank you for CCing us into this as non of us are on the mailing list.
> One question how do we app
On the basis of the additional information (thanks), there might be a
more specific path to investigate: It is that the PCI code does not
enumerate the second cardbus bridge PCI function in the more recent 4.19
kernel compared to the anvient (and working) 2.6 kernel.
Namely, only one CardBus bridg
On Tue, Oct 15, 2019 at 05:04:28PM +1100, Michael . wrote:
> Good afternoon kernel developers
> Please accept my apology for contacting you directly about this. A
> small group of friends, some of whom are CCed here, have come together
> to try and find a solution to a problem that originated with
Inform how many bits of randomness were provided by the bootloader,
and whether we trust that input.
Signed-off-by: Dominik Brodowski
Cc: Ard Biesheuvel
Cc: Hsin-Yi Wang
Cc: Stephen Boyd
Cc: Rob Herring
Cc: Theodore Ts'o
Cc: Will Deacon
diff --git a/drivers/char/random.c b/drivers
When connecting a thunderbolt-enabled docking station to my work laptop,
the following lockdep warning is reported on v5.3.0-rc6+ as of Thursday
morning (can look up the exact git id if so required):
thunderbolt 0-1: new device found, vendor=0xd4 device=0xb070
thunderbolt 0-1: Dell WD19TB Thunder
ty, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
>
> Signed-off-by: Fuqian Huang
Acked-by: Dominik Brodowski
Thanks,
Dominik
On Sun, May 12, 2019 at 03:18:16AM -0700, h...@zytor.com wrote:
> > Couldn't this parsing of the .xattr-list file and the setting of the xattrs
> > be done equivalently by the initramfs' /init? Why is kernel involvement
> > actually required here?
>
> There are a lot of things that could/should be
On Thu, May 09, 2019 at 01:24:17PM +0200, Roberto Sassu wrote:
> This proposal consists in marshaling pathnames and xattrs in a file called
> .xattr-list. They are unmarshaled by the CPIO parser after all files have
> been extracted.
Couldn't this parsing of the .xattr-list file and the setting of
On Tue, Apr 16, 2019 at 08:45:44PM +0300, Mohan Kumar wrote:
> Switch hardcoded function name with a reference to __func__ making the
> code more maintainable
Thanks for your patch. Are there any other patches pending to this driver?
As noted in Kconfig, the TCIC host briges "are only found on a
On Fri, Mar 15, 2019 at 12:18:13PM +, Al Viro wrote:
> On Fri, Mar 15, 2019 at 12:50:02PM +0100, Dominik Brodowski wrote:
> > On Fri, Mar 15, 2019 at 11:44:45AM +, David Howells wrote:
> > > Dominik Brodowski wrote:
> > >
> > > > [0.839322] RI
On Fri, Mar 15, 2019 at 11:44:45AM +, David Howells wrote:
> Dominik Brodowski wrote:
>
> > [0.839322] RIP: 0010:sysfs_init_fs_context+0x82/0xd0
>
> Could you load your kernel into gdb and then do:
>
> i li *sysfs_init_fs_context+0x82
Doesn't seem n
On Fri, Mar 15, 2019 at 11:34:47AM +, Al Viro wrote:
> On Fri, Mar 15, 2019 at 08:43:07AM +0100, Dominik Brodowski wrote:
> > David, Al,
> >
> > commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context")
> > seems to have introduce
David, Al,
commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context")
seems to have introduced a bug; at least that's the commit I bisected the
following oops down to:
[0.827317] BUG: unable to handle kernel NULL pointer dereference at
0220
[0.829771] #PF er
On Tue, Feb 19, 2019 at 04:54:49PM -0800, Kees Cook wrote:
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index cb28e98a0659..7e0ea4470f8e 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -312,10 +312,16 @@ static __init int setup_d
On Thu, Jan 10, 2019 at 03:50:05PM +0100, Christian Brauner wrote:
> On Tue, Jan 08, 2019 at 08:01:10AM +0100, Dominik Brodowski wrote:
> > On Mon, Jan 07, 2019 at 11:27:00PM +0100, Christian Brauner wrote:
> > > @@ -2833,6 +2836,10 @@ static int __do_proc_doulongvec
On Mon, Jan 07, 2019 at 11:27:00PM +0100, Christian Brauner wrote:
> @@ -2833,6 +2836,10 @@ static int __do_proc_doulongvec_minmax(void *data,
> struct ctl_table *table, int
> break;
> if (neg)
> continue;
> +
On Mon, Dec 10, 2018 at 04:30:05PM +0100, Paul Menzel wrote:
> Dear Linux folks,
>
>
> With Linux 4.14.76, the scaling governor *powersave* is shown as
> being available despite being disabled in the configuration.
Which cpufreq driver do you use? Presumably intel_pstate? That driver
exposes int
> I will queue this up to my kbuild tree
> along with Christoph's clean-up patch set.
Acked-by: Dominik Brodowski
Thanks,
Dominik
On Sun, Nov 25, 2018 at 07:33:54PM +0100, Thomas Gleixner wrote:
> + prctl - Indirect branch speculation is enabled,
> + but mitigation can be enabled via prctl
s/can be/is only/ or "must be".
Thanks,
Dominik
within #ifdef CONFIG_ACPI/#endif conditional compile.
>
> Any ideas how to fix this?
This isn't in 4.19.0, but in current mainline, and can be fixed by this
patch which is already on its way upstream.
https://patchwork.kernel.org/patch/10653593/
Thanks,
Dominik
Da
While at it, add a few comments which config options #ifdef
and #else statements refer to.
Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency attribute")
Cc: Srinivas Pandruvada
Cc: Rafael J. Wysocki
Signed-off-by: Dominik Brodowski
diff --git a/drivers/cpufreq/intel_
On Tue, Oct 23, 2018 at 12:17:28PM -0700, Srinivas Pandruvada wrote:
> On Tue, 2018-10-23 at 20:54 +0200, Dominik Brodowski wrote:
> > Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency
> > attribute")
> Thanks for the fix.
>
> > Cc: Srinivas
Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency attribute")
Cc: Srinivas Pandruvada
Cc: Rafael J. Wysocki
Cc: Len Brown
Signed-off-by: Dominik Brodowski
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 49c0abf2d48f..50c5699970c5 10
On Sun, Mar 18, 2018 at 04:12:10PM +0100, Harald Welte wrote:
> Hi Jia-Ju Bai,
>
> On Sun, Mar 18, 2018 at 10:49:57PM +0800, Jia-Ju Bai wrote:
> > This is found by a static analysis tool named DCNS written by myself.
>
> nice catch!
>
> > Signed-off-by: Jia-Ju Bai
>
> Acked-by: Harald Welte
On Mon, Jul 30, 2018 at 09:42:56PM +0800, Jia-Ju Bai wrote:
> pcmcia_fixup_iowidth() and pcmcia_enable_device() are
> never called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool
On Sun, Sep 09, 2018 at 01:21:06AM +0200, Maciej S. Szmigiero wrote:
> Currently, "disable_clkrun" yenta_socket module parameter is only
> implemented for TI CardBus bridges.
> Add also an implementation for Ricoh bridges that have the necessary
> setting documented in publicly available datasheets
Commit-ID: 8ecc4979b1bd9c94168e6fc92960033b7a951336
Gitweb: https://git.kernel.org/tip/8ecc4979b1bd9c94168e6fc92960033b7a951336
Author: Dominik Brodowski
AuthorDate: Tue, 22 May 2018 11:05:39 +0200
Committer: Thomas Gleixner
CommitDate: Wed, 23 May 2018 10:55:52 +0200
x86/speculation
On Tue, May 22, 2018 at 04:06:44PM +0100, Marc Zyngier wrote:
> If running on a system that performs dynamic SSBD mitigation, allow
> userspace to request the mitigation for itself. This is implemented
> as a prctl call, allowing the mitigation to be enabled or disabled at
> will for this particul
cpu_no_spec_store_bypass as well.
Signed-off-by: Dominik Brodowski
---
arch/x86/kernel/cpu/common.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 78decc3e3067..2fcc1fbf11b0 100644
--- a/arch
On Tue, May 15, 2018 at 09:22:23AM +0100, Mark Rutland wrote:
> On Mon, May 14, 2018 at 10:24:45PM +0200, Dominik Brodowski wrote:
> > On Mon, May 14, 2018 at 12:41:10PM +0100, Mark Rutland wrote:
> > > I agree it would be nicer if it had a wrapper that took a pt_regs, eve
On Tue, May 15, 2018 at 10:53:51AM +0100, Mark Rutland wrote:
> On Mon, May 14, 2018 at 10:34:14PM +0200, Dominik Brodowski wrote:
> > On Mon, May 14, 2018 at 06:14:28PM +0100, Mark Rutland wrote:
> > > On Mon, May 14, 2018 at 10:46:35AM +0100, Mark Rutland wrote:
> > &
On Mon, May 14, 2018 at 12:41:10PM +0100, Mark Rutland wrote:
> I agree it would be nicer if it had a wrapper that took a pt_regs, even
> if it does nothing with it.
>
> We can't use SYSCALL_DEFINE0() due to the fault injection muck, we'd
> need a ksys_ni_syscall() for our traps.c logic, and addin
call syscalls (i.e., sys_xyzyyz()) directly.
* Instead, use one of the functions which work equivalently, such as
* the ksys_xyzyyz() functions prototyped below.
*/
Once you have done so, feel free to add my
Reviewed-by: Dominik Brodowski
tag to this patch.
Thanks,
Dominik
On Mon, May 14, 2018 at 10:46:40AM +0100, Mark Rutland wrote:
> Note that we play games with sys_ni_syscall(). It can't be defined with
> SYSCALL_DEFINE0() because we must avoid the possibility of error
> injection. Additionally, there are a couple of locations where we need
> to call it from C cod
> +static void __invoke_syscall(struct pt_regs *regs, syscall_fn_t syscall_fn)
> +{
> + regs->regs[0] = syscall_fn(regs->regs[0], regs->regs[1],
> +regs->regs[2], regs->regs[3],
> +regs->regs[4], regs->regs[5]);
> +}
Any specific
For v4.17-rc1, the naming of syscall stubs changed. Update stack
traces and similar instances in the documentation to avoid sources
for confusion.
Signed-off-by: Dominik Brodowski
diff --git a/Documentation/admin-guide/bug-hunting.rst
b/Documentation/admin-guide/bug-hunting.rst
index
For v4.17-rc1, the naming of syscall stubs changed. Update the
perf scripts/utils/tests which need to be aware of the syscall
stub naming accordingly.
Signed-off-by: Dominik Brodowski
diff --git a/tools/perf/arch/powerpc/util/sym-handling.c
b/tools/perf/arch/powerpc/util/sym-handling.c
index
uot;syscalls/core, syscalls/x86: Rename struct
> pt_regs-based sys_*() to __x64_sys_*()")
> Signed-off-by: Steven Rostedt (VMware)
Acked-by: Dominik Brodowski
> Added back original compare to not miss 32bit kernel syscalls
s/32bit/32bit and 0-parameter syscalls.
Looks good otherwise.
Thanks,
Dominik
On Tue, Apr 17, 2018 at 12:39:27PM -0400, Steven Rostedt wrote:
> > > names, they do not match the default compare algorithm. As this was a
> > > problem for power pc, the algorithm can be overwritten by the
> > > architecture.
> > > The solution is to have x86 have its own algorithm to do the com
Steven,
On Tue, Apr 17, 2018 at 11:54:40AM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> Arnaldo noticed that the latest kernel is missing the syscall event system
> directory in x86. I bisected it down to d5a00528b58c ("syscalls/core,
> syscalls/x86: Rename struct pt_regs-b
On Mon, Apr 16, 2018 at 11:01:57AM +0200, Geert Uytterhoeven wrote:
> On Mon, Apr 16, 2018 at 3:55 AM, Linus Torvalds
> wrote:
> > We actually have a fair amount of other removal and cleanups too. I
> > was somewhat pleasantly surprised by the number of pull requests that
> > actually ended up rem
Commit-ID: e145242ea0df6b7d28fd7186e61d6840fa4bb06e
Gitweb: https://git.kernel.org/tip/e145242ea0df6b7d28fd7186e61d6840fa4bb06e
Author: Dominik Brodowski
AuthorDate: Mon, 9 Apr 2018 12:51:42 +0200
Committer: Ingo Molnar
CommitDate: Mon, 9 Apr 2018 16:47:27 +0200
syscalls/core
Commit-ID: c76fc98260751e71c884dc1a18a07e427ef033b5
Gitweb: https://git.kernel.org/tip/c76fc98260751e71c884dc1a18a07e427ef033b5
Author: Dominik Brodowski
AuthorDate: Mon, 9 Apr 2018 12:51:45 +0200
Committer: Ingo Molnar
CommitDate: Mon, 9 Apr 2018 16:47:28 +0200
syscalls/x86: Adapt
Commit-ID: d5a00528b58cdb2c71206e18bd021e34c4eab878
Gitweb: https://git.kernel.org/tip/d5a00528b58cdb2c71206e18bd021e34c4eab878
Author: Dominik Brodowski
AuthorDate: Mon, 9 Apr 2018 12:51:44 +0200
Committer: Ingo Molnar
CommitDate: Mon, 9 Apr 2018 16:47:28 +0200
syscalls/core
Commit-ID: 5ac9efa3c50d7caff9f3933bb8a3ad1139d92d92
Gitweb: https://git.kernel.org/tip/5ac9efa3c50d7caff9f3933bb8a3ad1139d92d92
Author: Dominik Brodowski
AuthorDate: Mon, 9 Apr 2018 12:51:43 +0200
Committer: Ingo Molnar
CommitDate: Mon, 9 Apr 2018 16:47:28 +0200
syscalls/core
Gerst
Cc: Denys Vlasenko
Cc: H. Peter Anvin
Cc: Josh Poimboeuf
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Signed-off-by: Dominik Brodowski
---
arch/x86/include/asm/syscall_wrapper.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/x86/include/asm
ro
Cc: Andrew Morton
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Brian Gerst
Cc: Denys Vlasenko
Cc: H. Peter Anvin
Cc: Josh Poimboeuf
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Signed-off-by: Dominik Brodowski
---
Documentation/process/adding-syscalls.rst | 4 +-
arch/x86/entry/syscalls/sysc
off-by: Dominik Brodowski
---
arch/x86/entry/syscalls/syscall_32.tbl | 424 -
arch/x86/include/asm/syscall_wrapper.h | 35 +-
include/linux/syscalls.h | 17 +-
scripts/bloat-o-meter | 2 +-
4 files changed, 242 insertions(+), 236 deletions(-)
r, I could not reproduce such a size regression
on local i386 builds.
Thanks,
Dominik
Dominik Brodowski (4):
syscalls: clean up syscall stub naming convention
syscalls: clean up compat syscall stub naming convention
syscalls: rename struct pt_regs-based sys_*() to __x64_
waitid as we need
a compat variant here.
Suggested-by: Ingo Molnar
Cc: Linus Torvalds
Cc: Al Viro
Cc: Andrew Morton
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Brian Gerst
Cc: Denys Vlasenko
Cc: H. Peter Anvin
Cc: Josh Poimboeuf
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Signed-off
On Mon, Apr 09, 2018 at 09:06:11AM +0200, Ingo Molnar wrote:
>
> * Ingo Molnar wrote:
>
> >
> > * Dominik Brodowski wrote:
> >
> > > On Sun, Apr 08, 2018 at 10:35:50AM +0200, Ingo Molnar wrote:
> > > > - _sys_waitid() # ridiculous
On Mon, Apr 09, 2018 at 08:45:11AM +0200, Ingo Molnar wrote:
>
> * Dominik Brodowski wrote:
>
> > On Sun, Apr 08, 2018 at 10:35:50AM +0200, Ingo Molnar wrote:
> > > - _sys_waitid() # ridiculous number of underscores?
> > > - __sys_waitid
On Mon, Apr 09, 2018 at 08:49:45AM +0200, Ingo Molnar wrote:
>
> * Dominik Brodowski wrote:
>
> > +emit_stub() {
> > +entry="$1"
> > +if [ "${entry}" != "${entry#__ia32_sys_}" ]; then
> > + # We need a stub named __ia32
On Sun, Apr 08, 2018 at 11:15:36AM +0200, Dominik Brodowski wrote:
> On a somewhat related note: I'll try to prepare a patch this evening which
> lets us build just the __ia32_sys and __x32_compat_sys stubs we actually
> need. We have that information already in entry/syscalls/sysca
Make the code in syscall_wrapper.h more readable by naming the stub macros
similar to the stub they provide. While at it, fix a stray newline at the
end of the __IA32_COMPAT_SYS_STUBx macro.
Signed-off-by: Dominik Brodowski
diff --git a/arch/x86/include/asm/syscall_wrapper.h
b/arch/x86/include
On Sun, Apr 08, 2018 at 10:35:50AM +0200, Ingo Molnar wrote:
> - _sys_waitid() # ridiculous number of underscores?
> - __sys_waitid() # too generic sounding?
... and we'd need to rename internal helpers in net/
> - __inline_sys_waitid() # too long?
sounds acceptable, thou
patch.
Suggested-by: Ingo Molnar
Cc: Linus Torvalds
Cc: Al Viro
Cc: Andrew Morton
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Brian Gerst
Cc: Denys Vlasenko
Cc: H. Peter Anvin
Cc: Josh Poimboeuf
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Signed-off-by: Dominik Brodowski
---
arch/x86/entry/sy
as we need a compat variant here.
Suggested-by: Ingo Molnar
Cc: Linus Torvalds
Cc: Al Viro
Cc: Andrew Morton
Cc: Andy Lutomirski
Cc: Borislav Petkov
Cc: Brian Gerst
Cc: Denys Vlasenko
Cc: H. Peter Anvin
Cc: Josh Poimboeuf
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Signed-off-by: Dominik Brodowsk
: Andy Lutomirski
Cc: Borislav Petkov
Cc: Brian Gerst
Cc: Denys Vlasenko
Cc: H. Peter Anvin
Cc: Josh Poimboeuf
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Signed-off-by: Dominik Brodowski
---
Documentation/process/adding-syscalls.rst | 4 +-
arch/x86/entry/syscalls/syscall_32.tbl
for i386-tinyconfig due to the first patch of this series. That seems to be a
false positive, as it likely doesn't take into account the change to
scripts/bloat-o-meter. Moreover, I could not reproduce such a size regression
on local i386 builds.
Thanks,
Dominik
Dominik Brodow
Commit-ID: 6dc936f175cc6d12a8eb14d29b87e9238e460383
Gitweb: https://git.kernel.org/tip/6dc936f175cc6d12a8eb14d29b87e9238e460383
Author: Dominik Brodowski
AuthorDate: Thu, 5 Apr 2018 11:53:06 +0200
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 16:59:39 +0200
syscalls/x86: Extend
Commit-ID: f8781c4a226319fe60e652118b90cf094ccfe747
Gitweb: https://git.kernel.org/tip/f8781c4a226319fe60e652118b90cf094ccfe747
Author: Dominik Brodowski
AuthorDate: Thu, 5 Apr 2018 11:53:05 +0200
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 16:59:38 +0200
syscalls/x86
Commit-ID: ebeb8c82ffaf94435806ff0b686fffd41dd410b5
Gitweb: https://git.kernel.org/tip/ebeb8c82ffaf94435806ff0b686fffd41dd410b5
Author: Dominik Brodowski
AuthorDate: Thu, 5 Apr 2018 11:53:04 +0200
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 16:59:38 +0200
syscalls/x86: Use
Commit-ID: 7303e30ec1d8fb5ca1f07c92d069241c32b2ee1b
Gitweb: https://git.kernel.org/tip/7303e30ec1d8fb5ca1f07c92d069241c32b2ee1b
Author: Dominik Brodowski
AuthorDate: Thu, 5 Apr 2018 11:53:03 +0200
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 16:59:38 +0200
syscalls/core: Prepare
Commit-ID: fa697140f9a20119a9ec8fd7460cc4314fbdaff3
Gitweb: https://git.kernel.org/tip/fa697140f9a20119a9ec8fd7460cc4314fbdaff3
Author: Dominik Brodowski
AuthorDate: Thu, 5 Apr 2018 11:53:02 +0200
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 16:59:26 +0200
syscalls/x86: Use
Commit-ID: 1bd21c6c21e848996339508d3ffb106d505256a8
Gitweb: https://git.kernel.org/tip/1bd21c6c21e848996339508d3ffb106d505256a8
Author: Dominik Brodowski
AuthorDate: Thu, 5 Apr 2018 11:53:01 +0200
Committer: Ingo Molnar
CommitDate: Thu, 5 Apr 2018 16:59:25 +0200
syscalls/core
On Fri, Apr 06, 2018 at 04:14:52PM +0200, Christoph Hellwig wrote:
> Hi Dominik,
>
> can you try current Linus' master with the following hack applied and
> see if that works?
>
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index 47aeb04c1997..32aacd0d56a8 100644
> --- a/lib/swiotlb.c
> +++ b/li
On Fri, Apr 06, 2018 at 02:34:20PM +0200, Ingo Molnar wrote:
>
> * Dominik Brodowski wrote:
>
> > > > __sys_mprotect as prefix won't work by the way, as the
> > > > double-underscore __sys_
> > > > variant is already used in net/* for inter
On Fri, Apr 06, 2018 at 11:20:46AM +0200, Ingo Molnar wrote:
>
> * Dominik Brodowski wrote:
>
> > On Fri, Apr 06, 2018 at 10:23:22AM +0200, Ingo Molnar wrote:
> > >
> > > * Dominik Brodowski wrote:
> > >
> > > > On Thu, Apr 05, 2018 at 0
On Fri, Apr 06, 2018 at 10:23:22AM +0200, Ingo Molnar wrote:
>
> * Dominik Brodowski wrote:
>
> > On Thu, Apr 05, 2018 at 05:19:33PM +0200, Ingo Molnar wrote:
> > > Ok, this series looks mostly good to me, but AFAICS this breaks the UML
> > > build:
> >
On Fri, Apr 06, 2018 at 10:23:22AM +0200, Ingo Molnar wrote:
>
> * Dominik Brodowski wrote:
>
> > On Thu, Apr 05, 2018 at 05:19:33PM +0200, Ingo Molnar wrote:
> > > Ok, this series looks mostly good to me, but AFAICS this breaks the UML
> > > build:
> >
On Fri, Apr 06, 2018 at 02:14:18AM +0100, Mark Brown wrote:
> On Thu, Apr 05, 2018 at 10:56:57PM +0200, Dominik Brodowski wrote:
> > Christoph,
> >
> > unfortunately, commit 6e4bf5867783 breaks sound on my Dell XPS13, see the
> > dmesg diff between fec777c385b6 and 6e4b
Christoph,
unfortunately, commit 6e4bf5867783 breaks sound on my Dell XPS13, see the
dmesg diff between fec777c385b6 and 6e4bf5867783:
-sst-acpi INT3438:00: DesignWare DMA Controller, 8 channels
-haswell-pcm-audio haswell-pcm-audio: Direct firmware load for
intel/IntcPP01.bin failed with error -
quot;
Cc: Andi Kleen
Cc: x...@kernel.org
Signed-off-by: Dominik Brodowski
diff --git a/arch/x86/entry/syscalls/syscalltbl.sh
b/arch/x86/entry/syscalls/syscalltbl.sh
index d71ef4bd3615..d6376b87ecb2 100644
--- a/arch/x86/entry/syscalls/syscalltbl.sh
+++ b/arch/x86/entry/syscalls/syscalltbl.sh
@@
no real "default" calling
convention any more. Therefore, I'd suggest *NOT* to apply this patch.
Thanks,
Dominik
Dominik Brodowski (7):
syscalls: introduce CONFIG_ARCH_HAS_SYSCALL_WRAPPER
syscalls/x86: use struct pt_regs based syscall calling for 64-bit
syscalls
While it may make sense to name different things differently, I am not so
sure that the additional code is worth it here...
Cc: Linus Torvalds
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: Andi Kleen
Cc: x...@kernel.org
Signed-off-by: Dominik Brodowski
---
arch
entry_SYSCALL_compat and
entry_INT80_compat.
Cc: Thomas Gleixner
Cc: Andi Kleen
Cc: Ingo Molnar
Cc: Andrew Morton
Cc: Al Viro
Cc: Andy Lutomirski
Cc: Denys Vlasenko
Cc: Brian Gerst
Cc: Peter Zijlstra
Cc: Linus Torvalds
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Signed-off-b
heavily modified by me, in particular to base it on
ARCH_HAS_SYSCALL_WRAPPER.
Cc: Thomas Gleixner
Cc: Andi Kleen
Cc: Ingo Molnar
Cc: Andrew Morton
Cc: Al Viro
Cc: Andy Lutomirski
Cc: Denys Vlasenko
Cc: Brian Gerst
Cc: Peter Zijlstra
Cc: Linus Torvalds
Cc: x...@kernel.org
Cc: "H. Pete
: Brian Gerst
Cc: Peter Zijlstra
Cc: Linus Torvalds
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Signed-off-by: Dominik Brodowski
---
arch/x86/Kconfig | 6 +-
arch/x86/entry/common.c | 10 ++
arch/x86/entry/syscall_32.c | 6 +++---
1 - 100 of 675 matches
Mail list logo
