Re: FEC_MPC52xx_MDIO oddness.

2007-10-31 Thread Domen Puncer
On 31/10/07 17:30 +0100, Gabriel C wrote: > Domen Puncer wrote: > > On 31/10/07 10:22 -0400, Dave Jones wrote: > >> The Kconfig for this reads.. > >> > >> +config FEC_MPC52xx_MDIO > >> + bool "MPC52xx FEC MDIO bus driver" >

Re: FEC_MPC52xx_MDIO oddness.

2007-10-31 Thread Domen Puncer
an invalid case, that I wanted to avoid). Domen > > Dave > > -- > http://www.codemonkey.org.uk -- Domen Puncer | Research & Development .

Re: [PATCH] mpc5200: psc-spi driver must not touch port_config or cdm registers

2007-10-23 Thread Domen Puncer
On 23/10/07 21:39 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > port_config and the cdm are the responsibility of firmware; and if > firmware doesn't set it up correctly, it should be fixed up by > platform code on a per-board basis because it's a property of the > board.

Re: [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl()

2007-07-28 Thread Domen Puncer
On 29/07/07 00:02 +0200, Jesper Juhl wrote: > Hi, > > Here's a small patch, prompted by a find by the Coverity checker, > that removes a potential NULL pointer dereference from > drivers/net/sb1000.c::sb1000_dev_ioctl(). > The checker spotted that we do a NULL test of 'dev', yet we > dereferenc

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
07 at 04:52:12PM +0200, Takashi Iwai wrote: > > > > > > > At Tue, 17 Jul 2007 15:02:30 +0200, > > > > > > > Sam Ravnborg wrote: > > > > > > > > > > > > > > > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: >

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
> > > > > On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: > > > > > At Tue, 17 Jul 2007 15:02:30 +0200, > > > > > Sam Ravnborg wrote: > > > > > > > > > > > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Dome

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 10:31 +0200, Adrian Bunk wrote: > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > > Introduce __init_exit, which is useful ie. for drivers that call > > cleanup functions when they fail in __init functions. > > > > > > Signed-off-b

[PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- include/linux/init.h |2 ++ 1 file changed, 2 insertions(+) Index: work-powerpc.git/include/linux/

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-06 Thread Domen Puncer
On 02/08/05 00:02 +0200, Jiri Slaby wrote: > Hello. > Could you send me critics and bugs? You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot. > Could somebody test it (but NOT now)? > Thanks. > > drivers/char/

2.6.13-rc4-kj

2005-07-29 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Patchset is at http://coderock.org/kj/2.6.13-rc4-kj/ new in this release: time_after-drivers_net_eth16i From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Subject: [KJ] [PATCH] drivers/net/eth16i.c : Use

Re: [PATCH][1/3] ppc32: add 440ep support

2005-07-28 Thread Domen Puncer
On 27/07/05 18:56 -0400, Paul Mackerras wrote: > Andrew Morton writes: > > > Matt Porter <[EMAIL PROTECTED]> wrote: > > > > > > +static u64 dma_mask = 0xULL; How about just DMA_32BIT_MASK from dma-mapping.h, that one has to be correct. ;-) > > > > I'm sure you're totally uninterested in

2.6.13-rc3-kj

2005-07-13 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Lots of new patches this time! Patchset is at http://coderock.org/kj/2.6.13-rc3-kj/ new in this release: flashpoint_01-remove_unused_things From: Alexey Dobriyan <[EMAIL PROTECTED]> Subject: [KJ] [PATCH

Re: kernel guide to space

2005-07-12 Thread Domen Puncer
On 12/07/05 10:12 +0300, Denis Vlasenko wrote: > > 3c. * in types > > Leave space between name and * in types. > > Multiple * dont need additional space between them. > > > > struct foo **bar; > > unless you declare a fuction: > > int* > function_style_for_easy_grep(...) > { >

2.6.13-rc2-kj

2005-07-06 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Patchset is at http://coderock.org/kj/2.6.13-rc2-kj/ new in this release: sparse-net From: Victor Fusco <[EMAIL PROTECTED]> Subject: Re: [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings [UPDATE 2/2

Re: [KJ] 2.6.13-rc2-kj (Should work now, was: (Broken Link))

2005-07-06 Thread Domen Puncer
That's what happens if you close the console with reminder to copy. :-) Domen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at h

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Domen Puncer
On 21/04/05 09:36 -0400, Ed L Cashin wrote: > "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: > > > Ed L Cashin <[EMAIL PROTECTED]> wrote: > > ... > >> + /sys/module/aoe/parameters/aoe_iflist instead of > > ^^^ > > > > Why does the module name need to

Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version

2005-04-19 Thread Domen Puncer
On 19/04/05 15:46 +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > In article <[EMAIL PROTECTED]> (at Tue, 19 Apr 2005 09:18:10 +0300), Denis > Vlasenko <[EMAIL PROTECTED]> says: > > > diff -urpN 2.6.12-rc2.1.be/include/linux/bitops.h > > 2.6.12-rc2.2.ror/include/linux/bitops.h > > --- 2.6.12-rc2

Re: [patch 1/1] nbd: Don't create all MAX_NBD devices by default all the time

2005-04-14 Thread Domen Puncer
On 14/04/05 13:23 +0200, Lars Marowsky-Bree wrote: > From: Lars Marowsky-Bree <[EMAIL PROTECTED]> > > This patches adds the "nbds_max" parameter to the nbd kernel module, > which limits the number of nbds allocated. Previously, always all 128 > entries were allocated unconditionally, which used to

Re: 2.6.12-rc2: Compose key doesn't work

2005-04-14 Thread Domen Puncer
On 10/04/05 11:52 +0200, Rene Herman wrote: > Hi Vojtech. > > I have mapped my right windows key to "Compose" in X: ... > > This worked fine upto 2.6.11.7, but doesn't under 2.6.12-rc2. The key > doesn't seem to be doing anything anymore: "Compose-'-e" just gets me > "'e" and so on. I can con

Re: [PATCH 0/5] autoparam

2005-04-09 Thread Domen Puncer
On 21/03/05 00:06 +0100, Magnus Damm wrote: > Here are a set of patches that makes it possible to autogenerate kernel > command > line documentation from the source code. The approach is rather > straightforward > - the parameter name, the type and the description are stored in a section > calle

Re: [patch 3/8] lib/c: documentation strncpy()

2005-04-08 Thread Domen Puncer
this clarifys the documentation on the behavier of strncpy(). From: walter harms <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- [Geez, again, next time i'll send them to myself first] kj-domen/lib/string.c |4 1 files changed, 4 insertions(

2.6.12-rc2-kj

2005-04-05 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Patchset is at http://coderock.org/kj/2.6.12-rc2-kj/ new in this release: bug-lib_sort.patch From: Daniel Dickman <[EMAIL PROTECTED]> Subject: [KJ] [patch 1/1] fix lib/sort regression test comment-

Re: [patch 4/4 with proper signed-off] security/selinux/ss/conditional.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/conditional.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff -puN security/selinux/ss/conditio

Re: [patch 3/4 with proper signed-off] security/selinux/ss/avtab.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/avtab.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN security/selinux/ss/avtab.c~sparse-security_selinux_ss_avtab securit

Re: [patch 2/4 with proper signed-off] security/selinux/ss/ebitmap.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/ebitmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN security/selinux/ss/ebitmap.c~sparse-security_selinux_ss_ebitm

Re: [patch 1/4 with proper signed-off] security/selinux/ss/policydb.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/policydb.c | 35 ++-- 1 files changed, 20 insertions(+), 15 deletions(-) diff -puN security/selinux/ss/polic

Re: [patch 4/4 with proper signed-off] crypto/tea.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/tea.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN crypto/tea.c~sparse-crypto_tea crypto/tea.c --- kj/crypto/tea.c~sparse-crypto_tea

Re: [patch 3/4 with proper signed-off] crypto/blowfish.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/blowfish.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN crypto/blowfish.c~sparse-crypto_blowfish crypto/blowfish.c --- kj/crypt

Re: [patch 2/4 with proper signed-off] crypto/sha512.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/sha512.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN crypto/sha512.c~sparse-crypto_sha512 crypto/sha512.c --- kj/crypto/sha512.c~sparse-c

Re: [patch 1/4 with proper signed-off] crypto/sha256.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/sha256.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c --- kj/crypto/sha256.c~sparse-c

Re: [patch 10/10 with proper signed-off] arch/i386/crypto/aes.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/crypto/aes.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/crypto/aes.c~sparse-arch_i386_crypto_aes arch/i386/crypto/aes.c

Re: [patch 09/10 with proper signed-off] arch/i386/mm/fault.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/mm/fault.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN arch/i386/mm/fault.c~sparse-arch_i386_mm_fault arch/i386/mm/fault.c --- kj/

Re: [patch 08/10 with proper signed-off] arch/i386/kernel/apm.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/kernel/apm.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN arch/i386/kernel/apm.c~sparse-arch_i386_kernel_apm arch/i386/kernel/

Re: [patch 07/10 with proper signed-off] arch/i386/kernel/traps.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/kernel/traps.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff -puN arch/i386/kernel/traps.c~sparse-arch_i386_kernel_traps arch

Re: [patch 06/10 with proper signed-off] init/do_mounts_initrd.c: fix sparse warning

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/init/do_mounts_initrd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN init/do_mounts_initrd.c~sparse-init_do_mounts_initrd init/do_mounts_ini

2.6.12-rc1-kj

2005-03-18 Thread Domen Puncer
lauser <[EMAIL PROTECTED]> Subject: [KJ] [UPDATE PATCH 2/3] drivers/block/sx8.c: Use the DMA_{64, 32}BIT_MASK constants dma_mask-drivers_block_umem.patch From: Tobias Klauser <[EMAIL PROTECTED]> Subject: [KJ] [UPDATE PATCH 3/3] drivers/block/umem.c: Use the DMA_{64, 32}BIT_MASK constants

Re: [ patch 1/5] drivers/serial/jsm: new serial device driver

2005-03-14 Thread Domen Puncer
On 14/03/05 12:35 -0500, Wen Xiong wrote: > Domen Puncer wrote: > > >Just some nitpicking... > > > > > > > Hi Domen, all, > > Thanks for your comments. I did some minor changes for patch1 based on > Domen's comment. > And i missed, what is p

Re: [patch 2/3] cdrom/cdu31a update

2005-03-13 Thread Domen Puncer
Use semaphores instead of sleep_on*. Stolen from patch: http://lkml.org/lkml/2004/12/18/107 from Ondrej Zary <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Acked-by: Ondrej Zary <[EMAIL PROTECTED]> --- ./drivers/cdrom/cdu31a.c.orig2 2005-03-13 14:12:

Re: [patch 1/3] cdrom/cdu31a update

2005-03-13 Thread Domen Puncer
Pretty trivial cleanups: - reordered #includes - improved some printk's (note: this actually enabled some debug printk's) - removed ()'s from returns - removed SONY_POLL_EACH_BYTE, as grep doesn't find it anywhere else - removed panic() as it can't happen. Signed-off

Re: [patch 3/3] cdrom/cdu31a update

2005-03-13 Thread Domen Puncer
Use wait_event instead of sleep_on. Also, remove two unused variables. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Acked-by: Ondrej Zary <[EMAIL PROTECTED]> --- ./drivers/cdrom/cdu31a.c.orig3 2005-03-06 22:04:42.0 +0100 +++ ./drivers/cdrom/cdu31a.c2005

[patch 0/3] cdrom/cdu31a update

2005-03-13 Thread Domen Puncer
Hi. These cdu31a patches are based on http://lkml.org/lkml/2004/12/18/107 from Ondrej Zary <[EMAIL PROTECTED]> Split into three files (see replies): 1 - printk and other trivial cleanups 2 - semaphorifization (hey, i invented a new word) 3 - use wait_event instead of sleep_on in irq handling Pat

Re: [ patch 1/5] drivers/serial/jsm: new serial device driver

2005-03-12 Thread Domen Puncer
Just some nitpicking... On 11/03/05 10:29 -0500, Wen Xiong wrote: > + * Globals > + */ > +int jsm_driver_state = DRIVER_INITIALIZED; > +spinlock_t jsm_board_head_lock = SPIN_LOCK_UNLOCKED; DEFINE_SPINLOCK() > +LIST_HEAD(jsm_board_head); > + > +static struct pci_device_id jsm_pci_tbl[]

Re: [patch 07/12] Re: radio-sf16fmi cleanup

2005-03-08 Thread Domen Puncer
ers must > switch over to, umm, `radio-sf16fmi.io=', yes? Right. > > > > > Signed-off-by: Marcel Sebek <[EMAIL PROTECTED]> > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > > --- > > > > > > kj-domen/Documentation/kernel-par

Re: [BK PATCH] I2C patches for 2.6.11

2005-03-08 Thread Domen Puncer
On 05/03/05 22:55 -0800, Greg KH wrote: > On Sat, Mar 05, 2005 at 12:59:02PM +0100, Jean Delvare wrote: > > Hi Greg, > > > > > Here is a I2C update for 2.6.11. It includes a number of fixes, and > > > some new i2c drivers. All of these patches have been in the past few > > > -mm releases. > > >

Re: [PATCH] whitespace cleanups for fs/cifs/file.c

2005-03-07 Thread Domen Puncer
or ctags will make your life much easier here. > > I now return you to your regularly scheduled programming. > > bob > > -Original Message- > From: > [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > org]On Behalf Of Jesper Juhl > Sent: Freitag, 4. März 2005

Re: [patch 2/8] isdn/capi: replace interruptible_sleep_on() with wait_event_interruptible()

2005-03-07 Thread Domen Puncer
compile-tested. > > > > Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > > --- > > > > > > kj-domen/drivers/isdn/capi/capi.c |9 ++--- > > 1 files changed, 2 insertions

Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

2005-03-06 Thread Domen Puncer
On 07/03/05 00:07 +, Ralph Corderoy wrote: > > Hi Domen, > > > - if (db->dict) { > > - vfree (db->dict); > > - db->dict = NULL; > > - } > > + vfree (db->dict); > > + db->dict = NULL; > > Is it really worth always cal

Re: [patch 2/6] 12/34: cdrom/cdu31a: replace interruptible_sleep_on() with wait_event_interruptible()

2005-03-06 Thread Domen Puncer
(still throws > >out warnings > >regarding {save,restore}_flags()). > > > >Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> > >Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > Uh, this one escaped me, as schedule() (sleep_on) after cli() is clearly wr

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-07 Thread Domen Puncer
On 07/02/05 07:59 -0800, Randy.Dunlap wrote: > Mikkel Krautz wrote: > >And, here's an updated version of hid-core.c: > > > >Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> > >--- > >--- clean/drivers/usb/input/hid-core.c > >+++ dirty/drivers/usb/input/hid-core.c ... > >+ > >+static unsigned int hi

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-06 Thread Domen Puncer
I'm a bit late, sorry. Haven't seen these mentioned in replies: On 03/02/05 17:43 -0500, Stephen Evanchik wrote: > +int tp_sens = TP_DEF_SENS; > +module_param_named(sens, tp_sens, uint, 0); > +MODULE_PARM_DESC(sens, "Sensitivity"); I don't see out-of-file usages... these could be static. ... >

2.6.11-rc2-kj

2005-01-22 Thread Domen Puncer
Another release from kernel janitors (http://kerneljanitors.org/) This one contains 194 patches. Mail me if I missed any patches. Feedback is appreciated, especially for some not so trivial patches like wait_event ones. Patchset is at http://coderock.org/kj/2.6.11-rc2-kj/ new in this release: -