On 1/29/19 6:02 AM, Sean Wang wrote:
> On Mon, Jan 28, 2019 at 2:35 PM Dmitry Voytik wrote:
>>
>> How to reproduce the problem:
>> $ make tinyconfig
>> $ make menuconfig
>> then enable:
>> CONFIG_COMPILE_TEST=y
>> CONFIG_PINCTRL=y
>
depend on CONFIG_OF=y.
Signed-off-by: Dmitry Voytik
---
drivers/pinctrl/mediatek/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index 1817786ab6aa..a005cbccb4f7 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b
After commit ef05bcb60, boot from USB drives is broken.
Fix this problem by enabling usb-host regulators during boot time.
Signed-off-by: Dmitry Voytik
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328
Fix potential NULL pointer dereference wich might happen in
beiscsi_alloc_mem(). If kmalloc_array() fails and mem_descr->mem_array
is set to NULL, then its dereferencing happens when passing
mem_descr->mem_array[] to dma_free_coherent().
Signed-off-by: Dmitry Voytik
---
Changes si
Wrap BUG() branches with unlikely() where it is possible. Use BUG_ON()
instead of "if () BUG();" where it is feasible.
Signed-off-by: Dmitry Voytik
---
mm/bootmem.c| 6 +++---
mm/filemap.c| 2 +-
mm/huge_memory.c| 4 ++--
mm/memory.c | 3 ++-
mm/memory
Signed-off-by: Dmitry Voytik
---
include/asm-generic/bug.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 630dd23..b0aa488 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -43,6 +43,10 @@ struct
Refactor mxc_iomux_mode():
- since it always returns 0 make it to return void
- remove unnecessary ret variable
- declare variables according to the kernel coding style
Signed-off-by: Dmitry Voytik
---
arch/arm/mach-imx/iomux-imx31.c | 8
arch/arm/mach-imx/iomux-mx3.h | 2 +-
2
ret variable is redundant. Call clk_pllv3_wait_lock() in the end
return.
Signed-off-by: Dmitry Voytik
---
arch/arm/mach-imx/clk-pllv3.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/arm/mach-imx/clk-pllv3.c b/arch/arm/mach-imx/clk-pllv3.c
index 57de74d..0ad6e54
Drop unnecessary semicolon after closing curly bracket.
Signed-off-by: Dmitry Voytik
---
arch/arm/mach-imx/clk-imx6q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
index 1412daf..43f376f 100644
--- a/arch/arm
Hi Peter,
On Tue, Nov 04, 2014 at 12:21:55PM +, Peter Chen wrote:
> > > -int mxc_iomux_mode(unsigned int pin_mode)
> > > +void mxc_iomux_mode(unsigned int pin_mode)
> > > {
> > > - u32 field, l, mode, ret = 0;
> > > + u32 field;
> > > + u32 l;
> > > + u32 mode;
> > > void __iomem *reg;
> >
Hi Shawn,
Any comments on this?
Thanks.
On Tue, Oct 21, 2014 at 06:35:51PM +0400, Dmitry Voytik wrote:
> Refactor mxc_iomux_mode():
> - since it always returns 0 make it to return void
> - remove unnecessary ret variable
> - declare variables according to the kernel coding style
On Sat, Oct 18, 2014 at 09:04:43PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/18/2014 8:03 AM, Balavasu wrote:
>
> >-static int check_routers_before_use = 0;
> >+static int check_routers_before_use = {0};
>
>Eh? I thought {} is only for arrays/structures...
It seems like this is from
Refactor mxc_iomux_mode():
- since it always returns 0 make it to return void
- remove unnecessary ret variable
- declare variables according to the kernel coding style
Signed-off-by: Dmitry Voytik
---
arch/arm/mach-imx/iomux-imx31.c | 8
arch/arm/mach-imx/iomux-mx3.h | 2 +-
2
ret variable is redundant. Call clk_pllv3_wait_lock() in the end
return.
Signed-off-by: Dmitry Voytik
---
arch/arm/mach-imx/clk-pllv3.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/arm/mach-imx/clk-pllv3.c b/arch/arm/mach-imx/clk-pllv3.c
index 57de74d..0ad6e54
Drop unnecessary semicolon after closing curly bracket.
Signed-off-by: Dmitry Voytik
---
arch/arm/mach-imx/clk-imx6q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
index 1412daf..43f376f 100644
--- a/arch/arm
On Wed, Sep 10, 2014 at 5:21 PM, Al Viro wrote:
> On Wed, Sep 10, 2014 at 01:20:19PM +0400, Dmitry Voytik wrote:
>> Use seq_putc() instead of seq_printf() in seq_pad() because the
>> former is faster.
>
> _Solitary_ seq_putc() is certainly going to be faster, but that
Use seq_putc() instead of seq_printf() in seq_pad() because the
former is faster.
Signed-off-by: Dmitry Voytik
---
fs/seq_file.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index 3857b72..fef338e 100644
--- a/fs/seq_file.c
+++ b/fs
On Mon, Sep 8, 2014 at 7:41 PM, Joe Perches wrote:
> On Mon, 2014-09-08 at 18:16 +0400, Dmitry Voytik wrote:
>> Fix coding style issues:
>> * put braces in all if-else branches;
>> * limit the length of changed lines to 80 columns.
>> checkpatch.pl warning count reduce
Fix coding style issues:
* put braces in all if-else branches;
* limit the length of changed lines to 80 columns.
checkpatch.pl warning count reduces by 3.
Signed-off-by: Dmitry Voytik
Reviewed-by: Joe Perches
---
drivers/staging/android/binder.c | 16 ++--
1 file changed, 10
Fix coding style issues:
* put braces in all if-else branches;
* limit the length of changed lines to 80 columns.
checkpatch.pl warning count reduces by 3.
Signed-off-by: Dmitry Voytik
---
drivers/staging/android/binder.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions
On Fri, Sep 5, 2014 at 10:48 PM, Greg Kroah-Hartman
wrote:
> On Fri, Sep 05, 2014 at 08:02:24PM +0400, Dmitry Voytik wrote:
>> Variable cmd_name must be initialised as variable name is.
>
> Why? What bug does this fix? Have you tested this change? Does this
> cause
Variable cmd_name must be initialised as variable name is.
Signed-off-by: Dmitry Voytik
---
drivers/staging/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 4f34dc0..93b067f 100644
Add "lowmemorykiller:" prefix to the debug print so it's easier to
analyse LMK's debug output:
dmesg | grep lowmemorykiller
Signed-off-by: Dmitry Voytik
---
drivers/staging/android/lowmemorykiller.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --g
On Fri, Mar 15, 2013 at 03:08:52PM -0700, David Rientjes wrote:
> > Ick, no, please use the proper interface for this (i.e. pr_fmt).
> >
>
> And I'm sure that mysterious new "lmk:" messages appearing in the kernel
> log will be understood by about 0.1% of people.
David, Greg,
Thank you for
Add "lmk:" prefix to the debug print so it's easier to analyse LMK's
debug output:
dmesg | grep lmk
Signed-off-by: Dmitry Voytik
---
drivers/staging/android/lowmemorykiller.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/
Add alternative vi-style keys for the menu navigation:
/ for down/up navigation, / for
page down/up, / for first/last menu item selection
and for entering to a submenu.
Signed-off-by: Dmitry Voytik
---
scripts/kconfig/nconf.c | 29 ++---
1 file changed, 22 insertions
Hi Michal,
Please don't apply this patch. I am going to send the new version.
Thank you.
On Fri, Dec 21, 2012 at 11:12:25PM +0400, Dmitry Voytik wrote:
> Add vi-style keys for menu navigation: press j/k for down/up navigation
> and l for entering to a submenu. Unfortantely h key is r
On Fri, Dec 21, 2012 at 12:23:41PM -0800, Stephen Boyd wrote:
> On 12/21/12 11:12, Dmitry Voytik wrote:
> > Add vi-style keys for menu navigation: press j/k for down/up navigation
> > and l for entering to a submenu. Unfortantely h key is reserved for
> > the items help.
&g
Add vi-style keys for menu navigation: press j/k for down/up navigation
and l for entering to a submenu. Unfortantely h key is reserved for
the items help.
Signed-off-by: Dmitry Voytik
---
scripts/kconfig/nconf.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git
29 matches
Mail list logo
