[PATCH] FS: add_partition silently ignored errors

2007-11-06 Thread Dirk Hohndel
ff-by: Dirk Hohndel <[EMAIL PROTECTED]> --- block/ioctl.c |9 +++-- fs/partitions/check.c | 35 --- include/linux/genhd.h |2 +- 3 files changed, 36 insertions(+), 10 deletions(-) diff --git a/block/ioctl.c b/block/ioctl.c index 52d6385..662

Re: [PATCH] add_partition silently ignored errors

2007-11-02 Thread Dirk Hohndel
On Fri, Nov 02, 2007 at 03:50:29PM -0400, Bob Copeland wrote: > On 11/2/07, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > @@ -554,8 +573,11 @@ int rescan_partitions(struct gendisk *disk, struct > > > > block_device *bdev) > > > >

Re: [PATCH] add_partition silently ignored errors

2007-11-02 Thread Dirk Hohndel
On Fri, Nov 02, 2007 at 02:04:39PM +0100, Jens Axboe wrote: > > > > > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, > > > > > > with > > > > > > the correct return values, the patch then looks fine to me. > > > > So Al, are you ok with this one? Still haven't seen f

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Dirk Hohndel
On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: > On Tue, 30 Oct 2007 09:56:08 -0700, > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, with > > > > the correct return

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Dirk Hohndel
On Tue, Oct 30, 2007 at 10:09:34AM +0100, Cornelia Huck wrote: > On Tue, 30 Oct 2007 09:07:42 +0100, > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > -void add_partition(struct gendisk *disk, int part, sector_t start, > > > sector_t len, int flags) > > > +int add_partition(struct gendisk *

Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

2007-10-29 Thread Dirk Hohndel
/D [PATCH] hidinput_connect ignores retval from input_register_device signed-off-by: Dirk Hohndel &l

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Dirk Hohndel
gt;part_uevent_suppress) > > + kobject_uevent(&p->kobj, KOBJ_REMOVE); > > + kobject_del(&p->kobj); > > You need a kobject_put() here to drop the reference you obtained in > kobject_init(). done We should be getting close

Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

2007-10-29 Thread Dirk Hohndel
On Mon, Oct 29, 2007 at 10:49:03AM -0400, Jeff Garzik wrote: > Dmitry Torokhov wrote: > > On 10/29/07, Jiri Kosina <[EMAIL PROTECTED]> wrote: > >> On Mon, 29 Oct 2007, Dirk Hohndel wrote: > >> > >>> [INPUT] hidinput_connect incorrectly ignored

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Dirk Hohndel
On Mon, Oct 29, 2007 at 02:06:57PM +0100, Cornelia Huck wrote: > On Mon, 29 Oct 2007 05:22:11 -0700, > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > @@ -390,20 +390,31 @@ void add_partition(struct gendisk *disk, int part, > > sector_t start, sector_t le

[PATCH] pciserial_resume_one ignored return value of pci_enable_device

2007-10-29 Thread Dirk Hohndel
[PATCH] pciserial_resume_one ignored return value of pci_enable_device Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- drivers/serial/8250_pci.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c index 0

[PATCH] add_partition silently ignored errors

2007-10-29 Thread Dirk Hohndel
Yet another issue where we ignore errors - this needs someone to make sure that I am passing around the right error codes (and am cleaning up correctly) [PATCH] add_partition silently ignored errors Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- block/ioctl.c |5 +++

Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

2007-10-29 Thread Dirk Hohndel
gned-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- drivers/hid/hid-input.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index dd332f2..880161b 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-in

[PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

2007-10-28 Thread Dirk Hohndel
[INPUT] hidinput_connect incorrectly ignored return value from input_register_device Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- drivers/hid/hid-input.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-i

Re: [Ksummit-2007-discuss] Re: [Ksummit-2006-discuss] 2007 LinuxKernel Summit

2007-01-31 Thread Dirk Hohndel
On 1/31/07 3:30 PM, "H. Peter Anvin" <[EMAIL PROTECTED]> wrote: > Gerrit Huizenga wrote: >> Don't confused KS with a conference; >> it is a workshop for a very, very large, very very active project. > > ... and *growing*, which is the real issue I think. > > Something that might make sense for K

Re: [Ksummit-2007-discuss] Re: [Ksummit-2006-discuss] 2007 LinuxKernel Summit

2007-01-29 Thread Dirk Hohndel
On 1/29/07 8:22 PM, "Greg Ungerer" <[EMAIL PROTECTED]> wrote: >>> Yep. IIRC the CPU architects panel was all x86/x86_64/ppc too wasn't it? >> >> I thought there was coldfire mentioned too, or maybe my memory is >> playing tricks on me. Maybe I'm misremembering the ppc bit. > > Your right, the p

Re: [Ksummit-2007-discuss] Re: [Ksummit-2006-discuss] 2007 LinuxKernel Summit

2007-01-29 Thread Dirk Hohndel
On 1/29/07 8:10 PM, "Dave Jones" <[EMAIL PROTECTED]> wrote: > > Again, I don't recall us spending any time at all discussing m68k, or > sparc, whilst the others you mention were well represented. Well, others where represented, I was there looking after non-mmu m68k for ex

Re: [Ksummit-2006-discuss] 2007 Linux Kernel Summit

2007-01-25 Thread Dirk Hohndel
On 1/25/07 12:51 PM, "David Miller" <[EMAIL PROTECTED]> wrote: >>> For the first time in many years I'm strongly considering actually >>> going to the kernel summit, however if it goes back to Ottawa I >>> definitely will stop going again. >> >> Is that specific to Ottawa, or is this any North Ame

Re: [Ksummit-2006-discuss] 2007 Linux Kernel Summit

2007-01-25 Thread Dirk Hohndel
On 1/23/07 9:57 AM, "David Miller" <[EMAIL PROTECTED]> wrote: >> Definitely disagree with that. I'd like to see the conference somewhere >> else different this time - perhaps Czech Republic, or somewhere else more >> easterly and Linux active (or even Finland...) > > This is my position as well.