Re: [PATCH v7 00/16] Device / Driver PCI / Platform Rust abstractions

2024-12-19 Thread Dirk Behme
; > - PCI: > - remove `Deref` of `pci::DeviceId` > - rename `DeviceId` constructors > - `new` -> `from_id` > - `with_class -> `from_class` > > - MISC: > - use `kernel::ffi::c_*` instead of `core::ffi::c_*` > - rebase onto latest rust-next (0c5

Re: [PATCH v6 00/16] Device / Driver PCI / Platform Rust abstractions

2024-12-12 Thread Dirk Behme
qemu. Additionally cross compiled for arm64 and will try it on real hardware once I have it available. But previous versions of this series have been fine on that, already. No issues observed for running the samples and for the examples/KUnit. So: Tested-by: Dirk Behme Many thanks! Dirk

[tip: irq/core] softirq: s/BUG/WARN_ONCE/ on tasklet SCHED state not set

2021-03-17 Thread tip-bot2 for Dirk Behme
The following commit has been merged into the irq/core branch of tip: Commit-ID: 6b2c339df90788ce6aeecee78d6494f262929206 Gitweb: https://git.kernel.org/tip/6b2c339df90788ce6aeecee78d6494f262929206 Author:Dirk Behme AuthorDate:Wed, 17 Mar 2021 11:20:12 +01:00 Committer

[PATCH 0/1] tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe()

2021-02-05 Thread Dirk Gouders
s would then hit the WARN_ONCE(), as well. Dirk [1] https://lore.kernel.org/linux-integrity/20201001180925.13808-5-james.bottom...@hansenpartnership.com/ [2] https://lore.kernel.org/linux-integrity/3936843b-c0da-dd8c-8aa9-90aa3b49d...@linux.ibm.com/T/#t Dirk Gouders (1): tpm_tis: han

[PATCH 1/1] tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe()

2021-02-05 Thread Dirk Gouders
latter case platform_get_irq_optional() often if not always returns a valid IRQ number on the first attempt. Harmonize builtin and module behavior by returning -EPROBE_DEFER, effectively putting the device on the deferred probe list for later probe attempts. Signed-off-by: Dirk Gouders --- drivers

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-03 Thread Dirk Gouders
Dirk Gouders writes: > Lukasz Majczak writes: > >> There are missing calls to tpm_request_locality before the calls to >> the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions >> internally send commands to the tpm. As the current >> approach mig

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Dirk Gouders
efore doing a TPM operation. >*/ > In this case we don't have to call tpm_try_get_ops() > as both calls (tpm_get_timeouts() and tpm_tis_probe_irq_single()) are > in the tpm_tis_core_init function and don't require any locking or clock > enablement. Similar

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Dirk Gouders
on these Intel machines as well. > > Fixes: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs") > Reported-by: Serge Belyshev > Reported-by: Dirk Gouders > Signed-off-by: Thomas Gleixner > --- > V2: Provide the actual delta patch. Should have stayed away f

Re: [PATCH V2] rtc: mc146818: Detect and handle broken RTCs

2021-01-31 Thread Dirk Gouders
gistered as rtc0 [2.785036] rtc_cmos 00:01: setting system clock to 2021-01-31T10:13:40 UTC (1612088020) [2.785713] rtc_cmos 00:01: alarms up to one month, y3k, 114 bytes nvram, hpet irqs Dirk [7.258410] [ cut here ] [7.258414] WARNING: CPU: 2

Re: [PATCH 1/1] iommu/vt-d: Add qi_submit trace event

2021-01-31 Thread Dirk Gouders
_qi_submit(iommu, desc[i].qw0, desc[i].qw1, | ^~~ cc1: some warnings being treated as errors On my machine CONFIG_INTEL_IOMMU is not set so #include cannot provide the prototype for that function. Dirk > --- > drivers/iommu/intel/dmar.c |

Re: [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-01-31 Thread Dirk Gouders
sdhci ccp cfg80211 rng_core tpm_tis tpm_tis_core tpm thinkpad_acpi(+) wmi nvram pinctrl_amd You might notice there is another warning but that is rtc related and I still have to find out if that is something I should report. Dirk [1] https://lore.kernel.org/linux-integrity/20201001180925.13808-1-jam

Re: WARN_ONCE triggered: tpm_tis: Add a check for invalid status

2020-10-14 Thread Dirk Gouders
James Bottomley writes: > On Wed, 2020-10-14 at 19:57 +0200, Dirk Gouders wrote: >> On my laptop the check introduced with 55707d531af62b (tpm_tis: Add a >> check for invalid status) triggered the warning (output below). >> >> So, my laptop seems to be a candidate

WARN_ONCE triggered: tpm_tis: Add a check for invalid status

2020-10-14 Thread Dirk Gouders
On my laptop the check introduced with 55707d531af62b (tpm_tis: Add a check for invalid status) triggered the warning (output below). So, my laptop seems to be a candidate for testing. Dirk [7.255467] [ cut here ] [7.255468] TPM returned invalid status

Re: [PATCH 1/1] drm/amdgpu: fix NULL pointer dereference for Renoir

2020-10-01 Thread Dirk Gouders
Dirk Gouders writes: > Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) > introduced a NULL pointer dereference when booting with > amdgpu.discovery=0, because it removed the call of vega10_reg_base_init() > for that case. > > Fix this by calli

[PATCH 1/1] drm/amdgpu: fix NULL pointer dereference for Renoir

2020-10-01 Thread Dirk Gouders
that amdgpu_discovery_reg_base_init() failed. Fixes: c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) Signed-off-by: Dirk Gouders Cc: Hawking Zhang Cc: Evan Quan --- drivers/gpu/drm/amd/amdgpu/soc15.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH 0/1] drm/amdgpu: fix NULL pointer dereference for Renoir

2020-10-01 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 30, 2020 at 4:46 PM Dirk Gouders wrote: >> >> Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) >> introduced a NULL pointer dereference when booting with >> amdgpu.discovery=0. >> >> For amdgpu.disc

BUG: amdgpu: NULL pointer dereference introduced in 5.9-rc1

2020-09-30 Thread Dirk Gouders
_init(adev); } - } + } else + vega10_reg_base_init(adev); break; case CHIP_VEGA20: vega20_reg_base_init(adev); Dirk

[PATCH] ./Makefile: consider PAGER for `make help'

2020-09-29 Thread Dirk Gouders
`make help' outputs more than a screenfull of lines. In case a user has PAGER defined in his environment, she most likely wants it to be used in such situations. Signed-off-by: Dirk Gouders --- Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile b/Makefile

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-27 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 23, 2020 at 3:45 PM Dirk Gouders wrote: >> >> Dirk Gouders writes: >> >> > Alex Deucher writes: >> > >> >> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >> >>> >> >>> D

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Dirk Gouders writes: > Alex Deucher writes: > >> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >>> >>> Dirk Gouders writes: >>> >>> > Hi, >>> > >>> > I noticed a call trace (attached) when starting my machin

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >> >> Dirk Gouders writes: >> >> > Hi, >> > >> > I noticed a call trace (attached) when starting my machine (ThinkPad >> > L14). This machine is new and I

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Dirk Gouders writes: > Hi, > > I noticed a call trace (attached) when starting my machine (ThinkPad > L14). This machine is new and I am still working on it's > configuration but visually noticeable is that scrolling in xterms with > SHIFT-PgUp/PgDn is broken. Usin

amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-22 Thread Dirk Gouders
been introduced between 5.8 and 5.9-rc1 and I tried to bisect this but always end in situations where I dont't find a bootable commit around the current bisect position. Mainly the machine then hangs when udevd is started. Please let me know if I can help with further information. Dirk =

Haswell Regression in 5.9-rcX and lower 5.7.x, 5.8.x #2024 - Revert 47f8253d2b89 ("drm/i915/gen7: Clear all EU/L3 residual contexts") ?

2020-09-15 Thread Dirk Neukirchen
", "Verified-By" tagging so that [1] can be closed. Greetings, Dirk [1]https://gitlab.freedesktop.org/drm/intel/-/issues/2024

Re: kworker/0:3+pm hogging CPU

2020-09-04 Thread Dirk Kostrewa
! Many thanks for your feedback and help! Best regards, Dirk. Am 01.09.20 um 17:27 schrieb Michal Hocko: On Mon 31-08-20 14:37:10, Mathias Nyman wrote: [...] I can't come up with any good solution to this right now. Only bad ideas such as a. Add a sleep to the over-current case, do

Re: [PATCH v2 1/3] kconfig: error out when seeing recursive dependency

2018-08-15 Thread Dirk Gouders
ng, which I guess was not intentional. > > Get it back to an error again. > > Also, rename the unit test directory "warn_recursive_dep" to > "err_recursive_dep" so that it matches to the behavior. > > Signed-off-by: Masahiro Yamada I tested v2 of this

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-15 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-08-14 19:38 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> Currently, Kconfig does not report anything about the recursive >>> dependency where 'imply' keywords are involved. >>> >

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-14 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> Currently, Kconfig does not report anything about the recursive >> dependency where 'imply' keywords are involved. >> >> [Test Code] >> >> config A >> bool "

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-14 Thread Dirk Gouders
tely seems to get void with your patches is item c) in "Practical solutions to kconfig recursive issue" in Documentation/kbuild/kconfig-language: c) Consider the use of "imply" instead of "select" Dirk > In the code above, Kconfig cannot calculate

[PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory

2018-08-02 Thread Dirk Gouders
The files auto.conf and tristate.conf are mandatory for building modules.builtin files, therefore include them as such. Usually, the top-level Makefile ensures that those files exist but we want to make sure we get noticed if they are missing for whatever reason. Signed-off-by: Dirk Gouders

[PATCH] arm64: Check for errata before evaluating cpu features

2018-07-25 Thread Dirk Mueller
From: Dirk Mueller Since commit d3aec8a28be3b8 ("arm64: capabilities: Restrict KPTI detection to boot-time CPUs") we rely on errata flags being already populated during feature enumeration. The order of errata and features was flipped as part of commit ed478b3f9e4a ("arm64: capa

[PATCH] arm64: Check for errata before evaluating cpu features

2018-07-25 Thread Dirk Mueller
ing of features and errata workarounds"). Return to the orginal order of errata and feature evaluation to ensure errata flags are present during feature evaluation. Fixes: d3aec8a28be3b8 ("arm64: capabilities: Restrict KPTI detection to boot-time CPUs") CC: Suzuki K Poulose CC: Mar

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-20 Thread Dirk Gouders
cate" symbol definitions are used and perhaps this helps you with your reordering. This is just a prototype, that hopefully helps with your current task, so I did not pay too much attention to make it beautiful. Please let me know if anything is missing. Anyway, apply the patch and then invoke

[PATCH v2] checkpatch: kbuild: if_changed: check for multiple calls in targets

2018-07-20 Thread Dirk Gouders
U-BOOT image format) 684151a75bf25f5ae (sparc32: added U-Boot build target: uImage) Reviewed-by: Joe Perches Suggested-by: Masahiro Yamada Signed-off-by: Dirk Gouders --- v2: rework commit message and regular expression --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions

Re: [PATCH] kconfig: handle format string before calling conf_message_callback()

2018-07-17 Thread Dirk Gouders
is patch and found no issues -- perhaps: except that it seems to require another series: kbuild/kconfig: do not update config during installation Dirk > Signed-off-by: Masahiro Yamada > --- > > scripts/kconfig/confdata.c | 17 +++-- > scripts/kconfig/lkc_proto.h

Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-17 Thread Dirk Gouders
Joe Perches writes: > On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: >> Because the kbuild function if_changed writes the command line to a >> .cmd file for later tests, multiple calls of that function within a >> target would result in overwrites of previous v

[PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Dirk Gouders
: Masahiro Yamada Signed-off-by: Dirk Gouders --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 447857ffaf6b..b0aadf23148e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2911,6 +2911,14 @@ sub

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-14 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-12 20:32 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>>> Dirk Gouders writes: >>>> >>>> I think, I solved the puzzle and perhaps, that saves

Re: [PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-13 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-10 20:34 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> The main motivation of this patch series is to suppress the syncconfig >>> during running installation targets. >>> >>> V1 consisted of o

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-12 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>> Dirk Gouders writes: >>> >>>> Dirk Gouders writes: >>>> >>>>> Masahiro Yamada writes: >>>>> >>>>&g

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-12 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >> Dirk Gouders writes: >> >>> Dirk Gouders writes: >>> >>>> Masahiro Yamada writes: >>>> >>>>> syncconfig updates the .config only when sym_cha

Re: [PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-10 Thread Dirk Gouders
xed or even noticed, because of -include and I wonder if it is safer to also change the -includes in that file. It seems, if one of those files is missing, one must have done it manually or some other serious issue is present that we probably want to notice. Dirk > kbuild: replace in

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-09 Thread Dirk Gouders
Dirk Gouders writes: > Dirk Gouders writes: > >> Masahiro Yamada writes: >> >>> syncconfig updates the .config only when sym_change_count > 0, i.e. >>> any change in config symbols has been detected. >>> >>> Not only symbols but als

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-06 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> syncconfig updates the .config only when sym_change_count > 0, i.e. >> any change in config symbols has been detected. >> >> Not only symbols but also comments are contained in the .config file. >> If

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-06 Thread Dirk Gouders
ot/header.o LD arch/x86/boot/setup.elf OBJCOPY arch/x86/boot/setup.bin OBJCOPY arch/x86/boot/vmlinux.bin BUILD arch/x86/boot/bzImage Setup is 15580 bytes (padded to 15872 bytes). System is 8069 kB CRC e01d75ec Kernel: arch/x86/boot/bzImage is ready (#15) Building modules, stage 2.

[RFC v9 1/1] mconf: global i-search in menu prompts

2018-06-23 Thread Dirk Gouders
existing text. It was extended by a parameter "height" and in combination with the parameter "width" it now makes sure that the whole region (width x height) is overwritten. * The function conf() now returns the key the user pressed so that calling functions can operate de

[RFC v9 0/1] mconf: global i-search in menu prompts

2018-06-23 Thread Dirk Gouders
Hello, v9 of this RFC mainly fixes an issue reported by Randy, I tested this fix a lot and it seems it is ready to send out. Dirk Changes in v9: * Move global variable declarations to lxdialog/dialog.h * Don't do unnecessary initialization of isearch_str. * Fix an issue with '-&#x

Re: [RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-21 Thread Dirk Gouders
Randy Dunlap writes: > On 06/20/2018 11:55 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi, >>> >>> On 06/20/2018 01:42 AM, Dirk Gouders wrote: >>>> >>>> Operation >>>> - >>>> The TAB

Re: [RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
Randy Dunlap writes: > Hi, > > On 06/20/2018 01:42 AM, Dirk Gouders wrote: >> >> Operation >> - >> The TAB key is reserved to toggle the focus between menu and bottons. >> Focus is on the buttons if one of the buttens (the active one) is >&

[RFC v8 0/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
fig a bool "a" config b bool "b / a" depends on a config c bool "c / a" menu "d / a" config e bool "e / a" endmenu config f bool "f / a" Dirk Changes in v8: * Get rid of flat_array and us

[RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
existing text. It was extended by a parameter "height" and in combination with the parameter "width" it now makes sure that the whole region (width x height) is overwritten. * The function conf() now returns the key the user pressed so that calling functions can operate de

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > On 06/19/2018 11:47 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi Dirk, >>> >>> On 06/17/2018 05:15 AM, Dirk Gouders wrote: >>>> >>>> At any time, at most one i-search is active and the nav

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > Hi Dirk, > > On 06/17/2018 05:15 AM, Dirk Gouders wrote: >> >> At any time, at most one i-search is active and the navigation path to >> the current menu is displayed in the subtitle, the second line in the >> menu window. > > Nic

[RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-17 Thread Dirk Gouders
tion conf() now returns the key the user pressed so that calling functions can operate depending on that key. Signed-off-by: Dirk Gouders --- scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdialog/dialog.h| 3 +- scripts/kconfig/lxdialog/inputbox.c | 2 +- scripts/

[RFC v7 0/1] mconf: global i-search in menu prompts

2018-06-17 Thread Dirk Gouders
A_UNDERLINE was replaced with A_STANDOUT to mark active menu items when the focus is on the buttons, because I tested mconf on a tty where underlines were not visible. For a complete list of changes see below. Dirk Changes in v7: * make menu_isearch() return void * Suggested-by removed, ask for Sam&#

[RFC v6 1/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
simply type 'n', 'f' and 's'. Hint: use the 'z' key with focus on buttons to search for invisible prompts. Signed-off-by: Dirk Gouders Suggested-by: Sam Ravnborg --- scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdialog/dialog.h

[RFC v6 0/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
needed functionality is already there in search_conf(), the search function for config symbols. The menu tree is converted in a flat menu to ease the implementation of a cyclic i-search and the rest of the implementation does no longer interfere so much with current menu handling. Dirk Changes in v6

[RFC v5 0/1] i-search navigation for mconf

2018-06-11 Thread Dirk Gouders
s the ability to not only search item strings, but also their selection marks. So, one can search for items selected as a module, for example. Dirk Changes in v5: * More thoroughly tested code * Hotkey navigation concept completely dropped * Printable characters except special ones form the s

[RFC v5 1/1] i-search navigation for mconf

2018-06-11 Thread Dirk Gouders
# Enter the submenu Suggested-by: Sam Ravnborg Signed-off-by: Dirk Gouders --- scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menubox.c | 489 +++-- scripts/kconfig/lxdialog/util.c| 106 +++- scripts/kconfig/mconf.c

Re: [RFC v4 0/1] i-search functionality for mconf

2018-06-09 Thread Dirk Gouders
Sam Ravnborg writes: > Hi Dirk. > > On Fri, Jun 08, 2018 at 08:46:05PM +0200, Dirk Gouders wrote: >> Hello, >> >> this version is a prototype of the idea, Sam suggested -- I hope I >> undestood it correctly. >> >> This is a remarkable ch

[RFC v4 0/1] i-search functionality for mconf

2018-06-08 Thread Dirk Gouders
earch mode, for a detailed description see 1/1. As stated earlier, this is just a prototype, documentation is missing and the code is not ready for a real commit. Dirk Dirk Gouders (1): Isearch functionality for mconf scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menu

[RFC v4 1/1] i-search functionality for mconf

2018-06-08 Thread Dirk Gouders
This patch prototypes isearch functionality for mconf based on an idea of Sam Ravnborg: * mconf now distinguishes if the focus is on the menu items or the buttons below it. * At startup focus is on the menu items and alphanumeric characters or space entered are used to form a string that is

[RFC v3 1/1] Emacs-like isearch for mconf.

2018-06-08 Thread Dirk Gouders
# navigate to Device Drivers 3) ENTER# terminate isearch and enter submenu 4) \# start isearch 5) USB # navigate to USB support 6) ENTER# terminate isearch and enter submenu Signed-off-by: Dirk Gouders --- Documentation/kbuild

[RFC v3 0/1] Emacs-like isearch for mconf.

2018-06-08 Thread Dirk Gouders
blems with mismatches and matches above the current position were fixed. Dirk Gouders (1): Emacs-like isearch for mconf. Documentation/kbuild/kconfig.txt | 18 +++- scripts/kconfig/lxdialog/dialog.h | 6 ++ scripts/kconfig/lxdialog/menubox.c | 171

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-08 Thread Dirk Gouders
e focus to the buttons, ENTER is reserved to stop searching -- and enter a submenu, depending on the item.) Dirk

[RFC v2 0/1] Emacs-like isearch for mconf.

2018-06-07 Thread Dirk Gouders
processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Documentation/kbuild/kconfig.txt | 18 +++- scripts/kconfig/lxdialog/dialog.h | 6 ++ scripts/kconfig/lxdialog/menubox.c

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-06-07 8:54 GMT+09:00 Dirk Gouders : >> Randy Dunlap writes: >> >>> On 06/06/2018 03:32 PM, Dirk Gouders wrote: >>>> Randy Dunlap writes: >>>> >>>>> On 06/06/2018 02:56 PM, Dirk Gouders wrote: >

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Randy Dunlap writes: > On 06/06/2018 03:32 PM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> On 06/06/2018 02:56 PM, Dirk Gouders wrote: >>>> Hello, >>>> >>>> being an Emacs user, I frequently find myself pressing CTRL-s in m

Re: [RFC 1/1] Emacs-like isearch for mconf.

2018-06-06 Thread Dirk Gouders
Segher Boessenkool writes: > On Wed, Jun 06, 2018 at 11:58:55PM +0200, Dirk Gouders wrote: >> @@ -332,6 +332,7 @@ int init_dialog(const char *backtitle) >> >> keypad(stdscr, TRUE); >> cbreak(); >> +raw(); /* Enable CTRL-sequence

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Randy Dunlap writes: > On 06/06/2018 02:56 PM, Dirk Gouders wrote: >> Hello, >> >> being an Emacs user, I frequently find myself pressing CTRL-s in mconf >> to search for some menu entry, especially in large menus. >> >> I decided to implement a basic

[RFC 1/1] Emacs-like isearch for mconf.

2018-06-06 Thread Dirk Gouders
--- scripts/kconfig/lxdialog/dialog.h | 5 ++ scripts/kconfig/lxdialog/menubox.c | 140 - scripts/kconfig/lxdialog/util.c| 1 + 3 files changed, 145 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog

[RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
anyone find this functionality useful. Thanks, Dirk Dirk Gouders (1): Emacs-like isearch for mconf. scripts/kconfig/lxdialog/dialog.h | 5 ++ scripts/kconfig/lxdialog/menubox.c | 140 - scripts/kconfig/lxdialog/util.c| 1 + 3 files changed, 145

Re: [PATCH 2/3] clk: WARN_ON about to disable a critical clock

2017-07-03 Thread Dirk Behme
On 03.07.2017 16:25, Lee Jones wrote: On Mon, 03 Jul 2017, Dirk Behme wrote: On 03.07.2017 13:53, Lee Jones wrote: On Tue, 27 Jun 2017, Dirk Behme wrote: On 11.02.2016 01:43, Michael Turquette wrote: Quoting Lee Jones (2016-01-18 06:28:50) Signed-off-by: Lee Jones Looks good to me

Re: [PATCH 2/3] clk: WARN_ON about to disable a critical clock

2017-07-03 Thread Dirk Behme
On 03.07.2017 13:53, Lee Jones wrote: On Tue, 27 Jun 2017, Dirk Behme wrote: On 11.02.2016 01:43, Michael Turquette wrote: Quoting Lee Jones (2016-01-18 06:28:50) Signed-off-by: Lee Jones Looks good to me. Regards, Mike --- drivers/clk/clk.c | 6 ++ 1 file changed, 6

Re: [PATCH 2/3] clk: WARN_ON about to disable a critical clock

2017-06-27 Thread Dirk Behme
nable_count 1 (from enabling the child '2'). What results a) in the WARN_ON output and b) enable_count of 'A' never decreases to 0. Being off by one after the WARN_ON It sounds like both is wrong for a configuration like above. Opinions or proposal how to fix/change this? Best regards Dirk [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/clk.c?id=2e20fbf592621b2c2aeddd82e0fa3dad053cce03

Re: [PATCH/RFC 4/4] soc: renesas: Identify SoC and register with the SoC bus

2016-10-05 Thread Dirk Behme
if (!mapped) + return -ENOMEM; + + product = readl(mapped); + iounmap(mapped); + + if (((product >> 8) & 0xff) != soc->id) { + pr_crit("SoC mismatch (product = 0x%x)\n", product); + return -ENODEV; + } + + esi = ((product >> 4) & 0x0f) + 1; + esf = product & 0xf; I'm somehow surprised to see that all SoCs covered here use the same way to encode esi and esf? I would have expected that we need different decoding for different SoCs. But if this isn't the case, even better :) Best regards Dirk

Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

2016-08-08 Thread Dirk Eibach
2016-08-08 15:43 GMT+02:00 Greg KH : > On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eib...@gdsys.cc wrote: >> From: Dirk Eibach >> >> sc16is7xx_port_irq() is laid out as an endless loop. It will exit only >> when there is no more interrupt left to service. This not co

[PATCH 2/2] sc16is7xx: Disable regmap cache

2016-08-08 Thread dirk . eibach
From: Dirk Eibach The regcache_cache_bypass() calls are not implemented to be threadsafe. Since I don't see the point in using a regmap cache on an UART interface it is better to disable it alltogether and avoid these problems. Signed-off-by: Dirk Eibach --- drivers/tty/serial/sc16is

[PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

2016-08-08 Thread dirk . eibach
From: Dirk Eibach sc16is7xx_port_irq() is laid out as an endless loop. It will exit only when there is no more interrupt left to service. This not common practice. In our case it lead to some strange hangup situation when there was an unexpected XOFF-interrupt that could not be handled. So let&#

[RFC PATCH] mconf: expand show_all_options to choices' checklist menus

2016-04-30 Thread Dirk Gouders
Boolean choices' checklist menus are currently immune against the 'z' key that toggles visibility of all options. Expansion of the 'z' toggle could be of use when debugging problems with comlex choice menus. A new tag 'z' for dialog_items was introduced for

Re: [PATCH] i2c: imx: use usleep_range(50,100) instead of udelay(50)

2016-04-26 Thread Dirk Behme
On 26.04.2016 13:02, Vladimir Zapolskiy wrote: Hi Dirk, On 26.04.2016 09:27, Dirk Behme wrote: From: Oleksij Rempel Documentation/timers/timers-howto.txt recommends to use usleep_range on delays > 10usec. According to my test results with Neonode zForce touchscreen driver, usleep_ra

[PATCH] i2c: imx: use usleep_range(50,100) instead of udelay(50)

2016-04-25 Thread Dirk Behme
From: Oleksij Rempel Documentation/timers/timers-howto.txt recommends to use usleep_range on delays > 10usec. According to my test results with Neonode zForce touchscreen driver, usleep_range indeed reduces CPU load. Stats collected with "./perf record -a -g -F 1000 sleep 10" i2c-imx with udela

Re: linux-next: Crash in arm_pmu_device_probe() due to 'drivers/perf: arm_pmu: make info messages more verbose'

2016-03-21 Thread Dirk Behme
On 18.03.2016 14:30, Guenter Roeck wrote: Hi Dirk, On 03/18/2016 02:18 AM, Dirk Behme wrote: Hi Guenter, On 18.03.2016 07:44, Guenter Roeck wrote: Hi, I am seeing the attached crash when running a realview-pb-a8 image with realview_defconfig in qemu. bisect wasn't successful, but a c

Re: linux-next: Crash in arm_pmu_device_probe() due to 'drivers/perf: arm_pmu: make info messages more verbose'

2016-03-19 Thread Dirk Behme
if it is NULL. The configuration I am testing does not use devicetree. Can you use dev_info() instead ? Does anything like below [1] does work for you? If so, could you please share the output? I.e. what it prints in your non-devicetree non-pmu case? Best regards Dirk [1] diff --git a/dr

Re: [RFC] namei: prevent sgid-hardlinks for unmapped gids

2015-11-03 Thread Dirk Steinmetz
On Tue, 3 Nov 2015 10:20:38 -0800, Kees Cook wrote: > On Mon, Nov 2, 2015 at 4:39 PM, Dirk Steinmetz > wrote: > > In order to hardlink to a sgid-executable, it is sufficient to be the > > file's owner. When hardlinking within an unprivileged user namespace, the > >

[RFC] namei: prevent sgid-hardlinks for unmapped gids

2015-11-02 Thread Dirk Steinmetz
f the namespace. This is a possible security risk. This change prevents hardlinking of sgid-executables within user namespaces, if the file is not owned by a mapped gid. Signed-off-by: Dirk Steinmetz --- MISSING: Documentation/sysctl/fs.txt not updated, as this patch is intended for discussion

Re: [PATCH] namei: permit linking with CAP_FOWNER in userns

2015-11-02 Thread Dirk Steinmetz
On Wed, 28 Oct 2015 17:33:10 +, Serge Hallyn wrote: > Quoting Dirk Steinmetz (pub...@rsjtdrjgfuzkfg.com): > > On Tue, 27 Oct 2015 20:28:02 +, Serge Hallyn wrote: > > > Quoting Dirk Steinmetz (pub...@rsjtdrjgfuzkfg.com): > > > > On Tue, 27 Oct 2015 09:3

Re: [PATCH] namei: permit linking with CAP_FOWNER in userns

2015-10-28 Thread Dirk Steinmetz
On Tue, 27 Oct 2015 20:28:02 +, Serge Hallyn wrote: > Quoting Dirk Steinmetz (pub...@rsjtdrjgfuzkfg.com): > > On Tue, 27 Oct 2015 09:33:44 -0500, Seth Forshee wrote: > > > I did want to point what seems to be an inconsistency in how > > > capabilities in user

Re: [PATCH] namei: permit linking with CAP_FOWNER in userns

2015-10-27 Thread Dirk Steinmetz
On Tue, 27 Oct 2015 09:33:44 -0500, Seth Forshee wrote: > On Tue, Oct 20, 2015 at 04:09:19PM +0200, Dirk Steinmetz wrote: > > Attempting to hardlink to an unsafe file (e.g. a setuid binary) from > > within an unprivileged user namespace fails, even if CAP_FOWNER is held > >

[PATCH] namei: permit linking with CAP_FOWNER in userns

2015-10-20 Thread Dirk Steinmetz
le to capable_wrt_inode_uidgid"). Signed-off-by: Dirk Steinmetz --- This is the third time I'm sending the patch, as the first two attempts did not provoke a reply. Feel free to point out any issues you see with it -- including formal requirements, as this is the first patch I'm submitting. I

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

2015-10-13 Thread Dirk Behme
e non-removable device and boot fast. Signed-off-by: Heiko Schocher --- Dirk Behme tried to bring this in, last mail I found: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-July/111022.html where Dirk worked in Arnds suggestion to use the "/aliases" device node" The last a

[PATCH] namei: permit linking with CAP_FOWNER in userns

2015-10-10 Thread Dirk Steinmetz
le to capable_wrt_inode_uidgid"). Signed-off-by: Dirk Steinmetz --- fs/namei.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 726d211..29fc6a6 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -955,26 +955,23 @@ static bool safe_hardlink_source(st

Re: [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object

2015-08-06 Thread Dirk Behme
h in mainline as commit b23157dc74272ac8ebffd1a566e3e822dbc3e65f [1] breaks our Atmel touch. It seems that above + set_bit(EV_ABS, input_dev->evbit); is missing in the version which went into mainline? Re-adding it makes it work for us, again. Opinions? Best regards Dirk [1] https://git.kernel.org/cgit

Re: [PATCH] Input: zforce_ts - fix playload length check

2015-07-28 Thread Dirk Behme
seems that at least 4 people have overlooked this issue :( Best regards Dirk Btw: Could anybody give me a hint how to get this warning? My GCC 4.8.1 with kernel default ARM Cortex A9 kernel options doesn't give me anything about this. -- To unsubscribe from this list: send the line &quo

Re: [PATCH] ARM: zynq: Set bit 22 in PL310 AuxCtrl register (6395/1)

2015-05-11 Thread Dirk Behme
nel, but in the boot loader/firmware: https://lkml.org/lkml/2015/2/20/199 http://lists.denx.de/pipermail/u-boot/2015-March/207803.html Best regards Dirk Clearing bit 22 in the PL310 Auxiliary Control register (shared attribute override enable) has the side effect of transforming Normal Shared Non-

Re: [PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-21 Thread Dirk Gouders
Bobby Powers writes: > Hi, > > Dirk Gouders wrote: >> Yes, I was suggesting something similar (but without founded reasoning), >> some time ago [1]. > > I submitted a patch for this a few days ago, but I didn't realize I > should CC linux-kbuild@ (my bad): &

Re: [PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-20 Thread Dirk Gouders
Ingo Molnar writes: > * Dirk Gouders wrote: > >> For example on Gentoo systems where _FORTIFY_SOURCE is set by default, >> `make -C tools/perf' fails, because of the macro being redefined. >> >> Fix that by a feature-check analogous to tools/perf/config/M

[PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-20 Thread Dirk Gouders
For example on Gentoo systems where _FORTIFY_SOURCE is set by default, `make -C tools/perf' fails, because of the macro being redefined. Fix that by a feature-check analogous to tools/perf/config/Makefile. Signed-off-by: Dirk Gouders --- tools/lib/api/Makefile | 9 - 1 file chang

Re: [PATCH 1/2 V6] intel_pstate: skip this driver if Sun server has _PPC method

2014-12-01 Thread Dirk Brandewie
On 11/30/2014 06:32 PM, Ethan Zhao wrote: Oracle Sun X86 servers have dynamic power capping capability that works via ACPI _PPC method etc, so skip loading this driver if Sun server has ACPI _PPC enabled. Signed-off-by: Ethan Zhao Signed-off-by: Dirk Brandewie Tested-by: Linda Knippers In

Re: [PATCH 1/2 v3] intel_pstate: skip this driver if Sun server has _PPC method

2014-11-25 Thread Dirk Brandewie
On 11/24/2014 08:59 PM, Ethan Zhao wrote: Oracle Sun X86 servers have dynamic power capping capability that works via ACPI _PPC method etc, so skip loading this driver if Sun server has ACPI _PPC enabled. How about this patch? only compile tested. diff --git a/drivers/cpufreq/intel_pstate.c b

  1   2   3   4   5   >