Remove unused event code and other cleanup for HUB RTC.
Signed-off-by: Dimitri Sivanich
---
arch/x86/platform/uv/uv_time.c | 362 +
1 file changed, 8 insertions(+), 354 deletions(-)
diff --git a/arch/x86/platform/uv/uv_time.c b/arch/x86/platform/uv
forthcoming platforms
based on Intel Cooper Lake and Sapphire Rapids processors. Some cleanup is
already being included as part of a forthcoming patchset in support of the
upcoming Sapphire Rapids platform.
Nacked-by: Dimitri Sivanich
On Mon, May 04, 2020 at 07:15:16PM +0200, Christoph Hellwig
While a reduction in object size is welcome, in this case it does come at the
expense of some clarity, as field sizes are no longer as clear.
Nevertheless, will add my ack.
Acked-by: Dimitri Sivanich
On Mon, Oct 07, 2019 at 11:30:46AM -0700, Joe Perches wrote:
> Use seq_puts and simple str
Reviewed-by: Dimitri Sivanich
On Mon, Aug 19, 2019 at 01:08:55AM +0530, Bharath Vedartham wrote:
> is_vm_hugetlb_page will always return false if CONFIG_HUGETLB_PAGE is
> not set.
>
> Cc: Ira Weiny
> Cc: John Hubbard
> Cc: Jérôme Glisse
> Cc: Greg Kroah-Hartman
> Cc
Reviewed-by: Dimitri Sivanich
On Mon, Aug 19, 2019 at 01:08:54AM +0530, Bharath Vedartham wrote:
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
>
> This is p
et_user_pages(). get_user_pages_fast(), on the other
> > hand, first calls __get_user_pages_fast(), but then falls back to the
> > slow path if __get_user_pages_fast() fails.
> >
> > Also: remove unnecessary CONFIG_HUGETLB ifdefs.
> >
> > Cc: Ira Weiny
>
On Wed, Aug 14, 2019 at 03:58:34PM +, Jason Gunthorpe wrote:
> On Thu, Aug 08, 2019 at 12:25:56PM +0200, Christoph Hellwig wrote:
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig
>
> Dimitri, are you OK with this patch?
>
I think this looks OK.
Reviewed-by: Dimitri Sivanich
On Tue, Aug 13, 2019 at 10:53:01PM +0530, Bharath Vedartham wrote:
> On Tue, Aug 13, 2019 at 09:50:29AM -0500, Dimitri Sivanich wrote:
> > Bharath,
> >
> > I do not believe that __get_user_pages_fast will work for the atomic case,
> > as
> > there is no guarant
ifdefs.
>
> Cc: Ira Weiny
> Cc: John Hubbard
> Cc: Jérôme Glisse
> Cc: Greg Kroah-Hartman
> Cc: Dimitri Sivanich
> Cc: Arnd Bergmann
> Cc: William Kucharski
> Cc: Christoph Hellwig
> Cc: linux-kernel@vger.kernel.org
> Cc: linux...@kvack.org
> Cc: linux-
Yes, the GRU driver is still maintained, and I have been in contact with Bharath
about my pending testing of his changes.
On Mon, Aug 12, 2019 at 01:05:19AM -0700, Christoph Hellwig wrote:
> Hi dear ex-SGI folks,
>
> do you know if the GRU driver is still maintained and in use?
>
> Both Bharath
For the series:
Reviewed-by: Dimitri Sivanich
On Wed, Feb 13, 2019 at 07:34:09PM +, Hedi Berriche wrote:
> - Changes since v2
> Addressed comments from Ard Biesheuvel:
> * expose efi_runtime_lock to UV platform only instead of globally
> * remove unnecessary #ifdef CON
Acked-by: Dimitri Sivanich
On Fri, Dec 21, 2018 at 10:44:19PM +, Colin King wrote:
> From: Colin Ian King
>
> There are a couple of statements that have extra spaces in the identation,
> fix this by removing them.
>
> Signed-off-by: Colin Ian King
> ---
> drivers
Acked-by: Dimitri Sivanich
On Thu, Sep 13, 2018 at 01:53:18PM -0500, Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
&
Acked-by: Dimitri Sivanich
On Wed, Apr 25, 2018 at 10:20:44AM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted
expensive slowpath, such as after
> the oom reaper has grabbed mm->mmap_sem of a still alive oom victim.
>
> Signed-off-by: David Rientjes
Acked-by: Dimitri Sivanich
> ---
> v2:
>- specifically exclude mmu_notifiers without invalidate callbacks
>- move flags to mmu
On Mon, Dec 11, 2017 at 02:11:55PM -0800, David Rientjes wrote:
> --- a/drivers/misc/sgi-gru/grutlbpurge.c
> +++ b/drivers/misc/sgi-gru/grutlbpurge.c
> @@ -298,6 +298,7 @@ struct gru_mm_struct *gru_register_mmu_notifier(void)
> return ERR_PTR(-ENOMEM);
> STAT(gms
Acked-by: Dimitri Sivanich
On Thu, Aug 31, 2017 at 05:17:35PM -0400, jgli...@redhat.com wrote:
> From: Jérôme Glisse
>
> Call to mmu_notifier_invalidate_page() are replaced by call to
> mmu_notifier_invalidate_range() and thus call are bracketed by
> call to mmu_notifier_invalid
Commit-ID: f822798e3ced63427d57d128ee8d118126455f84
Gitweb: http://git.kernel.org/tip/f822798e3ced63427d57d128ee8d118126455f84
Author: Dimitri Sivanich
AuthorDate: Fri, 26 May 2017 23:30:52 +0200
Committer: Thomas Gleixner
CommitDate: Sat, 27 May 2017 12:58:46 +0200
posix-timers
alarm alarmtimer;
ktime_t interval;
} alarm;
On Tue, May 23, 2017 at 07:36:01PM -0500, Dimitri Sivanich wrote:
> Since this is SN2 specific, this can be removed.
>
> On Tue, May 23, 2017 at 05:27:16PM +0200, Thomas Gleixner wrote:
> > On T
Since this is SN2 specific, this can be removed.
On Tue, May 23, 2017 at 05:27:16PM +0200, Thomas Gleixner wrote:
> On Tue, 23 May 2017, Christoph Hellwig wrote:
>
> Cc: + Mike
>
> > Hi folks,
> >
> > what's the status of the SGI support for the IA64 SN2-specific
> > altic mmtimer (drivers/char
On Wed, Oct 26, 2016 at 02:56:57PM +0200, Uwe Kleine-König wrote:
> It makes the result hard to interpret correctly if a base 10 number is
> prefixed by 0x. So change to a hex number.
>
Would like to have this be a decimal number.
Signed-off-by: Dimitri Sivanich
---
drivers/mis
Commit-ID: f68376fc9e6dc15a08e16f08c95e503f19ad8e34
Gitweb: http://git.kernel.org/tip/f68376fc9e6dc15a08e16f08c95e503f19ad8e34
Author: Dimitri Sivanich
AuthorDate: Fri, 29 Apr 2016 16:54:23 -0500
Committer: Ingo Molnar
CommitDate: Wed, 4 May 2016 08:48:51 +0200
x86/platform/UV: Fix
Commit-ID: 40bfb8eedf1e7fa0535c685ff1000c05bcf7a637
Gitweb: http://git.kernel.org/tip/40bfb8eedf1e7fa0535c685ff1000c05bcf7a637
Author: Dimitri Sivanich
AuthorDate: Fri, 29 Apr 2016 16:54:22 -0500
Committer: Ingo Molnar
CommitDate: Wed, 4 May 2016 08:48:51 +0200
x86/platform/UV: Remove
On Wed, Oct 14, 2015 at 10:22:25AM +0530, Sudip Mukherjee wrote:
> On Mon, Oct 05, 2015 at 10:18:32AM -0500, Dimitri Sivanich wrote:
> > On Mon, Oct 05, 2015 at 08:43:07PM +0530, Sudip Mukherjee wrote:
> > > On Thu, Sep 24, 2015 at 12:31:01PM +0530, Sudip Mukherjee wrote:
>
On Mon, Oct 05, 2015 at 08:43:07PM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 24, 2015 at 12:31:01PM +0530, Sudip Mukherjee wrote:
> > On Wed, Sep 23, 2015 at 12:48:25PM -0500, Dimitri Sivanich wrote:
> > > Sudip,
> > >
> > > I can take a look at the Jack Ste
Acked-by: Dimitri Sivanich
On Mon, Sep 21, 2015 at 03:48:19PM +0530, Sudip Mukherjee wrote:
> If kzalloc() fails then gms is NULL and we are returning NULL, but the
> functions which called this function gru_register_mmu_notifier() are not
> expecting NULL as the return. They are
Sudip,
I can take a look at the Jack Steiner patches. Was there anything in the set
of 3 patches that you sent that still needs a review?
On Mon, Sep 21, 2015 at 03:48:16PM +0530, Sudip Mukherjee wrote:
> Hi Dimitri,
> I have taken these patches which were having ACK from you. Apart from
> these
Acked-by: Dimitri Sivanich
On Fri, Sep 04, 2015 at 09:56:20AM +0530, Sudip Mukherjee wrote:
> gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
> not dereference it if it has returned error. And incase it has returned
> error then wait for some time and
On Thu, Sep 03, 2015 at 08:20:50PM +0530, Sudip Mukherjee wrote:
> gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
> not dereference it if it has returned error. And incase it has returned
> error then wait for some time and try again.
>
> Signed-off-by: Sudip Mukherjee
>
Acked-by: Dimitri Sivanich
On Thu, Sep 03, 2015 at 08:20:51PM +0530, Sudip Mukherjee wrote:
> dw was only assigned some value and was never reused.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> v2: It was part of first patch in v1. But since one logical change in
> one
Acked-by: Dimitri Sivanich
On Thu, Sep 03, 2015 at 08:20:47PM +0530, Sudip Mukherjee wrote:
> If the buffer is too small then return the error and in the process
> remove the variables which became unused.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> v1: only removed var
On Thu, Sep 03, 2015 at 10:10:12AM +0530, Sudip Mukherjee wrote:
> On Wed, Sep 02, 2015 at 09:42:04AM -0500, Dimitri Sivanich wrote:
> > On Wed, Sep 02, 2015 at 04:54:55PM +0530, Sudip Mukherjee wrote:
> > > These variables were only assigned some value and were never used.
>
On Wed, Sep 02, 2015 at 04:54:58PM +0530, Sudip Mukherjee wrote:
> gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
> not dereference it if it has returned error. And incase it has returned
> error then just downgrade the write lock and exit.
>
Not sure about this, because
Acked-by: Dimitri Sivanich
On Wed, Sep 02, 2015 at 04:54:57PM +0530, Sudip Mukherjee wrote:
> The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
> it can never be less than 0.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/misc/sgi-gru/grukdump.
Acked-by: Dimitri Sivanich
On Wed, Sep 02, 2015 at 04:54:56PM +0530, Sudip Mukherjee wrote:
> The functions gru_get_cb_exception_detail_str() and gru_abort() were
> only called locally from that file. We can make them static.
>
> Signed-off-by: Sudip Mukherjee
> ---
> dr
On Wed, Sep 02, 2015 at 04:54:55PM +0530, Sudip Mukherjee wrote:
> These variables were only assigned some value and were never used.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> I have removed the variables in the functions gru_dump_tfm() and
> gru_dump_tgh() but it appeared that the intended l
This should be %d, not 0x%x.
Nacked-by: Dimitri Sivanich
On Sun, Aug 02, 2015 at 01:27:27PM -0700, Joe Perches wrote:
> Correct misuse of 0x%d in logging message.
>
> Signed-off-by: Joe Perches
> ---
> drivers/misc/sgi-gru/grumain.c | 2 +-
> 1 file changed, 1 insert
On Fri, Jul 31, 2015 at 10:51:08AM +0530, Viresh Kumar wrote:
> On 30-07-15, 15:04, Christoph Lameter wrote:
> > You need to CC someone at SGI for this I guess. Robin? Nate? Dimitri?
> >
> > I am definitely not the right guy to be on the CC list.
>
> Sorry about that. It happened because get_main
Acked-by: Dimitri Sivanich
On Wed, May 13, 2015 at 09:19:46AM +0100, Colin King wrote:
> From: Colin Ian King
>
> static analysis from smatch found a potential null dereference:
>
> drivers/misc/sgi-gru/grutlbpurge.c:320 gru_register_mmu_notifier() error:
> potential nul
Acked-by: Dimitri Sivanich
On Thu, Jan 01, 2015 at 05:46:47PM +0100, Rickard Strandqvist wrote:
> Remove the function tfh_restart() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: R
Acked-by: Dimitri Sivanich
On Mon, Dec 29, 2014 at 01:31:16PM -0500, Nicholas Mc Guire wrote:
> fix-up for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
>
> V2: split out patch for individual files
info.type = X86_IRQ_ALLOC_TYPE_UV;
info.uv_limit = limit;
info.uv_blade = mmr_blade;
info.uv_offset = mmr_offset;
On Mon, Dec 15, 2014 at 03:37:35PM -0600, Dimitri Sivanich wrote:
> Was this patch ever tested on a UV system?
>
> Also, adding some SGI folks to the CC list, si
Was this patch ever tested on a UV system?
Also, adding some SGI folks to the CC list, since there were none listed before.
On Tue, Nov 25, 2014 at 01:53:31PM +0800, Jiang Liu wrote:
> Enhance UV code to support hierarchy irqdomain, it helps to make
> the architecture more clear.
>
> We should c
Acked-by: Dimitri Sivanich
On Mon, Aug 04, 2014 at 05:58:05PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg
> ---
> drivers/misc/sgi-gru/grumain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grumain.c b/dr
Decimal ("%d" without the "0x") for the ctxnum please.
Nacked-by: Dimitri Sivanich
On Sun, Aug 03, 2014 at 05:19:37PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg
> ---
> drivers/misc/sgi-gru/grumain.c | 2 +-
> 1 file changed, 1 insertion(+),
Acked-by: Dimitri Sivanich
On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
> unsigned variable 'gid' is less than zero.
>
> if (req.gid >= gru_max_gids || req.gid <
Acked-by: Dimitri Sivanich
On Wed, Jun 11, 2014 at 08:47:02PM +0200, Fabian Frederick wrote:
> unsigned value is never < 0
>
> Cc: Dimitri Sivanich
> Signed-off-by: Fabian Frederick
> ---
> drivers/misc/sgi-gru/grukdump.c | 2 +-
> 1 file changed, 1 insertion(+),
Acked-by: Dimitri Sivanich
On Fri, May 30, 2014 at 03:40:59PM +0200, Manuel Schölling wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_before() instead of plain, error-prone math.
>
> Signed-off-by: Manuel Schölling
> ---
om which
all calls to gru_vtop() originate.
The gru_find_lock_gts() function takes it when called from
gru_handle_user_call_os(), which then calls gru_user_dropin()->gru_try_dropin().
Nacked-by: Dimitri Sivanich
>
> Signed-off-by: Jonathan Gonzalez V
> Signed-off-by: Davidlohr Bueso
>
Commit-ID: 5f40f7d93898a473eb222aa8064144c1d6835470
Gitweb: http://git.kernel.org/tip/5f40f7d93898a473eb222aa8064144c1d6835470
Author: Dimitri Sivanich
AuthorDate: Mon, 31 Mar 2014 09:37:00 -0500
Committer: Ingo Molnar
CommitDate: Tue, 1 Apr 2014 12:10:44 +0200
x86/UV: Set n_lshift
Commit-ID: fe455b17de6c881eecf4f9784c3b0483a5e3d19e
Gitweb: http://git.kernel.org/tip/fe455b17de6c881eecf4f9784c3b0483a5e3d19e
Author: Dimitri Sivanich
AuthorDate: Mon, 31 Mar 2014 10:23:20 -0500
Committer: Ingo Molnar
CommitDate: Tue, 1 Apr 2014 12:10:45 +0200
x86/UV: Fix conditional
On Mon, Mar 31, 2014 at 09:25:05AM +0200, Ingo Molnar wrote:
> * Dimitri Sivanich wrote:
>
> > +static int gru_unsupported(void)
> > +{
> > + return !is_uv_system() || (is_uvx_hub() && !is_uv2_hub());
> > +}
>
> So the usual pattern is to introduce
On Mon, Mar 31, 2014 at 09:30:11AM +0200, Ingo Molnar wrote:
> * Dimitri Sivanich wrote:
> > @@ -843,12 +843,14 @@ void uv_cpu_init(void)
> > void __init uv_system_init(void)
> > {
> > union uvh_rh_gam_config_mmr_u m_n_config;
> > + union uv3
ease at minimum factor out a helper routine so that such
> mismatches cannot happen.
>
Agreed. Here's a new patch.
Fix supported system conditional in gru_exit.
Signed-off-by: Dimitri Sivanich
---
drivers/misc/sgi-gru/grufile.c |8 ++--
1 file changed, 6 insertions(+), 2 d
of the socket m_val.
Then n_lshift can be assigned a fixed value across a multi-partition system,
allowing for a fixed common global physical address format that is independent
of socket m_val.
Cleanup unneeded macros.
Signed-off-by: Dimitri Sivanich
---
arch/x86/include/asm/uv/uv_hub.h |
Fix conditional in gru_exit to match gru_init.
Signed-off-by: Dimitri Sivanich
---
drivers/misc/sgi-gru/grufile.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/misc/sgi-gru/grufile.c
Set the UV n_lshift value based on the GAM_GR_CONFIG MMR for UV3, making it
independent of the socket m_val.
Remove unneeded macros.
Signed-off-by: Dimitri Sivanich
---
arch/x86/include/asm/uv/uv_hub.h | 12 -
arch/x86/include/asm/uv/uv_mmrs.h | 42
Acked-by: Dimitri Sivanich
On Thu, Jan 30, 2014 at 03:10:48PM +0300, Dan Carpenter wrote:
> "ret" is zero here so we can remove the "!ret" part of the condition.
> "uhdr" is alread a __user pointer so we can remove the cast.
>
> Signed-off-by: Dan
Acked-by: Dimitri Sivanich
On Thu, Jan 30, 2014 at 03:10:44PM +0300, Dan Carpenter wrote:
> I was reviewing this and noticed that unlocking should be conditional on
> the error path. I've changed it to unlock and return directly since we
> only do it once and it seems unlikely to
s]
>
> Signed-off-by: Rashika Kheria
Acked-by: Dimitri Sivanich
> ---
> drivers/misc/sgi-gru/grukservices.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/grukservices.c
> b/drivers/misc/sgi-gru/grukservices.c
&g
Commit-ID: 879d5ad0dc3b096170c8f985b1465de5dca88de8
Gitweb: http://git.kernel.org/tip/879d5ad0dc3b096170c8f985b1465de5dca88de8
Author: Dimitri Sivanich
AuthorDate: Wed, 29 May 2013 10:56:09 -0500
Committer: Ingo Molnar
CommitDate: Thu, 30 May 2013 09:46:09 +0200
x86/UV: Add GRU
pr_debug()?
>
I had set it to what was being used in map_high(), but pr_debug should be OK,
so I changed both instances.
GRU hardware will support an optional distributed mode that will allow
per-node address mapping of local GRU space, as opposed to mapping all GRU
hardware to the same contigu
On Tue, May 28, 2013 at 09:59:12AM +0200, Ingo Molnar wrote:
>
> * Dimitri Sivanich wrote:
>
> > Setup mappings for GRU distributed mode and include them as untracked
> > pat ranges.
>
> Would be nice to have the customary changelog content:
>
> " Cur
Setup mappings for GRU distributed mode and include them as untracked
pat ranges.
Signed-off-by: Dimitri Sivanich
---
arch/x86/kernel/apic/x2apic_uv_x.c | 63 +
1 file changed, 57 insertions(+), 6 deletions(-)
Index: linux/arch/x86/kernel/apic/x2apic_uv_x.c
On Sun, May 19, 2013 at 09:30:41PM +0300, Dan Carpenter wrote:
> On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> >
> > Since we're here, maybe we should neaten this up a little?
> >
> > Signed-off-by: Dimitri Sivanich
> > ---
>
se[req.val1]) ||
> req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> ret = -EINVAL;
> } else {
Since we're here, maybe we should neaten this up a little?
Signed-off-by: Dimitri Sivanich
---
drivers/misc/sgi-gru/grufault.c |
Acked-by: Dimitri Sivanich
On Sun, Apr 21, 2013 at 08:01:07PM +0300, Dan Carpenter wrote:
> The "info.fill" array isn't initialized so it can leak uninitialized
> stack information to user space.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: style changes
>
Commit-ID: 94777fc51b3ad85ff9f705ddf7cdd0eb3bbad5a6
Gitweb: http://git.kernel.org/tip/94777fc51b3ad85ff9f705ddf7cdd0eb3bbad5a6
Author: Dimitri Sivanich
AuthorDate: Tue, 16 Oct 2012 07:50:21 -0500
Committer: Ingo Molnar
CommitDate: Wed, 24 Oct 2012 12:53:51 +0200
x86/irq/ioapic: Check
n-NULL.
Signed-off-by: Dimitri Sivanich
---
arch/x86/kernel/apic/io_apic.c |3 +++
1 file changed, 3 insertions(+)
Index: linux/arch/x86/kernel/apic/io_apic.c
===
--- linux.orig/arch/x86/kernel/apic/io_apic.c
+++ linux/arch/
69 matches
Mail list logo
