Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

On Fri, Oct 24, 2014 at 5:01 AM, Gioh Kim wrote: > > > 2014-10-24 오전 8:16, Gioh Kim 쓴 글: > >> >> >> 2014-10-24 오전 5:36, Devendra Naga 쓴 글: >>> >>> Hello, >>> >>> On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote: >&g

Re: [RFC 1/2] staging: ion: shrink page-pool by page unit

Hello, On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote: > This patch shrink page-pool by page unit. > > Signed-off-by: Gioh Kim > --- > drivers/staging/android/ion/ion_page_pool.c |5 +++-- > drivers/staging/android/ion/ion_system_heap.c |7 +-- > 2 files changed, 8 insertions(+),

[PATCH] uio: sercos3: use devm_kzalloc

use devm_kzalloc and no need of free's at error path and unload Signed-off-by: Devendra Naga --- Please apply this after changeid: 1fb4ec94e7e955a1e26bf81f2634e5be2fa5f1d5 [PATCH] uio: uio_sercos3: use module_pci_driver macro sorry for sending as patch should be patch 2/2. driver

[PATCH] uio: uio_sercos3: use module_pci_driver macro

use module_pci_driver macro and simplify the module init and exit code Signed-off-by: Devendra Naga --- drivers/uio/uio_sercos3.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/uio/uio_sercos3.c b/drivers/uio/uio_sercos3.c index 81a10a5..5419832

[PATCH] mfd: jz4740-adc: use devm_kzalloc

use devm_kzalloc and remove the error path free'ing and unload free'ing as the devm resource functions free them. Signed-off-by: Devendra Naga --- drivers/mfd/jz4740-adc.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/jz47

Re: Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach

On Tue, Sep 4, 2012 at 11:17 AM, MyungJoo Ham wrote: >> any comments ? >> > > Sorry for replying late. > > It has been applied to the extcon-for-next tree at > http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next > , which will appear in hours. Thanks! -- To uns

Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach

any comments ? On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga wrote: > actually we can do returns with error or success with out ret in this > function, > so remove the ret variable, and reduce a very little (4byte) space on stack > of this function > > Signed-off

[char-misc-next] tifm: use module_pci_driver

tifm_7xx1_init and tifm_7xx1_exit with module_init and module_exit calls can be replaced with the module_pci_driver call, as they are similar to what module_pci_driver does Signed-off-by: Devendra Naga --- drivers/misc/tifm_7xx1.c | 14 +- 1 file changed, 1 insertion(+), 13

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

ot; and "3.", > and on error condition call lp8727_unregister_psy(). > I think i need to learn more in order to touch this path. will give a try. Thanks, > Thanks, > >> On Sun, 2012-07-29 at 23:31 +0545, Devendra Naga wrote: >> > actually the driver does a

Re: [PATCH 2/2] lp8727_charger: unregister power supply at error path of lp8727_register_psy

psy_usb >> >> > if (power_supply_register(pchg->dev, &psy->batt)) >> > - goto err_psy; >> > + goto err_psy_usb; >> >> Same here, why don't you use err_psy_batt > > Thanks, folks! It was easy to change so I applied

[PATCH] misc: use module_spi_driver

iver(&driv_op); } module_exit(drv_exit); Signed-off-by: Devendra Naga --- drivers/misc/bmp085-spi.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/misc/bmp085-spi.c b/drivers/misc/bmp085-spi.c index 78aaff9..5e982af 100644 --- a/drivers/misc/bmp085-spi

[PATCH] thermal: solve compilation errors in rcar_thermal

: *** [drivers/thermal/rcar_thermal.o] Error 2 with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) Signed-off-by: Devendra Naga --- drivers/thermal/rcar_thermal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c

[PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach

actually we can do returns with error or success with out ret in this function, so remove the ret variable, and reduce a very little (4byte) space on stack of this function Signed-off-by: Devendra Naga --- compile tested. drivers/extcon/extcon-max8997.c | 6 ++ 1 file changed, 2

Re: [PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

Sorry to ask this again, But will anybody please ACK , NACK or comment on this patch? Thanks, Devendra. On Sun, Jul 29, 2012 at 11:16 PM, Devendra Naga wrote: > actually the driver does a request_threaded_irq and after this it calls > lp8727_register_psy, and if it fails it doesn'

Re: [PATCH] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info

On Mon, Aug 6, 2012 at 7:57 PM, Dan Carpenter wrote: > On Sat, Aug 04, 2012 at 11:06:12PM +0545, Devendra Naga wrote: >> as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in >> sm7xxx_probe is not having any assignment, and which leads to copying

[PATCH 2/2] staging/crystalhd: unregister chardev when class_create fails in chd_dec_init_chdev

we missed a unregiser_chrdev if the class_create and subsequent function calls / checks fail Signed-off-by: Devendra Naga --- drivers/staging/crystalhd/crystalhd_lnx.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers

[PATCH 1/2] staging/crystalhd: assign PTR_ERR at fail cases to rc in chd_dec_init_chdev

the rc assignment to PTR_ERR at fail cases of class_create and device_create are missed out, return proper error rather than returning -ENODEV. Signed-off-by: Devendra Naga --- drivers/staging/crystalhd/crystalhd_lnx.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging

[PATCH 2/2] staging: media: cxd2099: use kzalloc to allocate ci pointer of type struct cxd in cxd2099_attach

this does kmalloc and followed by memset, calling kzalloc will actually sets the allocated memory to zero, use kzalloc instead Signed-off-by: Devendra Naga --- drivers/staging/media/cxd2099/cxd2099.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media

[PATCH 1/2] staging: media: cxd2099: fix sparse warnings in cxd2099_attach

integer as NULL pointer Signed-off-by: Devendra Naga --- drivers/staging/media/cxd2099/cxd2099.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c index 1c04185..1678503 100644 --- a

[PATCH V2] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info

igned-off-by: Devendra Naga --- Changes since V1: Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1. drivers/staging/sm7xxfb/sm7xxfb.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/

[PATCH] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info

igned-off-by: Devendra Naga --- Only compile tested This patch is not tested using the hardware... if any one is having this hardware, i request them to please test this drivers/staging/sm7xxfb/sm7xxfb.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/stagin

[PATCH 5/5] staging/csr: fix coding style problems in handle_bh_error

the following fixes: * fix line over 80 * fix no space at start of line * use tabs instead of spaces * no need of opening & closing braces for single statement if block Cc: Mikko Virkkilä Cc: Lauri Hintsala Cc: Riku Mettälä Cc: Veli-Pekka Peltola Signed-off-by: Devendra Naga --- dri

[PATCH 4/5] staging/csr: remove the initialisation of interfaceTag and its comment in handle_bh_error

the interfaceTag is actually initialised in for loop of this function and its not needed to initialise it before for loop. and also remove the comment that is obvious about this variable. Cc: Mikko Virkkilä Cc: Lauri Hintsala Cc: Riku Mettälä Cc: Veli-Pekka Peltola Signed-off-by: Devendra

[PATCH 3/5] staging/csr: fix coding style problems in uf_wait_for_thread_to_stop

the following fixes: * fix no space at the start of line * line over 80 characters * use tabs instead of spaces at starting of every line Cc: Mikko Virkkilä Cc: Lauri Hintsala Cc: Riku Mettälä Cc: Veli-Pekka Peltola Signed-off-by: Devendra Naga --- drivers/staging/csr/bh.c | 29

[PATCH 2/5] staging/csr: fix coding style problems in uf_stop_thread

The following warnings and errors were fixed: * fix no space at the start of a line * fix line over 80 characters * use tabs instead of spaces Cc: Mikko Virkkilä Cc: Lauri Hintsala Cc: Riku Mettälä Cc: Veli-Pekka Peltola Signed-off-by: Devendra Naga --- drivers/staging/csr/bh.c | 15

[PATCH 1/5] staging/csr: clean coding style in uf_start_thread

: Mikko Virkkilä Cc: Lauri Hintsala Cc: Riku Mettälä Cc: Veli-Pekka Peltola Signed-off-by: Devendra Naga --- drivers/staging/csr/bh.c | 83 -- 1 file changed, 43 insertions(+), 40 deletions(-) diff --git a/drivers/staging/csr/bh.c b/drivers/staging

[PATCH 0/5] staging/csr: cleanup patches

, unifi_warning, unifi_error, and unifi_trace, I think these can be implemented using dev_warn, dev_dbg, functions, i mean we can remove these unifi_warning and unifi_error and unifi_trace and use the dev_warn and dev_dbg. Please correct me if i am wrong Devendra Naga (5): staging/csr: clean coding

[PATCH] rtc/at91sam9: use module_platform_driver macro

This driver does seems to do only platform_driver_register in the init function and platform_driver_unregister in the exit function, so replace all this code including the module_init and module_exit with module_platform_driver macro... Signed-off-by: Devendra Naga --- drivers/rtc/rtc-at91sam9

[PATCH 2/2] ds2781_battery: replace call to kzalloc with devm_kzalloc

with devm_kzalloc there is no need of freeing at the errorpath and also at unregister it. Signed-off-by: Devendra Naga --- drivers/power/ds2781_battery.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/power/ds2781_battery.c b/drivers/power

[PATCH 1/2] ds2781_battery: convert to module_platform_driver

ions); } static void __exit mymod_exit(void) { platform_driver_unregister(&drv_operations); } module_init(mymod_init); module_exit(mymod_exit); can be replaced with module_platform_driver(drv_operations)... Signed-off-by: Devendra Naga --- drivers/power/ds2781_battery.c | 14 +

[PATCH V2 2/2] lp8727_charger: unregister power supply at error path of lp8727_register_psy

-ENOMEM Signed-off-by: Devendra Naga --- Changes since V2: * fix the comments from the Ramakrishna (ramakrishna.pall...@intel.com) quoting his comments: > if (power_supply_register(pchg->dev, &psy->usb)) > - goto err_psy; > + goto err_psy_ac; &quo

[PATCH 2/2] lp8727_charger: unregister power supply at error path of lp8727_register_psy

-ENOMEM Signed-off-by: Devendra Naga --- drivers/power/lp8727_charger.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c index 699f0ef..401b66e 100644 --- a/drivers/power/lp8727_charger.c +++ b/drivers

[PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

actually the driver does a request_threaded_irq and after this it calls lp8727_register_psy, and if it fails it doesn't free the irqs that it registered to Signed-off-by: Devendra Naga --- drivers/power/lp8727_charger.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[PATCH 2/2] pch_phub: use module_pci_driver

this driver's pch_phub_pci_init, and pch_phub_pci_exit functions with the module_init and module_exit calls can be replaced with module_pci_driver Signed-off-by: Devendra Naga --- drivers/misc/pch_phub.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/dr

[PATCH 1/2] pch_phub: fix sparse warning

sparse warns about using 0 as NULL pointer, drivers/misc/pch_phub.c:702:44: warning: Using plain integer as NULL pointer Signed-off-by: Devendra Naga --- drivers/misc/pch_phub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc

[PATCH] pinctrl-sirf: remove devm_kfree at error path

the pointers that are allocated with devm_kzalloc will be automatically freed, at unload time. Signed-off-by: Devendra Naga --- drivers/pinctrl/pinctrl-sirf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c index 2aae8a8

[PATCH] thermal: fix build error at thermal_sys.c

(first use in this function) drivers/thermal/thermal_sys.c:1216:3: note: each undeclared identifier is reported only once for each function it appears in link: http://www.spinics.net/lists/linux-kernel-janitors/msg12174.html use the indx instead. Cc: Durgadoss R Signed-off-by: Devendra Naga ---

[PATCH 2/2] staging/tidspbridge: use module_platform_driver

the code under _init and _exit does platform_driver_register and platform_driver_unregister respectively only, so its better to use the module_platform_driver than just replicating the module_platform_driver's implementation Signed-off-by: Devendra Naga --- drivers/staging/tidspbridge

[PATCH 1/2] staging/iio: use module_platform_driver macro

the code which under _init and _exit does only the platform_driver_register and platform_driver_unregister, and nothing else, so its better to use the module_platform_driver macro rather duplicating its implementation Signed-off-by: Devendra Naga --- drivers/staging/iio/iio_hwmon.c | 12

[PATCH] pinctrl/pinctrl-u300: remove unneeded devm_kfree call

the allocated memory will be destroyed at the driver unload time, automatically if driver uses the devm_ functions, so no need of doing devm_kfree at the error path Signed-off-by: Devendra Naga --- drivers/pinctrl/pinctrl-u300.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[PATCH 3/3] staging/csr: remove firmware pointer check before giving to release_firmware

we do a check of firmware pointer against the NULL value before we give it to the release_firmware. as release_firmware is actually having a check against NULL, its not needed here. Signed-off-by: Devendra Naga --- drivers/staging/csr/firmware.c |4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 2/3] staging/csr: coding style fixes at sdio_linux_remove_irq and at install_irq

the following coding style problems were fixed: 1. move function return type from top to the starting of the function 2. remove all the spaces at the start of a line and used tabs Signed-off-by: Devendra Naga --- drivers/staging/csr/sdio_mmc.c | 43 +++- 1

[PATCH 1/3] staging/csr: coding style fixes in CsrTimeGet

the following warnings were fixed: 1. removed all spaces before the start of a line and used tabs 2. removed the braces around the if as it encloses only a single statement Signed-off-by: Devendra Naga --- drivers/staging/csr/csr_time.c | 20 +--- 1 file changed, 9 insertions

Re: [PATCH] staging/android: use module_platform_driver

oops forgot to add LKML, On Fri, Jul 20, 2012 at 10:45 PM, Devendra Naga wrote: > > as the init and exit functions just do a platform_driver_register and > platform_driver_unregister, and nothing else, so its better to > use the module_platform_driver macro rather replicating its im

[PATCH] staging/sbe-2t3e3: error path cleanup in t3e3_init_channel

-by: Devendra Naga --- drivers/staging/sbe-2t3e3/module.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sbe-2t3e3/module.c b/drivers/staging/sbe-2t3e3/module.c index cd778b3..1a1a9be 100644 --- a/drivers/staging/sbe-2t3e3/module.c +++ b/drivers

[PATCH 3/3] rtc/rtc-da9052: remove unneed devm_kfree call

freeing will trigger when driver unloads, so using devm_kfree is not needed. Signed-off-by: Devendra Naga --- drivers/rtc/rtc-da9052.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c index da6ab52..7807025 100644

[PATCH 2/3] rtc/rtc-88pm80x: remove unneed devm_kfree

devm_kzalloc doesn't need a matching devm_kfree, the freeing mechanism will trigger when driver unloads. Signed-off-by: Devendra Naga --- drivers/rtc/rtc-88pm80x.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm

[PATCH 1/3] rtc/rtc-88pm80x: assign ret only when rtc_register_driver fails

At the probe we are assigning ret to return value of PTR_ERR right after the rtc_register_driver, as we would have done it in the if (IS_ERR(ptr)) check, since the function fails and goes inside that case Signed-off-by: Devendra Naga --- drivers/rtc/rtc-88pm80x.c |2 +- 1 files changed, 1

[PATCH V2] staging/gdm72xx: use kthread APIs

From: Devendra Naga This patch modifies the kthread usage in the gdm_usb code, and tries to use the kthread APIs better. Actually the task_struct is taken as global as the limitation of priv. we run the kthread before we allocate the priv. did only compilation test, but not the insmod, check

[PATCH] staging/rts_pstor: use kthread_run instead doing kthread_create and wake_up_process

instead calling kthread_create and another call to the wake_up_process, so with this change the creation of rtsx_scan_thread will be in consistency with the other control and poll threads. Signed-off-by: Devendra Naga --- Compile tested only,.. didn't done ps ax to check whether this thread

[PATCH] powerpc/BSR: cleanup the error path of bsr_init

alloc_chrdev_region fail, we are still returning -ENODEV, use ret and the error path will take care of returning of the ret. Signed-off-by: Devendra Naga --- This patch is not compile tested because i dont have the powerpc toolchain, i am trying hard to setit up one, drivers/char

[PATCH] staging/wlan-ng: use kzalloc rather using kmalloc at create_wlan

create_wlan, and its called nowhere else... Signed-off-by: Devendra Naga --- drivers/staging/wlan-ng/prism2sta.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 417aea5..1dfd9aa 100644

[PATCH] staging/winbond: use err and remove nr

err can be used get return status of the usb_control_msg, rather using nr and assigning it to err when the function returns error. Signed-off-by: Devendra Naga --- drivers/staging/winbond/wbusb.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH 3/3] staging/vt6656: cleanup coding style in vResetCommandTimer

the following fixes... removed spaces at start of a line and used tabs Signed-off-by: Devendra Naga --- drivers/staging/vt6656/wcmd.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656

[PATCH 2/3] staging/vt6656: remove unnecessary return in BSSvSecondTxData

this return is at the function end, and function is returning nothing.. i.e a void. Signed-off-by: Devendra Naga --- drivers/staging/vt6656/wcmd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c index cecfdb6..c9de937 100644

[PATCH 1/3] staging/vt6656: coding style fix in BSSvSecondTxData

this function seemed bit more coding style fix... The following fixes: remove spaces at start of line and use tabs use space between if and ( give a space in a multiplication operation use space after = and another variable/constant Signed-off-by: Devendra Naga --- drivers/staging/vt6656

[PATCH] staging/sm7xxfb: select sm7xxfb only when CONFIG_PCI is enabled

7xxfb/sm7xxfb.c:1061:1: warning: type defaults to 'int' in declaration of 'module_pci_driver' [-Wimplicit-int] drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: parameter names (without types) in function declaration [enabled by default] Reported-by: Fengguang Wu Sig

[PATCH 5/5] staging/gdm72xx: coding style fixes gdm_qos.c

following warnings were fixed drivers/staging/gdm72xx/gdm_qos.c:198: ERROR: "foo* bar" should be "foo *bar" drivers/staging/gdm72xx/gdm_qos.c:198: ERROR: "foo* bar" should be "foo *bar" drivers/staging/gdm72xx/gdm_qos.c:244: WARNING: quoted string split ac

[PATCH 4/5] staging/gdm72xx: use kzalloc for phydev and sdev

in sdio probe function we are doing kmalloc which can be done using kzalloc. Signed-off-by: Devendra Naga --- drivers/staging/gdm72xx/gdm_sdio.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c

[PATCH 3/5] staging/gdm72xx: cleanup little at gdm_wimax_event_rcv

the event sock check is done at the netlink_init itself. Signed-off-by: Devendra Naga --- drivers/staging/gdm72xx/gdm_wimax.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index e616de1

[PATCH 2/5] staging/gdm72xx: use kzalloc for phydev and udev

we are doing kmalloc and memset, can be done using kzalloc itself. Signed-off-by: Devendra Naga --- drivers/staging/gdm72xx/gdm_usb.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index

[PATCH 1/5] staging/gdm72xx: return PTR_ERR rather -ENOENT

return the error of filp_open rather returning -ENOENT. Signed-off-by: Devendra Naga --- drivers/staging/gdm72xx/usb_boot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c index c163bcc..fef290c

[PATCH 2/2] staging/et131x: remove memset for the TCB

TCB has kcalloc' ed so no need to call memset again on it. Signed-off-by: Devendra Naga --- drivers/staging/et131x/et131x.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 227fca9..5010894 100644 --- a/dr

[PATCH 1/2] staging/et131x: use SET_ETHTOOL_OPS directly

using a wrapper around SET_ETHTOOL_OPS macro is not actually required, remove and use SET_ETHTOOL_OPS directly. Signed-off-by: Devendra Naga --- drivers/staging/et131x/et131x.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b

[PATCH] leds/leds-s3c24xx: use devm_gpio_request

why? because if the led_classdev_register fails we wont do gpio free because using devm_ functions, there is no need for error paths Signed-off-by: Devendra Naga --- Bryan, This patch is not even compile tested, since my machine crashed, and didn't have the ARM toolchain,

[PATCH] staging/gdm72xx: use kthread APIs

rmmod and see the thread is killed kind of tests. There were no checks while kthread_run may fail, returing some error which can be seen by using PTR_ERR. Signed-off-by: Devendra Naga --- drivers/staging/gdm72xx/gdm_usb.c | 13 + 1 file changed, 9 insertions(+), 4 deletions

[PATCH V2] staging/slicoss: disable pci device at remove

at probe we enabled the device, and we should disable it at remove. Signed-off-by: Devendra Naga --- changes v2: nothing, just a resend, incremented patch version count for maintainer to have notified the latest change easily. drivers/staging/slicoss/slicoss.c |1 + 1 file

[PATCH 6/6] staging/phison: use module_pci_driver macro

void) { pci_unregister_driver(&pci_test_driver_ops); } module_init(pci_test_dev_init); module_exit(pci_test_dev_exit); Signed-off-by: Devendra Naga --- drivers/staging/phison/phison.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/staging/phison/ph

[PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro

the driver duplicates the module_pci_driver code, how? module_pci_driver is used for those drivers whose init and exit paths does only register and unregister to pci API and nothing else. so use the module_pci_driver macro instead Signed-off-by: Devendra Naga

[PATCH 4/6] staging/media/dt3155v4l: use module_pci_driver macro

the driver duplicates the module_pci_driver code, remove the duplicate code and use the module_pci_driver macro. Signed-off-by: Devendra Naga --- drivers/staging/media/dt3155v4l/dt3155v4l.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/staging

[PATCH 3/6] staging/sep: use module_pci_driver macro

this driver duplicates the module_pci_driver code, so remove the duplicated code and use module_pci_driver and also remove the obvious comments about _init and _exit. Signed-off-by: Devendra Naga --- drivers/staging/sep/sep_main.c | 27 +-- 1 file changed, 1 insertion

[PATCH 2/6] staging/et131x: use module_pci_driver macro

remove code duplicating module_pci_driver and also the obvious comments about the _init and _exit points. Signed-off-by: Devendra Naga --- drivers/staging/et131x/et131x.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 1/6] staging/sbe-2t3e3: use module_pci_driver macro

the _init and _exit functions do nothing but pci_register_driver, and pci_unregister_driver, so replace these and also the module _init and _exit macros with the module_pci_driver macro. Signed-off-by: Devendra Naga --- drivers/staging/sbe-2t3e3/module.c | 13 + 1 file changed, 1

[PATCH 2/2] staging/sm7xxfb: return a proper err for smtc_alloc_fb_info failure

good to do -ENOMEM Signed-off-by: Devendra Naga --- drivers/staging/sm7xxfb/sm7xxfb.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index 0c0b603..7395196 100644 --- a/drivers/staging/sm7xxfb

[PATCH 1/2] staging/sm7xxfb: use module_pci_driver macro

. Signed-off-by: Devendra Naga --- drivers/staging/sm7xxfb/sm7xxfb.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index e3511ec..0c0b603 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c

[PATCH V2] staging/ft1000: remove all spaces, tabs issue in while loop of ft1000_interrupt

all spaces in the main while loop of ft1000_interrupt are converted to tabs. Signed-off-by: Devendra Naga --- Greg, You mean to say this only right? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 60 +++--- 1 file changed, 31 insertions(+), 29 deletions(-) diff

[PATCH 3/3] staging/slicoss: return -ENODEV if no devid matches

if no case matches we are simply asserting and doing break. and i think we may need to return that -ENODEV , no device is present, rather assert'ing. Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH 2/3] staging/slicoss: disable pci device at remove

at probe we enabled the device, and we should disable it at remove. Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index a511a2b..5bd3825 100644

[PATCH 1/3] staging/slicoss: remove not-needed ASSERT

As the private pointer is valid at the remove of driver, and remove wont' be called if probe fails, so no point for checking of ASSERT Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss

[PATCH] geodewdt: do a little cleanup at probe

at probe with out ret var, simple return misc_register was sufficient. Signed-off-by: Devendra Naga --- drivers/watchdog/geodewdt.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/geodewdt.c b/drivers/watchdog/geodewdt.c index dc563b6..df825b5 100644

[PATCH 7/8] staging/ft1000-pcmcia: fix checkpatch warnings

/ft1000_proc.c:57: ERROR: that open brace { should be on the previous line Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c b

[PATCH 6/8] staging/ft1000: fix the foo * bar warning

Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c index 67ad7ee..9a5ba07 100644 --- a

[PATCH 5/8] staging/ft1000: fix the no brace needed warning in ft1000_read_fifo_len

as the if else statements enclose only one line, so braces around them are not needed. The following warning is fixed drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:100: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Devendra Naga --- drivers/staging

[PATCH 4/8] staging/ft1000: fix sparse warning about the kernel thread handler function

sparse throws warning about the ft1000_poll_thread as drivers/staging/ft1000/ft1000-usb/ft1000_usb.c:40:5: warning: symbol 'ft1000_poll_thread' was not declared. Should it be static? Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.c |2 +- 1 file

[PATCH 3/8] staging/ft1000: fix sparse warning

sparse warns about having 0 assigned to a pointer, fix it up by using NULL. The following sparse warning is fixed drivers/staging/ft1000/ft1000-usb/ft1000_debug.c:170:52: warning: Using plain integer as NULL pointer Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-usb

[PATCH 8/8] staging/ft1000: remove unnecessary assignment of ret with STATUS_SUCCESS

as ret is assigned to the return of ft1000_poll, we dont need to initialise ret with STATUS_SUCCESS. Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ft1000/ft1000-usb

[PATCH 2/8] staging/ft1000: fix the spaces issue at the start of line

The following warns fixed drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: ERROR: code indent should use tabs where possible drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: WARNING: please, no spaces at the start of a line Signed-off-by: Devendra Naga --- drivers/staging/ft1000

[PATCH 1/8] staging/ft1000: fix the no brace needed warning in ft1000_interrupt

as the if statement encloses only one line braces around it are not needed. The following warn fixed, WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Devendra Naga --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c |5 ++--- 1 file changed, 2 insertions

[PATCH] drm/mgag200: fix null pointer dereference

we are referencing the pointer after doing alloc_apertures, as alloc_apertures kzallocs, the kzalloc may fail and we get a NULL. so we need to check for NULL before we dereference this pointer Signed-off-by: Devendra Naga --- drivers/gpu/drm/mgag200/mgag200_drv.c |3 +++ 1 file changed, 3

[PATCH 2/2] staging/rts_pstor: fix single statements block warning

The following warning is fixed up. drivers/staging/rts_pstor/sd.c:190: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Devendra Naga --- drivers/staging/rts_pstor/sd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 1/2] staging/rts_pstor: fix the no brace needed warning

for if else statements having single block no braces are needed fixed the following checkpatch warning drivers/staging/rts_pstor/sd.c:140: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Devendra Naga --- drivers/staging/rts_pstor/sd.c |5 ++--- 1 file