This patch adds support for "default-state" devicetree property, which
allows to defer pwm init to first use of led.
This allows to configure the PWM early in bootloader to let the LED
blink until an application in Linux userspace sets something different.
Signed-off-by: Denis Oste
The default-state is now supported for PWM leds.
Signed-off-by: Denis Osterland-Heim
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/leds/leds-pwm.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree
v6 -> v7: apply comments from Jacek
refactore default state read to separate function
and use it in leds-gpio and leds-pwm
@Pavel I hope that it is okay to keep your acked-by on 2/3,
the logic is the same but with switch, in favour of if
.../devicetree/bindings/leds/
This patch introduces a new function to read initial
default_state from fwnode.
Signed-off-by: Denis Osterland-Heim
---
drivers/leds/led-core.c | 15 +++
drivers/leds/leds-gpio.c | 12 ++--
drivers/leds/leds.h | 1 +
include/linux/leds.h | 12 +---
4 files
to let the LED
> > blink until an application in Linux userspace sets something different.
> >
> > Signed-off-by: Denis Osterland-Heim
> > Acked-by: Jacek Anaszewski
> > +#define LEDS_PWM_DEFSTATE_OFF 0
> > +#define LEDS_PWM_DEFSTATE_ON 1
> >
v5 -> v6: tested the rebase to v5.8-rc2 based for-next
.../devicetree/bindings/leds/leds-pwm.txt | 2 +
drivers/leds/leds-pwm.c| 54 +++---
2 files changed, 50 insertions(+), 6 deletions(-)
Message-Id: <20200421130644.16059-1-denis.osterl...@
The default-state is now supported for PWM leds.
Signed-off-by: Denis Osterland-Heim
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/leds/leds-pwm.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree
This patch adds support for "default-state" devicetree property, which
allows to defer pwm init to first use of led.
This allows to configure the PWM early in bootloader to let the LED
blink until an application in Linux userspace sets something different.
Signed-off-by: Denis Oste
Hi Jacek,
is your ack still valid for the new versions of the patch-set?
Due to the changes I made, I am not sure.
Regards, Denis
Am Dienstag, den 17.03.2020, 21:43 +0100 schrieb Jacek Anaszewski:
> Hi Denis,
>
> On 3/16/20 9:24 PM, Denis Osterland-Heim wrote:
> > Hi Jacek,
>
Am Freitag, den 28.09.2018, 14:04 +0200 schrieb Alexandre Belloni:
> Hello,
>
> Oh right, I actually had that but somehow, I stashed the patch instead
> of squashing it.
>
> If that is fine for you, I'll fold that in the original patch (I'll ad
> your SoB).
>
>
Sounds good.
Regards Denis
Dieh
From: Denis Osterland
The move of atrim, dtrim usr sysfs properties from i2c device
to rtc device require to access them via dev->parent.
This patch also aligns timestamp0.
Fixes: 03df75dd03301307ec578ccd4e8c1c0117b8e65c
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c |
Hi,
just for clarification:
This changes user-space representation from
/sys/class/rtc/rtcN/device/{atrim,dtrim,usr}
to
/sys/class/rtc/rtcN/{atrim,dtrim,usr}
and fixes the "mistake made back in 2006" you mention in
https://patchwork.ozlabs.org/patch/881397/
correct?
Regards Denis
Am Samstag, den
occurred.
Signed-off-by: Michael Grzeschik
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c | 131 --
1 file changed, 124 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 1a2c38cc0178..3150ebdcb179
From: Denis Osterland
Add support for "evdet" named interrupt source.
The check if i2c client irq matches evdet irq is needed
for the case that there is only one interrupt named "evdet".
In this case i2c client code handles this like an unnamed
interrupt souce and assigns th
From: Denis Osterland
The devicetree documentation for the ISL1219 device tree
binding is added with an short example. It is not a trivial
device, because it supports two interrupt sources.
Signed-off-by: Denis Osterland
---
.../devicetree/bindings/rtc/isil,isl1219.txt | 29
From: Denis Osterland
This patches addresses following problem:
rtc_allocate_device
devm_device_add_group <-- kernel oops / null pointer, because
sysfs entry does not yet exist
rtc_register_device
rc = devm_device_add_group
if (rc)
return rc; <-- forbid
up(s)
- use kcalloc
- return error if device is already registered
- include helper functions into rtc_add_groups
Michael Grzeschik (1):
rtc: isl1208: add support for isl1219 with tamper detection
Denis Osterland (4):
rtc: sysfs: facilitate attribute add to rtc device
rtc: isl1208: A
From: Denis Osterland
Add support to disable event in pull-up.
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 0812a14c2d5c
Hi,
Am Mittwoch, den 18.07.2018, 10:13 +0200 schrieb Alexandre Belloni:
> On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:
> >
> > + if (id->driver_data == TYPE_ISL1219) {
> > + rc = ISL1219_REG_EV_EVEN;
> > + rc = i2c_smbus_write_byte_d
Hello,
Am Mittwoch, den 18.07.2018, 09:38 +0200 schrieb Alexandre Belloni:
> Hi,
>
> On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:
> >
> > +
> > +Optional properties:
> > +
> > + - "interrupt-names": list which may contains "ir
Hello,
thanks for your comments.
Am Mittwoch, den 18.07.2018, 09:25 +0200 schrieb Alexandre Belloni:
> Hello,
>
> On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:
> >
> > +
> > +static size_t rtc_group_count(struct rtc_device *rtc)
> > +{
> I don't
Am Mittwoch, den 11.07.2018, 09:16 -0600 schrieb Rob Herring:
> On Tue, Jul 10, 2018 at 09:44:15AM +0000, Denis OSTERLAND wrote:
> >
> > From: Denis Osterland
> >
> > The devicetree documentation for the ISL1219 device tree
> > binding is added with an s
uild test ERROR on v4.18-rc4 next-20180709]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-and-isl1219-support/20180710-181709
From: Denis Osterland
The devicetree documentation for the ISL1219 device tree
binding is added with an short example. It is not a trivial
device, because it supports two interrupt souces.
Signed-off-by: Denis Osterland
---
.../devicetree/bindings/rtc/isil,isl1219.txt | 29
From: Denis Osterland
This patches addresses following problem:
rtc_allocate_device
devm_device_add_group <-- kernel oops / null pointer, because
sysfs entry does not yet exist
rtc_register_device
rc = devm_device_add_group
if (rc)
return rc; <-- forbid
occurred.
Signed-off-by: Michael Grzeschik
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c | 131 --
1 file changed, 124 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 1a2c38cc0178..bb189fe6744a
From: Denis Osterland
Add support for "evdet" named interrupt source.
The check if i2c client irq matches evdet irq is needed
for the case that there is only one interrupt named "evdet".
In this case i2c client code handles this like an unnamed
interrupt souce and assigns th
tm before convert and use unsigned long long cased value.
Add device-tree flag to disable event in pull-up to maximize battery
life time.
Michael Grzeschik (1):
rtc: isl1208: add support for isl1219 with tamper detection
Denis Osterland (4):
rtc: sysfs: facilitate attribute add to rtc
From: Denis Osterland
Add support to disable event in pull-up.
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index bbe08c1ab9f3..2f18ee3c615a 100644
Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni:
> > > > +
> > > > + tv64.tv_sec = rtc_tm_to_time64(&tm);
> > > Why not using an unsigned long long directly here? time64_t is not the
> > > correct type.
> > Do you mean timespec64 is not the correct type here?
> > Then yes,
Am Dienstag, den 06.03.2018, 21:42 +0100 schrieb Alexandre Belloni:
> On 05/03/2018 at 10:43:52 +0000, Denis OSTERLAND wrote:
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt
> > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt
>
occurred.
The devicetree documentation for the ISL1219 device tree
binding is added with an short example. It is not a trivial
device, because it supports two interrupt souces.
Signed-off-by: Michael Grzeschik
Signed-off-by: Denis Osterland
---
.../devicetree/bindings/rtc/isil,isl1219.txt | 28
the two possible interrupt sources for isl1219.
Support "evdet" named interrupt souce.
Michael Grzeschik (2):
rtc: isl1208: enable interrupt after context preparation
rtc: isl1208: add support for isl1219 with tamper detection
Denis Osterland (2):
rtc: isl1208: switch to rtc_regis
From: Denis Osterland
Fix possible race condition.
It is not allowed to return with an error code after RTC is registered.
Suggested-by: Alexandre Belloni
Signed-off-by: Denis Osterland
Reviewed-by: Michael Grzeschik
---
drivers/rtc/rtc-isl1208.c | 8
1 file changed, 4 insertions
Grzeschik
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index c8b4953..a13a4ba 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b
From: Denis Osterland
Add support for "evdet" named interrupt source.
The check if i2c client irq matches evdet irq is needed
for the case that there is only one interrupt named "evdet".
In this case i2c client code handles this like an unnamed
interrupt souce and assigns th
elloni/rtc-next]
> [also build test ERROR on v4.16-rc3 next-20180302]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Denis-OSTERLAND/rtc-isl1208-fixes-documentation-an
From: Denis Osterland
Fix possible race condition.
It is not allowed to return with an error code after RTC is registered.
Suggested-by: Alexandre Belloni
Signed-off-by: Denis Osterland
Reviewed-by: Michael Grzeschik
---
drivers/rtc/rtc-isl1208.c | 8
1 file changed, 4 insertions
Grzeschik
Signed-off-by: Denis Osterland
---
drivers/rtc/rtc-isl1208.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index c8b4953..a13a4ba 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b
rupt souce.
Michael Grzeschik (2):
rtc: isl1208: enable interrupt after context preparation
rtc: isl1208: add support for isl1219 with tamper detection
Denis Osterland (2):
rtc: isl1208: switch to rtc_register_device
rtc: isl1208: Add "evdet" interrupt source for isl1219.
.../devicetr
From: Denis Osterland
Add support for "evdet" named interrupt source.
The check if i2c client irq matches evdet irq is needed
for the case that there is only one interrupt named "evdet".
In this case i2c client code handles this like an unnamed
interrupt souce and assigns th
occurred.
The devicetree documentation for the ISL1219 device tree
binding is added with an short example. It is not a trivial
device, because it supports two interrupt souces.
Signed-off-by: Michael Grzeschik
Signed-off-by: Denis Osterland
---
.../devicetree/bindings/rtc/isil,isl1219.txt | 28
Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni:
> On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote:
> >
> > From: Denis Osterland
> >
> > After successful
> > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);
Am Dienstag, den 30.01.2018, 11:27 +0100 schrieb Alexandre Belloni:
> On 29/01/2018 at 13:59:19 -0800, Guenter Roeck wrote:
> >
> > On Wed, Jan 24, 2018 at 10:03:33AM +0100, Michael Grzeschik wrote:
> > [ ... ]
> > >
> > > >
> > > > >
> > > > > +
> > > > > diff --git a/Documentation/hwmon/sysfs
; > binding is added with an short example.
> >
> > Signed-off-by: Michael Grzeschik
> > Signed-off-by: Denis Osterland
> > ---
> > .../rtc/{intersil,isl1208.txt => isil,isl1208.txt} | 18 +-
> > Documentation/hwmon/sysfs-interface| 7 +
&
45 matches
Mail list logo
