Re: [PATCH v3] arm64: dts: rockchip: add initial dts support for Rockpro64

2018-09-26 Thread Deepak Das
64/boot/dts/rockchip/rk3399-rockpro64.dts | 692 > + > 3 files changed, 697 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > Acked-by: Deepak Das > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > b/Do

Re: [PATCH] arm64: dts: rockchip: add initial dts support for Rockpro64 board

2018-09-19 Thread Deepak Das
Hi Akash, On Wednesday 19 September 2018 08:13 PM, Akash Gajjar wrote: > This patch basic node support for Rockpro64 board and make it able to bring > up. > Please modify the commit message to make it more clear. > Peripheral Works > - SDIO, Sdcard > - USB 2.0, 3.0 > - Leds > > Not working: >

Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration

2016-10-25 Thread Deepak Das
On Tuesday 25 October 2016 05:41 PM, Linus Walleij wrote: > On Tue, Oct 25, 2016 at 6:57 AM, Deepak Das wrote: > >> generic gpio request/free should be added after gpiocip registration >> to validate mapping of gpiochip with pinctrl subsystem. >> >> gpiochip

[PATCH] gpio: mxc: Shift generic request/free after gpiochip registration

2016-10-24 Thread Deepak Das
to map with pinctrl subsystem for any reason. For Ex.:- generic gpio request/free should not be used if IOMUX pin controller device node is disabled in device tree. This commit checks above list and skips adding generic gpio request/free if list is found empty. Signed-off-by: Deepak Das Signed-off

[PATCH v2] driver: base: pinctrl: return error from, pinctrl_bind_pins()

2016-09-13 Thread Deepak Das
ns() only returns -EPROBE_DEFER which makes device driver probe successful even if the pin request is rejected by the pin controller subsystem. This commit modifies pinctrl_bind_pins() to return error if the pin is rejected by pin control subsystem. Signed-off-by: Deepak Das --- Changes from

Re: [PATCH] driver: base: pinctrl: return error from pinctrl_bind_pins()

2016-09-13 Thread Deepak Das
On Wednesday 14 September 2016 02:31 AM, Linus Walleij wrote: On Tue, Sep 13, 2016 at 3:41 PM, Deepak Das wrote: Can you confim that this works for you too? Yes, This works for me as well but do we really need this extra error message ? Nah, good point. I'll go in and drop it then.

Re: [PATCH] driver: base: pinctrl: return error from pinctrl_bind_pins()

2016-09-13 Thread Deepak Das
to return error if the pin is rejected by pin control subsystem. Signed-off-by: Deepak Das Aha /* Only return deferrals */ -if (ret != -EPROBE_DEFER) +if ((ret != -EPROBE_DEFER) && (ret != -EINVAL)) ret = 0; I rewrote this when applying, like this: -