Re: [PATCH RFT v11 2/8] Documentation: userspace-api: Add shadow stack API documentation

2024-10-30 Thread Deepak Gupta
On Sat, Oct 05, 2024 at 11:31:29AM +0100, Mark Brown wrote: There are a number of architectures with shadow stack features which we are presenting to userspace with as consistent an API as we can (though there are some architecture specifics). Especially given that there are some important consid

Re: [PATCH RFT v11 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack()

2024-10-30 Thread Deepak Gupta
ce to just return an int with 0 on success and a negative error code on failure. Signed-off-by: Mark Brown Acked-by: Deepak Gupta

[PATCH V2] rpmsg: glink: Add abort_tx check in intent wait

2024-09-25 Thread Deepak Kumar Singh
lag check in intent wait, to abort intent wait from qcom_glink_native_remove. Fixes: c05dfce0b89e ("rpmsg: glink: Wait for intent, not just request ack") Cc: sta...@vger.kernel.org Signed-off-by: Sarannya S Signed-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_native.c | 6 +

Re: [PATCH V3 2/2] soc: qcom: smp2p: Introduce tracepoint support

2024-06-28 Thread Deepak Kumar Singh
notifications, and ssr activity. These logs are useful for debugging issues between subsystems. Signed-off-by: Sudeepgoud Patil Reviewed-by: Deepak Kumar Singh --- drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smp2p.c | 9 drivers/soc/qcom/trace-smp2p.h | 98

Re: [PATCH V1] rpmsg: glink: Make glink smem interrupt wakeup capable

2024-06-13 Thread Deepak Kumar Singh
On 6/3/2024 3:07 PM, Caleb Connolly wrote: Hi Deepak, On 03/06/2024 09:36, Deepak Kumar Singh wrote: There are certain usecases which require glink interrupt to be wakeup capable. For example if handset is in sleep state and usb charger is plugged in, dsp wakes up and sends glink interrupt

Re: [PATCH V2 2/2] soc: qcom: smp2p: Introduce tracepoint support

2024-06-12 Thread Deepak Kumar Singh
On 6/12/2024 4:35 AM, Chris Lew wrote: On 6/11/2024 5:33 AM, Sudeepgoud Patil wrote: This commit introduces tracepoint support for smp2p, enabling logging of communication between local and remote processors. The tracepoints include information about the remote processor ID, remote subsyste

[PATCH V1] rpmsg: glink: Make glink smem interrupt wakeup capable

2024-06-03 Thread Deepak Kumar Singh
wakeup irq. Remove IRQF_NO_SUSPEND flag as it is no longer required. Signed-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_smem.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c index 7a982c60a8dd

Re: [PATCHv6 bpf-next 0/9] uprobe: uretprobe speed up

2024-05-21 Thread Deepak Gupta
On Tue, May 21, 2024 at 12:48:16PM +0200, Jiri Olsa wrote: hi, as part of the effort on speeding up the uprobes [0] coming with return uprobe optimization by using syscall instead of the trap on the uretprobe trampoline. I understand this provides an optimization on x86. I believe primary reaso

Re: [PATCHv5 bpf-next 6/8] x86/shstk: Add return uprobe support

2024-05-14 Thread Deepak Gupta
om broonie (arm shadow stack) and Deepak (riscv shadow stack). Deepak, even if riscv has a special instruction that pushes to the shadow stack, will it be ok if there is a callable operation that does the same thing? Like, aren't you relying on endbranches or the compiler or something such that

Re: [PATCHv4 bpf-next 2/7] uprobe: Add uretprobe syscall to speed up return probe

2024-05-03 Thread Deepak Gupta
On Fri, May 03, 2024 at 07:38:18PM +, Edgecombe, Rick P wrote: +Some more shadow stack folks from other archs. We are discussing how uretprobes work with shadow stack. Context: https://lore.kernel.org/lkml/ZjU4ganRF1Cbiug6@krava/ Thanks Rick. Yeah I didn't give enough attention to uprobes

Re: [RFC PATCH] rpmsg: glink: Add bounds check on tx path

2024-03-19 Thread Deepak Kumar Singh
On 1/29/2024 10:03 PM, Michal Koutný wrote: On Mon, Jan 29, 2024 at 04:18:36PM +0530, Deepak Kumar Singh wrote: There is already a patch posted for similar problem - https://lore.kernel.org/all/20231201110631.669085-1-quic_dee...@quicinc.com/ I was not aware, thanks for the pointer. Do

Re: [RFC PATCH] rpmsg: glink: Add bounds check on tx path

2024-01-29 Thread Deepak Kumar Singh
On 1/13/2024 5:55 AM, Michal Koutný wrote: Add bounds check on values read from shared memory in the tx path. In cases where the VM is misbehaving, the transport should exit and print a warning when bogus values may cause out of bounds to be read. Link: https://git.codelinaro.org/clo/la/kern

[PATCH V1] rpmsg: glink: smem: validate index before fifo read write

2023-12-01 Thread Deepak Kumar Singh
: 9607 [#1] PREEMPT SMP pc : __memcpy_fromio+0x34/0xb4 lr : glink_smem_rx_peak+0x68/0x94 __memcpy_fromio+0x34/0xb4 glink_smem_rx_peak+0x68/0x94 qcom_glink_native_intr+0x90/0x888 Signed-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_smem.c | 21 ++--- 1 file changed, 18

Re: [PATCH 1/6] staging: media: atomisp: improve function argument alignment

2021-04-20 Thread Deepak R Varma
On Tue, Apr 20, 2021 at 03:24:32PM +0200, Hans Verkuil wrote: > On 19/04/2021 21:12, Deepak R Varma wrote: > > Improve multi-line function argument alignment according to the code style > > guidelines. Resolves checkpatch feedback: "Alignment should match > > open parenth

Re: [PATCH 4/6] staging: media: atomisp: reformat code comment blocks

2021-04-20 Thread Deepak R Varma
On Tue, Apr 20, 2021 at 10:44:48AM +0200, Fabio Aiuto wrote: > On Tue, Apr 20, 2021 at 12:45:04AM +0530, Deepak R Varma wrote: > > Reformat code comment blocks according to the coding style guidelines. > > This resolves different checkpatch script WARNINGs around block comments.

Re: [PATCH 6/6] staging: media: atomisp: use printk with KERN facility level

2021-04-20 Thread Deepak R Varma
On Tue, Apr 20, 2021 at 10:35:23AM +0200, Fabio Aiuto wrote: > Hi Deepak, > > On Tue, Apr 20, 2021 at 12:46:40AM +0530, Deepak R Varma wrote: > > printk() without KERN_ facility is flagged by checkpatch as a > > warning. It is better to use pr_info() which comes with an

[PATCH 6/6] staging: media: atomisp: use printk with KERN facility level

2021-04-19 Thread Deepak R Varma
printk() without KERN_ facility is flagged by checkpatch as a warning. It is better to use pr_info() which comes with an inbuilt KERN_INFO level. Signed-off-by: Deepak R Varma --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 5/6] staging: media: atomisp: fix CamelCase variable naming

2021-04-19 Thread Deepak R Varma
Mixed case variable names are discouraged and they result in checkpatch script "Avoid CamelCase" warnings. Replace such CamelCase variable names by lower case strings according to the coding style guidelines. Signed-off-by: Deepak R Varma --- .../media/atomisp/i2c/atomisp-mt9m114.c

[PATCH 4/6] staging: media: atomisp: reformat code comment blocks

2021-04-19 Thread Deepak R Varma
Reformat code comment blocks according to the coding style guidelines. This resolves different checkpatch script WARNINGs around block comments. Signed-off-by: Deepak R Varma --- .../media/atomisp/i2c/atomisp-gc2235.c| 8 +++ .../atomisp/i2c/atomisp-libmsrlisthelper.c| 3

[PATCH 3/6] staging: media: atomisp: use __func__ over function names

2021-04-19 Thread Deepak R Varma
Replace hard coded function names from the debug print strings by standard __func__ predefined identifier. This resolves following checkpatch script WARNING: Prefer using '"%s...", __func__' to using function's name, in a string. Signed-off-by: Deepak R Varma --- .../

[PATCH 2/6] staging: media: atomisp: balance braces around if...else block

2021-04-19 Thread Deepak R Varma
Balance braces around the if else blocks as per the code style guidelines. Resolves checkpatch script CHECK / WARNING feedback messages. Signed-off-by: Deepak R Varma --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4

[PATCH 1/6] staging: media: atomisp: improve function argument alignment

2021-04-19 Thread Deepak R Varma
Improve multi-line function argument alignment according to the code style guidelines. Resolves checkpatch feedback: "Alignment should match open parenthesis". Signed-off-by: Deepak R Varma --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- drivers/staging/media/a

[PATCH 0/6] staging: media: atomisp: code cleanup fixes

2021-04-19 Thread Deepak R Varma
This patch set addresses different kinds of checkpatch WARNING and CHECK complaints. Note: The patches should be applied in the ascending order. Deepak R Varma (6): staging: media: atomisp: improve function argument alignment staging: media: atomisp: balance braces around if...else block

Re: [PATCH 3/3] gpio: zynq: Check return value of irq_get_irq_data

2021-04-17 Thread Deepak R Varma
On Fri, Apr 09, 2021 at 07:38:06PM +0530, Srinivas Neeli wrote: > In two different instances the return value of "irq_get_irq_data" > API was neither captured nor checked. > Fixed it by capturing the return value and then checking for any error. > > Addresses-Coverity: "returned_null" > Signed-off

[PATCH V2 2/2] soc: qcom: aoss: Add debugfs entry

2021-04-08 Thread Deepak Kumar Singh
It can be useful to control the different power states of various parts of hardware for device testing. Add a debugfs node for qmp so messages can be sent to aoss for debugging and testing purposes. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/qcom_aoss.c

[PATCH V2 1/2] soc: qcom: aoss: Expose send for generic usecase

2021-04-08 Thread Deepak Kumar Singh
From: Deepak Kumar Singh Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own messages to aoss. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom

[PATCH V2 0/2] soc: qcom: aoss: Expose send for generic usecase

2021-04-08 Thread Deepak Kumar Singh
Change from V1 Addressesed all review comments in previous set. Deepak Kumar Singh (2): soc: qcom: aoss: Expose send for generic usecase soc: qcom: aoss: Add debugfs entry drivers/soc/qcom/qcom_aoss.c | 91 +- include/linux/soc/qcom/qcom_aoss.h | 33

[PATCH V1 2/2] soc: qcom: aoss: Add debugfs entry

2021-04-01 Thread Deepak Kumar Singh
It can be useful to control the different power states of various parts of hardware for device testing. Add a debugfs node for qmp so messages can be sent to aoss for debugging and testing purposes. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/qcom_aoss.c

[PATCH V1 1/2] soc: qcom: aoss: Expose send for generic usecase

2021-04-01 Thread Deepak Kumar Singh
Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own messages to aoss. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/qcom_aoss.c | 36

[PATCH V1 0/2] soc: qcom: aoss: Expose send for generic usecase

2021-04-01 Thread Deepak Kumar Singh
[Change from V0] Update qmp_get to parse qmp handle with binding qcom,qmp Deepak Kumar Singh (2): soc: qcom: aoss: Expose send for generic usecase soc: qcom: aoss: Add debugfs entry drivers/soc/qcom/qcom_aoss.c | 77 +++- 1 file changed, 76 insertions

[PATCH V1 1/1] soc: qcom: smp2p: Add enable_irq_wake to SMP2P IRQ

2021-03-18 Thread Deepak Kumar Singh
SMP2P interrupts are expected to wake the processor from suspend. Use enable_irq_wake to mark it wakeup capable from suspend. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/soc/qcom/smp2p.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/smp2p.c b

Re: [PATCH v2] drm/vc4: replace idr_init() by idr_init_base()

2020-11-08 Thread Deepak R Varma
On Fri, Nov 06, 2020 at 11:52:49AM +0100, Maxime Ripard wrote: > On Thu, Nov 05, 2020 at 01:24:14PM -0800, Eric Anholt wrote: > > On Thu, Nov 5, 2020 at 12:21 PM Deepak R Varma wrote: > > > > > > idr_init() uses base 0 which is an invalid identifier for this driver. &

[PATCH v2] drm/vc4: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
from 0 since 0 is always unused / available. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") Signed-off-by: Deepak R Varma --- Changes since v1: - Change suggested by Eric Anholt 1. Use VC4_PERFMONID_MIN instead of magic number 1 drivers/g

Re: [PATCH] drm/vc4: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
On Thu, Nov 05, 2020 at 11:25:11AM -0800, Eric Anholt wrote: > On Thu, Nov 5, 2020 at 10:25 AM Deepak R Varma wrote: > > > > idr_init() uses base 0 which is an invalid identifier for this driver. > > The idr_alloc for this driver uses VC4_PERFMONID_MIN as start value for &

[PATCH] drm/vmwgfx: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
/ available. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") Signed-off-by: Deepak R Varma --- drivers/gpu/drm/vmwgfx/ttm_object.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

[PATCH] drm/qxl: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
/ available. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") Signed-off-by: Deepak R Varma --- drivers/gpu/drm/qxl/qxl_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index dc

[PATCH] drm/vc4: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
from 0 since 0 is always unused / available. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") Signed-off-by: Deepak R Varma --- drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_pe

[PATCH] drm/tegra: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
cient") Signed-off-by: Deepak R Varma --- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index ba9d1c3e7cac..e4baf07992a4 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu

Re: [PATCH] drm/vgm: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
On Thu, Nov 05, 2020 at 12:16:34PM +0100, Daniel Vetter wrote: > On Thu, Nov 5, 2020 at 11:31 AM Deepak R Varma wrote: > > > > On Thu, Nov 05, 2020 at 10:42:15AM +0100, Daniel Vetter wrote: > > > On Wed, Nov 04, 2020 at 04:53:38PM +0530, Deepak R Varma wrote: > > &g

[PATCH v2] drm/vgem: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
Signed-off-by: Deepak R Varma --- Changes since v1: - Changes suggested by Daniel Vetter: 1. Correct typo in patch summary 2. cc intel-gfx to get the patch through CI bot test drivers/gpu/drm/vgem/vgem_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

Re: [PATCH] drm/amdkfd: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
On Wed, Nov 04, 2020 at 03:01:17PM -0500, Felix Kuehling wrote: > On 2020-11-04 10:13 a.m., Deepak R Varma wrote: > > idr_init() uses base 0 which is an invalid identifier. The new function > > idr_init_base allows IDR to set the ID lookup from base 1. This avoids > > all l

Re: [PATCH] drm/vgm: replace idr_init() by idr_init_base()

2020-11-05 Thread Deepak R Varma
On Thu, Nov 05, 2020 at 10:42:15AM +0100, Daniel Vetter wrote: > On Wed, Nov 04, 2020 at 04:53:38PM +0530, Deepak R Varma wrote: > > idr_init() uses base 0 which is an invalid identifier. The new function > > idr_init_base allows IDR to set the ID lookup from base 1. This avoids

[PATCH] drm/amdgpu: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/

[PATCH] drm/amdkfd: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_events.c index ba2c2ce0c55a..b3

[PATCH] drm/i915/perf: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index e94976976571..2d033255b7cf 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gp

[PATCH] drm/i915/gvt: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/gvt/gvt.c | 2 +- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c index c7c561237883..45b492edbb19 100644 --- a/drivers/gp

[PATCH] drm/vgm: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
Signed-off-by: Deepak R Varma --- drivers/gpu/drm/vgem/vgem_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c index 17f32f550dd9..2902dc6e64fa 100644 --- a/drivers/gpu/drm/vgem/vgem_fence.c +++ b/drive

[PATCH 6/6] drm/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
should be "foo *bar" ERROR: "foo*bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/atom.c | 16 drivers/gpu/drm/amd/amdgpu/at

[PATCH 5/6] drm/amdgpu/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
should be "foo *bar" ERROR: "foo*bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ato

[PATCH 4/6] drm/amdgpu/sdma: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
should be "foo *bar" ERROR: "foo*bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 6

[PATCH 3/6] drm/amdgpu/jpeg: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
should be "foo *bar" ERROR: "foo*bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c

[PATCH 2/6] drm/amdgpu/umc: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
should be "foo *bar" ERROR: "foo*bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/umc_v6_1.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 4 ++--

[PATCH 1/6] drm/amdgpu/vcn: use "*" adjacent to data name

2020-11-02 Thread Deepak R Varma
quot; should be "foo *bar" ERROR: "foo*bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c

[PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Deepak R Varma
Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue reported by checkpatch script as: ERROR: do not initialise globals to 0 (or NULL). Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 46 - drivers/gpu/drm

[PATCH 6/6] drm/amdgpu: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. The patch covers various .c files for this driver. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu

[PATCH 5/6] drm/amdgpu/amdgpu: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. The patch corrects issues for various amdgpu_*.c files for this driver. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers

[PATCH 4/6] drm/amdgpu/nbio: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 4 ++-- drivers/gpu/drm/amd/amdgpu

[PATCH 3/6] drm/amdgpu/vcn: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_5

[PATCH 2/6] drm/amdgpu/gfx: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 10 +- drivers/gpu/drm/amd/amdgpu

[PATCH 1/6] drm/amdgpu/dce: improve code indentation and alignment

2020-11-02 Thread Deepak R Varma
General code indentation and alignment changes such as replace spaces by tabs or align function arguments as per the coding style guidelines. Issue reported by checkpatch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu

Re: [Outreachy kernel] [PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-30 Thread Deepak R Varma
; Am 30.10.20 um 08:57 schrieb Deepak R Varma: > > > > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote: > > > > > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote: > > > > > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro wit

Re: [Outreachy kernel] [PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-30 Thread Deepak R Varma
On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote: > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote: > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe() > > function in place of the debugfs_create_file() function will make the > >

[PATCH v2] drm/amd/pm: replace kmalloc+memcpy by kmemdup

2020-10-29 Thread Deepak R Varma
Use kmemdup() for instructions using kmalloc() + memcpy(). More information here: https://lwn.net/Articles/198928/ Issue reported by coccinelle script: scripts/coccinelle/api/memdup.cocci Signed-off-by: Deepak R Varma --- Changes since v1: - Update patch subject and log message to match

[PATCH] drm/sti: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Issue reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is a Outreachy project task patch. drivers/gpu/drm/sti/sti_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH] drm/panel: st7703: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Issue reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is a Outreachy project task patch. drivers/gpu/drm/panel/panel-sitronix-st7703.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff

[PATCH] drm/i915/gvt: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Issue reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is a Outreachy project task patch. drivers/gpu/drm/i915/gvt/debugfs.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/

[PATCH] drm/amd/pm: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Issue reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is a Outreachy project task patch. .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 ++--- 1 file changed, 2 insertions(+), 3 del

[PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Issue reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is a Outreachy project task patch. drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 20 ++-- 1 file changed, 10 insertions(+), 10 del

[PATCH 2/2] drm: msm: adreno: improve code indentation & alignment

2020-10-29 Thread Deepak R Varma
Align instructions split across multiple lines as per the coding standards. Issue flagged by checkpatch script. Signed-off-by: Deepak R Varma --- Please note: This is a project task specific patch. drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 1/2] drm: msm: adreno: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-10-29 Thread Deepak R Varma
Issue reported by Coccinelle script: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Please Note: This is project task specific patch. drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [PATCH V5 0/4] Signaling api support in glink/rpmsg clients

2020-09-02 Thread Deepak Kumar Singh
On 7/6/2020 11:34 PM, Mathieu Poirier wrote: Hi Deepak, On Fri, Jun 26, 2020 at 08:16:55PM +0530, Deepak Kumar Singh wrote: Change from version 5 [V5,4/4] rpmsg: char: Add signal callback and POLLPRI support Updated for sparse warning. Replaced POLLPRI => EPOLLPRI to fix warning. Cha

[PATCH V7 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2020-09-02 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 54

[PATCH V7 1/4] rpmsg: core: Add signal API support

2020-09-02 Thread Deepak Kumar Singh
. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 40 drivers/rpmsg/rpmsg_internal.h | 5 + include/linux/rpmsg.h | 27 +++ 3

[PATCH V7 4/4] rpmsg: char: Add signal callback and POLLPRI support

2020-09-02 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 22

[PATCH V7 2/4] rpmsg: glink: Add support to handle signals command

2020-09-02 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Deepak

[PATCH V7 0/4] Signaling api support in glink/rpmsg clients

2020-09-02 Thread Deepak Kumar Singh
tch V4,2/4 is intentional. Arun Kumar Neelakantam (3): rpmsg: glink: Add support to handle signals command rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support rpmsg: char: Add signal callback and POLLPRI support Deepak Kumar Singh (1): rpmsg: core: Add signal API support drivers/rp

[PATCH V1 1/4] net: qrtr: Do not send packets before hello negotiation

2020-08-30 Thread Deepak Kumar Singh
From: Chris Lew There is a race where broadcast packets can be sent to a node that has not sent the hello message to the remote processor. This breaks the protocol expectation. Add a status variable to track when the hello packet has been sent. An alternative solution attempted was to remove the

[PATCH V1 4/4] net: qrtr: Check function pointer before calling

2020-08-30 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam sk_error_report callback function called without validating cause the NULL pointer dereference. Validate function pointer before using for error report. --- net/qrtr/qrtr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/qrtr/qrtr.c b/net/q

[PATCH V1 2/4] net: qrtr: Add socket mode optimization

2020-08-30 Thread Deepak Kumar Singh
From: Chris Lew A remote endpoint should not need to know when a client socket is freed if the socket never established commnication with the endpoint. Add a mode to keep track of which endpoints a socket communicates with. There are three modes a socket can be in: INIT - Socket has no

[PATCH V1 3/4] net: qrtr: Change port allocation to use cyclic idr

2020-08-30 Thread Deepak Kumar Singh
From: Chris Lew There is a race for clients that open sockets before the control port is bound. If a client gets an idr that was allocated before the control port is bound, there is a chance the previous address owner sent lookup packets to the control port. The new address owner will get residua

[PATCH V1 0/4] General qrtr fixes

2020-08-30 Thread Deepak Kumar Singh
Arun Kumar Neelakantam (1): net: qrtr: Check function pointer before calling Chris Lew (3): net: qrtr: Do not send packets before hello negotiation net: qrtr: Add socket mode optimization net: qrtr: Change port allocation to use cyclic idr net/qrtr/qrtr.c | 93 +++

[PATCH V1 2/6] rpmsg: glink: Deny intent request if reusable intent fits

2020-07-29 Thread Deepak Kumar Singh
. In order to prevent intent build up, deny intent requests that can be fulfilled by default intents that are reusable. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_native.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff

[PATCH V1 4/6] rpmsg: glink: Remove the rpmsg dev in close_ack

2020-07-29 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Un-register and register of rpmsg driver is sending invalid open_ack on closed channel. To avoid sending invalid open_ack case unregister the rpmsg device after receiving the local_close_ack from remote side. Signed-off-by: Deepak Kumar Singh signed-off-by: Arun

[PATCH V1 3/6] rpmsg: glink: Add TX_DATA_CONT command while sending

2020-07-29 Thread Deepak Kumar Singh
-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_native.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index df3c608..ac179b1 100644 --- a/drivers/rpmsg

[PATCH V1 6/6] rpmsg: glink: Send READ_NOTIFY command in FIFO full case

2020-07-29 Thread Deepak Kumar Singh
sending IRQ. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg

[PATCH V1 5/6] rpmsg: glink: Remove channel decouple from rpdev release

2020-07-29 Thread Deepak Kumar Singh
that should only happen from the close commands. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_native.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 031bc1d..efaf32d 100644

[PATCH V1 1/6] rpmsg: glink: fix destroy channel endpoint logic

2020-07-29 Thread Deepak Kumar Singh
sending second glink close command. Signed-off-by: Konstantin Dorfman Signed-off-by: Deepak Kumar Singh --- drivers/rpmsg/qcom_glink_native.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 1995f5b..2668c66

[PATCH V1 0/6] Glink native fixes upstreaming

2020-07-29 Thread Deepak Kumar Singh
Includes fixes for - Few race conditions while channel release and close Proper unregistration of rpmsg device to avoid use of stale device Send notify command to remote when glink fifo is full Handling packet size larger that 16K Arun Kumar Neelakantam (3): rpmsg: glink: Add TX_DATA_CONT comman

[PATCH V5 0/4] Signaling api support in glink/rpmsg clients

2020-06-26 Thread Deepak Kumar Singh
to and from native signal as done in patch V4,2/4 is intentional. Arun Kumar Neelakantam (3): rpmsg: glink: Add support to handle signals command rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support rpmsg: char: Add signal callback and POLLPRI support Deepak Kumar Singh (1): rpmsg: core:

[PATCH V6 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2020-06-26 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 54

[PATCH V6 4/4] rpmsg: char: Add signal callback and POLLPRI support

2020-06-26 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 22

[PATCH V6 1/4] rpmsg: core: Add signal API support

2020-06-26 Thread Deepak Kumar Singh
. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 40 drivers/rpmsg/rpmsg_internal.h | 5 + include/linux/rpmsg.h | 27 +++ 3

[PATCH V6 2/4] rpmsg: glink: Add support to handle signals command

2020-06-26 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Deepak

[PATCH V5 2/4] rpmsg: glink: Add support to handle signals command

2020-06-24 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Deepak

[PATCH V5 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2020-06-24 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 54

[PATCH V5 4/4] rpmsg: char: Add signal callback and POLLPRI support

2020-06-24 Thread Deepak Kumar Singh
From: Arun Kumar Neelakantam Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 22

[PATCH V5 1/4] rpmsg: core: Add signal API support

2020-06-24 Thread Deepak Kumar Singh
. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 40 drivers/rpmsg/rpmsg_internal.h | 5 + include/linux/rpmsg.h | 27 +++ 3

[PATCH V7 4/4] rpmsg: glink: Expose rpmsg name attr for glink

2020-06-24 Thread Deepak Kumar Singh
From: Chris Lew Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 26

[PATCH V7 1/4] rpmsg: glink: Use complete_all for open states

2020-06-24 Thread Deepak Kumar Singh
From: Chris Lew The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar

[PATCH V7 3/4] rpmsg: glink: Add support for rpmsg glink chrdev

2020-06-24 Thread Deepak Kumar Singh
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 38

  1   2   3   >