Hi Linus,
Thanks for you adding it.
I left the office for a few days due to holiday.
在 2017/10/7 18:32, Linus Walleij 写道:
On Sat, Sep 30, 2017 at 5:07 PM, Heiko Stuebner wrote:
Am Samstag, 30. September 2017, 20:13:21 CEST schrieb David Wu:
If the gmac-m1 optimization(bit10) is selected, the
Hi Thierry,
在 2017/8/19 0:28, Brian Norris 写道:
On Fri, Aug 18, 2017 at 05:32:55PM +0200, Thierry Reding wrote:
I don't understand what the "judge" is supposed to be, but I've applied
this to for-4.14/drivers anyway. Thanks.
Probably just an artifact of non-native English.
Judging by context,
Hi Heiko,
在 2017/8/21 18:32, Heiko Stuebner 写道:
Hi David,
Am Montag, 21. August 2017, 18:22:31 CEST schrieb David.Wu:
Hi Elaine,
在 2017/8/21 16:16, Elaine Zhang 写道:
This patch exports gmac aclk and pclk for dts reference.
Signed-off-by: Elaine Zhang
---
include/dt-bindings/clock/rv1108
Hi Elaine,
在 2017/8/21 16:16, Elaine Zhang 写道:
cru_sel24_con[8]
rmii_extclk_sel
clock source select control register
1'b0: from internal PLL
1'b1: from external IO
Signed-off-by: Elaine Zhang
---
drivers/clk/rockchip/clk-rv1108.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Hi Elaine,
在 2017/8/21 16:16, Elaine Zhang 写道:
This MAC has no internal phy for rv1108.
Signed-off-by: Elaine Zhang
---
drivers/clk/rockchip/clk-rv1108.c | 12 ++--
include/dt-bindings/clock/rv1108-cru.h | 6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
Acked-by:
Hi Elaine,
在 2017/8/21 16:16, Elaine Zhang 写道:
This patch exports gmac aclk and pclk for dts reference.
Signed-off-by: Elaine Zhang
---
include/dt-bindings/clock/rv1108-cru.h | 2 ++
1 file changed, 2 insertions(+)
Acked-by: David Wu
Hi Elaine,
在 2017/8/21 16:16, Elaine Zhang 写道:
Signed-off-by: Elaine Zhang
---
drivers/clk/rockchip/clk-rv1108.c | 2 ++
1 file changed, 2 insertions(+)
Acked-by: David Wu
Hi Thierry,
For the PWM patches, whether we let the first patch land in, that is PWM
APB and function clocks are different in rk3328 and rv1108 SOCs. If the
first patch was merged before 4.14, it will guarantee that the PWM is
working, and the lock function you might review it later.
在 2017/
Hi Boris && thierry,
Do you have any other suggestion for the patches?
在 2017/8/8 23:38, David Wu 写道:
There are two features of rk3328 pwm module.
- PWM APB and function clocks are different.
- Add pwm atomic hardware update
David Wu (7):
pwm: rockchip: Add APB and function both clocks
Hi Andrew, Florian
在 2017/8/10 8:20, Andrew Lunn 写道:
Hi Florian, David.
I'm happy with the property name. But i think the text needs more
description. We deal with Ethernet switches with integrated PHYs. Yet
for us, this property is unneeded.
Seeing this property means some bit of software nee
Hi Chen-Yu,
在 2017/8/10 10:40, Chen-Yu Tsai 写道:
Hi David,
On Wed, Aug 9, 2017 at 5:38 PM, David.Wu wrote:
Hello Corentin, Chen-Yu
在 2017/8/9 16:45, Corentin Labbe 写道:
On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote:
On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli
wrote
Hello Corentin, Chen-Yu
在 2017/8/9 16:45, Corentin Labbe 写道:
On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote:
On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli wrote:
On 08/01/2017 11:21 PM, David Wu wrote:
To make internal phy work, need to configure the phy_clock,
phy cru_reset
Hi Andrew,
在 2017/8/2 21:21, Andrew Lunn 写道:
+static struct phy_driver rockchip_phy_driver[] = {
+{
+ .phy_id = 0x1234d400,
+ .phy_id_mask= 0xfff0,
+ .name = "Rockchip internal EPHY",
+ .features = (PHY_BASIC
Hi Boris,
在 2017/8/4 15:09, Boris Brezillon 写道:
On Fri, 4 Aug 2017 10:38:26 +0800
"David.Wu" wrote:
Hi Boris，
在 2017/8/2 19:40, Boris Brezillon 写道:
Yep, just define 3 different pwm_ops (one for each IP), each of them
implementing ->apply() and ->get_state() and that's
Hi Boris，
在 2017/8/2 19:40, Boris Brezillon 写道:
Yep, just define 3 different pwm_ops (one for each IP), each of them
implementing ->apply() and ->get_state() and that's all.
Something like:
static const struct pwm_ops rockchip_pwm_ops_v1 = {
.get_state = rockchip_pwm_v1_get_state,
Hi Florian & ChenYu
在 2017/8/3 1:38, Florian Fainelli 写道:
This is incorrect in two ways:
- this is a property of the PHY, so it should be documented as such in
Documentation/devicetree/bindings/net/phy.txt so other bindings can
re-use it
- if it was specific to your MAC you would expect a vend
Hi Boris,
在 2017/8/2 16:59, Boris Brezillon 写道:
Actually, when I suggested to just implement ->apply_state() and be
done with all other fields I was thinking that you could get rid of
this rockchip_pwm_data struct entirely and just have 3 different
pwm_ops. You seem to take the other direction h
Hi thierry & boris,
Do you have any other suggestion for the patches?
We hope to make them arrive in Linux-v4.14.
在 2017/7/8 12:03, David Wu 写道:
There are two features of rk3328 pwm module.
- PWM APB and function clocks are different.
- Add pwm atomic hardware update
David Wu (7):
pwm:
Hi Florian,
在 2017/7/28 0:51, Florian Fainelli 写道:
+}
+
+static int rockchip_internal_phy_config_init(struct phy_device *phydev)
+{
+ int val;
+
+ /*
+* The auto MIDX has linked problem on some board,
+* workround to disable auto MDIX.
+*/
If this a board-spe
Hi Andrew,
在 2017/7/27 21:38, Andrew Lunn 写道:
+ /*
+* If mode switch happens from 10BT to 100BT, all DSP/AFE
+* registers are set to default values. So any AFE/DSP
+* registers have to be re-initialized in this case.
+*/
Hi David
Are they also lost on sus
Hi Florian,
在 2017/7/28 0:54, Florian Fainelli 写道:
- if you need knowledge about this PHY connection type prior to binding
the PHY device and its driver (that is, before of_phy_connect()) we
could add a boolean property e.g: "phy-is-internal" that allows us to
know that, or we can have a new phy
Hi Andrew,
在 2017/7/27 21:48, Andrew Lunn 写道:
I think we need to discuss this. This PHY appears to be on an MDIO
bus, it uses a standard PHY driver, and it appears to be using an RMII
interface. So it is just an ordinary PHY.
Internal is supposed to be something which is not ordinary, does not
Hi Andrew,
在 2017/6/24 10:29, Andrew Lunn 写道:
If this is the PHY clock, should it actually be specified in the PHY
binding? Can you read the PHY ID registers with this clock off?
If the phy clock is closed, we can not read the PHYID.
Hi Doug,
在 2017/7/12 1:03, Doug Anderson 写道:
Hi,
On Fri, Jul 7, 2017 at 9:03 PM, David Wu wrote:
@@ -6,7 +6,13 @@ Required properties:
"rockchip,rk3288-pwm": found on RK3288 SoC
"rockchip,vop-pwm": found integrated in VOP on RK3288 SoC
- reg: physical base address and length of
Hi Boris,
在 2017/7/4 2:39, Boris Brezillon 写道:
Yet another customization. Don't you think we can extract common parts,
expose them as helpers and then have 3 different pwm_ops (with 3
different ->apply() implementation), one for each IP revision.
Sounds reasonable.I will try to implement 3 dif
Hi Boris,
在 2017/7/4 2:36, Boris Brezillon 写道:
Hm, maybe it's time to drop these custom hooks and implement
pwm_apply_v1 and pwm_apply_v2 instead.
Okay, drop the enable and config hooks, only use the apply hook to
instead them.
Hi Andrew,
在 2017/6/27 22:46, Andrew Lunn 写道:
it has been licensed from somebody.
And does that somebody already have a driver for it? There is no point
adding a driver, if all you need to do is add the ID to another
driver.
I didn't find it.
Maybe use the same, but the configuration is dif
Hi Andrew,
在 2017/6/24 10:19, Andrew Lunn 写道:
On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote:
Support internal ephy currently.
Signed-off-by: David Wu
---
drivers/net/phy/Kconfig| 4 ++
drivers/net/phy/Makefile | 1 +
drivers/net/phy/rockchip.c | 94 +
Hi Heiko,
在 2017/6/24 1:19, Heiko Stuebner 写道:
Hi David,
Am Freitag, 23. Juni 2017, 12:59:07 CEST schrieb David Wu:
To make internal phy worked, need to configure the phy_clock,
phy cru_reset and related registers.
Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13
please remove all Chang
Hi Florian,
Sorry for reply late.
在 2017/6/24 0:22, Florian Fainelli 写道:
On 06/22/2017 09:59 PM, David Wu wrote:
To make internal phy worked, need to configure the phy_clock,
phy cru_reset and related registers.
Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13
Signed-off-by: David Wu
---
Hi Heiko,
在 2017/5/26 5:12, Heiko Stuebner 写道:
Requiring developers to calculate this pin-bit-value for each bank
is cumbersome and error-prone. With the routes-struct known in
the driver (see above and below), you can keep the the value element
in rockchip_pin_bank, but calculate the per-bank v
Hi Boris，
在 2017/3/1 18:19, Boris Brezillon 写道:
On Wed, 1 Mar 2017 18:16:02 +0800
David Wu wrote:
From: "david.wu"
If the pwm was not enabled at uboot loader, pwm could not work for clock
always disabled at pwm driver. The pwm clock is enabled at beginning of
pwm_apply(), but d
Hi Heiko,
在 2017/2/24 0:51, Heiko Stuebner 写道:
Hi David,
Am Dienstag, 14. Februar 2017, 18:35:40 CET schrieb David Wu:
From: "david.wu"
struct rockchip_pin_config {
@@ -1355,6 +1358,53 @@ static int rockchip_set_pull(struct rockchip_pin_bank
*bank, return ret;
}
+
Hi Rafael,
Sorry not to include your email address in the email list.
And thank Heiko.
I will resend the patch.
在 2017/2/21 23:06, Heiko Stuebner 写道:
Am Montag, 20. Februar 2017, 10:08:05 CET schrieb David Wu:
From: "david.wu"
This adds the necessary data for handling io voltage
Hi Heiko,
Sorry for late reply because of the holiday.
@@ -355,6 +359,24 @@ struct rockchip_pinctrl {
unsigned intnfunctions;
};
+/**
+ * struct rockchip_mux_recalced_data: represent a pin iomux data.
+ * @num: bank num.
+ * @bit: index at register or used to calc
rning, and they should fix it, not
to start i2c access and the moment.
在 2016/12/8 0:27, Grygorii Strashko 写道:
On 12/06/2016 09:37 PM, David.Wu wrote:
Hi Doug,
在 2016/12/7 0:31, Doug Anderson 写道:
Hi,
On Tue, Dec 6, 2016 at 12:12 AM, David.Wu
wrote:
Hi Heiko,
在 2016/12/5 18:54, Heiko S
Hi Doug,
在 2016/12/7 0:31, Doug Anderson 写道:
Hi,
On Tue, Dec 6, 2016 at 12:12 AM, David.Wu wrote:
Hi Heiko,
在 2016/12/5 18:54, Heiko Stuebner 写道:
Hi David,
Am Montag, 5. Dezember 2016, 16:02:59 CET schrieb David Wu:
During suspend there may still be some i2c access happening.
And if we
Hi Heiko,
在 2016/12/5 18:54, Heiko Stuebner 写道:
Hi David,
Am Montag, 5. Dezember 2016, 16:02:59 CET schrieb David Wu:
During suspend there may still be some i2c access happening.
And if we don't keep i2c irq ON, there may be i2c access timeout if
i2c is in irq mode of operation.
can you desc
Hi Doug,
Last replied email HTML HEAD error, resend it.
在 2016/8/30 5:22, Douglas Anderson 写道:
Depending on a number of factors including:
- Which exact Rockchip SoC we're working with
- How deep we suspend
- Which i2c port we're on
We might lose the state of the i2c registers at suspend time.
Hi Wolfram，
在 2016/6/17 19:56, Wolfram Sang 写道:
Applied whole series to for-next, thanks! This was nicely refactored and
easy to review, thanks. Also thanks to all reviewers who helped this
series. I fixed one checkpatch issue for you, though:
WARNING: Statements should start on a tabstop
#278:
Hi Wolfram，
在 2016/6/17 19:56, Wolfram Sang 写道:
Applied whole series to for-next, thanks! This was nicely refactored and
easy to review, thanks. Also thanks to all reviewers who helped this
series. I fixed one checkpatch issue for you, though:
WARNING: Statements should start on a tabstop
#278:
Hi Doug,
在 2016/5/17 4:09, Douglas Anderson 写道:
From: David Wu
We've got 9 (count em!) i2c controllers on rk3399, some of which are in
the PMU power domain and some of which are normal peripherals. Add them
all to the main rk3399 dtsi file so future patches can turn them on in
the board dts f
Hi Doug，
在 2016/5/12 9:08, David.Wu 写道:
Hi Doug,
在 2016/5/12 1:37, Doug Anderson 写道:
Hi,
On Tue, May 10, 2016 at 12:31 PM, David Wu
wrote:
static void rk3x_i2c_adapt_div(struct rk3x_i2c *i2c, unsigned long
clk_rate)
{
struct i2c_timings *t = &i2c->t;
Hi Doug,
在 2016/5/12 0:35, Doug Anderson 写道:
Hi,
On Tue, May 10, 2016 at 12:30 PM, David Wu wrote:
The bus clock and function clock are separated at rk3399,
and others use one clock as the bus clock and function clock.
Signed-off-by: David Wu
Reviewed-by: Douglas Anderson
---
Change in v8:
Hi Heiko
在 2016/5/12 2:26, Heiko Stuebner 写道:
Am Mittwoch, 11. Mai 2016, 03:24:07 schrieb David Wu:
Call rk3x_i2c_setup() before rk3x_i2c_start()
That beginning of the sentence could use a tiny improvement, like
rk3x_i2c_setup() gets called directly before rk3x_i2c_start()
Okay,
Hi Doug,
在 2016/5/12 1:37, Doug Anderson 写道:
Hi,
On Tue, May 10, 2016 at 12:31 PM, David Wu wrote:
static void rk3x_i2c_adapt_div(struct rk3x_i2c *i2c, unsigned long clk_rate)
{
struct i2c_timings *t = &i2c->t;
struct rk3x_i2c_calced_timings calc;
u64 t_low_ns,
Hi Doug,
在 2016/5/6 7:00, Doug Anderson 写道:
David,
On Wed, May 4, 2016 at 7:36 AM, David Wu wrote:
+/**
+ * Calculate timing values for desired SCL frequency
+ *
+ * @clk_rate: I2C input clock rate
+ * @t: Known I2C timing information
+ * @t_calc: Caculated rk3x private timings that would be
Hi Rob,
在 2016/5/6 6:12, Rob Herring 写道:
On Wed, May 04, 2016 at 10:35:23PM +0800, David Wu wrote:
The bus clock and function clock are separated at rk3399,
and others use one clock as the bus clock and function clock.
Signed-off-by: David Wu
---
Documentation/devicetree/bindings/i2c/i2c-rk
Hi Doug,
在 2016/5/6 6:58, Doug Anderson 写道:
David,
On Wed, May 4, 2016 at 7:34 AM, David Wu wrote:
Signed-off-by: David Wu
As you can probably guess, again a description would be nice. Like maybe:
The i2c timing specs are really just constant data. There's no reason
to write code to ini
Hi Doug,
在 2016/5/6 6:56, Doug Anderson 写道:
David,
On Wed, May 4, 2016 at 7:13 AM, David Wu wrote:
Signed-off-by: David Wu
---
Change in v7:
- none
drivers/i2c/busses/i2c-rk3x.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Probably this change could be dropped now. Switch
Hi Doug,
在 2016/5/6 6:55, Doug Anderson 写道:
David,
On Wed, May 4, 2016 at 7:13 AM, David Wu wrote:
Signed-off-by: David Wu
Usually folks like a description and not just a subject line. I'd add
a description like:
The "div_high" and "div_low" values are always used together. Group them
i
Hi Doug,
在 2016/5/6 7:02, Doug Anderson 写道:
David,
On Wed, May 4, 2016 at 7:37 AM, David Wu wrote:
Signed-off-by: David Wu
---
drivers/i2c/busses/i2c-rk3x.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i
Hi Wolfram，
在 2016/4/16 1:58, Wolfram Sang 写道:
The default frequency rate of function clock is 50M Hz, it can match
F/S mode, but HS mode not. If use default rate 50M to get 1.7M
scl-frequency rate , we could not get accurately 1.7M frequecy rate.
The input-clk-rate is more higher, we get more a
Hi Heiko,
在 2016/4/15 15:31, Heiko Stübner 写道:
David,
Am Donnerstag, 14. April 2016, 20:48:48 schrieb Wolfram Sang:
+ - input-clk-rate : frequency rate of function clock used(in Hz). If
omitted, + the default clock rate is used. It is just used at rk3399 soc.
Why is this needed? Why don'
Hi Wolfram,
在 2016/4/15 2:48, Wolfram Sang 写道:
+ - input-clk-rate : frequency rate of function clock used(in Hz). If omitted,
+ the default clock rate is used. It is just used at rk3399 soc.
Why is this needed? Why don't we simply use the default or calculate the
best value somehow?
The d
Hi Heiko,
在 2016/2/2 5:17, Heiko Stübner 写道:
Hi David,
Am Montag, 1. Februar 2016, 16:54:38 schrieb David.Wu:
在 2016/1/30 20:39, Heiko Stuebner 写道:
Am Samstag, 30. Januar 2016, 20:01:45 schrieb David Wu:
As rk3368 contained two separated iodomain areas, this was
determined to use which
Hi Heiko,
在 2016/1/30 20:39, Heiko Stuebner 写道:
Hi David,
Am Samstag, 30. Januar 2016, 20:01:45 schrieb David Wu:
As rk3368 contained two separated iodomain areas, this was
determined to use which regmap base address.
Signed-off-by: David Wu
I don't think we need to specify this on a driver
Hi Heiko,
在 2016/1/30 20:16, Heiko Stuebner 写道:
Hi David,
Am Samstag, 30. Januar 2016, 19:31:57 schrieb David Wu:
Change-Id: Ic1bdb3dc358837e97d7b48dd58be2f8d9d08d766
please no Change-Id, it's missing the Signed-off, and as Linus Walleij said,
the compatible addition to the documentation can
Hi Heiko,
在 2016/1/29 0:56, Heiko Stübner 写道:
Hi David,
Am Donnerstag, 7. Januar 2016, 15:41:38 schrieb David Wu:
From: David Wu
The pinctrl of rk3399 is much different from other's,
especially the 3bits of drive strength.
Signed-off-by: David Wu
---
change from v1:
- need spin_unlock_irqr
59 matches
Mail list logo
