Re: [PATCH v5 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-05-03 Thread David Heidelberg
Kind ping on the series. When the series is considered solid, it will improve Linux usability on lower-quality touchscreen replacements (including those from other vendors and models) outside of our Snapdragon 845 downstream fork. Thank you David On 10/04/2025 16:28, David Heidelberg via B4

[PATCH v5 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs

2025-04-10 Thread David Heidelberg via B4 Relay
t, so these fallback values are offered as an alternative to the error path when register descriptors aren't available. Signed-off-by: Kaustabh Chakraborty [changes for readability / codeflow, checkpatch fixes] Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/

[PATCH v5 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries

2025-04-10 Thread David Heidelberg via B4 Relay
us 6T (original parts): manufacturer: Synaptics, product: S3706B, fw id: 2852315 Co-developed-by: Kaustabh Chakraborty Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c

[PATCH v5 7/7] Input: synaptics-rmi4 - support fallback values for PDT descriptor bytes

2025-04-10 Thread David Heidelberg via B4 Relay
IC) rmi4_i2c 12-0020: read 6 bytes at 0x00e3: 0 (2c 23 0d 06 00 00) Signed-off-by: Kaustabh Chakraborty [codeflow adjustments, checkpatch fixes, wording] Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 62

[PATCH v5 4/7] Input: synaptics-rmi4 - f55: handle zero electrode count

2025-04-10 Thread David Heidelberg via B4 Relay
nolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_f55.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/input/rmi4/rmi_f55.c b/drivers/input/rmi4/rmi_f55.c index 488adaca4dd00482cd1106d813b32871092c83a0..776c915b82e72b8a6eb5ec701cce9059c87089c4 100644 --- a/drivers/

[PATCH v5 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b

2025-04-10 Thread David Heidelberg via B4 Relay
From: David Heidelberg Mostly irrelevant for authentic Synaptics touchscreens, but very important for applying workarounds to cheap TS knockoffs. These knockoffs work well with the downstream driver, and since the user has no way to distinguish them, later in this patch set, we introduce

[PATCH v5 5/7] Input: synaptics-rmi4 - don't do unaligned reads in IRQ context

2025-04-10 Thread David Heidelberg via B4 Relay
unaligned address. Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4

[PATCH v5 6/7] Input: synaptics-rmi4 - read product ID on aftermarket touch ICs

2025-04-10 Thread David Heidelberg via B4 Relay
Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_f01.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index 47be64284b25ede8103ada86d6b58fd3a26976bb..2278e9b6a920774b07ec9dd3e452cedc69469be8 100644

[PATCH v5 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-04-10 Thread David Heidelberg via B4 Relay
- Link to v1: https://lore.kernel.org/r/20230929-caleb-rmi4-quirks-v1-0-cc3c703f0...@linaro.org --- Caleb Connolly (1): Input: synaptics-rmi4 - handle duplicate/unknown PDT entries David Heidelberg (1): dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b Kaustabh Chakraborty (5)

[PATCH v4 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b-i2c

2025-04-05 Thread David Heidelberg via B4 Relay
From: David Heidelberg Mostly irrelevant for authentic Synaptics touchscreens, but very important for applying workarounds to cheap TS knockoffs. These knockoffs work well with the downstream driver, and since the user has no way to distinguish them, later in this patch set, we introduce

[PATCH v4 4/7] Input: synaptics-rmi4 - f55: handle zero electrode count

2025-04-05 Thread David Heidelberg via B4 Relay
nolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_f55.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/input/rmi4/rmi_f55.c b/drivers/input/rmi4/rmi_f55.c index 488adaca4dd00482cd1106d813b32871092c83a0..776c915b82e72b8a6eb5ec701cce9059c87089c4 100644 --- a/drivers/

[PATCH v4 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-04-04 Thread David Heidelberg via B4 Relay
...@linaro.org Changes in v2: - Improve dt-bindings patch (thanks Rob) - Add missing cast in patch 5 to fix the pointer arithmetic - Link to v1: https://lore.kernel.org/r/20230929-caleb-rmi4-quirks-v1-0-cc3c703f0...@linaro.org --- Caleb Connolly (1): Input: synaptics-rmi4 - handle duplicate/

[PATCH v4 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs

2025-04-04 Thread David Heidelberg via B4 Relay
t, so these fallback values are offered as an alternative to the error path when register descriptors aren't available. Signed-off-by: Kaustabh Chakraborty [changes for readability / codeflow, checkpatch fixes] Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/

[PATCH v4 7/7] Input: synaptics-rmi4 - support fallback values for PDT descriptor bytes

2025-04-02 Thread David Heidelberg via B4 Relay
IC) rmi4_i2c 12-0020: read 6 bytes at 0x00e3: 0 (2c 23 0d 06 00 00) Signed-off-by: Kaustabh Chakraborty [codeflow adjustments, checkpatch fixes, wording] Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 62

Re: [PATCH v3 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries

2025-04-02 Thread David Heidelberg
On 10/03/2025 20:10, Dmitry Torokhov wrote: Hi David, On Sat, Mar 08, 2025 at 03:08:38PM +0100, David Heidelberg via B4 Relay wrote: From: Caleb Connolly Some third party rmi4-compatible ICs don't expose their PDT entries very well. Add a few checks to skip duplicate entries as we

[PATCH v4 5/7] Input: synaptics-rmi4 - don't do unaligned reads in IRQ context

2025-04-02 Thread David Heidelberg via B4 Relay
unaligned address. Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4

[PATCH v4 6/7] Input: synaptics-rmi4 - read product ID on aftermarket touch ICs

2025-04-02 Thread David Heidelberg via B4 Relay
Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_f01.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index 47be64284b25ede8103ada86d6b58fd3a26976bb..2278e9b6a920774b07ec9dd3e452cedc69469be8 100644

[PATCH v4 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries

2025-04-02 Thread David Heidelberg via B4 Relay
us 6T (original parts): manufacturer: Synaptics, product: S3706B, fw id: 2852315 Co-developed-by: Kaustabh Chakraborty Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-28 Thread David Heidelberg
On 26/03/2025 11:26, Caleb Connolly wrote: On 3/26/25 07:57, Krzysztof Kozlowski wrote: On 25/03/2025 14:23, Caleb Connolly wrote: On 3/25/25 08:36, Krzysztof Kozlowski wrote: On 24/03/2025 19:00, David Heidelberg wrote: On 10/03/2025 10:45, Krzysztof Kozlowski wrote: On Sat, Mar 08

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-24 Thread David Heidelberg
On 10/03/2025 10:45, Krzysztof Kozlowski wrote: On Sat, Mar 08, 2025 at 03:08:37PM +0100, David Heidelberg wrote: From: Caleb Connolly This new property allows devices to specify some register values which are missing on units with third party replacement displays. These displays use

Re: [PATCH v3 0/7] Subject: [PATCH v3 0/7] Input: synaptics-rmi4: add quirks for third party touchscreen controllers

2025-03-11 Thread David Heidelberg
erstand it's an old series but I don't think that courtesy is too much to ask. On 3/8/25 14:08, David Heidelberg via B4 Relay wrote: With the growing popularity of running upstream Linux on mobile devices, we're beginning to run into more and more edgecases. The OnePlus 6 is a

[PATCH v3 6/7] Input: synaptics-rmi4 - read product ID on aftermarket touch ICs

2025-03-08 Thread David Heidelberg via B4 Relay
From: methanal Some replacement displays include third-party touch ICs which do not report the product ID correctly unless we read directly from the product ID register. Add a check and a fallback read to handle this. Signed-off-by: methanal Signed-off-by: Caleb Connolly --- drivers/input/rmi

[PATCH v3 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs

2025-03-08 Thread David Heidelberg via B4 Relay
From: methanal Some replacement displays include third-party touch ICs which are devoid of register descriptors. Create a fake data register descriptor for such ICs and provide hardcoded default values. It isn't possible to reliably determine if the touch IC is original or not, so these fallback

[PATCH v3 5/7] Input: synaptics-rmi4 - don't do unaligned reads in IRQ context

2025-03-08 Thread David Heidelberg via B4 Relay
From: methanal Some replacement displays include third-party touch ICs which incur a significant penalty (1-2 seconds) when doing certain unaligned reads. This is enough to break functionality when it happens in the hot path, so adjust the interrupt handler to not read from an unaligned address.

[PATCH v3 7/7] Input: synaptics-rmi4 - support fallback values for PDT descriptor bytes

2025-03-08 Thread David Heidelberg via B4 Relay
fixes, wording] Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 73 - drivers/input/rmi4/rmi_driver.h | 2 ++ include/linux/rmi.h | 3 ++ 3 files changed, 70 insertions(+), 8 deletions

[PATCH v3 4/7] Input: synaptics-rmi4 - f55: handle zero electrode count

2025-03-08 Thread David Heidelberg via B4 Relay
From: methanal Some third party ICs claim to support f55 but report an electrode count of 0. Catch this and bail out early so that we don't confuse the i2c bus with 0 sized reads. Signed-off-by: methanal [simplify code, adjust wording] Signed-off-by: Caleb Connolly --- drivers/input/rmi4/rmi_

[PATCH v3 0/7] Subject: [PATCH v3 0/7] Input: synaptics-rmi4: add quirks for third party touchscreen controllers

2025-03-08 Thread David Heidelberg via B4 Relay
| 3 + 7 files changed, 258 insertions(+), 47 deletions(-) --- base-commit: 0a2f889128969dab41861b6e40111aa03dc57014 change-id: 20250308-synaptics-rmi4-c832b2f73ceb Best regards, -- David Heidelberg

[PATCH v3 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries

2025-03-08 Thread David Heidelberg via B4 Relay
us 6T (original parts): manufacturer: Synaptics, product: S3706B, fw id: 2852315 Co-developed-by: methanal Signed-off-by: methanal Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 47 +++-- drivers/input

[PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-08 Thread David Heidelberg via B4 Relay
: David Heidelberg --- Documentation/devicetree/bindings/input/syna,rmi4.yaml | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/input/syna,rmi4.yaml b/Documentation/devicetree/bindings/input/syna,rmi4.yaml index

[PATCH] irq: Request and release resources for chained IRQs

2020-06-15 Thread David Heidelberg
Hello, is there chance to get this patch included or could be this issue solved with different approach? Actually this patch solve issue on two APQ8064 devices: * Nexus 7 2013 Tested-by: David Heidelberg * Nexus 4 Tested-by: Iskren Chernev Best regards David Heidelberg