ile tested.
Looks good, thanks!
Reviewed-by: David Dillow
superpages avoids the erroneous free.
Signed-off-by: David Dillow
---
drivers/iommu/intel-iommu.c | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index fc2765ccdb57..3a8036f60367 10
+Jens, Christoph, and Ming based on off-list suggestion
On Fri, Feb 3, 2017 at 11:57 AM, Linus Torvalds
wrote:
>
> On Wed, Feb 1, 2017 at 1:29 PM, David Dillow wrote:
> > When called with a region of contiguous pages totaling > 4 GB of memory,
> > sg_alloc_table_from_page
various page lists with contiguous 8GB regions and
observing that they are correctly split without overflowing length.
Signed-off-by: David Dillow
---
lib/scatterlist.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/lib/scatterlist.c b/lib/scatterlist
On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
> In some cases the return value of a failing function is not being used
> and the function typhoon_init_one() returns another negative error
> code instead.
I'm not sure these changes are especially valuable, since we'll need to
look at th
On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
> Those spaces were actually left out purposely: The file in question
> (typhoon.c)
> is missing those spaces between the statements (if, for, while) and the
> following opening bracket pretty much always (except 2-3 times) and we figured
>
On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote:
> diff --git a/drivers/net/ethernet/3com/typhoon.c
> b/drivers/net/ethernet/3com/typhoon.c
> index a0cacbe..9a3ab58 100644
> --- a/drivers/net/ethernet/3com/typhoon.c
> +++ b/drivers/net/ethernet/3com/typhoon.c
> @@ -2404,6 +2404,7 @@ typho
On Wed, 2016-11-02 at 00:11 +0100, Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes
LGTM.
Reviewed-by: David Dillow
On Tue, 2014-10-21 at 16:51 +0200, Rasmus Villemoes wrote:
> Both image_data and typhoon_fw->data are const u8*, so the cast to u8*
> is unnecessary and confusing.
>
> Signed-off-by: Rasmus Villemoes
Acked-by: David Dillow
--
To unsubscribe from this list: send the line &qu
On Sat, 2013-06-01 at 00:55 -0400, David Dillow wrote:
> On Tue, 2013-05-28 at 15:45 +0200, Jiri Kosina wrote:
> > I'd be glad if you could provide your Tested-by: for the patch below.
> > Thanks a lot.
>
> I tried to test this tonight, but was thwarted by Fedor
On Tue, 2013-05-28 at 15:45 +0200, Jiri Kosina wrote:
> I'd be glad if you could provide your Tested-by: for the patch below.
> Thanks a lot.
I tried to test this tonight, but was thwarted by Fedora 16 on the only
readily available test platform -- old bluetoothd w/ the internal
driver. I'll need
On Tue, 2013-05-28 at 10:38 +0200, Jiri Kosina wrote:
> Let's follow the structure we are trying to keep for most of the specific
> HID drivers, and let the separation follow the producing vendor.
> Merge functionality provided by ps3remote driver into hid-sony.
>
> Signed-off-by: Jiri Kosina
>
[Apologies for the dupe, fixing stupid typo for netdev address...
-ENOCAFFEINE]
I hesitate to reward the squeaky wheel, but in the community spirit,
here goes...
Please fix the subject for future submissions. The subject should be a
short, one line description of the patch. It helps if the subjec
I hesitate to reward the squeaky wheel, but in the community spirit,
here goes...
Please fix the subject for future submissions. The subject should be a
short, one line description of the patch. It helps if the subject
includes the section of the code you are affecting. Also, if you are
resending
On Sun, 2013-01-20 at 19:40 -0500, Tom St Denis wrote:
> The problem is for me to add the ()'s is a no brainer.
It was more than just the ()'s. You completely botched the indentation
in the parts of code you didn't copy from xcbc.c, among other issues.
> For me to re-write complete statements for
On Sun, 2013-01-20 at 12:40 -0500, Tom St Denis wrote:
> > On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote:
> > > In all likelihood I will submit a revised CMAC patch but it'll take
> > > time before I can get business hours to work on it. So instead of
> > > having a maintainer just touch i
On Sun, 2013-01-20 at 10:07 -0500, Tom St Denis wrote:
> In all likelihood I will submit a revised CMAC patch but it'll take
> time before I can get business hours to work on it. So instead of
> having a maintainer just touch it up we're all going to lose out
> because of pride?
Yes -- but it wou
On Sun, 2012-08-19 at 09:02 +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Initialize rc before returning on failure, as done elsewhere in the
> function.
>
> Signed-off-by: Julia Lawall
Acked-by: David Dillow
--
To unsubscribe from this list: send the line "u
On Wed, 2012-07-25 at 18:55 -0700, Kevin Ross wrote:
> On 07/25/2012 06:00 PM, Phil Turmel wrote:
> > Piles of small reads scattered across multiple drives, and a
> > concentration of queued writes to /dev/sda. What's on /dev/sda?
> > It's not a member of the raid, so it must be some other system
On Thu, 2012-07-26 at 22:15 -0400, David Dillow wrote:
> If you can, upgrade to the latest 3.4 stable kernel (3.4.6 right now).
> As far as I can see, the latest 3.2 stable does not contain the delayed
> stripe fix.
And I was looking at the wrong version; 3.2.24 does indeed have the fi
On Thu, 2012-07-26 at 19:17 -0700, Kevin Ross wrote:
> On 07/26/2012 07:17 PM, David Dillow wrote:
> > On Thu, 2012-07-26 at 22:15 -0400, David Dillow wrote:
> >> If you can, upgrade to the latest 3.4 stable kernel (3.4.6 right now).
> >> As far as I can see, the latest
On Mon, 2008-02-04 at 14:53 +0100, Bart Van Assche wrote:
> Another issue I have to look further into is that dd and xdd report
> different results for very large block sizes (> 1 MB).
Be aware that xdd reports 1 MB as 100, not 1048576. Though, it looks
like dd is the same, so that's probably
On Thu, 2008-01-31 at 18:08 +0100, Bart Van Assche wrote:
> If anyone has a suggestion for a better test than dd to compare the
> performance of SCSI storage protocols, please let it know.
xdd on /dev/sda, sdb, etc. using -dio to do direct IO seems to work
decently, though it is hard (ie, impossi
On Fri, 2008-01-11 at 10:34 +0100, Ingo Molnar wrote:
> * David Dillow <[EMAIL PROTECTED]> wrote:
>
> > Ingo, Thomas added as I think this is related to
> > sched.c:__update_rq_clock()'s checking for forward time warps.
>
> yep, we've got some fixes i
On Fri, 2008-01-11 at 11:29 +0100, Ingo Molnar wrote:
> (David, could you try the patch further below - does it fix bkltrace
> timestamps too?)
Jens already got back to you, but I can confirm it works here as well.
--
Dave Dillow
National Center for Computational Science
Oak Ridge National Labo
On Thu, 2008-01-10 at 23:44 +0100, Guillaume Chazarain wrote:
> David Dillow <[EMAIL PROTECTED]> wrote:
>
> > At the moment, I'm not sure how to track this farther, or how to fix it
> > properly. Any advice would be appreciated.
>
> Just out of curiosity, co
Ingo, Thomas added as I think this is related to
sched.c:__update_rq_clock()'s checking for forward time warps.
On Wed, 2008-01-09 at 17:48 -0500, David Dillow wrote:
> While trying to gain some insight into a disk issue, I found that
> blktrace/blkparse was giving me bogus traces -- I
While trying to gain some insight into a disk issue, I found that
blktrace/blkparse was giving me bogus traces -- I was seeing requests
complete before they were even dispatched or queued even! I had thought
that maybe this was an issue with SMP on the box, but when running with
'maxcpus=1', it tol
On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote:
> As for a better fix, I'm not sure.
Here's a better way than the strncmp. If this meets everyone's approval,
then I can roll up a proper commit.
diff --git a/drivers/scsi/scsi_transport_srp.c
b/drivers/scsi/scsi_tra
sts, as it will cause an oops when the
SRP transport code will free up an object that is not its own. So,
temporarily reorder the calls in srp_remove_work() to avoid the problem
as well until the transport code can be fixed.
Signed-off-by: David Dillow <[EMAIL PROTECTED]>
---
On Thu, 200
On Thu, 2008-01-03 at 10:56 -0800, Roland Dreier wrote:
> > If we've got time before 2.6.24 final, I'd wait on this a bit.
> > ib_srp:srp_remove_work() has them reversed as well, and I'm currently
> > tracking down why it oopses when the srp_remove_host() happens before
> > the scsi_remove_host
der has
> > > survived over 500 insert/probe/remove cycles.
> > >
> > > Tested-by: David Dillow <[EMAIL PROTECTED]>
> > > ---
> > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
> > b/drivers/infiniband/ulp/srp/ib_srp.c
> > > ind
/linux/kernel/git/roland/infiniband.git
> for-linus
>
> This will pull one fix for an oops caused by reloading the ib_srp module:
>
> David Dillow (1):
> IB/srp: Fix list corruption/oops on module reload
If we've got time before 2.6.24 final, I'd wait on this a bit
On Thu, 2007-12-27 at 11:58 +0900, FUJITA Tomonori wrote:
> On Wed, 26 Dec 2007 12:14:11 -0500
> David Dillow <[EMAIL PROTECTED]> wrote:
>
> >
> > On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote:
> > > transport_container_unregister(&
st.
>
> Can you try this?
That patched oopsed in scsi_remove_host(), but reversing the order has
survived over 500 insert/probe/remove cycles.
Tested-by: David Dillow <[EMAIL PROTECTED]>
---
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index
On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote:
> I'm getting the following oops when doing the following commands:
>
> modprobe ib_srp
>
> rmmod ib_srp
> modprobe ib_srp
>
>
> I'm going to try and track down how the list is getting corrupted; it
On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote:
> Before I get too far into this, has anyone seen this one before? I
> looked at 'git diff v2.6.24-rc4..' and didn't see any changes that would
> stand out as fixing it.
This should read v2.6.24-rc5...
--
To unsubscr
I'm getting the following oops when doing the following commands:
modprobe ib_srp
rmmod ib_srp
modprobe ib_srp
I'm going to try and track down how the list is getting corrupted; it
looks like attribute_container_list in
drivers/base/attribute_container.c is the one getting corrupted.
Before I
On Sat, 2005-02-19 at 09:43 +0100, Adrian Bunk wrote:
> This patch makes a nedlessly global firmware image static.
Doh! ACK.
--
David Dillow <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTEC
39 matches
Mail list logo
