net/rtnetlink.sh | 95
> 1 file changed, 95 insertions(+)
>
Reviewed-by: David Ahern
uot;ipv6/addrconf: fix timing bug in tempaddr regen")
> Signed-off-by: Hangbin Liu
> ---
> net/ipv6/addrconf.c | 41 +++++
> 1 file changed, 29 insertions(+), 12 deletions(-)
>
Reviewed-by: David Ahern
On 11/15/24 1:46 PM, Sam Edwards wrote:
> Hi Hangbin,
>
> It took me a while to grasp but the problem seems to be a confusion
> about what it means to set a temporary's lifetimes to 0/0:
> 1) "The mngtmpaddrs has gone away; this temporary is slated for
> deletion by addrconf_verify_rtnl()"
> 2) "T
f36a30
> 28 [bd13003d3ee8] kthread at 8cf2b39f
> 29 [bd13003d3f28] ret_from_fork at 8ce5fa64
> 30 [bd13003d3f50] ret_from_fork_asm at 8ce03cbb
>
> Fixes: 66f5d6ce53e6 ("ipv6: replace rwlock with rcu and spinlock in
> fib6_table")
>
On 10/31/24 4:13 AM, Paolo Abeni wrote:
> Given the issue is long-standing, and the fix is somewhat invasive, I
> suggest steering this patch on net-next.
>
FWIW, I think net-next is best.
On 6/6/24 9:37 AM, Yan Zhai wrote:
> # cat /sys/kernel/debug/tracing/events/skb/kfree_skb/format
> name: kfree_skb
> ID: 2260
> format:
> field:unsigned short common_type; offset:0;
> size:2; signed:0;
> field:unsigned char common_flags; offset:2;
> size:1; signed:0;
>
check
> for CONFIG_IPV6.
>
> Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create")
> Signed-off-by: Geert Uytterhoeven
> ---
> No changes in generated code.
>
> include/trace/events/neigh.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: David Ahern
Google put your email in the spam folder, BTW.
[ cc author of 648700f76b03b7e8149d13cc2bdb3355035258a9 ]
On 4/16/21 3:58 PM, Keyu Man wrote:
> Hi,
>
>
>
> My name is Keyu Man. We are a group of researchers from University
> of California, Riverside. Zhiyun Qian is my advisor. We found the code
> in processing IPv4/IPv6 fragments will p
Since this is a single patch set, just put this good cover letter
content as the message in the patch.
On 4/7/21 12:03 PM, Andrea Mayer wrote:
> diff --git a/include/uapi/linux/seg6_local.h b/include/uapi/linux/seg6_local.h
> index 3b39ef1dbb46..ae5e3fd12b73 100644
> --- a/include/uapi/linux/seg6_local.h
> +++ b/include/uapi/linux/seg6_local.h
> @@ -27,6 +27,7 @@ enum {
> SEG6_LOCAL_OIF,
>
; case for UDP_GRO
>
> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
> Signed-off-by: Norman Maurer
> ---
> net/ipv4/udp.c | 4
> 1 file changed, 4 insertions(+)
>
Reviewed-by: David Ahern
On 3/31/21 7:10 AM, Norman Maurer wrote:
> Friendly ping…
>
> As this missing change was most likely an oversight in the original commit I
> do think it should go into 5.12 and subsequently stable as well. That’s also
> the reason why I didn’t send a v2 and changed the commit message / subject
sit.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: David Ahern
Signed-off-by: Yejune Deng
> ---
> net/ipv4/route.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
Reviewed-by: David Ahern
On 3/22/21 11:02 AM, Matteo Croce wrote:
> From: Matteo Croce
>
> This series enables recycling of the buffers allocated with the page_pool API.
> The first two patches are just prerequisite to save space in a struct and
> avoid recycling pages allocated with other API.
> Patch 2 was based on a p
subject line should have net-next as the target branch
On 3/23/21 4:20 AM, Yejune Deng wrote:
> Put if and else if together, and remove unnecessary judgments, because
> it's caller can make sure it is true. And add likely() in
> ipv4_confirm_neigh().
>
> Signed-off-by: Yejune Deng
> ---
> net/
On 3/20/21 6:20 PM, Riccardo Paolo Bestetti wrote:
> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> index 50a73178d63a..734c0332b54b 100644
> --- a/net/ipv4/raw.c
> +++ b/net/ipv4/raw.c
> @@ -717,6 +717,7 @@ static int raw_bind(struct sock *sk, struct sockaddr
> *uaddr, int addr_len)
> {
>
On 3/17/21 9:07 AM, Anish Udupa wrote:
> Ran checkpatch and found these warnings. Fixed some of them in this patch.
> a) Added a space before '='.
> b) Removed the space before the tab.
>
> Signed-off-by: Anish Udupa H
> ---
> net/ipv4/route.c | 8
> 1 file changed, 4 insertions(+), 4 d
On 3/9/21 1:02 PM, Steven Rostedt wrote:
> On Tue, 9 Mar 2021 12:53:37 -0700
> David Ahern wrote:
>
>> Changing the order of the fields will impact any bpf programs expecting
>> the existing format
>
> I thought bpf programs were not API. And why are they not parsi
On 3/9/21 10:40 AM, Steven Rostedt wrote:
> The order of the fields is important. Don't worry about breaking API by
> fixing it. The parsing code uses this output to find where the binary data
> is.
Changing the order of the fields will impact any bpf programs expecting
the existing format.
3 insertions(+)
>
Reviewed-by: David Ahern
On 3/8/21 9:26 AM, Balazs Nemeth wrote:
> On Mon, 2021-03-08 at 09:17 -0700, David Ahern wrote:
>> On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>>>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>>>> index b1690149b6fa..cc1b6457fc93 100644
>>>>
On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>> index b1690149b6fa..cc1b6457fc93 100644
>> --- a/net/mpls/mpls_gso.c
>> +++ b/net/mpls/mpls_gso.c
>> @@ -27,7 +27,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff
>> *skb,
>>
>>
On 2/28/21 5:53 PM, Henry Shen wrote:
> When an IPv4 packet with a destination address of broadcast is received
> on an ingress interface, it will not be forwarded out of the egress
> interface if the ingress interface is not configured with bc_forwarding
> but the egress interface is. If both the
On 2/22/21 9:32 AM, Kaustubh Pandey wrote:
> When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised.
>
> addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route ->
> fib6_nh_mtu_change
>
> As part of handling NETDEV_CHANGEMTU notification we land up on a
> condition where if rout
On 2/22/21 1:37 AM, Eric Dumazet wrote:
>
>
> On 2/22/21 4:15 AM, Yejune Deng wrote:
>> The arp_hh_ops structure is similar to the arp_generic_ops structure.
>> but the latter is more general,so remove the arp_hh_ops structure.
>>
>> Fix when took out the neigh->ops assignment:
>> 8.973653] #PF:
On 2/19/21 9:32 PM, Yejune Deng wrote:
> static const struct neigh_ops arp_direct_ops = {
> .family = AF_INET,
> .output = neigh_direct_output,
> @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh)
> memcpy(neigh->
On 2/9/21 3:31 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Signed-off-by: Oleksandr Mazur
> ---
applied to iproute2-next.
In the future, please add example commands - g
On 2/2/21 6:04 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Example:
> $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value
> false cmode runtime
t; Thanks to Colin Ian King for catching the overflow problem, providing a
> solution and inspiring this patch.
> Thanks to Jakub Kicinski for his useful suggestions during the design of
> this patch.
>
> v2:
> - remove the SEG6_LOCAL_MAX_SUPP which is not strictly needed: it c
Jiri/Parav: does this look ok to you?
On 2/3/21 7:27 PM, Andrea Mayer wrote:
>
> I think there is an issue here because BITS_PER_TYPE(unsigned long) is greater
> than the SEG6_LOCAL_MAX (currently = 9).
>
> I think it should be like this:
>
> BUILD_BUG_ON(SEG6_LOCAL_MAX + 1 > BITS_PER_TYPE(unsigned long))
>
> I will send a v2 with
On 2/2/21 11:56 AM, Andrea Mayer wrote:
> diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
> index b07f7c1c82a4..7cc50d506902 100644
> --- a/net/ipv6/seg6_local.c
> +++ b/net/ipv6/seg6_local.c
> @@ -31,6 +31,9 @@
> #include
> #include
>
> +#define SEG6_F_ATTR(i) BIT(i)
On 1/25/21 6:48 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
Add example commands here - both set and show. Include a json version of
the show.
> Signed-off-by: Oleksandr Maz
=y.
>
> Signed-off-by: Masahiro Yamada
> ---
>
> net/Makefile| 4 +---
> net/l3mdev/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern
; Ideally, user should be able to configure metric on default route for IPv6
> similar to IPv4. This fix adds sysctl for the same.
>
> Signed-off-by: Praveen Chaudhary
> Signed-off-by: Zhenggen Xu
>
> Reviewed-by: David Ahern
>
> Changes in v1.
> 1.) Correct the call
On 1/23/21 1:00 PM, Jakub Kicinski wrote:
> On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote:
>> On 1/22/21 9:02 PM, Maciej Żenczykowski wrote:
>>> Why can't we get rid of the special case for 0 and simply make 1024 the
>>> default value?
>>
>>
On 1/22/21 9:02 PM, Maciej Żenczykowski wrote:
> Why can't we get rid of the special case for 0 and simply make 1024 the
> default value?
That would work too.
>
> As for making it an RA option: it's not clear how that would work, the
> use case I see for this is for example two connections to th
include/linux/ipv6.h | 1 +
> include/net/ip6_route.h| 3 ++-
> include/uapi/linux/ipv6.h | 1 +
> include/uapi/linux/sysctl.h| 1 +
> net/ipv6/addrconf.c | 10 ++
> net/ipv6/ndisc.c | 14 ++
> net/ipv6/route.c | 5 +++--
> 8 files changed, 40 insertions(+), 7 deletions(-)
>
LGTM. I can't think of a better way to do this than a sysctl. Shame that
the metric/priority is not an RA option.
Reviewed-by: David Ahern
On 1/19/21 3:17 PM, praveen chaudhary wrote:
>>>
>>> For IPv4:
>>>
>>>
>>> Config in etc/network/interfaces
>>> -
On 1/15/21 12:21 PM, Jarod Wilson wrote:
> diff --git a/Documentation/networking/bonding.rst
> b/Documentation/networking/bonding.rst
> index adc314639085..36562dcd3e1e 100644
> --- a/Documentation/networking/bonding.rst
> +++ b/Documentation/networking/bonding.rst
> @@ -951,6 +951,19 @@ xmit_hash
On 1/15/21 1:02 AM, Praveen Chaudhary wrote:
> For IPv4, default route is learned via DHCPv4 and user is allowed to change
> metric using config etc/network/interfaces. But for IPv6, default route can
> be learned via RA, for which, currently a fixed metric value 1024 is used.
>
> Ideally, user sh
On 1/15/21 4:12 PM, Matteo Croce wrote:
> On Fri, Jan 15, 2021 at 11:50 PM Jakub Kicinski wrote:
>>
>> On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote:
>>> From: Matteo Croce
>>>
>>> Fix two wrong flags in the IPv6 multicast routes created
>>> by the autoconf code.
>>
>> Any chance for Fixe
On 1/15/21 11:42 AM, Matteo Croce wrote:
> From: Matteo Croce
>
> The ff00::/8 multicast route is created without specifying the fc_protocol
> field, so the default RTPROT_BOOT value is used:
>
> $ ip -6 -d route
> unicast ::1 dev lo proto kernel scope global metric 256 pref medium
> unica
On 1/12/21 6:50 PM, Praveen Chaudhary wrote:
> For IPv4, default route is learned via DHCPv4 and user is allowed to change
> metric using config etc/network/interfaces. But for IPv6, default route can
> be learned via RA, for which, currently a fixed metric value 1024 is used.
>
> Ideally, user sh
On 12/24/20 12:01 AM, YANG LI wrote:
> Assigning local variable txq to the outputting parameter xdp->txq is not
> safe, txq will be released after the end of the function call.
> Then the result of using xdp is unpredictable.
txq can only be accessed in this devmap context. Was it actually hit
du
+++---
> 1 file changed, 55 insertions(+), 55 deletions(-)
>
I should have caught that in my review.
Reviewed-by: David Ahern
On 12/2/20 5:54 PM, Dan Williams wrote:
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 8d7001712062..040be48ce046 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -1,6 +1,9 @@
> # SPDX-License-Identifier: GPL-2.0
> menu "Generic Driver Options"
>
> +conf
> GATEWAY and VIA");
> - goto errout;
> + return -EINVAL;
> }
>
> return 0;
>
Thanks for the patch.
Reviewed-by: David Ahern
On 11/25/20 7:36 AM, Vladimir Oltean wrote:
> Extend the 'bridge mdb' command for the following syntax:
> bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent
>
> Signed-off-by: Vladimir Oltean
> ---
> Changes in v3:
> - Using rt_addr_n2a_r instead of inet_ntop/ll_addr_n2a directly.
>
On 11/25/20 9:47 AM, Jakub Kicinski wrote:
> On Tue, 24 Nov 2020 21:37:18 -0700 David Ahern wrote:
>> On 11/24/20 6:58 PM, Jakub Kicinski wrote:
>>> But it's generally not a huge issue for applying the patch. I just like
>>> to see the build bot result, to ma
On 11/24/20 6:58 PM, Jakub Kicinski wrote:
> But it's generally not a huge issue for applying the patch. I just like
> to see the build bot result, to make sure we're not adding W=1 C=1
> warnings.
ah, the build bot part is new. got it.
aveM having a problem, so
maybe it is the new patchworks that is not liking it?
>
>> I would like to thank David Ahern for his support during the development of
>> this patchset.
>
> Should I take this to mean that David has review the code off-list?
>
reviews and general guidance.
On 11/20/20 10:27 AM, Andreas Roeseler wrote:
> On Thu, 2020-11-19 at 21:01 -0700, David Ahern wrote:
>> On 11/19/20 8:51 PM, David Ahern wrote:
>>> On 11/17/20 5:46 PM, Andreas Roeseler wrote:
>>>> The popular utility ping has several severe limitations such as
&g
On 11/20/20 8:13 AM, Daniel Borkmann wrote:
> [ +David ]
>
> On 11/19/20 8:04 AM, xiakaixu1...@gmail.com wrote:
>> From: Kaixu Xia
>>
>> The return value of dev_get_by_index_rcu() can be NULL, so here it
>> is need to check the return value and return error code if it is NULL.
>>
>> Signed-off-by
On 11/19/20 8:51 PM, David Ahern wrote:
> On 11/17/20 5:46 PM, Andreas Roeseler wrote:
>> The popular utility ping has several severe limitations such as the
>> inability to query specific interfaces on a node and requiring
>> bidirectional connectivity between the p
On 11/17/20 5:46 PM, Andreas Roeseler wrote:
> The popular utility ping has several severe limitations such as the
> inability to query specific interfaces on a node and requiring
> bidirectional connectivity between the probing and the probed
> interfaces. RFC8335 attempts to solve these limitati
On 11/9/20 6:19 PM, Andrii Nakryiko wrote:
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index d7a7bc3b6098..1e78faaf20a5 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -274,6 +274,15 @@ config DEBUG_INFO_BTF
> Turning this on expects presence of pahole tool, which
only the user command
> perspective.
> From the kernel point of view in solution 2 the vrftable will be a new
> [SEG6_LOCAL_VRFTABLE] optional parameter.
>
>> BTW you prefer to operate on tables (and therefore require
>> net.vrf.strict_mode=1) because that's closer to the
On 11/13/20 10:02 AM, Stefano Salsano wrote:
> Il 2020-11-13 17:55, Jakub Kicinski ha scritto:
>> On Thu, 12 Nov 2020 18:49:17 -0700 David Ahern wrote:
>>> On 11/12/20 6:28 PM, Andrea Mayer wrote:
>>>> The implementation of SRv6 End.DT4 differs from the the
>>&g
On 11/12/20 6:28 PM, Andrea Mayer wrote:
> The implementation of SRv6 End.DT4 differs from the the implementation of SRv6
> End.DT6 due to the different *route input* lookup functions. For IPv6 is it
> possible to force the routing lookup specifying a routing table through the
> ip6_pol_route() fun
On 10/29/20 4:28 PM, Vladimir Oltean wrote:
> @@ -168,9 +176,14 @@ static void print_mdb_entry(FILE *f, int ifindex, const
> struct br_mdb_entry *e,
> print_string(PRINT_ANY, "port", " port %s",
>ll_index_to_name(e->ifindex));
>
> + if (af == AF_INET || af == AF_INE
-+
> +# |host |Action |
> +# +---+
> +# |10.0.0.1 |apply seg6 encap segs fc00:21:100::6004|
> +# +-------+
> +# |10.0.0.0/24|forward to dev veth_t100 |
> +# +---+
> +#
> +# rt-2: VRF tenant 200 (table 200)
> +# +---+
> +# |host |Action |
> +# +---+
> +# |10.0.0.3 |apply seg6 encap segs fc00:21:200::6004|
> +# +---+
> +# |10.0.0.0/24|forward to dev veth_t200 |
> +# +---+
> +#
> +
>
thanks for creating the very well documented test case.
Reviewed-by: David Ahern
6, depending on which L3 packet is
> received.
>
> Signed-off-by: Andrea Mayer
> ---
> drivers/net/vrf.c | 78 +++
> 1 file changed, 72 insertions(+), 6 deletions(-)
>
Reviewed-by: David Ahern
On 10/18/20 1:40 PM, Jakub Kicinski wrote:
> This one got applied a few days ago, and the urgency is low so it may be
> worth letting it see at least one -rc release ;)
agreed
On 10/12/20 7:10 AM, Mathieu Desnoyers wrote:
> - On Oct 12, 2020, at 9:45 AM, David Ahern dsah...@gmail.com wrote:
>
>> On 10/12/20 5:57 AM, Mathieu Desnoyers wrote:
>>> OK, do you want to pick up the RFC patch series, or should I re-send it
>>> without RFC t
On 10/12/20 5:57 AM, Mathieu Desnoyers wrote:
> OK, do you want to pick up the RFC patch series, or should I re-send it
> without RFC tag ?
you need to re-send for Dave or Jakub to pick them up via patchworks
On 10/5/20 9:30 AM, David Ahern wrote:
> On 9/25/20 1:04 PM, Mathieu Desnoyers wrote:
>> Hi,
>>
>> Here is an updated series of fixes for ipv4 and ipv6 which which ensure
>> the route lookup is performed on the right routing table in VRF
>> configurations whe
On 9/25/20 1:04 PM, Mathieu Desnoyers wrote:
> Hi,
>
> Here is an updated series of fixes for ipv4 and ipv6 which which ensure
> the route lookup is performed on the right routing table in VRF
> configurations when sending TTL expired icmp errors (useful for
> traceroute).
>
> It includes tests f
On 9/23/20 1:12 PM, Michael Jeanson wrote:
>
> Just a final clarification, the asymmetric setup would have no return
> route in VRF 2 and only test the TTL case since the others would fail?
correct. add a statement about it representing a customer setup so it is
clear such a config is a 1-off
On 9/23/20 11:03 AM, Michael Jeanson wrote:
> On 2020-09-23 12 h 04, Michael Jeanson wrote:
>>> It should work without asymmetric routing; adding the return route to
>>> the second vrf as I mentioned above fixes the FRAG_NEEDED problem. It
>>> should work for TTL as well.
>>>
>>> Adding a second pa
On 9/22/20 7:52 AM, Michael Jeanson wrote:
>>>
>>> the test setup is bad. You have r1 dropping the MTU in VRF red, but not
>>> telling VRF red how to send back the ICMP. e.g., for IPv4 add:
>>>
>>>ip -netns r1 ro add vrf red 172.16.1.0/24 dev blue
>>>
>>> do the same for v6.
>>>
>>> Also, I do
On 9/21/20 12:44 PM, Mathieu Desnoyers wrote:
> - On Sep 21, 2020, at 2:36 PM, David Ahern dsah...@gmail.com wrote:
>
>> On 9/18/20 12:17 PM, Mathieu Desnoyers wrote:
>>> Hi,
>>>
>>> Here is an updated series of fixes for ipv4 and ipv6 which which ensu
On 9/18/20 12:17 PM, Mathieu Desnoyers wrote:
> Hi,
>
> Here is an updated series of fixes for ipv4 and ipv6 which which ensure
> the route lookup is performed on the right routing table in VRF
> configurations when sending TTL expired icmp errors (useful for
> traceroute).
>
> It includes tests
ions in reverse
> Christmas tree ordering.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
> ---
> net/ipv6/route.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern
On 9/1/20 9:50 AM, Brian Vazquez wrote:
> Hey David,
>
> On Tue, Sep 1, 2020 at 7:57 AM David Ahern wrote:
>>
>> On 9/1/20 1:56 AM, Eric Dumazet wrote:
>>> On Tue, Sep 1, 2020 at 8:58 AM Brian Vazquez wrote:
>>>>
>>>> The prob
On 9/1/20 1:56 AM, Eric Dumazet wrote:
> On Tue, Sep 1, 2020 at 8:58 AM Brian Vazquez wrote:
>>
>> The problem is exposed when the system has multiple ifaces and
>> forwarding is enabled on a subset of them, __rt6_purge_dflt_routers will
>> clean the default route on all the ifaces which is not de
pv4/inet_hashtables.c | 6 ++
> 2 files changed, 2 insertions(+), 14 deletions(-)
>
Reviewed-by: David Ahern
v6/inet6_hashtables.c | 6 ++
> 2 files changed, 2 insertions(+), 15 deletions(-)
>
Reviewed-by: David Ahern
On 8/29/20 3:04 AM, Miaohe Lin wrote:
> @@ -138,15 +138,13 @@ static struct sock *inet6_lhash2_lookup(struct net *net,
> const __be16 sport, const struct in6_addr *daddr,
> const unsigned short hnum, const int dif, const int sdif)
> {
> - bool exact_dif = inet6_exac
On 8/29/20 3:01 AM, Miaohe Lin wrote:
> @@ -277,15 +277,13 @@ static struct sock *inet_lhash2_lookup(struct net *net,
> const __be32 daddr, const unsigned short hnum,
> const int dif, const int sdif)
> {
> - bool exact_dif = inet_exac
On 8/26/20 6:12 AM, Ahmed Abdelsalam wrote:
>
> On 26/08/2020 02:45, David Ahern wrote:
>> On 8/25/20 5:45 PM, Ahmed Abdelsalam wrote:
>>>
>>> Hi David
>>>
>>> The seg6 encap is implemented through the seg6_lwt rather than
>>> seg6_local
On 8/25/20 5:45 PM, Ahmed Abdelsalam wrote:
>
> Hi David
>
> The seg6 encap is implemented through the seg6_lwt rather than
> seg6_local_lwt.
ok. I don't know the seg6 code; just taking a guess from a quick look.
> We can add a flag(SEG6_IPTUNNEL_DSCP) in seg6_iptunnel.h if we do not
> want to
On 8/25/20 10:02 AM, Ahmed Abdelsalam wrote:
> This patch allows SRv6 encapsulation to inherit the DSCP value of
> the inner IPv4 packet.
>
> This allows forwarding packet across the SRv6 fabric based on their
> original traffic class.
>
> The option is controlled through a sysctl (seg6_inherit_i
On 8/21/20 10:00 AM, Nikolay Aleksandrov wrote:
>
> This seems like a much older bug to me, the code allows to pass 0 groups
> and
> thus we end up without any nh_grp_entry pointers. I reproduced it with a
> modified iproute2 that sends an empty NHA_GROUP and then just uses the new
> nexthop in an
Do not update thread stats or show idle summary unless CPU is in
the list of interest.
Fixes: c30d630d1bcf ("perf sched timehist: Add support for filtering on CPU")
Signed-off-by: David Ahern
---
v2
- check that cpu_list is set before checking cpu_bitmap in
timehist_print_summary
s:
>
> - Route leaking between global routing table and VRF
> - Route leaking between VRFs
>
> Preferably use the source device routing table when sending ICMPv6 error
> messages. If no source device is set, fall-back on the destination
> device routing table.
>
> Link: ht
On 8/11/20 1:50 PM, Mathieu Desnoyers wrote:
> +run_cmd()
> +{
> + local cmd="$*"
> + local out
> + local rc
> +
> + if [ "$VERBOSE" = "1" ]; then
> + echo "COMMAND: $cmd"
> + fi
> +
> + out=$(eval $cmd 2>&1)
> + rc=$?
> + if [ "$VERBOSE" = "1" ] && [ -n
;net: icmp_route_lookup should use rt dev to determine
> L3 domain")
> Link: https://tools.ietf.org/html/rfc792
> Signed-off-by: Mathieu Desnoyers
> Cc: David Ahern
> Cc: David S. Miller
> Cc: net...@vger.kernel.org
> ---
> net/ipv4/icmp.c | 15 +--
>
On 8/12/20 1:51 AM, Andrei Vagin wrote:
>
> I rebased the task_diag patches on top of v5.8:
> https://github.com/avagin/linux-task-diag/tree/v5.8-task-diag
Thanks for updating the patches.
>
> /proc/pid files have three major limitations:
> * Requires at least three syscalls per process per fil
On 8/11/20 12:42 AM, Namhyung Kim wrote:
>> @@ -2575,7 +2575,8 @@ static int timehist_sched_change_event(struct
>> perf_tool *tool,
>> }
>>
>> if (!sched->idle_hist || thread->tid == 0) {
>> - timehist_update_runtime_stats(tr, t, tprev);
>> + if (!cpu_li
On 8/11/20 1:11 PM, Mathieu Desnoyers wrote:
> One thing I am missing before this series can be considered for upstreaming
> is an Acked-by of the 2 fixes for ipv4 and ipv6 from you, as maintainer
> of l3mdev, if you think the approach I am taking with those fixes makes sense.
Send the set, and I
On 8/11/20 11:28 AM, David Miller wrote:
> From: Michael Jeanson
> Date: Thu, 6 Aug 2020 14:51:21 -0400
>
>> The objective is to check that the incoming vrf routing table is selected
>> to send an ICMP error back to the source when the ttl of a packet reaches 1
>> while it is forwarded between d
On 8/7/20 8:06 PM, Andrew Lunn wrote:
> So i personally don't think netdev statistics is a good idea, i doubt
> it scales.
+1
On 8/7/20 1:43 PM, Arnaldo Carvalho de Melo wrote:
>> @@ -2958,9 +2967,10 @@ static int timehist_check_attr(struct perf_sched
>> *sched,
>>
>> static int perf_sched__timehist(struct perf_sched *sched)
>> {
>> -const struct evsel_str_handler handlers[] = {
>> +struct evsel_str_handler h
Do not update thread stats or show idle summary unless CPU is in
the list of interest.
Fixes: c30d630d1bcf ("perf sched timehist: Add support for filtering on CPU")
Signed-off-by: David Ahern
---
tools/perf/builtin-sched.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
di
ack to sched_wakeup if it does not. Similarly, update timehist
command to skip sched_wakeup events if the session includes
sched_waking (ie., sched_waking is preferred over sched_wakeup).
Signed-off-by: David Ahern
---
tools/perf/builtin-sched.c | 32 +---
1 fil
On 8/6/20 10:04 AM, Murali Karicheri wrote:
> that the maintainers are different than the netdev maintainers. My bad.
> The PRP driver support in kernel is merged by Dave to net-next and this
> iproute2 change has to go with it. So please review and apply this if it
> looks good. The kernel part me
parses the output to check
> for a hop on r1.
>
> Signed-off-by: Michael Jeanson
> Cc: David Ahern
Update the address to dsah...@kernel.org
> Cc: David S. Miller
> Cc: net...@vger.kernel.org
> ---
> tools/testing/selftests/net/Makefile | 1 +
> .../sel
On 7/31/20 12:05 PM, pet...@infradead.org wrote:
> On Fri, Jul 31, 2020 at 08:36:12AM -0700, Andi Kleen wrote:
>>> yep, we have a customer that needs to compare data from multiple servers
>>
>> It's also needed to correlate over different guests on the same machine.
>> This is an important use case
1 - 100 of 1648 matches
Mail list logo
