Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-07-01 Thread Dave P Martin
On Tue, Jun 30, 2020 at 06:37:34PM +0100, Will Deacon wrote: > When building with LTO, there is an increased risk of the compiler > converting an address dependency headed by a READ_ONCE() invocation > into a control dependency and consequently allowing for harmful > reordering by the CPU. > > Ens

Re: [PATCH 1/3] arm64: cpufeature: Fix the type of no FP/SIMD capability

2019-10-14 Thread Dave P Martin
On Mon, Oct 14, 2019 at 04:45:40PM +0100, Suzuki K Poulose wrote: > > > On 14/10/2019 15:52, Dave Martin wrote: > > On Fri, Oct 11, 2019 at 06:28:43PM +0100, Suzuki K Poulose wrote: > >> > >> > >> On 11/10/2019 15:21, Dave Martin wrote: > >>> On Fri, Oct 11, 2019 at 01:13:18PM +0100, Suzuki K Poulo

Re: [PATCH 4/8] arm64: Basic Branch Target Identification support

2019-05-28 Thread Dave P Martin
On Fri, May 24, 2019 at 06:19:10PM +0100, Mark Rutland wrote: > On Fri, May 24, 2019 at 05:12:40PM +0100, Dave Martin wrote: > > On Fri, May 24, 2019 at 04:38:48PM +0100, Mark Rutland wrote: > > > On Fri, May 24, 2019 at 03:53:06PM +0100, Dave Martin wrote: > > > > On Fri, May 24, 2019 at 02:02:17P

Re: [REVIEW][PATCH 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL

2019-05-23 Thread Dave P Martin
On Thu, May 23, 2019 at 03:53:06PM +0100, Eric W. Biederman wrote: > Dave Martin writes: > > > On Thu, May 23, 2019 at 01:38:53AM +0100, Eric W. Biederman wrote: > >> It really only matters to debuggers but the SIGKILL does not have any > >> si_codes that use the fault member of the siginfo union.

Re: [PATCH v6 4/6] arm64/kvm: add a userspace option to enable pointer authentication

2019-03-01 Thread Dave P Martin
On Fri, Mar 01, 2019 at 09:41:20AM +, Amit Daniel Kachhap wrote: > Hi, > > On 2/21/19 9:23 PM, Dave Martin wrote: > > On Tue, Feb 19, 2019 at 02:54:29PM +0530, Amit Daniel Kachhap wrote: > >> This feature will allow the KVM guest to allow the handling of > >> pointer authentication instructions

Re: [kvmtool PATCH v6 6/6] arm/kvm: arm64: Add a vcpu feature for pointer authentication

2019-03-01 Thread Dave P Martin
On Fri, Mar 01, 2019 at 10:37:54AM +, Amit Daniel Kachhap wrote: > Hi, > > On 2/21/19 9:24 PM, Dave Martin wrote: > > On Tue, Feb 19, 2019 at 02:54:31PM +0530, Amit Daniel Kachhap wrote: [...] > >> diff --git a/arm/aarch64/include/kvm/kvm-config-arch.h > >> b/arm/aarch64/include/kvm/kvm-conf

Re: [PATCH v5 5/5] arm64/kvm: control accessibility of ptrauth key registers

2019-02-13 Thread Dave P Martin
On Wed, Feb 13, 2019 at 05:35:46PM +, Kristina Martsenko wrote: > On 28/01/2019 06:58, Amit Daniel Kachhap wrote: > > According to userspace settings, ptrauth key registers are conditionally > > present in guest system register list based on user specified flag > > KVM_ARM_VCPU_PTRAUTH. > > > >

Re: [PATCH 0/3] arm64/sve: UAPI: Disentangle ptrace.h from sigcontext.h

2018-12-14 Thread Dave P Martin
On Fri, Dec 14, 2018 at 07:00:07PM +, Szabolcs Nagy wrote: > On 14/12/2018 18:25, Dave Martin wrote: > > On Fri, Dec 14, 2018 at 06:13:33PM +, Szabolcs Nagy wrote: > >> On 11/12/2018 19:26, Dave Martin wrote: > >>> This patch refactors the UAPI header definitions for the Arm SVE > >>> exten

Re: [PATCH] arch/arm64 : fix error in dump_backtrace

2018-11-06 Thread Dave P Martin
On Tue, Nov 06, 2018 at 11:00:19AM +, Mark Rutland wrote: > On Tue, Nov 06, 2018 at 08:57:51AM +, Daniel Thompson wrote: > > On Tue, Nov 06, 2018 at 08:39:01AM +, Mark Rutland wrote: > > > On Tue, Nov 06, 2018 at 03:19:35PM +0800, Zhaoyang Huang wrote: > > > > From: Zhaoyang Huang > >

Re: [PATCH 33/38] arm64: Implement thread_struct whitelist for hardened usercopy

2018-01-15 Thread Dave P Martin
On Thu, Jan 11, 2018 at 02:03:05AM +, Kees Cook wrote: > This whitelists the FPU register state portion of the thread_struct for > copying to userspace, instead of the default entire structure. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Christian Borntraeger > Cc: Ingo Molnar > Cc: Jam

Re: arm64: unhandled level 0 translation fault

2017-12-14 Thread Dave P Martin
On Thu, Dec 14, 2017 at 02:34:50PM +, Geert Uytterhoeven wrote: > Hi Catalin, Will, Dave, > > On Tue, Dec 12, 2017 at 11:20 AM, Geert Uytterhoeven > wrote: > > During userspace (Debian jessie NFS root) boot on arm64: > > > > rpcbind[1083]: unhandled level 0 translation fault (11) at 0x0008

Re: [RESEND PATCH] arm64: v8.4: Support for new floating point multiplication variant

2017-12-11 Thread Dave P Martin
On Sat, Dec 09, 2017 at 03:28:42PM +, Dongjiu Geng wrote: > ARM v8.4 extensions include support for new floating point > multiplication variant instructions to the AArch64 SIMD Do we have any human-readable description of what the new instructions do? Since the v8.4 spec itself only describes

Re: [PATCH 8/9] RISC-V: User-facing API

2017-07-06 Thread Dave P Martin
On Wed, Jul 05, 2017 at 09:49:36AM -0700, Palmer Dabbelt wrote: > On Mon, 03 Jul 2017 16:06:39 PDT (-0700), james.ho...@imgtec.com wrote: > > On Thu, Jun 29, 2017 at 02:42:38PM -0700, Palmer Dabbelt wrote: > >> On Wed, 28 Jun 2017 15:42:37 PDT (-0700), james.ho...@imgtec.com wrote: > >> > On Wed, J

Re: [PATCH] gcc-plugins: Add structleak for more stack initialization

2017-01-17 Thread Dave P Martin
On Tue, Jan 17, 2017 at 08:25:49PM +0100, PaX Team wrote: > On 17 Jan 2017 at 18:07, Dave P Martin wrote: > > > On Tue, Jan 17, 2017 at 06:09:49PM +0100, PaX Team wrote: > > > On 17 Jan 2017 at 10:42, Dave P Martin wrote: > > > > > > > This can be read wi

Re: [PATCH] gcc-plugins: Add structleak for more stack initialization

2017-01-17 Thread Dave P Martin
On Tue, Jan 17, 2017 at 06:09:49PM +0100, PaX Team wrote: > On 17 Jan 2017 at 10:42, Dave P Martin wrote: > > > On Mon, Jan 16, 2017 at 08:22:24PM +0100, PaX Team wrote: > > > the 'issue' is that before C11 the standard didn't make it clear that in > >

Re: [PATCH] gcc-plugins: Add structleak for more stack initialization

2017-01-17 Thread Dave P Martin
On Mon, Jan 16, 2017 at 08:22:24PM +0100, PaX Team wrote: > On 16 Jan 2017 at 11:54, Mark Rutland wrote: [...] > > I assume that this is only guaranteed to initialise fields in a struct, > > and not padding, is that correct? I ask due to the issue described in: > > > > https://lwn.net/Articles/41

Re: [PATCH 1/2] ARM: PIE infrastructure

2016-04-25 Thread Dave P Martin
On Sat, Apr 23, 2016 at 01:15:03AM +0200, Alexandre Belloni wrote: > On 04/04/2016 at 11:00:52 +0100, Russell King - ARM Linux wrote : > > > + /* Copy chunk specific code/data */ > > > + fncpy((char *)chunk->addr, code_start, code_sz); > > > > Sorry, NAK. This abuses fncpy(). There is extensive d

Re: [PATCH 00/22] arm64: Consolidate CPU feature handling

2015-09-23 Thread Dave P Martin
On Wed, Sep 23, 2015 at 05:37:19PM +0100, Suzuki K. Poulose wrote: > On 23/09/15 16:58, Suzuki K. Poulose wrote: > > On 23/09/15 16:56, Dave P Martin wrote: > >> On Wed, Sep 16, 2015 at 03:20:58PM +0100, Suzuki K. Poulose wrote: > >>> From: "Suzuki K. Poulo

Re: 答复: Question about the sparse memory section size

2015-09-23 Thread Dave P Martin
On Wed, Sep 23, 2015 at 02:16:45AM +0100, Qijiwen wrote: > In fact the free_unused_memmap function is not invoked when > CONFIG_SPARSEMEM_VMEMMAP is enabled. > The reason is that the memmap region is mapped in unit of 2MB, not in unit of > 4KB. > > Below is the source code in arch/arm64/mm/init

Re: [PATCH] serial/amba-pl011: fix minor bugs for pio mode

2015-05-05 Thread Dave P Martin
Hi, On Tue, May 05, 2015 at 04:00:25AM +0100, Leo Yan wrote: > When use pio mode, there have two issues can be observed: > > - In the commit 2240197 "serial/amba-pl011: Leave the TX IRQ alone when > the UART is not open", it will skip clearing the TX IRQ across > pl011_shutdown() and pl011_st

Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len

2015-04-29 Thread Dave P Martin
On Wed, Apr 29, 2015 at 04:18:46PM +0100, Alex Bennée wrote: > The only caller to this function (__print_array) was getting it wrong by > passing the array length instead of buffer length. As the element size > was already being passed for other reasons it seems reasonable to push > the calculation

Re: [PATCH] tracing: make ftrace_print_array_seq compute buf_len

2015-04-27 Thread Dave P Martin
On Mon, Apr 27, 2015 at 01:17:48PM +0100, Alex Bennée wrote: > The only caller to this function was getting it wrong. I favoured What caller? Wrong in what way? > pushing the calculation to as close to the need as possible rather than > fixing the one caller. This seems reasonable, but... > >

Re: [RFC PATCH v6 1/9] tracing: Add array printing helpers

2014-12-08 Thread Dave P Martin
On Mon, Dec 08, 2014 at 03:42:10PM +, Steven Rostedt wrote: > On Fri, 5 Dec 2014 19:04:12 + > "Javi Merino" wrote: [...] > > + > > +DEFINE_PRINT_ARRAY(u8, unsigned int, "0x%x"); > > +DEFINE_PRINT_ARRAY(u16, unsigned int, "0x%x"); > > +DEFINE_PRINT_ARRAY(u32, unsigned int, "0x%x"); > > +

Re: [RFC PATCH v6 1/9] tracing: Add array printing helpers

2014-12-08 Thread Dave P Martin
On Fri, Dec 05, 2014 at 07:04:12PM +, Javi Merino wrote: > From: Dave Martin > > If a trace event contains an array, there is currently no standard > way to format this for text output. Drivers are currently hacking > around this by a) local hacks that use the trace_seq functionailty > direc

debugfs and module unloading

2014-05-21 Thread Dave P Martin
Hi there, I have a quick debugfs question: How can I protect against a module being unloaded while debugfs files it provides are open? I can do something like the following: static int my_debugfs_file_open(struct inode *, struct file *) { if (!try_module_get()) return -E

Re: [PATCH 16/17] Add EFI stub for ARM

2013-08-13 Thread Dave P Martin
On Thu, Aug 08, 2013 at 10:57:29PM +0100, Roy Franz wrote: > On Wed, Aug 7, 2013 at 11:05 AM, Dave Martin wrote: > > On Tue, Aug 06, 2013 at 08:45:12PM -0700, Roy Franz wrote: > >> This patch adds EFI stub support for the ARM Linux kernel. The EFI stub > >> operations similarly to the x86 stub: i

Re: [PATCH 6/7] Add EFI stub for ARM

2013-08-06 Thread Dave P Martin
On Tue, Aug 06, 2013 at 01:06:17AM +0100, Roy Franz wrote: > On Mon, Aug 5, 2013 at 8:33 AM, Leif Lindholm > wrote: > > On Mon, Aug 05, 2013 at 03:11:49PM +0100, Dave Martin wrote: > >> > diff --git a/arch/arm/boot/compressed/head.S > >> > b/arch/arm/boot/compressed/head.S > >> > index 75189f1..

Re: [PATCH 6/7] Add EFI stub for ARM

2013-08-06 Thread Dave P Martin
On Mon, Aug 05, 2013 at 04:33:19PM +0100, Leif Lindholm wrote: > On Mon, Aug 05, 2013 at 03:11:49PM +0100, Dave Martin wrote: > > > diff --git a/arch/arm/boot/compressed/head.S > > > b/arch/arm/boot/compressed/head.S > > > index 75189f1..4c70b9e 100644 > > > --- a/arch/arm/boot/compressed/head.S >

Re: [PATCH 1/7] EFI stub documentation updates

2013-08-06 Thread Dave P Martin
On Tue, Aug 06, 2013 at 12:56:12AM +0100, Roy Franz wrote: > On Mon, Aug 5, 2013 at 7:12 AM, Dave Martin wrote: > > On Fri, Aug 02, 2013 at 02:29:02PM -0700, Roy Franz wrote: > >> The ARM kernel also has an EFI stub which works largely the same way > >> as the x86 stub, so move the documentation o

Re: scripts/kallsyms: Avoid ARM veneer symbols

2013-07-08 Thread Dave P Martin
On Sat, Jul 06, 2013 at 01:34:56AM +0200, Arnd Bergmann wrote: > On Friday 05 July 2013, Dave P Martin wrote: > > On Fri, Jul 05, 2013 at 05:42:44PM +0100, Arnd Bergmann wrote: > > > On Friday 05 July 2013, Dave P Martin wrote: > > > > On Wed, Jul 03, 2013 at 06:03:0

Re: scripts/kallsyms: Avoid ARM veneer symbols

2013-07-05 Thread Dave P Martin
On Fri, Jul 05, 2013 at 05:42:44PM +0100, Arnd Bergmann wrote: > On Friday 05 July 2013, Dave P Martin wrote: > > On Wed, Jul 03, 2013 at 06:03:04PM +0200, Arnd Bergmann wrote: > > > On Tuesday 25 June 2013, Dave Martin wrote: > > > suggest would significantly increa

Re: [PATCH] ARM: move body of head-common.S back to text section

2013-07-05 Thread Dave P Martin
On Wed, Jul 03, 2013 at 08:22:35PM -0400, Paul Gortmaker wrote: > [Re: [PATCH] ARM: move body of head-common.S back to text section] On > 03/07/2013 (Wed 18:20) Russell King - ARM Linux wrote: > > > On Wed, Jul 03, 2013 at 11:30:12AM -0400, Paul Gortmaker wrote: > > > [Re: [PATCH] ARM: move body

Re: scripts/kallsyms: Avoid ARM veneer symbols

2013-07-05 Thread Dave P Martin
On Wed, Jul 03, 2013 at 06:03:04PM +0200, Arnd Bergmann wrote: > On Tuesday 25 June 2013, Dave Martin wrote: > > On Mon, Jun 24, 2013 at 04:01:43PM +0200, Arnd Bergmann wrote: > > > When building ARM kernels that exceed a certain size, the linker > > > will add "veneers" that allow long branches. U