er to make sure
that shadow_pkey_reg is properly set?
Signed-off-by: Dave Kleikamp
Cc: Ram Pai
---
tools/testing/selftests/vm/protection_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vm/protection_keys.c
b/tools/testing/selftes
Thanks, applied.
Shaggy
On 3/17/21 2:10 AM, zuoqil...@163.com wrote:
From: zuoqilin
Change 'inacitve' to 'inactive'.
Signed-off-by: zuoqilin
---
fs/jfs/jfs_dmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c
index 7aee156..91f4
The following changes since commit a0b96314870f7eff6d15a242cb162dfc46b3c284:
Merge tag 'xfs-5.11-merge-4' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
(2020-12-18 12:50:18 -0800)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-5.12
for you t
ULL macro as suggested by
Dave Kleikamp.
---
fs/jfs/jfs_dmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c
index 94b7c1cb5ceb..7aee15608619 100644
--- a/fs/jfs/jfs_dmap.c
+++ b/fs/jfs/jfs_dmap.c
@@ -1656,7 +1656,7 @@ s64 dbDiscar
On 2/5/21 11:11 AM, Colin King wrote:
From: Colin Ian King
The left shift of int 32 bit integer constant 1 is evaluated using 32 bit
arithmetic and then assigned to a signed 64 bit integer. In the case where
l2nb is 32 or more this can lead to an overflow. Avoid this by shifting
using the BIT_
.c:1422:5-7: Unneeded variable: "rc". Return "0" on
line 1527
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Signed-off-by: Dave Kleikamp
---
Changes in v3
- don't check return value of txLog() in txCommit() (Dave Kleikamp)
Changes in v2
-turn functions forw
I just realized I mangled some whitespace trying to mail this through
Thunderbird. I'll repost it the right way.
Shaggy
On 2/8/21 9:05 AM, Dave Kleikamp wrote:
On 2/7/21 2:32 AM, Yang Li wrote:
These functions always return '0' and no callers use the return value.
So make it
.
So make it a void function.
This eliminates the following coccicheck warning:
./fs/jfs/jfs_txnmgr.c:1365:5-7: Unneeded variable: "rc". Return "0" on
line 1414
./fs/jfs/jfs_txnmgr.c:1422:5-7: Unneeded variable: "rc". Return "0" on
line 1527
Reported-
On 2/3/21 9:39 PM, Yang Li wrote:
This patch removes unneeded return variables, using only
'0' instead.
It fixes the following warning detected by coccinelle:
./fs/jfs/jfs_txnmgr.c:1370:5-7: Unneeded variable: "rc". Return "0" on
line 1417
Looks good. I wonder if we should take it a step furthe
You probably don't need 4 patches to fs/jfs/. These can be combined into
a single patch.
Dave
On 1/28/21 1:11 AM, Chaitanya Kulkarni wrote:
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_logmgr.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/jfs/jfs_logmgr
I suspect Randy Dunlap's fix for
https://syzkaller.appspot.com/bug?extid=36315852ece4132ec193
will take care of this one as well:
https://github.com/kleikamp/linux-shaggy/commit/3bef198f1b17d1bb89260bad947ef084c0a2d1a6
sbi->l2nbperpage is derived from sbi->l2bsize, which is sanity checked
by Rand
this making this like a game of whack-a-mole.
syzkaller link: https://syzkaller.appspot.com/bug?extid=36315852ece4132ec193
Reported-by: syzbot+36315852ece4132ec...@syzkaller.appspotmail.com
Reported-by: kernel test robot # v2
Signed-off-by: Randy Dunlap
Cc: Dave Kleikamp
Cc: jfs-di
-5.11
for you to fetch changes up to c61b3e4839007668360ed8b87d7da96d2e59fc6c:
jfs: Fix array index bounds check in dbAdjTree (2020-11-13 16:03:07 -0600)
A few jfs fixes
---
h4ck.
>
> On Sun, Nov 15, 2020 at 12:17 AM Dave Kleikamp
> wrote:
>>
>> Thanks for reporting and testing this!
>>
>> Shaggy
>>
>> On 11/14/20 7:55 AM, butt3rflyh4ck wrote:
>>> Yes, I have tested the patch, it seem to fix the problem.
>>&g
Thanks for reporting and testing this!
Shaggy
On 11/14/20 7:55 AM, butt3rflyh4ck wrote:
> Yes, I have tested the patch, it seem to fix the problem.
>
> Regard,
> butt3rflyh4ck.
>
> On Sat, Nov 14, 2020 at 5:16 AM Dave Kleikamp
> wrote:
>>
>> On 10/8/20 12:
this patch fix the problem?
jfs: Fix array index bounds check in dbAdjTree
Bounds checking tools can flag a bug in dbAdjTree() for an array index
out of bounds in dmt_stree. Since dmt_stree can refer to the stree in
both structures dmaptree and dmapctl, use the larger array to eliminate
the fals
On 10/22/20 11:25 AM, Vanshi Konda wrote:
> On Thu, Oct 22, 2020 at 12:21:27PM +0100, Robin Murphy wrote:
>> On 2020-10-22 02:07, Vanshi Konda wrote:
>>> On Thu, Oct 22, 2020 at 12:44:15AM +0100, Robin Murphy wrote:
On 2020-10-21 12:02, Jonathan Cameron wrote:
> On Wed, 21 Oct 2020 09:43:2
and "if" in comments.
>>
>> Signed-off-by: Randy Dunlap
>> Cc: Dave Kleikamp
>> Cc: jfs-discuss...@lists.sourceforge.net
>> ---
>> fs/jfs/jfs_extent.h |2 +-
>> fs/jfs/jfs_logmgr.h |2 +-
>> 2 files changed, 2 insertions(+), 2 dele
off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Christoph Hellwig
> Reviewed-by: Dave Chinner
> Reviewed-by: Darrick J. Wong
For jfs:
Acked-by: Dave Kleikamp
> ---
> fs/iomap/buffered-io.c | 8
> fs/jfs/jfs_metapage.c | 2 +-
> fs/xfs/xfs_aops.c |
The following changes since commit 2c523b344dfa65a3738e7039832044aa133c75fb:
Linux 5.6-rc5 (2020-03-08 17:44:44 -0700)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-5.8
for you to fetch changes up to 7aba5dcc234635b44b2781dbc268048cfba388ad:
Thanks Gustavo.
I have already merged this into jfs-next. It was all I had queued up and
I failed to push it in the last merge window to Linus. I'll make sure I
get it in the next one.
https://github.com/kleikamp/linux-shaggy/commits/jfs-next
Shaggy
On 5/7/20 1:55 PM, Gustavo A. R. Silva wrote:
On 5/5/20 9:15 AM, Markus Elfring wrote:
>> This data race is found by our concurrency fuzzer.
>
> * How do you think about to replace the word “is” by “was”?
>
> * Is this analysis tool publicly available?
>
>
> …
>> ---
>> fs/jfs/jfs_metapage.c | 11 +--
>
> I suggest to omit the tri
On 5/5/20 12:12 AM, Markus Elfring wrote:
>> I am not sure how to add the tag "Fixes"...
>
> How helpful do you find the available software documentation?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=47cf1b422e6093aee2a3e
On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong
>
> Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> values so that we can standardize the implementations that follow ext4's
> flag values.
>
> Signed-off-by: Darrick J. Wong
-- clip --
> diff --gi
fs/jfs: Switch to use new generic UUID API
Arnd Bergmann (1):
jfs: fix bogus variable self-initialization
Chengguang Xu (1):
jfs: compare old and new mode before setting update_mode flag
Colin Ian King (1):
jfs: fix spelling mistake, EACCESS -> EACCES
Dave Kleikamp (
Thanks Arnd. Will push it upstream.
Shaggy
>
> Fixes: c9e3ad6021e5 ("JFS: Get rid of "may be used uninitialized" warnings")
> Signed-off-by: Arnd Bergmann
Signed-off-by: Dave Kleikamp
> ---
> fs/jfs/jfs_txnmgr.c | 3 +--
> 1 file changed, 1 insertion(+), 2
On 1/21/19 10:23 AM, Christoph Hellwig wrote:
> On Mon, Jan 21, 2019 at 10:19:15AM -0600, Dave Kleikamp wrote:
>> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
>> index 65d8fc87ab11..c15ff56a8516 100644
>> --- a/fs/jfs/super.c
>> +++ b/fs/jfs/super.c
>> @@ -174,9
On 1/21/19 2:49 AM, Christoph Hellwig wrote:
>> +buf->f_fsid.val[1] = (u32)crc32_le(0, (char *)&sbi->uuid +
>> sizeof(sbi->uuid)/2,
>
> This adds an overly long line, and has weird operator spacing.
>
> In fact given how much deep magic it does it should probably be moved
> into a helper and
On 1/10/19 7:41 AM, Andy Shevchenko wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
Looks good to me. I tweaked it slightly to keep checkpatch from
complaining about line
On 10/26/18 1:09 PM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to a spelling mistake of the error access name EACCESS,
> rename to EACCES
>
> Signed-off-by: Colin Ian King
Thanks. Pulled into the jfs tree.
Shaggy
> ---
> fs/jfs/namei.c | 2 +-
> 1 file changed, 1 insertion(+)
The following changes since commit be65e2595b4c1fbeceba336d8ee83406726b1d8d:
Merge tag 'trace-v4.19-rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace (2018-09-06
09:06:49 -0700)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/
On 9/20/18 9:18 AM, Chao Yu wrote:
> Ping,
>
> Any comments?
Sorry for putting it off. It looks good to me. I'll push it upstream.
Thanks,
Dave
>
> On 2018/9/17 15:12, Chao Yu wrote:
>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>> remove one of them for cleanup.
>>
>
On 9/5/18 1:13 AM, cgxu519 wrote:
>
> On 09/04/2018 04:34 AM, Dave Kleikamp wrote:
>> Are you pushing these as a series, or would you like this patch pushed
>> through the jfs tree?
> I'd hope maintainers pick individual patch to their tree.
I'll take ca
The following changes since commit ba4dbdedd3edc2798659bcd8b1a184ea8bdd04dc:
Merge tag 'jfs-4.18' of git://github.com/kleikamp/linux-shaggy
(2018-06-19 07:47:32 +0900)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.19
for you to fetch changes u
On 07/30/2018 07:28 PM, AKASHI Takahiro wrote:
> On Mon, Jul 30, 2018 at 04:36:28PM -0500, Dave Kleikamp wrote:
>> On 07/30/2018 11:57 AM, Will Deacon wrote:
>>> On Mon, Jul 30, 2018 at 11:46:24AM -0500, Dave Kleikamp wrote:
>>>> On 07/30/2018 11:22 AM, Will Deac
On 07/30/2018 11:57 AM, Will Deacon wrote:
> On Mon, Jul 30, 2018 at 11:46:24AM -0500, Dave Kleikamp wrote:
>> On 07/30/2018 11:22 AM, Will Deacon wrote:
>>> On Mon, Jul 30, 2018 at 05:16:42PM +0100, Catalin Marinas wrote:
>>>> On Mon, Jul 30, 2018 at 10:29:2
On 07/30/2018 11:57 AM, Will Deacon wrote:
> On Mon, Jul 30, 2018 at 11:46:24AM -0500, Dave Kleikamp wrote:
>> On 07/30/2018 11:22 AM, Will Deacon wrote:
>>> On Mon, Jul 30, 2018 at 05:16:42PM +0100, Catalin Marinas wrote:
>>>> On Mon, Jul 30, 2018 at 10:29:2
On 07/30/2018 11:22 AM, Will Deacon wrote:
> On Mon, Jul 30, 2018 at 05:16:42PM +0100, Catalin Marinas wrote:
>> On Mon, Jul 30, 2018 at 10:29:21AM -0500, Dave Kleikamp wrote:
>>> machine_kexec flushes the reboot_code_buffer from the icache
>>> after stopping the
call with __flush_icache_range
Signed-off-by: Dave Kleikamp
Cc: AKASHI Takahiro
Cc: Catalin Marinas
Cc: Will Deacon
---
arch/arm64/kernel/machine_kexec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/machine_kexec.c
b/arch/arm64/kernel/machine_kexec.c
index f62effc..e8c0
This fixes a regression in the for-next/core branch
Dave Kleikamp (1):
arm64: kexec: machine_kexec should call __flush_icache_range
arch/arm64/kernel/machine_kexec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 06/18/2018 03:38 AM, Nikolay Borisov wrote:
> Currently ea_buf->xattr buffer is allocated with min(min_size, ea_size).
> This is wrong since after the xattr buffer is allocated the ->max_size
> variable is actually rounded up to th next ->s_blocksize size. Fix this
> by using the rounded up max_
The following changes since commit 716a685fdb89942a50c4138141027e38336a895f:
Merge branch 'x86-hyperv-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2018-06-04 21:37:30
-0700)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-
hanks for finding this.
Shaggy
>
> Regards,
> Shankara
>
> On Mon, Jun 4, 2018 at 11:24 AM, Dave Kleikamp
> wrote:
>> On 06/01/2018 11:06 PM, shankarapailoor wrote:
>>> Hi,
>>>
>>> Looking at the crash some more, it seems that if value_len > PAGE
On 06/01/2018 11:06 PM, shankarapailoor wrote:
> Hi,
>
> Looking at the crash some more, it seems that if value_len > PAGE_SIZE
> then e_buf->max_size is rounded up nearest page size [1]. If a new
> attribute is added with value_len < e_buf->max_size - EA_SIZE(ea) then
> no new space is allocated
On 05/16/2018 04:43 AM, Christoph Hellwig wrote:
> Use remove_proc_subtree to remove the whole subtree on cleanup, and
> unwind the registration loop into individual calls. Switch to use
> proc_create_seq where applicable.
>
> Signed-off-by: Christoph Hellwig
Acked-by:
The following changes since commit c8a0739b185d11d6e2ca7ad9f5835841d1cfc765:
Merge tag 'ntb-4.15' of git://github.com/jonmason/ntb (2017-11-19 20:41:53
-1000)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.15-2
for you to fetch changes up to 8
The following changes since commit b39ab98e2f4728d98973fd1bc531e3c4cbccb21c:
Mark 'ioremap_page_range()' as possibly sleeping (2017-10-30 10:09:56 -0700)
are available in the Git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.15
for you to fetch changes up to 88a96fa84
On 11/02/2017 08:43 AM, Juerg Haefliger wrote:
Furthermore, it looks like all the callers of __get_metapage() check for
a null return, so I'm not sure we need to handle the error at this
point. I might have to look a bit harder at that, since there are many
callers.
>>>
>>> I d
On 11/02/2017 01:59 AM, Juerg Haefliger wrote:
>
>
> On 10/30/2017 11:13 PM, Dave Kleikamp wrote:
>> On 10/25/2017 02:50 AM, Juerg Haefliger wrote:
>>> Is this a patch you might consider?
>>
>> Sorry it's taken me so long to respond.
>>
>> I d
On 10/30/2017 10:16 AM, Jeff Layton wrote:
> From: Jeff Layton
>
> JFS does not set SB_I_VERSION and doesn't use the i_version counter
> internally. Just remove this increment.
Looks good. I'll push it upstream.
Thanks,
Shaggy
>
> Signed-off-by: Jeff Layton
> ---
> fs/jfs/super.c | 1 -
> 1
On 10/25/2017 02:50 AM, Juerg Haefliger wrote:
> Is this a patch you might consider?
Sorry it's taken me so long to respond.
I don't think this is the right fix. A failed allocation will still
result in a null pointer dereference by the caller, __get_metapage(). I
think the check needs to be put
Acked-by: Dave Kleikamp
On 09/20/2017 03:45 PM, Kees Cook wrote:
> From: David Windsor
>
> The jfs symlink pathnames, stored in struct jfs_inode_info.i_inline and
> therefore contained in the jfs_ip slab cache, need to be copied to/from
> userspace.
>
> cache object all
jfs had previously avoided the use of MAX_LFS_FILESIZE because it hadn't
accounted for the whole 32-bit index range on 32-bit systems. That has
been fixed, so we can simplify the code now.
Suggested by Andreas Dilger.
Signed-off-by: Dave Kleikamp
Cc: Andreas Dilger
Cc: jfs-di
On 08/27/2017 02:47 PM, Linus Torvalds wrote:
> On Wed, Aug 23, 2017 at 2:01 PM, Andreas Dilger wrote:
>>
>> Doug,
>> I noticed while checking for other implications of changing MAX_LFS_FILESIZE
>> that fs/jfs/super.c is also working around this limit.
>
> Note to people: I just committed the pat
On 08/24/2017 05:20 AM, Doug Nazar wrote:
> On 8/23/17 5:01 PM, Andreas Dilger wrote:
>> Doug,
>> I noticed while checking for other implications of changing
>> MAX_LFS_FILESIZE
>> that fs/jfs/super.c is also working around this limit. If you are going
>> to submit a patch for this, it also makes
is a straightforward conversion from calling
> filemap_write_and_wait_range in their fsync operation to calling
> file_write_and_wait_range.
>
> Signed-off-by: Jeff Layton
Acked-by: Dave Kleikamp
(for jfs)
> ---
> arch/powerpc/platforms/cell/spufs/file.c | 2 +-
> drivers/s
The following changes since commit d966564fcdc19e13eb6ba1fbe6b8101070339c3d:
Revert "x86/ioapic: Restore IO-APIC irq_chip retrigger callback" (2017-02-08
18:08:29 -0800)
are available in the git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.13
for you to fetch change
There are a couple places where jfs calls write_one_page() where
clean recovery is not possible. In these cases, the file system
should be marked dirty. To do this, it is now necessary to store the
superblock in the metapage structure.
Signed-off-by: Dave Kleikamp
---
fs/jfs/jfs_metapage.c | 7
Andrew,
Do you want to pick this up into akpm-current? I could push it through
the jfs tree, but without the change to write_one_page(), my version of
the patch would need a manual merge. It'd be a simple one, so maybe
that's not a big deal.
Thanks,
Shaggy
On 05/26/2017 03:45 PM, Dav
On 05/26/2017 05:16 AM, Jeff Layton wrote:
> On Fri, 2017-05-26 at 12:43 +1000, Stephen Rothwell wrote:
>> Hi Andrew,
>>
>> After merging the akpm-current tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> fs/jfs/jfs_metapage.c: In function 'force_metapage':
>>
Commit-ID: c249f255aab86b9b187ba319b9d2684841ac7c8d
Gitweb: http://git.kernel.org/tip/c249f255aab86b9b187ba319b9d2684841ac7c8d
Author: Dave Kleikamp
AuthorDate: Mon, 15 May 2017 14:14:13 -0500
Committer: Ingo Molnar
CommitDate: Tue, 23 May 2017 10:01:34 +0200
sched/rt: Minimize rq
On 05/21/2017 10:41 AM, Fabian Frederick wrote:
> Filesystems generally use SUPER_MAGIC values from magic.h
> instead of a local definition.
>
> Signed-off-by: Fabian Frederick
Acked-by: Dave Kleikamp
> ---
> fs/jfs/jfs_incore.h| 6 +-
> include/uapi/lin
zero, this function does
nothing while holding the lock, so don't bother taking it at all.
Orabug: 25491970
Signed-off-by: Dave Kleikamp
Cc: Ingo Molnar
Cc: Peter Zijlstra
---
kernel/sched/rt.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/kernel/sched/rt.c b/kernel/
Peter, Ingo,
I sent this patch about a month ago and got no response.
https://patchwork.kernel.org/patch/9684545/
Does it seem reasonable? I'm not sure if taking rt_runtime_lock is
strictly necessary, but it's a big improvement to taking rq->lock every
pass through the loop. Is there another way
zero, this function does
nothing while holding the lock, so don't bother taking it at all.
Orabug: 25491970
Signed-off-by: Dave Kleikamp
Cc: Ingo Molnar
Cc: Peter Zijlstra
---
kernel/sched/rt.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/kernel/sched/rt.c b/kernel/
On 04/12/2017 09:27 AM, Matthew Wilcox wrote:
> On Wed, Apr 12, 2017 at 08:05:58AM -0400, Jeff Layton wrote:
>> The callers all set it to 1. Also, make it clear that this function will
>> not set any sort of AS_* error, and that the caller must do so if
>> necessary. No existing caller uses this on
On 01/23/2017 01:52 PM, Fabian Frederick wrote:
>
>
>> On 23 January 2017 at 19:43 Dave Kleikamp wrote:
>>
>>
>> On 01/23/2017 11:50 AM, Fabian Frederick wrote:
>>> See i_size_read() comments in include/linux/fs.h
>>
>> Is this fixing a rea
On 01/23/2017 11:50 AM, Fabian Frederick wrote:
> See i_size_read() comments in include/linux/fs.h
Is this fixing a real problem? Can the bd_inode size change while we're
mounting or resizing the filesystem?
>
> Signed-off-by: Fabian Frederick
> ---
> fs/jfs/resize.c | 4 ++--
> fs/jfs/super.c
On 01/17/2017 02:44 PM, David Miller wrote:
> From: Christoph Hellwig
> Date: Mon, 16 Jan 2017 23:55:21 -0800
>
>> On Mon, Jan 16, 2017 at 10:42:43PM -0500, David Miller wrote:
>>> The lseek() done by dump_skip() should extend the file properly.
>>
>> lseek never extends a file. It just moves th
smaller than the current file position.
This problem can be demonstrated with gdb's bigcore testcase on the
sparc architecture.
Signed-off-by: Dave Kleikamp
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
fs/binfmt_elf.c | 1 +
fs/cored
The following changes since commit 015ed9433be2b476ec7e2e6a9a411a56e3b5b035:
Merge branch 'maybe-uninitialized' (patches from Arnd) (2016-11-11 10:03:01
-0800)
are available in the git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.10
for you to fetch changes up to 36
smaller than the current file position.
This problem can be demonstrated with gdb's bigcore testcase on the
sparc architecture.
Signed-off-by: Dave Kleikamp
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
fs/binfmt_elf.c | 1 +
fs/cored
On 11/22/2016 06:05 PM, Christian Kujau wrote:
> For some time now, I always[0] receive a lockdep warning when there's some
> disk I/O on the system. But recently the warning looks kinda mangled,
> I suspect the recent printk change (4bcc595ccd80, "printk: reinstate
> KERN_CONT for printing conti
is one
through the jfs tree.
Thanks,
Shaggy
>
> Signed-off-by: Deepa Dinamani
> Acked-by: Dave Kleikamp
> Reviewed-by: Arnd Bergmann
> ---
> fs/jfs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
>
The following changes since commit b8927721ae9d5ac0582d29d7b8c267d465ad5f00:
Merge tag 'ext4_for_linus_stable' of
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2016-08-29 12:37:11
-0700)
are available in the git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs
occinelle script:
> /
> @@
> expression y,z;
> @@
>
> - list_splice(y,z);
> - INIT_LIST_HEAD(y);
> + list_splice_init(y,z);
>
> Signed-off-by: Christophe JAILLET
Signed-off-by: Dave Kleikamp
> ---
> fs/jfs/jfs_txnmgr.c | 3 +--
> 1 file changed, 1 insertion(
On 08/26/2016 09:40 AM, Quorum Laval wrote:
> filemap_fdatawait/filemap_write_and_wait may fail, so check the return
> value and jump to error_out in the case of error.
>
> Signed-off-by: Quorum Laval
This looks good. I'll push it upstream.
Thanks,
Dave
> ---
> fs/jfs/resize.c | 10 --
On 08/22/2016 03:28 PM, Quorum Laval wrote:
> filemap_fdatawait may fail, so check the return value and jump to
> error_out in the case of error.
>
> Signed-off-by: Quorum Laval
These look good, but I don't see why these shouldn't be combined into a
single patch.
Thanks,
Dave
> ---
> fs/jfs/r
Trimming the cc list..
On 08/02/2016 07:11 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding m
ts.sourceforge.net
Acked-by: Dave Kleikamp
> ---
> fs/jfs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> index 8653cac..b6fd1ff 100644
> --- a/fs/jfs/ioctl.c
> +++ b/fs/jfs/ioctl.c
> @@ -121,7 +121,7
The following changes since commit 1993b176a8224e371e0732ffada7ab9eb3b0912b:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide (2016-03-28
15:17:02 -0500)
are available in the git repository at:
git://github.com/kleikamp/linux-shaggy.git tags/jfs-4.7
for you to fetch changes up
On 03/30/2016 11:22 AM, Joe Perches wrote:
> On Wed, 2016-03-30 at 10:56 -0500, Dave Kleikamp wrote:
>> On 03/30/2016 07:23 AM, Joe Perches wrote:
>>>
>>> There is a difference in use between jfs_error and the other
>>> jfs_info, jfs_warn, and jfs_err logging
On 03/30/2016 07:23 AM, Joe Perches wrote:
> This patchset fixes the uses of jfs_info, jfs_warn and jfs_err that
> have terminating newlines and a couple other trivialities to make
> the logging a bit more consistent.
These patches look good. I'm pushing them out to the -next build.
> There is a
;
>
> - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
>
> - page_cache_get() -> get_page();
>
> - page_cache_release() -> put_page();
>
> Signed-off-by: Kirill A. Shutemov
Looks good to me. I've also verified the jfs changes in the large pa
Some of the crypto algorithms write to the initialization vector,
but no space has been allocated for it. This clobbers adjacent memory.
Signed-off-by: Dave Kleikamp
---
arch/sparc/crypto/aes_glue.c | 2 ++
arch/sparc/crypto/camellia_glue.c | 1 +
arch/sparc/crypto/des_glue.c | 2
On 09/28/2015 09:18 AM, Yaowei Bai wrote:
> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
>
> Signed-off-by: Yaowei Bai
Acked-by: Dave Kleikamp
> ---
> fs/jfs/namei.c | 3 ---
> fs/jfs/super.c | 3 ---
> 2 files changed, 6 dele
On 07/30/2015 06:36 AM, Ming Lei wrote:
> This patches provides one interface for enabling direct IO
> from user space:
>
> - userspace(such as losetup) can pass 'file' which is
> opened/fcntl as O_DIRECT
>
> Also __loop_update_dio() is introduced to check if direct I/O
> can be used
ain.
>
> So this patch doesn't dirtying pages for ITER_BVEC/ITER_KVEC
> direct read, and loop should be the 1st case to use ITER_BVEC/ITER_KVEC
> for direct read I/O.
>
> The patch is based on previous Dave's patch.
>
> Cc: Dave Kleikamp
> Reviewed-by: Christoph
indentation on if statement
Dave Kleikamp (1):
jfs: clean up jfs_rename and fix out of order unlock
Nan Jia (1):
jfs: removed a prohibited space after opening parenthesis
fs/jfs/file.c | 2 +-
fs/jfs/inode.c | 4 ++--
fs/jfs/namei.c | 27 +--
3 files changed, 16
On 06/04/2015 11:57 AM, Colin King wrote:
> From: Colin Ian King
>
> The if statement and closing brace are indented by 1
> extra space, so remove this extra spacing. Cosmetic
> change only.
Thanks. Pushed to jfs-next.
>
> Signed-off-by: Colin Ian King
> ---
> fs/jfs/inode.c | 4 ++--
> 1 f
On 05/31/2015 04:53 AM, Nan Jia wrote:
> Fixed a coding style issue.
Thanks. Added to jfs-next.
>
> Signed-off-by: Nan Jia
> ---
> fs/jfs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/file.c b/fs/jfs/file.c
> index e98d39d..b9dc23c 100644
> --- a/fs/jf
On 05/05/2015 06:49 AM, Ming Lei wrote:
> Documentation/workqueue.txt:
> If there is dependency among multiple work items used
> during memory reclaim, they should be queued to separate
> wq each with WQ_MEM_RECLAIM.
>
> Loop devices can be stacked, so we have to convert to per-d
On 05/05/2015 12:21 AM, Al Viro wrote:
> From: Al Viro
>
> Signed-off-by: Al Viro
Acked-by: Dave Kleikamp
> ---
> fs/jfs/inode.c | 3 ++-
> fs/jfs/namei.c | 5 ++---
> fs/jfs/symlink.c | 10 +-
> 3 files changed, 5 insertions(+), 13 deletions(-)
>
&g
Not much this time. Just a one-liner.
The following changes since commit 09d35919b06e8508b51ee8a643a67b56f7bea0dd:
Merge branch 'i2c/for-current' of
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2015-03-12 09:50:45
-0700)
are available in the git repository at:
git://github.com
On 03/26/2015 02:28 AM, Christoph Hellwig wrote:
> On Wed, Mar 25, 2015 at 07:37:40PM -0700, David Rientjes wrote:
>> That would be true only for
>>
>> ptr = mempool_alloc(gfp, pool);
>> mempool_free(ptr, pool);
>>
>> and nothing in between, and that's pretty pointless. Typically, caller
and properly initialize the element in alloc_metapage().
>
> At the same time, META_free is never used, so remove it as well.
>
> Signed-off-by: David Rientjes
Acked-by: Dave Kleikamp
> ---
> fs/jfs/jfs_metapage.c | 31 ---
> fs/jfs/jfs_metapag
On 03/20/2015 06:33 PM, Richard Weinberger wrote:
> Hi!
>
> Mainline commit 44512449c0ab368889dd13ae0031fba74ee7e1d2
> (jfs: fix readdir cookie incompatibility with NFSv4) does not work as
> expected on 3.2.
> Maybe on other stable kernels too.
>
> UML stumbled over it:
> https://bugzilla.kernel
On 03/19/2015 06:20 PM, David Rientjes wrote:
> On Mon, 16 Mar 2015, Rasmus Villemoes wrote:
>
>>> Mempools keep elements in a reserved pool for contexts in which
>>> allocation may not be possible. When an element is allocated from the
>>> reserved pool, its memory contents is the same as when i
een this once as well but did not have
> the gumption to send a fix. (The sysv.h one)
>
> I totally agree with this patch. (So many of them, bread crumbs of copy/paste
> for you ;0)
I'm sure that was the case with jfs.
>
> Reviewed-by: Boaz Harrosh
Acked-by: Dave Kleik
On 03/11/2015 10:13 PM, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor.
>
> Signed-off-by: Scott Wood
> Cc: jfs-discuss...@lists.sourceforge.net
Acked-by: Dave Kleikamp
Do
1 - 100 of 522 matches
Mail list logo
