RE: [PATCH 1/4] scsi: aacraid: remove AAC_STAT_GOOD define

2018-07-06 Thread Dave Carroll
> > On Thu, Jul 05, 2018 at 05:42:02PM +, Dave Carroll wrote: > > > Remove the AAC_STAT_GOOD definition and open code it in the places > > > it was used. > > > > > > This will make subsequent refactoring in this area easier. > > > > >

RE: aacraid code passes GFP_DMA32 to kmalloc this will not work

2018-04-04 Thread Dave Carroll
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: Thursday, March 29, 2018 8:51 AM > To: dl-esc-Aacraid Linux Driver ; James E.J. > Bottomley ; Martin K. Petersen > ; SCSI development list s...@vger.kernel.org>; Linux Kernel Mailing List > > Subject: aacraid

RE: [PATCH] aacraid: use timespec64 instead of timeval

2017-11-07 Thread Dave Carroll
y about aacraid by that time. > > Signed-off-by: Arnd Bergmann > --- Reviewed-by: Dave Carroll

RE: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use

2017-09-15 Thread Dave Carroll
- > drivers/scsi/aacraid/linit.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Dave Carroll

RE: [PATCH 3/6] scsi: aacraid: constify pci_error_handlers structures

2017-08-12 Thread Dave Carroll
ers aac_pci_err_handler = { > .error_detected = aac_pci_error_detected, > .mmio_enabled = aac_pci_mmio_enabled, > .slot_reset = aac_pci_slot_reset, Acked-by: Dave Carroll

RE: [PATCH] scsi: aacraid: fix leak of data from stack back to userspace

2017-06-13 Thread Dave Carroll
by: Colin Ian King > --- > drivers/scsi/aacraid/commctrl.c | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Dave Carroll

RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-26 Thread Dave Carroll
o check and also the dead-code non-zero case too. > > Detected by CoverityScan, CID#1411632 ("Logically Dead Code") > > Signed-off-by: Colin Ian King > --- > drivers/scsi/aacraid/commsup.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Acked-by: Dave Carroll