Hi,
Artem Savkov schrieb:
>On Sun, Mar 31, 2013 at 08:15:14AM +0200, Danny Baumann wrote:
>> Artem Savkov schrieb:
>> >acpi_video_device_lcd_get_level_current() called
>> >acpi_video_bqc_value_to_level()
>> >with "*level" as a second argument, r
Artem Savkov schrieb:
>acpi_video_device_lcd_get_level_current() called
>acpi_video_bqc_value_to_level()
>with "*level" as a second argument, resulting in level being returned
>based on
>initial input, not current brightness, breaking backlight controls.
I don't think this change is correct. A
Hi,
Well, the ACPI spec says this (section B.5.2):
"
The OEM may define the number 0 as "Zero brightness" that can mean
to turn off the lighting (e.g. LCD panel backlight) in the device.
This may be useful in the case of an output device that can still be
viewed using only ambient light, for ex
Hi,
Well, the ACPI spec says this (section B.5.2):
"
The OEM may define the number 0 as "Zero brightness" that can mean
to turn off the lighting (e.g. LCD panel backlight) in the device.
This may be useful in the case of an output device that can still be
viewed using only ambient light, for ex
Hi,
Thus far our assumption always was that the acpi backlight works better
than the intel native backlight. So everything only uses the intel
backlight if there's no other backlight driver by default.
There are machines, such as the pnv netbook on my desk, on which
intel_backlight does nothin
Hi,
Am 26.03.2013 18:02, schrieb Matthew Garrett:
On Tue, Mar 26, 2013 at 12:48:44PM +0100, Danny Baumann wrote:
This patch makes the behaviour of the intel_backlight backlight device
consistent to e.g. acpi_videoX: When writing the value 0, the set brightness
makes the panel content barely
Hi,
Thus far our assumption always was that the acpi backlight works better
than the intel native backlight. So everything only uses the intel
backlight if there's no other backlight driver by default.
So if I should merge this as a general solution for Windows 8 machines not
working properly,
of the maximum
level. The default is 5, which provides a backlight level that is barely
readable. Setting it to 0 restores the old behaviour.
Signed-off-by: Danny Baumann
---
drivers/gpu/drm/i915/intel_panel.c | 48 --
1 file changed, 41 insertions(+), 7 deleti
l.org/show_bug.cgi?id=55071
Danny Baumann (1):
drm/i915: Allow specifying a minimum brightness level for sysfs
control.
drivers/gpu/drm/i915/intel_panel.c | 48 --
1 file changed, 41 insertions(+), 7 deletions(-)
--
1.8.1.4
--
To unsubscribe from this list:
0xe024
The first one doesn't require handling; the two latter ones do not have
a real meaning in Linux, so bind them to launcher keycodes.
Signed-off-by: Danny Baumann
---
drivers/platform/x86/dell-wmi.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/del
, and what
scancode to use), I would appreciate input on that.
Regards,
Danny
[1] http://www.tomshw.it/files/2012/08/collezioni/1752/32067_b.jpg
Danny Baumann (1):
dell-wmi: Add support for keys present on Inspiron 15R SE.
drivers/platform/x86/dell-wmi.c | 9 +
1 file changed, 9
v3 incorporates Aaron's feedback, v4 fixes my inability to use git
send-email properly. Sorry for that.
Regards,
Danny
Am 19.03.2013 17:22, schrieb Danny Baumann:
In particular, this fixes brightness control initialization for all
devices that return index values from _BQC and don
itialization case.
Signed-off-by: Danny Baumann
---
drivers/acpi/video.c | 43 ++-
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 313f959..09e4722 100644
--- a/drivers/acpi/video.c
+++ b/driv
Make code paths a little easier to follow, and don't needlessly continue
list iteration.
Signed-off-by: Danny Baumann
---
drivers/acpi/video.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 09e4722..89
The value initially read via _BQC also needs to be offset by 2 to
compensate for the first 2 special items in _BCL. Introduce a helper
function that does the BQC-value-to-level conversion in order to not
needlessly duplicate code.
Signed-off-by: Danny Baumann
---
drivers/acpi/video.c | 60
Hi,
>> +static unsigned long long
+acpi_video_bqc_value_to_level(struct acpi_video_device *device,
+ unsigned long long bqc_value)
+{
+ unsigned long long level;
+
+ if (device->brightness->flags._BQC_use_index) {
+ if (device->brightness->fl
Hi,
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 313f959..9c33871 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -222,7 +222,7 @@ static int acpi_video_device_lcd_set_level(struct
acpi_video_device *device,
int level);
static int acpi
The value initially read via _BQC also needs to be offset by 2 to
compensate for the first 2 special items in _BCL. Introduce a helper
function that does the BQC-value-to-level conversion in order to not
needlessly duplicate code.
Signed-off-by: Danny Baumann
---
drivers/acpi/video.c | 52
Make code paths a little easier to follow, and don't needlessly continue
list iteration.
Signed-off-by: Danny Baumann
---
drivers/acpi/video.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 9c33871..5e
itialization case.
Signed-off-by: Danny Baumann
---
drivers/acpi/video.c | 33 -
1 file changed, 20 insertions(+), 13 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 313f959..9c33871 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video
Hi,
>> +static unsigned long long
+acpi_video_index_to_level(struct acpi_video_device *device,
+ unsigned long long index)
+{
+ if (device->brightness->flags._BCL_reversed)
+ index = device->brightness->count - 3 - index;
+
+ return device->brigh
The value initially read via _BQC also needs to be offset by 2 to
compensate for the first 2 special items in _BCL. Introduce a helper
function to do the conversion in order to not needlessly duplicate code.
---
drivers/acpi/video.c | 23 ++-
1 file changed, 14 insertions(+), 9
Make code paths a little easier to follow, and don't needlessly continue
list iteration.
---
drivers/acpi/video.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index ef85574..d0fade7 100644
--- a/drivers/acpi/video.c
+
SE (7520).
Regards,
Danny
Danny Baumann (3):
ACPI video: Fix brightness control initialization for some laptops.
ACPI video: Make logic a little easier to understand.
ACPI video: Fix applying indexed initial brightness value.
drivers/acpi/video.c | 59
In particular, this fixes brightness control initialization for all
devices that return index values from _BQC and don't happen to have the
initial index set by the BIOS in their _BCL table. One example for that
is the Dell Inspiron 15R SE (model number 7520).
What happened for those devices is th
25 matches
Mail list logo
