[RFC PATCH 0/2] USB: input: yealink.c: update key mappings

2014-12-22 Thread Daniele Forsi
erspace: "RING" whose purpose according to the user manual is to cycle all available ringtones "MUTE" whose purpose is to mute the USB microphone which KEY_* values should be used for them? I have two more questions: DRIVER_VERSION should be updated? are both patches suitable for s

[RFC PATCH 1/2] USB: input: yealink.c: use KEY_NUMERIC_* for numeric keys, star and pound

2014-12-22 Thread Daniele Forsi
Fix the "pound" key that being mapped to Shift+3 was returning '£' instead of '#' when using an Italian keyboard mapping and use the same values as the cm109.c driver (which was based on this yealink.c driver) also for '0' to '9' and for '*&#

[RFC PATCH 2/2] USB: input: yealink.c: add mapping for "RING" and "MUTE" keys

2014-12-22 Thread Daniele Forsi
According to the user manual of the "VOIP-3 SKY" USB phone, the RING key is used to select different ring tones and the MUTE key is used to mute the microphone. Signed-off-by: Daniele Forsi --- drivers/input/misc/yealink.c | 4 1 file changed, 4 insertions(+) diff --git a/dri

Re: [RFC RESEND 00/10] Create separate header for ehci-dbgp driver

2014-11-04 Thread Daniele Forsi
2014-11-03 4:07 GMT+01:00 Chris Rorvick: > fusbh200: Make Xen notificaiton consistent with EHCI > fotg210: Make Xen notificaiton consistent with EHCI you may want to fix the spelling: s/notificaiton/notification/ -- Daniele Forsi -- To unsubscribe from this list: send th

Re: [PATCH 5/5] phy: exynos5-usbdrd: Adding Kconfig dependency for Exynos7

2014-08-28 Thread Daniele Forsi
> tristate "Exynos5 SoC series USB DRD PHY driver" > - depends on ARCH_EXYNOS5 && OF > + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF shouldn't that prompt and its help text be updated to mention also Exynos7? -- Daniele Forsi -- To un

Re: [PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Daniele Forsi
2014-08-20 14:35 GMT+02:00 Hayes Wang: > Is this necessary? Besides the check of the "start", > there are checks of the "size" and rtl_fw_data_ok(). > I think they cover the situations which you indicate. it's not necessary and it's better checked lat

Re: [PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Daniele Forsi
tart = le32_to_cpu(fw_header->fw_start); > + if (start > fw->size) > + goto out; since "start" is an offset in an array of size "fw->size" this should check for ">=" and if a command is at least cmd(2 bytes) + length(2 bytes),

[PATCH] arch/x86/kernel/cpu/cyrix.c: remove redundant code

2014-08-02 Thread Daniele Forsi
This function doesn't read dir1 so it doesn't need to set a default value and code for case 3 and case 5 is identical so replace it with a "fall through" comment. Signed-off-by: Daniele Forsi --- arch/x86/kernel/cpu/cyrix.c | 6 ++ 1 file changed, 2 insertions(+), 4 dele

Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-20 Thread Daniele Forsi
if (index >= gpio->gpio_chip.ngpio) return -EINVAL; gpio->index |= gpio_index_mask[offset]; if (value) gpio->index |= gpio_value_mask[offset]; else gpio->index

Re: [PATCH 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-04 Thread Daniele Forsi
STMicroelectronics SoCs chip with one DesignWare Core USB3 IP > + inside (i.e. STiH407). > + > Say 'Y' or 'M' here if you have one such device > > comment "Debugging features" you are actually removing the line "Say '

Re: [PATCH 2/3] ARM: dts: sti: Add st-dwc3 devicetree bindings documentation

2014-07-04 Thread Daniele Forsi
all other lines in this block start with a lower case letter; two lines end with a full stop, three lines without; colons the last lines do not align to the first three -- Daniele Forsi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] leds: USB: Add support for MSI GT683R led panels

2014-06-05 Thread Daniele Forsi
2014-06-05 13:06 GMT+02:00: >> + dev_err(&led->usb_dev->dev, "Message to be send to device is >> too long\n"); there's a typo: s/send/sent/ -- Daniele Forsi -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH] USB: serial: ftdi_sio: add id for Brainboxes VX-001 ExpressCard

2014-03-25 Thread Daniele Forsi
2014-03-25 20:00 GMT+01:00 Michele Baldessari: > Custom VID/PID for Brainboxes VX-001 ExpressCard RS232 as reported in > + * Product: ExpressCard 1 Port RS2323 there is a stray trailing "3" -- Daniele Forsi -- To unsubscribe from this list: send the line "unsubscribe linu