[PATCH v2 0/4] media: vidtv: add media controller support

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" This series adds media controller support for vidtv so that we can support this driver at the test-media script in v4l-utils. I based my implementation on vim2m's. changes in v2: added missing #ifdef that otherwise prevented this

[PATCH v2 4/4] media: vidtv: print message when driver is removed

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Print a message when the driver is removed so that we get some visual confirmation when unbinding vidtv. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH v2 2/4] media: vidtv: reinstate sysfs bind attrs

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Reinstate sysfs bind attrs so that vidtv can be bound and unbound via sysfs. This is useful for automated regression testing in userspace. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 1 - 1 file changed,

[PATCH v2 3/4] media: vidtv: use a simpler name in platform_{device|driver}

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Change from "vidtv_bridge" to simply "vidtv" so that vidtv looks more similar to the other media virtual drivers in /sys/bus/platform. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 ++

[PATCH v2 1/4] media: vidtv: Add media controller support

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Add media controller support when CONFIG_MEDIA_CONTROLLER_DVB is set so that, in the future, a test sequence in v4l-utils can be written without having to know which /dev/fooX device should be used. Signed-off-by: Daniel W. S. Almeida --- .../media/te

[PATCH v4l-utils] test-media: add support for vidtv

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Add support for vidtv at the test-media script so that automated testing is possible. Proper compliance tests are still pending. Signed-off-by: Daniel W. S. Almeida --- contrib/test/test-media | 72 + 1 file c

[PATCH 4/4] media: vidtv: print message when driver is removed

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Print a message when the driver is removed so that we get some visual confirmation when unbinding vidtv. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH 3/4] media: vidtv: use a simpler name in platform_{device|driver}

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Change from "vidtv_bridge" to simply "vidtv" so that vidtv looks more similar to the other media virtual drivers in /sys/bus/platform. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 ++

[PATCH 0/4] media: vidtv: add media controller support

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" This series adds media controller support for vidtv so that we can support this driver at the test-media script in v4l-utils. I based my implementation on vim2m's. Daniel W. S. Almeida (4): media: vidtv: Add media controller support media: v

[PATCH 1/4] media: vidtv: Add media controller support

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Add media controller support when CONFIG_MEDIA_CONTROLLER_DVB is set so that, in the future, a test sequence in v4l-utils can be written without having to know which /dev/fooX device should be used. Signed-off-by: Daniel W. S. Almeida --- .../media/te

[PATCH 2/4] media: vidtv: reinstate sysfs bind attrs

2021-01-05 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Reinstate sysfs bind attrs so that vidtv can be bound and unbound via sysfs. This is useful for automated regression testing in userspace. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 1 - 1 file changed,

[PATCH 2/3] media: vidtv: remove unused field from 'struct vidtv_mpeg_ts'

2020-12-24 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Commit 3d1387b3b8f6 ("media: vidtv: fix some warnings") replaced the unused flexible array member at the end of struct vidtv_mpeg_ts with a pointer. This broke the 188-byte alignment since the struct no longer was 4 bytes in size. Fix this by

[PATCH 3/3] media: vidtv: add initial debugfs interface

2020-12-24 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Add a debugfs interface for testing purposes that can be enabled by selecting **DVB_VIDTV_DEBUGFS**. This makes it possible to: dynamically inject errors at runtime by interacting with the files at /sys/kernel/debug/vidtv/* read some dvbv5 stati

[PATCH 1/3] vidtv: psi: fix missing crc for PMT

2020-12-24 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" The PMT write function was refactored and this broke the CRC computation. Fix it. Fixes: db9569f67e2e ("media: vidtv: cleanup PMT write table function") Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 5 +

[PATCH v2 4/6] media: vidtv: psi: extract descriptor chaining code into a helper

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The code to append a descriptor to the end of a chain is repeated throughout the psi generator code. Extract it into its own helper function to avoid cluttering. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 49

[PATCH v2 6/6] media: vidtv: psi: fix missing assignments in while loops

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Some variables were only assigned once but were used in while loops as if they had been updated at every iteration. Fix this. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 22 +--- 1 file changed, 10

[PATCH v2 3/6] media: vidtv: psi: Implement an Event Information Table (EIT)

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Implement an Event Information Table (EIT) as per EN 300 468 5.2.4. The EIT provides information in chronological order regarding the events contained within each service. For now only present event information is supported. Signed-off-by: Daniel W. S. Almeida

[PATCH v2 5/6] media: vidtv: Move s302m specific fields into encoder context

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida A few fields used only by the tone generator in the s302m encoder are stored in struct vidtv_encoder. Move them into struct vidtv_s302m_ctx instead. While we are at it: fix a checkpatch warning for long lines. Signed-off-by: Daniel W. S. Almeida --- .../media/test

[PATCH v2 1/6] media: vidtv: extract the initial CRC value to into a #define

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The same constant (0x) is used in three different functions. Extract it into a #define to avoid repetition. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH v2 2/6] media: vidtv: psi: add a Network Information Table (NIT)

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Add a Network Information Table (NIT) as specified in ETSI EN 300 468. This table conveys information relating to the physical organization of the multiplexes carried via a given network and the characteristics of the network itself. It is conveyed in the output of

[PATCH v2 0/6] media: vidtv: Add support for more MPEG PSI tables

2020-10-31 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Implement support for more MPEG PSI tables (i.e. NIT & EIT). While we're at it, fix a few minor mistakes in the PSI generator. I initially sent this without a cover letter and as WIP but I have now tidied it up and it's spotless. I tested the driver on

Re: [PATCH WIP 1/6] media: vidtv: extract the initial CRC value to into a #define

2020-09-29 Thread Daniel W. S. Almeida
Hi Mauro! > Next time, please add a patch 0, specially when you tag something as > WIP, or RFC. Sorry about that :) These are almost good but I came across some weird kasan output. Can you test this series in a kernel with kasan instrumentation turned on? Should apply just fine on top of your

[PATCH WIP 5/6] media: vidtv: Move s302m specific fields into encoder context

2020-09-28 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida A few fields used only by the tone generator in the s302m encoder are stored in struct vidtv_encoder. Move them into struct vidtv_s302m_ctx instead. While we are at it: fix a checkpatch warning for long lines. Signed-off-by: Daniel W. S. Almeida --- .../media/test

[PATCH WIP 4/6] media: vidtv: psi: extract descriptor chaining code into a helper

2020-09-28 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The code to append a descriptor to the end of a chain is repeated throughout the psi generator code. Extract it into its own helper function to avoid cluttering. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 49

[PATCH WIP 3/6] media: vidtv: psi: Implement an Event Information Table (EIT)

2020-09-28 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Implement an Event Information Table (EIT) as per EN 300 468 5.2.4. The EIT provides information in chronological order regarding the events contained within each service. For now only present event information is supported. Signed-off-by: Daniel W. S. Almeida

[PATCH WIP 6/6] media: vidtv: psi: fix missing assignments in while loops

2020-09-28 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Some variables were only assigned once but were used in while loops as if they had been updated at every iteration. Fix this. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 22 +--- 1 file changed, 10

[PATCH WIP 2/6] media: vidtv: psi: add a Network Information Table (NIT)

2020-09-28 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Add a Network Information Table (NIT) as specified in ETSI EN 300 468. This table conveys information relating to the physical organization of the multiplexes carried via a given network and the characteristics of the network itself. It is conveyed in the output of

[PATCH WIP 1/6] media: vidtv: extract the initial CRC value to into a #define

2020-09-28 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The same constant (0x) is used in three different functions. Extract it into a #define to avoid repetition. Signed-off-by: Daniel W. S. Almeida --- drivers/media/test-drivers/vidtv/vidtv_psi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH v2] media: vidtv: fix build on 32bit architectures

2020-09-16 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following error for builds on 32bit architectures: ERROR: modpost: "__udivdi3" [drivers/media/test-drivers/vidtv/dvb-vidtv-bridge.ko] undefined! Which is due to 64bit divisions that did not go through the helpers in linux/math64.h As vidtv_mux_chec

Re: [PATCH] media: vidtv: fix build on 32bit architectures

2020-09-16 Thread Daniel W. S. Almeida
Hi Mauro, Geert, > That doesn't seem to be the right thing to do here. > > Assuming that sampling rate is 48 kHz, you'll > have duration = 1.875, which would be rounded to 1. > > In other words, the above is identical to: > > au->pts = count > > Now, I don't know from where that CLOCK_UNIT_90KHZ c

Re: [v10 3/4] media: vidtv: add a bridge driver

2020-09-15 Thread Daniel W. S. Almeida
Hi Geert, Thanks for bringing this to my attention. >> +u32 nbytes = 0; /* the number of bytes written by this function */ >> + >> +u64 nbytes_expected; /* the number of bytes we should have written */ >> +u64 nbytes_streamed; /* the number of bytes we actually wrote */ >> +u32

Re: [v10 3/4] media: vidtv: add a bridge driver

2020-09-15 Thread Daniel W. S. Almeida
Hi there Geert! Sorry for breaking stuff :) Anyways I just sent in a fix. I decided to drop that entire function because as I said, it needs a do-over and that can be done later at a slower pace. I'm not sure on how to go about testing this properly. I tried 'make ARCH=x86' for example and it bu

[PATCH] media: vidtv: fix build on 32bit architectures

2020-09-15 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following error for builds on 32bit architectures: ERROR: modpost: "__udivdi3" [drivers/media/test-drivers/vidtv/dvb-vidtv-bridge.ko] undefined! Which is due to 64bit divisions that did not go through the helpers in linux/math64.h As vidtv_mux_chec

Re: [PATCH RFC 06/11] media: vidtv: get rid of some endiannes nonsense

2020-09-14 Thread Daniel W. S. Almeida
Hi Mauro, > Genmask is always highest order to low order. It doesn't make > any sense to make it depends on endiannes. > I added these #ifdefs due to this: https://lwn.net/Articles/741762/ i.e. Fields to access are specified as GENMASK() values - an N-bit field starting at bit #M is encoded a

Re: [v10 0/4] media: vidtv: Implement a virtual DVB driver

2020-09-12 Thread Daniel W. S. Almeida
Hi Hans and Mauro & all >Why the dvb_ prefix? All virtual drivers just start with 'vi'. > >And wouldn't it make more sense to call dvb_vidtv_bridge.ko just vidtv.ko? >Just like the other virtual media drivers? I guess Mauro was the one to come up with the dvb_* prefix for the kernel modules for

Re: [v10 0/4] media: vidtv: Implement a virtual DVB driver

2020-09-11 Thread Daniel W. S. Almeida
Hey Mauro, > Thanks for all the hard work on it. Very much appreciated! > > I finally found some time to test it. For now, just a quick > test from my side, without passing any arguments to the > driver. > That's nice! > My plan is to write some patches on the top of yours, in order to > addre

[v2 2/2] media: platform: vpdma.c: fix comparison to bool

2020-09-03 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING: Comparison to bool Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/ti-vpe/vpdma.c | 9 ++

[v2 1/2] media: dvb-frontends: lgdt3306a.c: remove dead code

2020-09-03 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/dvb-frontends/lgdt3306a.c:718:5-8: Unneeded variable: "ret". Return "0" on line 744 Code was enclosed with #if 0 and thus this variable was not needed. Remove

[v10 4/4] media: Documentation: vidtv: Add ReST documentation for vidtv

2020-08-21 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Add documentation for the Virtual Digital TV driver (vidtv) in the Restructured Text (ReST) format. This discusses: - What is vidtv - Why vidtv is needed - How to build and run vidtv - How vidtv is structured - How to test vidtv - How to improve vidtv Sig

[v10 1/4] media: vidtv: implement a tuner driver

2020-08-21 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" The virtual DVB test driver serves as a reference DVB driver and helps validate the existing APIs in the media subsystem. It can also aid developers working on userspace applications. This dummy tuner should support common TV standards such as DVB-T/T2/S/

[v10 2/4] media: vidtv: implement a demodulator driver

2020-08-21 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Implement a I2C demodulator driver, simulating support for DVB-T, DVB-C and DVB-S. This demodulator will periodically check the signal quality against a table and drop the TS lock if it drops below a threshold value, regaining it in the event that

[v10 0/4] media: vidtv: Implement a virtual DVB driver

2020-08-21 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" This series is work in progress. It represents the current work done on a virtual DVB driver for the Linux media subsystem. I am new to the media subsystem and to kernel development in general. This driver aims to: - Serve as template for new

[v9 1/4] media: vidtv: implement a tuner driver

2020-08-18 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" The virtual DVB test driver serves as a reference DVB driver and helps validate the existing APIs in the media subsystem. It can also aid developers working on userspace applications. This dummy tuner should support common TV standards such as DVB-T/T2/S/

[v9 0/4] media: vidtv: Implement a virtual DVB driver

2020-08-18 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" This series is work in progress. It represents the current work done on a virtual DVB driver for the Linux media subsystem. I am new to the media subsystem and to kernel development in general. This driver aims to: - Serve as template for new

[v9 4/4] media: Documentation: vidtv: Add ReST documentation for vidtv

2020-08-18 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Add documentation for the Virtual Digital TV driver (vidtv) in the Restructured Text (ReST) format. This discusses: - What is vidtv - Why vidtv is needed - How to build and run vidtv - How vidtv is structured - How to test vidtv - How to improve vidtv Sig

[v9 2/4] media: vidtv: implement a demodulator driver

2020-08-18 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Implement a I2C demodulator driver, simulating support for DVB-T, DVB-C and DVB-S. This demodulator will periodically check the signal quality against a table and drop the TS lock if it drops below a threshold value, regaining it in the event that

Re: [PATCH 04/20] media: uvc: uvc_v4l2.c: add temp variable for list iteration

2020-08-10 Thread Daniel W. S. Almeida
Hi Laurent, thanks for reviewing! > If no entity is found by this loop the next line will dereference a NULL > pointer. There's a similar issue below. You mean this line, right? > pin = iterm->id; In which case, yes I missed it! > I think the issues reported by coccinelle are fals

Re: [PATCH 03/20] media: usb: uvc_ctrl.c: add temp variable for list iteration

2020-08-10 Thread Daniel W. S. Almeida
Hi Laurent! > I'f you're OK with these changes there's no need to resubmit, I can > update when applying. Please let me know how you'd like to proceed. That's OK with me! Thanks for reviewing. - Daniel

[PATCH 13/20] media: dvb-frontends: mb86a16.c: remove useless if/else

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/dvb-frontends/mb86a16.c:1455:6-8: WARNING: possible condition with no effect (if == else) Both branches are the same, so remove the if/else altogether. Found using - Coccinelle (http://coccinelle.lip6.f

[PATCH 18/20] media: pci: cobalt-i2c.c: fix comparison of 0/1 to bool variable

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/cobalt/cobalt-i2c.c:176:16-21: WARNING: Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:180:29-33: WARNING: Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt

[PATCH 06/20] media: mtk-vcodec: mtk_vcodec_dec.c: fix comparison to bool

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:197:14-35: WARNING: Comparison to bool drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:198:7-29: WARNING: Comparison to bool drivers/media/platform/

[PATCH 20/20] media: mtk-vcodec: vdec_vp9_if.c: fix comparison to bool

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c:963:6-31: WARNING: Comparison to bool Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/mtk-v

[PATCH 19/20] media: platform: vpdma.c: fix comparison to bool

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING: Comparison to bool Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida --- drivers/media/platform/ti-vpe/vpdma.c | 2

[PATCH 16/20] media: i2c: imx219.c: fix assignment of 0/1 to bool variable

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/i2c/imx219.c:1191:1-18: WARNING: Assignment of 0/1 to bool variable Replace the assignment to 0 with false instead. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W.

[PATCH 12/20] media: usb: dib0700_devices.c: remove useless if/else

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/usb/dvb-usb/dib0700_devices.c:1741:1-3: WARNING: possible condition with no effect (if == else) Both branches are the same, so remove the if/else altogether. Found using - Coccinelle (http://coccinel

[PATCH 08/20] media: pci: saa7164.c: Replace if(cond) BUG with BUG_ON

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-buffer.c:254:3-6: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-buffer.c:261:3-6: WARNING: Use BUG_ON instead of if condition follo

[PATCH 11/20] media: pci: saa7164-core.c: replace if (cond) BUG() with BUG_ON()

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-core.c:579:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-core.c:592:3-6: WARNING: Use BUG_ON instead of if condition follo

[PATCH 09/20] media: pci: saa7164-dvb.c: replace if(cond) BUG() with BUG_ON()

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-dvb.c:341:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG drivers/media/pci/saa7164/saa7164-dvb.c:483:2-5: WARNING: Use BUG_ON instead of if condition followed by B

[PATCH 15/20] media: pci: cx23855-video.c: remove duplicate argument in 'or'

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/pci/cx23885/cx23885-video.c:639:24-44: duplicated argument to & or | V4L2_CAP_VBI_CAPTURE appears twice, remove it. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel

[PATCH 07/20] media: vicodec: vicodec-core.c: fix assignment of 0/1 to bool variable

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/test-drivers/vicodec/vicodec-core.c:1674:2-21: WARNING: Assignment of 0/1 to bool variable drivers/media/test-drivers/vicodec/vicodec-core.c:1675:2-26: WARNING: Assignment of 0/1 to bool variable By rep

[PATCH 10/20] media: pci: saa7164-vbi.c: replace if (cond) BUG() with BUG_ON()

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/pci/saa7164/saa7164-vbi.c:707:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. drivers/media/pci/saa7164/saa7164-vbi.c:760:2-5: WARNING: Use BUG_ON instead of if condition followed by B

[PATCH 17/20] media: i2c: tda1997x.c: Fix assignment of 0/1 to bool variable

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle reports: drivers/media/i2c/tda1997x.c:911:6-21: WARNING: Assignment of 0/1 to bool variable drivers/media/i2c/tda1997x.c:939:2-17: WARNING: Assignment of 0/1 to bool variable drivers/media/i2c/tda1997x.c:947:4-19: WARNING:

[PATCH 05/20] media: cobalt: cobalt-omnitek.c: fix comparison to bool

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/pci/cobalt/cobalt-omnitek.c:119:5-19: WARNING: Comparison to bool By using "!cond" instead of "cond == false" Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Dani

[PATCH 14/20] media: dvb-frontends: lgdt3306a.c: remove dead code

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following coccinelle report: drivers/media/dvb-frontends/lgdt3306a.c:718:5-8: Unneeded variable: "ret". Return "0" on line 744 Code was enclosed with #if 0 and thus this variable was not needed. Remove that code altogether.

[PATCH 01/20] media: sunxi: sun8i-rotate.c: remove useless error message

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" This fixes the following coccinelle report: drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9: line 751 is redundant because platform_get_irq() already prints an error By removing the useless call to dev_err() Found using - Coccin

[PATCH 04/20] media: uvc: uvc_v4l2.c: add temp variable for list iteration

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fixes the following coccinelle reports: drivers/media/usb/uvc/uvc_v4l2.c:840:8-13: ERROR: invalid reference to the index variable of the iterator on line 836 drivers/media/usb/uvc/uvc_v4l2.c:851:5-10: ERROR: invalid reference to the index variable of th

[PATCH 03/20] media: usb: uvc_ctrl.c: add temp variable for list iteration

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fixes the following coccinelle report: drivers/media/usb/uvc/uvc_ctrl.c:1860:5-11: ERROR: invalid reference to the index variable of the iterator on line 1854 By introducing a temporary variable to iterate the list. Do not dereference the 'entity&#x

[PATCH 02/20] media: exynos4-is: media-dev.c: use PTR_ERR_OR_ZERO

2020-08-07 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fixes the following coccinelle report: drivers/media/platform/exynos4-is/media-dev.c:1273:1-3: WARNING: PTR_ERR_OR_ZERO can be used By using PTR_ERR_OR_ZERO in place of the existing logic. Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-

[v8 1/4] media: vidtv: implement a tuner driver

2020-07-30 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida The virtual DVB test driver serves as a reference DVB driver and helps validate the existing APIs in the media subsystem. It can also aid developers working on userspace applications. This dummy tuner should support common TV standards such as DVB-T/T2/S/S2, ISDB-T

[v8 4/4] media: Documentation: vidtv: Add ReST documentation for vidtv

2020-07-30 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Add documentation for the Virtual Digital TV driver (vidtv) in the Restructured Text (ReST) format. This discusses: - What is vidtv - Why vidtv is needed - How to build and run vidtv - How vidtv is structured - How to test vidtv - How to improve vidtv Signed-off-by

[v8 2/4] media: vidtv: implement a demodulator driver

2020-07-30 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Implement a I2C demodulator driver, simulating support for DVB-T, DVB-C and DVB-S. This demodulator will periodically check the signal quality against a table and drop the TS lock if it drops below a threshold value, regaining it in the event that the signal improves

[v8 0/4] media: vidtv: Implement a virtual DVB driver

2020-07-30 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida This series is work in progress. It represents the current work done on a virtual DVB driver for the Linux media subsystem. I am new to the media subsystem and to kernel development in general. This driver aims to: - Serve as template for new DVB driver

[PATCH] docs: admin-guide/index.rst: Add pstore-blk.rst

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warning: Documentation/admin-guide/pstore-blk.rst: WARNING: document isn't included in any toctree By adding 'pstore-blk.rst' to the index Signed-off-by: Daniel W. S. Almeida --- Documentation/admin-guide/index.rst | 1 + 1

[PATCH] docs: trace/index.rst: add histogram-design.rst

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warning: Documentation/trace/histogram-design.rst: WARNING: document isn't included in any toctree By adding 'histogram-design.rst' to the index. Signed-off-by: Daniel W. S. Almeida --- Documentation/trace/index.rst | 1 + 1

[PATCH] docs: firmware-guide/acpi/index.rst: Add intel-pmc-mux.rst

2020-07-18 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: Documentation/firmware-guide/acpi/intel-pmc-mux.rst: WARNING: document isn't included in any toctree By adding 'intel-pmc-mux.rst' to the index. Signed-off-by: Daniel W. S. Almeida --- Documentation/firmware

[PATCH] docs: kvm/api.rst: Fix indentation

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warnings: WARNING: Definition list ends without a blank line; unexpected unindent Signed-off-by: Daniel W. S. Almeida --- Documentation/virt/kvm/api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/virt/kvm

[PATCH] docs: admin-guide/mm/index: Fix reference to nonexistent document

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warning: WARNING: toctree contains reference to nonexistent document 'admin-guide/mm/nommu-map' This was due to a typo. Signed-off-by: Daniel W. S. Almeida --- Documentation/admin-guide/mm/index.rst | 2 +- 1 file changed, 1 inser

[PATCH] docs: process/index.rst: Fix reference to nonexistent document

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warning: WARNING: toctree contains reference to nonexistent document 'process/unaligned-memory-access' The path to the document was wrong. Signed-off-by: Daniel W. S. Almeida --- Documentation/process/index.rst | 4 ++-- 1 file

[PATCH] docs: staging/tee.rst: convert into definition list

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warnings: tee.rst:65: WARNING: Unexpected indentation. tee.rst:69: WARNING: Block quote ends without a blank line; unexpected unindent. By switching to the 'definition list' syntax. Signed-off-by: Daniel W. S. Almeida --- Documentati

[PATCH] docs: watch_queue.rst: fix malformed inline literal

2020-07-18 Thread Daniel W. S. Almeida
From: Daniel W. S. Almeida Fix the following warnings: watch_queue.rst:107: WARNING: Inline literal start-string without end-string. watch_queue.rst:107: WARNING: Inline emphasis start-string without end-string watch_queue.rst:184: WARNING: Inline literal start-string without end-string

[PATCH 25/25] Documentation/index.rst: Add watch_queue

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following sphinx warning: Documentation/watch_queue.rst: WARNING: document isn't included in any toctree Signed-off-by: Daniel W. S. Almeida --- Documentation/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentat

[PATCH 22/25] Documentation/bpf/index.rst: fix sphinx warning:

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning Documentation/bpf/ringbuf.rst: WARNING: document isn't included in any toctree Signed-off-by: Daniel W. S. Almeida --- Documentation/bpf/index.rst | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/

[PATCH 23/25] Documentation/firmware-guide/acpi/index.rst: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: Documentation/firmware-guide/acpi/intel-pmc-mux.rst: WARNING: document isn't included in any toctree Signed-off-by: Daniel W. S. Almeida --- Documentation/firmware-guide/acpi/index.rst | 1 + 1 file changed, 1 insertion(+

[PATCH 24/25] Documentation/trace/index.rst: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: Documentation/trace/histogram-design.rst: WARNING: document isn't included in any toctree Signed-off-by: Daniel W. S. Almeida --- Documentation/trace/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Docu

[PATCH 21/25] Documentation/admin-guide/index.rst: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: Documentation/admin-guide/pstore-blk.rst: WARNING: document isn't included in any toctree Signed-off-by: Daniel W. S. Almeida --- Documentation/admin-guide/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 13/25] Documentation: watch_queue.rst: fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warnings: watch_queue.rst:107: WARNING: Inline literal start-string without end-string. watch_queue.rst:107: WARNING: Inline emphasis start-string without end-string watch_queue.rst:184: WARNING: Inline literal start-string without

[PATCH 19/25] Documentation/core-api/printk-formats.rst: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: WARNING: Definition list ends without a blank line; unexpected unindent. Signed-off-by: Daniel W. S. Almeida --- Documentation/core-api/printk-formats.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH 20/25] Documentation/admin-guide/device-mapper/dm-ebs.rst: fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: /Documentation/admin-guide/device-mapper/dm-ebs.rst: WARNING: document isn't included in any toctree Signed-off-by: Daniel W. S. Almeida --- Documentation/admin-guide/device-mapper/index.rst | 1 + 1 file changed, 1 ins

[PATCH 12/25] Documentation/admin-guide/mm/index.rst: Fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: WARNING: toctree contains reference to nonexisting document 'admin-guide/mm/nommu-map' Signed-off-by: Daniel W. S. Almeida --- Documentation/admin-guide/mm/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 18/25] Documentation/bpf/ringbuf.rst: fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warnings: ringbuf.rst:197: WARNING: Unknown target name: "bench_ringbuf.c" Signed-off-by: Daniel W. S. Almeida --- Documentation/bpf/ringbuf.rst | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 11/25] Documentation: vmalloc.c: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: warning: Excess function parameter 'prot' description in 'vm_map_ram' Signed-off-by: Daniel W. S. Almeida --- mm/vmalloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c inde

[PATCH 17/25] Documentation/bpf/bpf_devel_QA.rst: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following sphinx warning: bpf_devel_QA.rst:444: WARNING: Unknown target name: "documentation/bpf/btf.rst" Signed-off-by: Daniel W. S. Almeida --- Documentation/bpf/bpf_devel_QA.rst | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 14/25] Documentation: kvm/api.rst: Fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warnings: WARNING: Definition list ends without a blank line; unexpected unindent Signed-off-by: Daniel W. S. Almeida --- Documentation/virt/kvm/api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentatio

[PATCH 09/25] Documentation: rcu/tree.c: rcu_nmi_enter: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: warning: Excess function parameter 'irq' description in 'rcu_nmi_enter' Signed-off-by: Daniel W. S. Almeida --- kernel/rcu/tree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/rcu/tr

[PATCH 16/25] Documentation/process/index.rst: Fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: WARNING: toctree contains reference to nonexisting document 'process/unaligned-memory-access' Signed-off-by: Daniel W. S. Almeida --- Documentation/process/index.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH 15/25] Documentation: staging/tee.rst: fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" tee.rst:65: WARNING: Unexpected indentation. tee.rst:69: WARNING: Block quote ends without a blank line; unexpected unindent. Signed-off-by: Daniel W. S. Almeida --- Documentation/staging/tee.rst | 18 +++--- 1 file changed, 11 insert

[PATCH 04/25] Documentation: amdgpu_gtt_mgr_del: fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warnings: warning: Excess function parameter 'tbo' description in 'amdgpu_gtt_mgr_del' warning: Excess function parameter 'place' description in 'amdgpu_gtt_mgr_del' Signed-off-by: Dan

[PATCH 01/25] Documentation: amdgpu_device_suspend: Fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix this warning: warning: Excess function parameter 'suspend' description in 'amdgpu_device_suspend' Signed-off-by: Daniel W. S. Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-) diff --gi

[PATCH 10/25] Documentation: rculist.h: fix sphinx warning

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warning: warning: bad line: [@right ][node2 ... ] This was missing a '*' at the start. Signed-off-by: Daniel W. S. Almeida --- include/linux/rculist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inclu

[PATCH 05/25] Documentation: serial_core.c: uart_get_rs485_mode: Fix sphinx warnings

2020-07-17 Thread Daniel W. S. Almeida
From: "Daniel W. S. Almeida" Fix the following warnings: warning: Excess function parameter 'dev' description in 'uart_get_rs485_mode' warning: Excess function parameter 'rs485conf' description in 'uart_get_rs485_mode' Signed-off-by: Daniel W.

  1   2   >