Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

On Mon, Apr 7, 2025 at 11:47 AM David Hildenbrand wrote: > > >>> Heh, but that one said: > >>> > >>> +\item[ VIRTIO_BALLOON_F_WS_REPORTING(6) ] The device has support for > >>> Working Set > >>> > >>> Which does not seem to reflect reality ... > > > > Please feel free to disregard these features a

Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues

> > > > Which does not seem to reflect reality ... Please feel free to disregard these features and reuse their bits and queue indexes; as far as I know, they are not actually enabled anywhere currently and the corresponding guest patches were only applied to some (no-longer-used) Chrome

Re: [PATCH] virtio_console: fix order of fields cols and rows

e patch matches the spec, so from that perspective, looks fine: Reviewed-by: Daniel Verkamp Since the driver code has been using the wrong order since support for this message was added in 2010, but there is no support for sending this message in the current qemu device implementation, I wondered wh

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

On Wed, Jul 10, 2024 at 1:39 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 12:58:11PM -0700, Daniel Verkamp wrote: > > On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: &

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

On Wed, Jul 10, 2024 at 11:39 AM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:12:34AM -0700, Daniel Verkamp wrote: > > On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > > > > > virtio balloon communicates to the core that in some >

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

On Wed, Jul 10, 2024 at 4:43 AM Michael S. Tsirkin wrote: > > virtio balloon communicates to the core that in some > configurations vq #s are non-contiguous by setting name > pointer to NULL. > > Unfortunately, core then turned around and just made them > contiguous again. Result is that driver is

[PATCH v2] ntb: initialize max_mw for Atom before using it

Fill out max_mw in ntb_atom_detect() to match ntb_xeon_detect(); this happens before the use of max_mw in the ndev->mw allocation. Fixes a null pointer dereference on Atom platforms with ntb hardware. v2: fix typo (mw_max should be max_mw) Signed-off-by: Daniel Verkamp Acked-by: Da

[PATCH] ntb: initialize max_mw for Atom before using it

Fill out max_mw in ntb_atom_detect() to match ntb_xeon_detect(); this happens before the use of max_mw in the ndev->mw allocation. Fixes a null pointer dereference on Atom platforms with ntb hardware. Signed-off-by: Daniel Verkamp Acked-by: Dave Jiang --- drivers/ntb/ntb_hw.c | 1 + 1 file ch