Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Stone
Hi, On Wed, 25 Nov 2020 at 18:06, Jason Gunthorpe wrote: > On Wed, Nov 25, 2020 at 05:28:32PM +0100, Daniel Vetter wrote: > > Apologies again, this shouldn't have been included. But at least I > > have an idea now why this patch somehow was included in the git > > send-email. Lovely interface :-/

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-25 Thread Daniel Stone
Hi Mauro, On Tue, 25 Aug 2020 at 12:30, Mauro Carvalho Chehab wrote: > Sorry, but I can't agree that review is more important than to be able > to properly indicate copyrights in a valid way at the legal systems that > it would apply ;-) The way to properly indicate copyright coverage is to inse

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-07-09 Thread Daniel Stone
Hi, Jumping in after a couple of weeks where I've paged most everything out of my brain ... On Fri, 19 Jun 2020 at 10:43, Daniel Vetter wrote: > On Fri, Jun 19, 2020 at 10:13:35AM +0100, Chris Wilson wrote: > > > The proposed patches might very well encode the wrong contract, that's > > > all up

Re: [git pull] drm for 5.8-rc1

2020-07-02 Thread Daniel Stone
Hi, On Wed, 1 Jul 2020 at 20:45, James Jones wrote: > OK, I think I see what's going on. In the Xorg modesetting driver, the > logic is basically: > > if (gbm_has_modifiers && DRM_CAP_ADDFB2_MODIFIERS != 0) { >drmModeAddFB2WithModifiers(..., gbm_bo_get_modifier(bo->gbm)); > } else { >drm

Re: [PATCH v2 0/5] 180 degrees rotation support for NVIDIA Tegra DRM

2020-06-17 Thread Daniel Stone
Hi, On Tue, 16 Jun 2020 at 22:16, Dmitry Osipenko wrote: > The panel's orientation could be parsed by any panel driver and then > assigned as the connector's property in order to allow userspace/FB-core > to decide what to do with the rotated display. Apparently upstream > kernel supports only th

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Daniel Stone
Hi, On Thu, 11 Jun 2020 at 09:44, Dave Airlie wrote: > On Thu, 11 Jun 2020 at 18:01, Chris Wilson wrote: > > Introducing a global lockmap that cannot capture the rules correctly, > > Can you document the rules all drivers should be following then, > because from here it looks to get refactored e

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-16 Thread Daniel Stone
On Wed, 16 Jan 2019 at 16:06, h...@lst.de wrote: > On Wed, Jan 16, 2019 at 07:28:13AM +, Koenig, Christian wrote: > > To summarize once more: We have an array of struct pages and want to > > coherently map that to a device. > > And the answer to that is very simple: you can't. What is so hard

Re: Linux 4.17-rc7

2018-05-30 Thread Daniel Stone
Hi Pavel, On 30 May 2018 at 12:17, Pavel Machek wrote: >> The bulk of it is really pretty trivial one-liners, and nothing looks >> particularly scary. Let's see how next week looks, but if nothing really >> happens I suspect we can make do without an rc8. >> >> Shortlog appended as usual. Go out

Re: [PATCHv3 3/8] drm/omap: add support for manually updated displays

2018-04-20 Thread Daniel Stone
Hi Tony! On 20 April 2018 at 15:25, Tony Lindgren wrote: > * Daniel Stone [180420 10:21]: >> On 20 April 2018 at 08:09, Tomi Valkeinen wrote: >> > It's actually not quite clear to me how manual update displays work with >> > DRM... >> > >> >

Re: [PATCHv3 3/8] drm/omap: add support for manually updated displays

2018-04-20 Thread Daniel Stone
Hi Tomi, On 20 April 2018 at 08:09, Tomi Valkeinen wrote: > It's actually not quite clear to me how manual update displays work with > DRM... > > As far as I see, we have essentially two cases: 1) single buffering, > where the userspace must set an area in the fb dirty, which then > triggers the

Re: [RfC PATCH] Add udmabuf misc device

2018-04-06 Thread Daniel Stone
Hi Gerd, On 14 March 2018 at 08:03, Gerd Hoffmann wrote: >> Either mlock account (because it's mlocked defacto), and get_user_pages >> won't do that for you. >> >> Or you write the full-blown userptr implementation, including mmu_notifier >> support (see i915 or amdgpu), but that also requires Ch

Re: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format

2018-03-21 Thread Daniel Stone
Hi Paul, On 21 March 2018 at 15:29, Paul Kocialkowski wrote: > +/* > + * Allwinner "MB32" tiled format > + * > + * This is the primary layout coming out of the VPU, where pixels are tiled > + * 32x32. > + */ Can you please be a bit more specific here, following the other examples? In particular,

Re: [PATCH] drm/vc4: Add support for SAND modifier.

2018-03-14 Thread Daniel Stone
/ 48 params split would make more sense. Either way, those are just my opinions (you did ask), and I don't see anything really objectionable, so if you think that's a good split then this is: Acked-by: Daniel Stone Cheers, Daniel

Re: [git pull] drm pull for v4.16-rc1

2018-02-01 Thread Daniel Stone
On 2 February 2018 at 02:50, Dave Airlie wrote: > On 2 February 2018 at 12:44, Linus Torvalds > wrote: >> On Thu, Feb 1, 2018 at 6:22 PM, Dave Airlie wrote: >>> >>> Turned out I was running on wayland instead of X.org and my cut-n-paste from >>> gedit to firefox got truncated, wierd. I'll go ann

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Stone
Hi Johannes, On 20 December 2017 at 11:08, Johannes Thumshirn wrote: > On Tue, Dec 19, 2017 at 05:16:30PM +0100, Daniel Vetter wrote: >> Ok I've realized that my assumptions about why you need this aren't >> So from reading these patches it sounded like you want an in-kernel boot >> splash becaus

Re: [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-05 Thread Daniel Stone
Hi Pavel, On 5 December 2017 at 17:34, Pavel Machek wrote: > Yes, so... This patch makes it more likely to see machines with locked > down kernels, preventing developers from working with systems their > own, running hardware. That is evil, and direct threat to Free > software movement. > > Users

Re: [PATCH 2/2] drm: vblank: remove drm_timestamp_monotonic parameter

2017-10-11 Thread Daniel Stone
fault behavior. I don't think there's any reason to remain suspicious of CLOCK_MONOTONIC in 2017. Not to mention that removing it wrecks Weston/etc's ability to give clients present-timing feedback, so removing it is a net uABI improvement. Acked-by: Daniel Stone Cheers, Daniel

Re: [PATCH 2/2] drm/vc4: Add get/set tiling ioctls.

2017-06-16 Thread Daniel Stone
On 13 June 2017 at 16:49, Eric Anholt wrote: > Daniel Stone writes: >> I posted a DRI3 v1.1 patch series which can advertise and also transit >> modifiers directly under X11, and have also typed up the support for >> Wayland which is working just fine with Weston from git

[PATCH] Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse"

2017-06-15 Thread Daniel Stone
driver is being used. This reverts commit f4b65b9563216b3e01a5cc844c3ba68901d9b195. Signed-off-by: Daniel Stone Cc: Che-Liang Chiou Cc: Thierry Escande Cc: Jiri Kosina Cc: Benjamin Tissoires --- drivers/hid/hid-magicmouse.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions

Re: [PATCH 2/2] drm/vc4: Add get/set tiling ioctls.

2017-06-13 Thread Daniel Stone
Hi Eric, On 8 June 2017 at 01:13, Eric Anholt wrote: > This allows mesa to set the tiling format for a BO and have that > tiling format be respected by mesa on the other side of an > import/export (and by vc4 scanout in the kernel), without defining a > protocol to pass the tiling through userspa

Re: [PATCH] drm/fb-helper: Allow var->x/yres(_virtual) < fb->width/height again

2017-03-23 Thread Daniel Stone
date the DRM_DEBUG output to be slightly more accurate, this > doesn't only affect requests from userspace. This test looks much more sensible, and also fixes VT switching for me. Reviewed-by: Daniel Stone Cheers, Daniel

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-16 Thread Daniel Stone
Hi, On 16 March 2017 at 09:55, Michel Dänzer wrote: > Otherwise this can also prevent modesets e.g. for switching VTs. > > FB_MISC_USER_EVENT is set when the request originates from userspace, > which is what we're interested in here according to the DRM_DEBUG > output. > > Bugzilla: https://bugs

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-17 Thread Daniel Stone
Hi, On 17 February 2017 at 14:56, Ville Syrjälä wrote: > On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: >> If we're talking fixed point reprsentation, ChromeOS is using this : >> >> https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/drm_device.cc?q=DrmDevice&l=209

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-15 Thread Daniel Stone
Hi, On 15 February 2017 at 11:39, Ville Syrjälä wrote: > On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote: >> On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä >> wrote: >> > Hmm. Two's complement is what I was thinking it is. Which shows that >> > I never managed to read the code in a

Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs

2017-02-14 Thread Daniel Stone
Hi John, On 14 February 2017 at 19:25, John Stultz wrote: > +static enum drm_mode_status > +drm_connector_check_crtc_modes(struct drm_connector *connector, > + struct drm_display_mode *mode) > +{ > + struct drm_device *dev = connector->dev; > + const struc

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-13 Thread Daniel Stone
Hi Maxime, On 13 February 2017 at 10:54, Maxime Ripard wrote: > On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: >> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: >> > This patch add a config to support to create multi buffer for cma fbdev. >> > Such as double buffer and t

Re: [PATCH v2 2/2] drm/fb_helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-09 Thread Daniel Stone
Hi, On 9 February 2017 at 17:01, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 11:31:57AM +0100, Maxime Ripard wrote: >> +int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, unsigned >> long arg) >> +{ >> + struct drm_fb_helper *fb_helper = info->par; >> + struct drm_device

Re: [RFC] [GPU][DRM][PROPERTY] -Added a new ioctl in Linux DRM KMS driver.

2017-01-20 Thread Daniel Stone
Hi Satendra, On 20 January 2017 at 08:12, Satendra Singh Thakur wrote: > -Added a new ioctl in Linux DRM KMS driver. > This ioctl allows user to set the values of an object’s multiple > properties in one go. > -In the absence of such ioctl, User would be calling one ioctl to set each > propert

Re: [PATCH] drm/i915/dp: Stop enabling limited color ranges for everything

2017-01-05 Thread Daniel Stone
Hi, On 5 January 2017 at 08:52, Daniel Vetter wrote: > On Thu, Jan 05, 2017 at 10:41:07AM +0200, Jani Nikula wrote: >> No matter what we do here, the question remains what to do with >> Chamelium. Changing the color range is really a workaround for >> Chamelium, not a fix. Using CEA range is perf

Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format

2017-01-04 Thread Daniel Stone
Hi Randy, On 4 January 2017 at 16:29, Randy Li wrote: > index 90d2cc8..23c8e99 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 > format) > { .format = DRM_FORMAT_UYVY,

Re: [PATCH 1/2] drm_fourcc: Add new P010 video format

2017-01-03 Thread Daniel Stone
Hi Randy, On 2 January 2017 at 09:50, Randy Li wrote: > P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits > per channel video format. Rockchip's vop support this > video format(little endian only) as the input video format. > > Signed-off-by: Randy Li > --- > include/uapi/drm/drm_fo

Re: [PATCH 2/2] [media] v4l: Add 10-bits per channel YUV pixel formats

2017-01-03 Thread Daniel Stone
Hi all, On 2 January 2017 at 13:03, ayaka wrote: > On 01/02/2017 07:07 PM, Sakari Ailus wrote: >> On Mon, Jan 02, 2017 at 06:53:16PM +0800, ayaka wrote: >>> On 01/02/2017 05:10 PM, Sakari Ailus wrote: If the format resembles the existing formats but on a different bit depth, it sho

Re: linux-next: problems fetching the drm-intel, etc trees

2016-12-01 Thread Daniel Stone
Hi Stephen, On 1 December 2016 at 20:45, Stephen Rothwell wrote: > On Thu, 01 Dec 2016 11:02:26 +0000 Daniel Stone wrote: >> Sorry about this, it is quite bad. I think having mirrors for the key DRM >> trees on GitHub is a good idea though, and I can get to setting that up. >&

Re: [PATCH] drm/vc4: Fix race between page flip completion event and clean-up

2016-11-29 Thread Daniel Stone
iewed-by: Eric Anholt Reviewed-by: Daniel Stone

Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-06 Thread Daniel Stone
Hi Tomeu, On 22 July 2016 at 15:10, Tomeu Vizoso wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame > as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control generation of CRCs in a given C

Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5

2016-05-24 Thread Daniel Stone
k_busy returns outdated information. > > v4: Hold dev->event_lock while checking the VOP's event field as > suggested by Daniel Stone. > > v5: Only block if there's outstanding work if it's a blocking call. > > Signed-off-by: Tomeu Vizoso Reviewed-by: Daniel Stone Cheers, Daniel

Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v3

2016-05-24 Thread Daniel Stone
Hi Tomeu, On 5 April 2016 at 16:07, Tomeu Vizoso wrote: > On 4 April 2016 at 17:44, Daniel Stone wrote: >> On 4 April 2016 at 14:55, Tomeu Vizoso wrote: >>> + if (async) { >>> + for_each_crtc_in_state(state, crtc, crtc_state, i) { >>> +

Re: [RFC v2 5/8] drm/fence: add in-fences support

2016-04-29 Thread Daniel Stone
Hi, On 28 April 2016 at 23:28, Rob Clark wrote: > On Wed, Apr 27, 2016 at 2:39 AM, Daniel Vetter wrote: >> On Tue, Apr 26, 2016 at 01:48:02PM -0700, Greg Hackmann wrote: >>> A (per-CRTC?) array of fences would be more flexible. And even in the cases >>> where you could make a 1-to-1 mapping bet

Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc

2016-04-27 Thread Daniel Stone
Hi, On 26 April 2016 at 00:33, Gustavo Padovan wrote: > +static inline struct drm_crtc *fence_to_crtc(struct fence *fence) > +{ > + if (fence->ops != &drm_crtc_fence_ops) > + return NULL; Since this is (currently) only used before unconditional dereferences, maybe turn this i

Re: [RFC v2 5/8] drm/fence: add in-fences support

2016-04-26 Thread Daniel Stone
Hi, On 26 April 2016 at 21:48, Greg Hackmann wrote: > On 04/26/2016 01:05 PM, Daniel Vetter wrote: >> On Tue, Apr 26, 2016 at 09:55:06PM +0300, Ville Syrjälä wrote: >>> What are they doing that can't stuff the fences into an array >>> instead of props? >> >> The hw composer interface is one in-fe

Re: [RFC 1/6] drm/fence: add FENCE_FD property to planes

2016-04-05 Thread Daniel Stone
Hi, On 5 April 2016 at 15:04, Rob Clark wrote: > On Tue, Apr 5, 2016 at 8:57 AM, Daniel Stone wrote: >> I've been assuming that it would have to be write-only; I don't >> believe there would be any meaningful usecases for read. Do you have >> any in mind, or is

Re: [RFC 1/6] drm/fence: add FENCE_FD property to planes

2016-04-05 Thread Daniel Stone
Hi, On 5 April 2016 at 13:36, Rob Clark wrote: > ok, so I've been slacking on writing up the reasons that I don't like > the idea of using a property for fd's (including fence fd's).. I did > at one point assume we'd use properties for fence fd's, but that idea > falls apart pretty quickly when y

Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v3

2016-04-04 Thread Daniel Stone
Hi Tomeu, On 4 April 2016 at 14:55, Tomeu Vizoso wrote: > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 3b8f652698f8..8305bbd2a4d7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Daniel Stone
Hi Inki, On 31 March 2016 at 12:26, Inki Dae wrote: > 2016-03-31 19:56 GMT+09:00 Daniel Stone : >> On 31 March 2016 at 11:05, Inki Dae wrote: >>> Then, existing drivers would need additional works for explicit fencing >>> support. This wouldn't be really what t

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Daniel Stone
Hi Inki, On 31 March 2016 at 11:05, Inki Dae wrote: > 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >> On 31 March 2016 at 08:45, Inki Dae wrote: >>> As of now, it seems that this wouldn't be optional but mandatory if >>> explicit fence support is added to the ato

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Daniel Stone
Hi Inki, On 31 March 2016 at 08:45, Inki Dae wrote: > 2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: >> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote: >>> In addition, I wonder how explicit and implicit fences could coexist >>> together. >>> Rob said, >>> "Implicit sync ofc remains the default, bu

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-28 Thread Daniel Stone
Hi Inki, On 28 March 2016 at 02:26, Inki Dae wrote: > 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: >> Second, really. Vulkan avoids implicit sync entirely, and exposes >> fence-like primitives throughout its whole API. These include being >> able to pass prerequisite fen

Re: [RFC 0/6] drm/fences: add in-fences to DRM

2016-03-25 Thread Daniel Stone
Hi all, On 25 March 2016 at 11:58, Rob Clark wrote: > On Thu, Mar 24, 2016 at 7:49 PM, Inki Dae wrote: >> It's definitely different case. This tries to add new user-space interfaces >> to expose fences to user-space. At least, implicit interfaces are embedded >> into drivers. >> So I'd like to

Re: [PATCH 2/2] drm/virtio: send vblank event on plane atomic update

2016-03-22 Thread Daniel Stone
Hi, On 21 March 2016 at 19:23, Gustavo Padovan wrote: > @@ -96,6 +98,11 @@ static void virtio_gpu_plane_atomic_update(struct > drm_plane *plane, > plane->state->crtc_y, > plane->state->crtc_w, >

Re: [PATCH 0/2] drm/vc4: Fixes for Raspberry Pi 3

2016-03-01 Thread Daniel Stone
n immediately hard-hangs - no serial console - after cat /sys/class/drm/card0-HDMI-A-1/edid. On the grounds that the VC4 node isn't yet in upstream DT though, and this _does_ indeed fix HPD: Tested-by: Daniel Stone Cheers, Daniel

Re: [PATCH] component: remove device from master match list on failed add

2016-02-15 Thread Daniel Stone
Russell, On 12 February 2016 at 00:57, Akshay Bhat wrote: > Daniel Stone collabora.com> writes: >> Fixes: ffc30b74fd6d01588bd3fdebc3b1acc0857e6fc8 >> Signed-off-by: Daniel Stone collabora.com> > > Tested-by: Akshay Bhat > > Tested on imx6 processor based boar

Re: [RFC] component: Fix: Unassign components' masters if bringing up master fails

2016-02-15 Thread Daniel Stone
Hi Archit, On 11 February 2016 at 09:35, Archit Taneja wrote: > component_master_add_with_match can fail if the master's bind op doesn't > go through successfully. In such a scenario, all the components in the > master's match array have their 'master' pointer set to the given master. > These poi

[PATCH] component: remove device from master match list on failed add

2016-02-08 Thread Daniel Stone
bd3fdebc3b1acc0857e6fc8 Signed-off-by: Daniel Stone Cc: Russell King Cc: Thierry Reding Cc: Laurent Pinchart --- drivers/base/component.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/component.c b/drivers/base/component.c index 2738039..04a1582 100644 --- a/drivers/base/

Re: [PATCH v7 2/4] drm: Add support for ARM's HDLCD controller.

2015-12-23 Thread Daniel Stone
idn't get to take as close a look as last time, but I only had fairly minor quibbles then, and nothing jumped out at me this time either. Reviewed-by: Daniel Stone Cheers, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [PATCH 8/9] drm/vc4: Add support for async pageflips.

2015-12-07 Thread Daniel Stone
Hi, On 4 December 2015 at 01:42, Eric Anholt wrote: > Daniel Stone writes: >> On 1 December 2015 at 20:35, Eric Anholt wrote: >>> An async pageflip stores the modeset to be done and executes it once >>> the BOs are ready to be displayed. This gets us about 3x per

Re: [PATCH v3 2/4] drm: Add support for ARM's HDLCD controller.

2015-12-03 Thread Daniel Stone
Hi Liviu, On 3 December 2015 at 10:00, Liviu Dudau wrote: > On Wed, Dec 02, 2015 at 05:21:44PM +0000, Daniel Stone wrote: >> On 2 December 2015 at 12:23, Liviu Dudau wrote: >> > + if (irq_status & HDLCD_INTERRUPT_VSYNC) { >> > +

Re: [PATCH 9/9] drm/vc4: Add an interface for capturing the GPU state after a hang.

2015-12-02 Thread Daniel Stone
ific tests reporting >> failure, and get me permission to just push code to that repository >> (It's hard enough getting piglit tests reviewed, vc4-specific tests and >> tools would never get review). > > Daniel Stone claimed that this Just Works but evidently it do

Re: [PATCH v3 2/4] drm: Add support for ARM's HDLCD controller.

2015-12-02 Thread Daniel Stone
Hi Liviu, On 2 December 2015 at 12:23, Liviu Dudau wrote: > + if (irq_status & HDLCD_INTERRUPT_VSYNC) { > + unsigned long flags; > + > + drm_handle_vblank(drm, 0); > + > + spin_lock_irqsave(&drm->event_lock, flags); > + if (hdlcd->even

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-02 Thread Daniel Stone
Hi Mark, On 2 December 2015 at 14:18, Daniel Stone wrote: > On 1 December 2015 at 09:31, Mark yao wrote: >> Can you share your Weston environment to me, I'm interesting to test drm >> rockchip on weston. > > Of course. You can download Weston from http://wayland.fr

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-02 Thread Daniel Stone
Hi Mark, Thanks for getting back to this. On 1 December 2015 at 09:31, Mark yao wrote: > On 2015年12月01日 16:18, Daniel Stone wrote: >> On 1 December 2015 at 03:26, Mark Yao wrote: >>> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) { >>> >+

Re: [PATCH 8/9] drm/vc4: Add support for async pageflips.

2015-12-02 Thread Daniel Stone
Hi, On 1 December 2015 at 20:35, Eric Anholt wrote: > An async pageflip stores the modeset to be done and executes it once > the BOs are ready to be displayed. This gets us about 3x performance > in full screen rendering with pageflipping. Looks good, but you're missing a preclose callback to r

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Daniel Stone
Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: > +static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) > +{ > + struct drm_crtc_state *crtc_state; > + struct drm_crtc *crtc; > + int i; > + > + for_each_crtc_in_state(state, crtc, crtc_state,

Re: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_*

2015-11-30 Thread Daniel Stone
Hi, On 1 December 2015 at 03:26, Mark Yao wrote: > No functional update, drm_vblank_* is the legacy version of > drm_crtc_vblank_*. and use new api make driver more clean. > > Signed-off-by: Mark Yao Heh, I had the same patch in my series to fix pageflip events. Reviewed-by:

Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt

2015-11-21 Thread Daniel Stone
Hi, On 21 November 2015 at 14:22, Christian König wrote: > On 20.11.2015 16:52, cp...@redhat.com wrote: >> This is somewhat rare on most cards (depending on what angle you plug >> the DVI connector in), but on some cards it happens constantly. The >> Radeon R5 on the machine used for testing this

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Daniel Stone
On 16 November 2015 at 17:43, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:32:05PM +0000, Daniel Stone wrote: >> On 16 November 2015 at 17:22, Russell King - ARM Linux >> wrote: >> > Please sensibly wrap your messages. Your lines are longer than 80 >&g

Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

2015-11-16 Thread Daniel Stone
On 16 November 2015 at 17:22, Russell King - ARM Linux wrote: > Please sensibly wrap your messages. Your lines are longer than 80 > characters which makes it exceedingly difficult for some people to reply > to your very very very very very very very very very very very very > very very very very

Re: [PATCH RFC 0/8] Add New DRM Driver for Hisilicon's Hi6220 SoC

2015-09-16 Thread Daniel Stone
Hi Xinwei, Thanks for this contribution! We look forward to seeing support for these devices. This isn't an exhaustive review, but two very high-level comments which should result in a lot of changes ... On 15 September 2015 at 10:37, Xinwei Kong wrote: > 1. Hardware Detail > The display subsy

Re: Linux 4.1 WARNING in drm_ioctl.c

2015-06-23 Thread Daniel Stone
Hi, On 23 June 2015 at 07:39, Daniel Vetter wrote: > Which drm driver are you using? I didn't spot anything in your module list > but might have missed it. Booting with drm.debug=0xe and grabbing dmesg > will tell us for sure. That'd be vgem. Cheers, Daniel -- To unsubscribe from this list: sen

Re: [PATCH] drm: remove unused function

2015-05-14 Thread Daniel Stone
Hi Sudip, On 14 May 2015 at 12:14, Sudip Mukherjee wrote: > this function was not used anywhere and was giving a build warning. Thanks for the patch, but this function is used in following patches that are in the process of being merged. This shouldn't have snuck in in the earlier patch; apologi

Re: [RFC][PATCH 2/2] drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.

2015-05-13 Thread Daniel Stone
Hi, On 13 May 2015 at 16:23, CK Hu wrote: > + /* > +* copy the mode data adjusted by mode_fixup() into crtc->mode > +* so that hardware can be seet to proper mode. > +*/ > + memcpy(&crtc->mode, adjusted_mode, sizeof(*adjusted_mode)); Please do not do this. adj

Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD

2015-05-04 Thread Daniel Stone
Hi, On 4 May 2015 at 08:43, Inki Dae wrote: > On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >> error: > > No, eDP has no any dependency of FIMD but DECON. Just add dependency > code like below, > > config DRM_EXYNOS

Re: [PATCH] Add virtio gpu driver.

2015-03-24 Thread Daniel Stone
Hi, On 24 March 2015 at 16:07, Gerd Hoffmann wrote: > +static int virtio_gpu_crtc_page_flip(struct drm_crtc *crtc, > +struct drm_framebuffer *fb, > +struct drm_pending_vblank_event *event, > +

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Daniel Stone
On 9 February 2015 at 10:49, Geert Uytterhoeven wrote: > On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone wrote: >> On 5 February 2015 at 11:35, One Thousand Gnomes >> wrote: >>> #if defined (CONFIG_SUPPORT_SHITE_VGA_ADAPTERS) >>> >>> #endif >>> &

Re: [PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Daniel Stone
On 5 February 2015 at 11:35, One Thousand Gnomes wrote: >> If I'm not mistaken, that would be as simple as adding >> >> #define VT_BUF_HAVE_RW. >> #define scr_writew(val, addr) (*(addr) = (val)) >> #define scr_readw(addr) (*(addr)) >> >> to arch/x86/include/asm/vga.h. > > and stick an

Re: [Linaro-mm-sig] [RFC 0/1] drm/pl111: Initial drm/kms driver for pl111

2013-09-14 Thread Daniel Stone
Hi, On Tue, 2013-08-06 at 12:31 +0100, Tom Cooksey wrote: > > >> On Fri, Jul 26, 2013 at 11:58 AM, Tom Cooksey > > >> wrote: > > that was part of the reason to punt this problem to userspace ;-) > > > > In practice, the kernel drivers doesn't usually know too much about > > the dimensions/format/

Re: Revert "intel_agp: fix stolen mem range on G33"

2007-10-07 Thread Daniel Stone
On Sat, Oct 06, 2007 at 12:41:21PM +0200, Jiri Slaby wrote: > On 10/06/2007 07:42 AM, Kyle McMartin wrote: > > This reverts commit f443675affe3f16dd428e46f0f7fd3f4d703eeab, which > > breaks horribly if you aren't running an unreleased xf86-video-intel > > driver out of git. > > I guess, this will

Re: State of Linux graphics

2005-08-30 Thread Daniel Stone
On Tue, 2005-08-30 at 12:03 -0400, Jon Smirl wrote: > The article has been reviewed but if it still contains technical > errors please let me know. Opinions on the content are also > appreciated. 'As a whole, the X.org community barely has enough resources to build a single server. Splitting these

Re: Cosmetic JFFS patch.

2001-06-29 Thread Daniel Stone
, to do what they want. :) d [1]: : , e.g.: eth0: Intel EtherExpress PRO/100, IRQ10, etc [2]: : : , e.g.: eepro100.c: v0.1, Daniel Stone <[EMAIL PROTECTED]> eth0: Intel EtherExpress PRO/100, IRQ10, etc [3]: : : , e.g.: eepro100.c: v0.1, Dan

Re: [OOPS] XFS in large Maildir

2001-06-24 Thread Daniel Stone
On Sun, Jun 24, 2001 at 01:07:40PM +0200, Seth Mos wrote: > On Sun, 24 Jun 2001, Daniel Stone wrote: > > > On Sun, Jun 24, 2001 at 12:18:00PM +0200, Seth Mos wrote: > > > On Sun, 24 Jun 2001, Daniel Stone wrote: > > > > > > > Hi guys, > > > &

Re: [OOPS] XFS in large Maildir

2001-06-24 Thread Daniel Stone
On Sun, Jun 24, 2001 at 12:18:00PM +0200, Seth Mos wrote: > On Sun, 24 Jun 2001, Daniel Stone wrote: > > > Hi guys, > > I've attached the ksymoops output from Linux 2.4.6-pre3-xfs (CVS tree from > > some point). I'll try an update now, but when I try to acces

[OOPS] XFS in large Maildir

2001-06-24 Thread Daniel Stone
so I doubt it's a mutt bug. :) d -- Daniel Stone <[EMAIL PROTECTED]> "can NE1 help me aim nuclear weaponz? /MSG ME!!" ksymoops 2.4.1 on i586 2.4.6-pre3-xfs. Options used -V (default) -k /proc/ksyms (default)

Re: The latest Microsoft FUD. This time from BillG, himself.

2001-06-21 Thread Daniel Stone
Very clean format - see http://kabuki.sfarc.net/daniel/netfilter/netfilter.mgp -- Daniel Stone <[EMAIL PROTECTED]> "can NE1 help me aim nuclear weaponz? /MSG ME!!" - To unsubscribe from this list: send the line "unsubscribe lin

Re: XFS and Alan kernel tree

2001-06-12 Thread Daniel Stone
r porting effort to the -ac series? Thanks, d -- Daniel Stone<[EMAIL PROTECTED]> <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kern

Re: [PATCH] 2.4.6-pre2 page_launder() improvements

2001-06-10 Thread Daniel Stone
20 + apt/dpkg + gcc), than with vanilla -ac12. To get it to compile on -ac, just hand-hack in the patch, and s/CAN_GET_IO/can_get_io_locks/ in vmscan.c. :) d -- Daniel Stone<[EMAIL PROTECTED]> <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscr

Re: CML 1 is ok

2001-05-18 Thread Daniel Stone
ty. > -mirabilos > > PS: Don't answer plz as I'll be offline for a time. > _And_ I mean this honest, even it might considered sp.m The FUD has to be corrected. -- Daniel Stone [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linu

[BUG] Vibra16XS and OSS/Free - static

2001-05-12 Thread Daniel Stone
nly to get the same result. This is using 2.4.4-ac6, with only Netfilter hacks. d -- Daniel Stone [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] Single user linux

2001-04-27 Thread Daniel Stone
me). > > -d, who owns a 7110 and can lock it solid, or get it to do funny resetting > > tricks, at least once every 2 days > > Hmm, maybe your 7110 needs memory protection so that runaway calendar > can not hurt basic functions? ;-). Oh, I think it's just to do

Re: [PATCH] Single user linux

2001-04-27 Thread Daniel Stone
On Fri, Apr 27, 2001 at 03:12:39PM +0200, Robert Varga wrote: > On Wed, Apr 25, 2001 at 10:34:56AM +1000, Daniel Stone wrote: > > On Wed, Apr 25, 2001 at 01:16:03AM +0100, Alan Cox wrote: > > > > What real value does it have, apart from the geek "look at me, I&#

Re: [PATCH] Single user linux

2001-04-25 Thread Daniel Stone
one, but corrected nevertheless. (I've only seen the agenda in action, and it seemed a lot of time writing "date" for relatively little action - the date). -- Daniel Stone [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [PATCH] Single user linux

2001-04-24 Thread Daniel Stone
On Tue, Apr 24, 2001 at 05:35:10PM -0700, Aaron Lehmann wrote: > On Wed, Apr 25, 2001 at 10:32:46AM +1000, Daniel Stone wrote: > > True, but then imagine trying to hack C (no, that's a CURLY BRACE, and a > > tab! not space! you just broke my makefiles! aargh!), and compili

Re: [PATCH] Single user linux

2001-04-24 Thread Daniel Stone
spose, if it only goes into suspend, the ability to write "uptime" on it constitutes a walking penis extension after a while? -- Daniel Stone Linux Kernel Developer [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [PATCH] Single user linux

2001-04-24 Thread Daniel Stone
On Tue, Apr 24, 2001 at 05:20:27PM -0700, Aaron Lehmann wrote: > On Wed, Apr 25, 2001 at 10:07:48AM +1000, Daniel Stone wrote: > > What real value does it have, apart from the geek "look at me, I'm using > > bash" value? > > I don't really want to get i

Re: [PATCH] Single user linux

2001-04-24 Thread Daniel Stone
On Tue, Apr 24, 2001 at 05:01:18PM -0700, Aaron Lehmann wrote: > On Tue, Apr 24, 2001 at 11:38:01PM +1000, Daniel Stone wrote: > > And UNIX on a phone is pure overkill. > > Quit being a naysayer. UNIX on a PDA is a wet dream. What real value does it have, apart from the geek &

Re: problem found (was Re: [PATCH] Single user linux)

2001-04-24 Thread Daniel Stone
On Tue, Apr 24, 2001 at 09:04:02PM +0700, [EMAIL PROTECTED] wrote: > > What's with all these blank lines? Everywhere! > On Tue, 24 Apr 2001, Daniel Stone wrote: > > Aah. I see. Where was this? I never saw it. > > psst, it's a proto. Right-o. In the news, yo

Re: [PATCH] Single user linux

2001-04-24 Thread Daniel Stone
On Tue, Apr 24, 2001 at 08:27:56PM +0700, [EMAIL PROTECTED] wrote: > On Tue, 24 Apr 2001, Daniel Stone wrote: > > Hence, Microsoft Windows. It might not be stable, it might not be fast, it > > might not do RAID, packet-filtering and SQL, but it does a job. A simple > > job.

Re: [PATCH] Single user linux

2001-04-24 Thread Daniel Stone
ive everyone a chance > to use linux. If you don't want multiple users, don't add them. Just be content with root, and give her root. It has multiple user capabilities, which should be used under all circumstances, but if you don't want something, don't use it. You have

Re: comments on CML 1.1.0

2001-04-15 Thread Daniel Stone
Only as modules: conntrack/queueing/iptables, ipchains compat, and ipfwadm compat, are all mutually exclusive. The only way that this was at all possible in 2.4.x was via modules, but even then, they were still mutually exclusive. -- Daniel Stone Linux Kernel Developer [EMAIL PROTECTED] -BEGIN

Re: [reiserfs-list] Re: Apparent instability of reiserfs on 2.4.1

2001-02-10 Thread Daniel Stone
On 11 Feb 2001 02:02:00 +1300, Chris Wedgwood wrote: > On Thu, Feb 08, 2001 at 05:34:44PM +1100, Daniel Stone wrote: > > I run Reiser on all but /boot, and it seems to enjoy corrupting my > mbox'es randomly. > > what kind of corruption are you seeing? Zeroed

Re: [reiserfs-list] Re: Apparent instability of reiserfs on 2.4.1

2001-02-07 Thread Daniel Stone
s. So, it really should be a reiserfs bug. I run Reiser on all but /boot, and it seems to enjoy corrupting my mbox'es randomly. Using the old-style Reiser FS format, 2.4.2-pre1, Evolution, on a CMD640 chipset with the fixes enabled. This also occurs in some log files, but I put it down to syslogd

Re: Firewall netlink question...

2001-01-22 Thread Daniel Stone
l versions are always bad. > egg.microsoft.com: Remote operating system guess: Solaris 2.6 - 2.7 My all-time favourite is Microsoft-IIS/4.0 (Unix) mod_ssl/2. OpenSSL/0.9.4 -- Daniel Stone Linux Kernel Developer [EMAIL PROTECTED] -BEGIN GEEK CODE BLOCK- Version: 3.1 G!>CS d s++:- a---

  1   2   >